]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
2 months agodoc/radosgw: Improve formatting in layout.rst 62999/head
Anthony D'Atri [Fri, 25 Apr 2025 17:10:06 +0000 (13:10 -0400)]
doc/radosgw: Improve formatting in layout.rst

Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
(cherry picked from commit a7dcc3cf24239a9728d9622e4a980894e7741e48)

2 months agoMerge pull request #62995 from ronen-fr/wip-rf-qa71099-squid
Ronen Friedman [Sun, 27 Apr 2025 15:29:29 +0000 (18:29 +0300)]
Merge pull request #62995 from ronen-fr/wip-rf-qa71099-squid

squid: osd/scrub: always round up reported scrub duration

Reviewed-by: Matan Breizman <mbreizma@redhat.com>
2 months agoMerge pull request #62956 from ronen-fr/wip-rf-62692-squid
Ronen Friedman [Sun, 27 Apr 2025 14:25:53 +0000 (17:25 +0300)]
Merge pull request #62956 from ronen-fr/wip-rf-62692-squid

squid: osd/scrub: additional configuration parameters to trigger scrub reschedule

Reviewed-by: Matan Breizman <mbreizma@redhat.com>
2 months agoMerge pull request #62974 from ronen-fr/wip-rf-24647e8-qatarget-squid
Ronen Friedman [Sun, 27 Apr 2025 14:09:10 +0000 (17:09 +0300)]
Merge pull request #62974 from ronen-fr/wip-rf-24647e8-qatarget-squid

squid: qa/standalone/scrub: fix osd-scrub-test.sh

Reviewed-by: Matan Breizman <mbreizma@redhat.com>
2 months agoosd/scrub: always round up reported scrub duration 62995/head
Ronen Friedman [Sat, 26 Apr 2025 08:33:59 +0000 (03:33 -0500)]
osd/scrub: always round up reported scrub duration

as expected by some tests, and clearer for the user.

Fixes: https://tracker.ceph.com/issues/71099
Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
2 months agoqa/standalone/scrub: fix osd-scrub-test.sh 62974/head
Ronen Friedman [Wed, 26 Jun 2024 15:02:19 +0000 (10:02 -0500)]
qa/standalone/scrub: fix osd-scrub-test.sh

following changes in scrub code

(cherry picked from commit 24647e87e8fba9b16d81730662b22798ed1885cb)
Conflict resolved by:
- electing to keep the up-to-date order between 'set noscrub' and 'set ..chunk_max'
in 'step 2'

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
2 months agoMerge pull request #62989 from zdover23/wip-doc-2025-04-26-backport-62988-to-squid
Anthony D'Atri [Sat, 26 Apr 2025 14:25:15 +0000 (10:25 -0400)]
Merge pull request #62989 from zdover23/wip-doc-2025-04-26-backport-62988-to-squid

squid: doc/radosgw: Fix RST syntax rendeded as text in oidc.rst

2 months agodoc/radosgw: Fix RST syntax rendeded as text in oidc.rst 62989/head
Ville Ojamo [Sat, 26 Apr 2025 04:17:16 +0000 (11:17 +0700)]
doc/radosgw: Fix RST syntax rendeded as text in oidc.rst

Empty line after starting a pre-formatted block with the double-colon
syntax is required, otherwise the double-colon does nothing and is just
rendered as-is as "::" and there would be no following pre-formatted
block.

Add empty lines after the double-colon syntax so that the following
block is rendered pre-formatted.

Also add bash privileged prompts to a block with 2 example CLI commands.

Signed-off-by: Ville Ojamo <14869000+bluikko@users.noreply.github.com>
(cherry picked from commit b4fb5dc4030b4de477942630ebe3b98b882ae978)

2 months agoMerge pull request #62748 from ivancich/wip-70825-squid
Yuri Weinstein [Fri, 25 Apr 2025 16:04:50 +0000 (09:04 -0700)]
Merge pull request #62748 from ivancich/wip-70825-squid

squid: rgw: add force option to radosgw-admin object rm ...

Reviewed-by: Adam Emerson <aemerson@redhat.com>
2 months agoMerge pull request #62741 from jzhu116-bloomberg/wip-70741-squid
Yuri Weinstein [Fri, 25 Apr 2025 16:04:13 +0000 (09:04 -0700)]
Merge pull request #62741 from jzhu116-bloomberg/wip-70741-squid

squid: rgw: cleanup orphaned bucket entry in <user>.buckets OMAP

Reviewed-by: Adam Emerson <aemerson@redhat.com>
2 months agoMerge pull request #62559 from cbodley/wip-70517-squid
Yuri Weinstein [Fri, 25 Apr 2025 16:00:13 +0000 (09:00 -0700)]
Merge pull request #62559 from cbodley/wip-70517-squid

squid: rgw: rgw_init_ioctx() adds set_pool_full_try()

Reviewed-by: Adam Emerson <aemerson@redhat.com>
2 months agoMerge pull request #62356 from cbodley/wip-70528-squid
Yuri Weinstein [Fri, 25 Apr 2025 15:58:36 +0000 (08:58 -0700)]
Merge pull request #62356 from cbodley/wip-70528-squid

squid: rgw: sync fairness watcher reconnects on any error

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
Reviewed-by: Oguzhan Ozmen <oozmen@bloomberg.net>
2 months agoMerge pull request #62034 from kchheda3/wip-70210-squid
Yuri Weinstein [Fri, 25 Apr 2025 15:56:38 +0000 (08:56 -0700)]
Merge pull request #62034 from kchheda3/wip-70210-squid

squid: rgw:lua: Skip the healthchecks and system requests from going to backend storage

Reviewed-by: Yuval Lifshitz <ylifshit@redhat.com>
2 months agoMerge pull request #62752 from idryomov/wip-70831-squid
Yuri Weinstein [Fri, 25 Apr 2025 15:34:30 +0000 (08:34 -0700)]
Merge pull request #62752 from idryomov/wip-70831-squid

squid: test/librbd/test_notify.py: force line-buffered output

Reviewed-by: Mykola Golub <mgolub@suse.com>
2 months agoMerge pull request #62337 from yuvalif/wip-67309-squid
Yuri Weinstein [Thu, 24 Apr 2025 20:51:28 +0000 (13:51 -0700)]
Merge pull request #62337 from yuvalif/wip-67309-squid

squid: rgw/async/notifications: use common async waiter in pubsub push

Reviewed-by: Adam Emerson <aemerson@redhat.com>
2 months agoMerge pull request #61546 from aiivashchenko/wip-69588-squid
Yuri Weinstein [Thu, 24 Apr 2025 17:15:30 +0000 (10:15 -0700)]
Merge pull request #61546 from aiivashchenko/wip-69588-squid

squid: rgw: add missing last_modified field to swift API

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
Reviewed-by: Tobias Urdin <tobias.urdin@binero.com>
2 months agoMerge pull request #61995 from cbodley/wip-70170-squid
Yuri Weinstein [Thu, 24 Apr 2025 16:16:39 +0000 (09:16 -0700)]
Merge pull request #61995 from cbodley/wip-70170-squid

squid: rgw: fix to correctly store updated attrs in backend store after erasing an attr/attrs for delete ops on a bucket.

Reviewed-by: Adam Emerson <aemerson@redhat.com>
2 months agoMerge pull request #61532 from soumyakoduri/wip-skoduri-squid
Yuri Weinstein [Thu, 24 Apr 2025 16:15:16 +0000 (09:15 -0700)]
Merge pull request #61532 from soumyakoduri/wip-skoduri-squid

squid: rgw: Fix a bug in LCOpAction_Transition::check()

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
2 months agoosd/scrub: additional configuration params to trigger scrub reschedule 62956/head
Ronen Friedman [Sun, 6 Apr 2025 12:31:48 +0000 (07:31 -0500)]
osd/scrub: additional configuration params to trigger scrub reschedule

Adding the following parameters to the (small) set of configuration
options that, if changed, trigger re-computation of the next scrub
schedule:
- osd_scrub_interval_randomize_ratio,
(not cherry-picked) - osd_deep_scrub_interval_cv, and
- osd_deep_scrub_interval (which was missing in the list of
  parameters watched by the OSD).

Fixes: https://tracker.ceph.com/issues/70909
Original tracker: https://tracker.ceph.com/issues/70806
(cherry picked from commit d56f613d5a69797e727938f04b66aed747cfb6b1)
Conflicts resolved by removing refs to the deep_scrub_interval_cv
parameter, which does not yet exist in this version.
Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
2 months agoMerge pull request #61782 from cbodley/wip-69933-squid
Yuri Weinstein [Thu, 24 Apr 2025 14:57:00 +0000 (07:57 -0700)]
Merge pull request #61782 from cbodley/wip-69933-squid

squid: rgw: allow management of `accounts` user caps

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 months agoMerge pull request #61242 from kchheda3/wip-69410-squid
Yuri Weinstein [Thu, 24 Apr 2025 14:54:54 +0000 (07:54 -0700)]
Merge pull request #61242 from kchheda3/wip-69410-squid

squid: rgw/notification: Forward Topic & Notification creation request to master when notification_v2 enabled

Reviewed-by: Yuval Lifshitz <ylifshit@redhat.com>
2 months agoMerge pull request #61161 from ivancich/wip-69136-squid
Yuri Weinstein [Thu, 24 Apr 2025 14:53:43 +0000 (07:53 -0700)]
Merge pull request #61161 from ivancich/wip-69136-squid

squid: rgw: relax RGWPutACLs_ObjStore::get_params read data log

Reviewed-by: Adam Emerson <aemerson@redhat.com>
2 months agoMerge pull request #61840 from vshankar/wip-69683
Yuri Weinstein [Thu, 24 Apr 2025 14:28:43 +0000 (07:28 -0700)]
Merge pull request #61840 from vshankar/wip-69683

squid: mds: prevent duplicate wrlock acquisition for a single request

Reviewed-by: Venky Shankar <vshankar@redhat.com>
2 months agoMerge pull request #62531 from aaSharma14/wip-70686-squid
afreen23 [Tue, 22 Apr 2025 16:07:45 +0000 (21:37 +0530)]
Merge pull request #62531 from aaSharma14/wip-70686-squid

squid: mgr/dashboard: fix image filter's query on rbd-details grafana panel

Reviewed-by: Afreen Misbah <afreen@ibm.com>
2 months agocommon: missing std include with GCC 14 62337/head
Yuval Lifshitz [Tue, 1 Oct 2024 15:19:46 +0000 (15:19 +0000)]
common: missing std include with GCC 14

In file included from src/rgw/driver/posix/bucket_cache.h:19,
                 from src/test/rgw/test_posix_bucket_cache.cc:4:
src/common/cohort_lru.h: In member function _void cohort::lru::TreeX<T, TTree, CLT, CEQ, K, LK>::lock()_:
src/common/cohort_lru.h:334:14: error: _for_each_ is not a member of _std_
  334 |         std::for_each(locks.begin(), locks.end(),
      |              ^~~~~~~~
src/common/cohort_lru.h: In member function _void cohort::lru::TreeX<T, TTree, CLT, CEQ, K, LK>::unlock()_:
/home/yuvalif/ceph5/src/common/cohort_lru.h:339:14: error: _for_each_ is not a member of _std_
  339 |         std::for_each(locks.begin(), locks.end(),
      |              ^~~~~~~~

Signed-off-by: Yuval Lifshitz <ylifshit@ibm.com>
2 months agorgw/async/notifications: use common async waiter in pubsub push
Yuval Lifshitz [Tue, 23 Jul 2024 17:41:50 +0000 (17:41 +0000)]
rgw/async/notifications: use common async waiter in pubsub push

* use the "yield_waiter" and "waiter" from common/async insteasd of the "waiter"
  implemented inside the bucket notification code (this is so we don't
  need separate investigations for 2 implementations)
* added a unit test that simulate how a separate thread (kafka or amqp) is
resuming a coroutine which is created by either the frontend or the
notification manager.

before using "defer" the unit test is passing, however,
when executed under thread sanitizer (using the WITH_TSAN cmake flag)
the following errors are observed: https://0x0.st/Xp4P.txt
after using "defer" the unit test passes under TSAN without errors.

Fixes: https://tracker.ceph.com/issues/64184
Signed-off-by: Yuval Lifshitz <ylifshit@ibm.com>
(cherry picked from commit 2872c75f184c9e715219dfa9ad44f5b6cfe4e1fe)

2 months agocommon/async: add yield_waiter template
Casey Bodley [Tue, 30 Apr 2024 16:04:15 +0000 (12:04 -0400)]
common/async: add yield_waiter template

Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit dd779c74e1eebaf888d95b2329c7d5ead176f0a9)

2 months agoMerge pull request #62386 from pritha-srivastava/wip-70535-squid
Casey Bodley [Tue, 22 Apr 2025 13:42:14 +0000 (09:42 -0400)]
Merge pull request #62386 from pritha-srivastava/wip-70535-squid

squid: rgw/sts: replacing load_stats with list_buckets

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2 months agoMerge pull request #61062 from k0ste/wip-69218-squid
Yuri Weinstein [Mon, 21 Apr 2025 21:14:02 +0000 (14:14 -0700)]
Merge pull request #61062 from k0ste/wip-69218-squid

squid: rgw: Delete stale entries in bucket indexes while deleting obj

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
2 months agoMerge pull request #62586 from cbodley/wip-70738-squid
Yuri Weinstein [Mon, 21 Apr 2025 21:11:02 +0000 (14:11 -0700)]
Merge pull request #62586 from cbodley/wip-70738-squid

squid: rgw: fixing tempest ObjectTestACLs and ObjectACLsNegativeTest cases

Reviewed-by: Adam Emerson <aemerson@redhat.com>
2 months agoMerge pull request #62590 from cbodley/wip-70739-squid
Yuri Weinstein [Mon, 21 Apr 2025 14:24:35 +0000 (07:24 -0700)]
Merge pull request #62590 from cbodley/wip-70739-squid

squid: cls/rgw: non-versioned listings skip past version suffix

Reviewed-by: Adam Emerson <aemerson@redhat.com>
2 months agoMerge pull request #62365 from cbodley/wip-70538-squid
Yuri Weinstein [Mon, 21 Apr 2025 14:22:15 +0000 (07:22 -0700)]
Merge pull request #62365 from cbodley/wip-70538-squid

squid: qa/rgw: fix user cleanup in s3tests task

Reviewed-by: Adam Emerson <aemerson@redhat.com>
2 months agoMerge pull request #62623 from rhcs-dashboard/wip-70762-squid
afreen23 [Mon, 21 Apr 2025 08:52:57 +0000 (14:22 +0530)]
Merge pull request #62623 from rhcs-dashboard/wip-70762-squid

squid: mgr/dashboard: enable ha by default on subsystem POST API

Reviewed-by: Naman Munet <nmunet@redhat.com>
2 months agoMerge pull request #62495 from kchheda3/wip-66805-squid
Yuri Weinstein [Fri, 18 Apr 2025 21:05:43 +0000 (14:05 -0700)]
Merge pull request #62495 from kchheda3/wip-66805-squid

squid: rgw/notification: For kafka include user-id & password as part of the key along with endpoint for connection pooling.

Reviewed-by: Adam Emerson <aemerson@redhat.com>
3 months agoMerge pull request #62881 from cbodley/wip-doc-rgw-user-admin-system-squid
Casey Bodley [Fri, 18 Apr 2025 18:27:09 +0000 (14:27 -0400)]
Merge pull request #62881 from cbodley/wip-doc-rgw-user-admin-system-squid

squid: doc/rgw: document Admin and System Users

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
3 months agodoc/rgw: document Admin and System Users 62881/head
Casey Bodley [Thu, 17 Apr 2025 21:52:27 +0000 (17:52 -0400)]
doc/rgw: document Admin and System Users

Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit dc93b888f16793b00390b32d6814f9243b6808e2)

3 months agodoc/rgw: Admin Capabilities section links to Admin Ops API
Casey Bodley [Thu, 17 Apr 2025 21:51:46 +0000 (17:51 -0400)]
doc/rgw: Admin Capabilities section links to Admin Ops API

Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit cdc04b87842e02f81add403c8843b77e56cb3ef4)

3 months agoMerge pull request #62874 from zdover23/wip-doc-2025-04-18-backport-62300-to-squid
Anthony D'Atri [Fri, 18 Apr 2025 03:12:17 +0000 (23:12 -0400)]
Merge pull request #62874 from zdover23/wip-doc-2025-04-18-backport-62300-to-squid

squid: doc/cephfs: link section for pausing async threads in section for...

3 months agodoc/cephfs: link section for pausing async threads in section for... 62874/head
Rishabh Dave [Fri, 14 Mar 2025 12:39:56 +0000 (18:09 +0530)]
doc/cephfs: link section for pausing async threads in section for...

disabling volumes plugin part.

Fixes: https://tracker.ceph.com/issues/70479
Signed-off-by: Rishabh Dave <ridave@redhat.com>
(cherry picked from commit 36cfbfb0eacbfbd459558d1bdff699daf8fae575)

3 months agorgw: metadata and data sync fairness notifications to retry upon any error case 62356/head
Oguzhan Ozmen [Fri, 11 Apr 2025 21:45:19 +0000 (21:45 +0000)]
rgw: metadata and data sync fairness notifications to retry upon any error case

This is a complementary fix to the earlier one described at #62156.
When the sync shard notification fails due to any failures including timeout,
this change keeps the loop going for both metadata and data sync.

Fixes https://tracker.ceph.com/issues/70270

Signed-off-by: Oguzhan Ozmen <oozmen@bloomberg.net>
(cherry picked from commit 766b7a14315ae7ca9645b462ee774570caeff64c)

3 months agoMerge pull request #60978 from cbodley/wip-69148-squid
Casey Bodley [Thu, 17 Apr 2025 15:47:59 +0000 (11:47 -0400)]
Merge pull request #60978 from cbodley/wip-69148-squid

squid: test/rgw/multisite: add meta checkpoint after bucket creation

Reviewed-by: Adam Emerson <aemerson@redhat.com>
3 months agoMerge pull request #62856 from zdover23/wip-doc-2025-04-17-backport-62763-to-squid
Anthony D'Atri [Thu, 17 Apr 2025 03:45:21 +0000 (23:45 -0400)]
Merge pull request #62856 from zdover23/wip-doc-2025-04-17-backport-62763-to-squid

squid: doc/radosgw: Promptify CLI, cosmetic fixes

3 months agodoc/radosgw: Promptify CLI, cosmetic fixes 62856/head
Ville Ojamo [Thu, 10 Apr 2025 10:34:57 +0000 (17:34 +0700)]
doc/radosgw: Promptify CLI, cosmetic fixes

Use the more modern prompt block for CLI commands
and use right one $ vs #.
Fix indentation on JSON example outputs and
some CLI command switches.
Add some arguably missing comma in JSON example output.
Add a full stop at the end of a one-sentence paragraph.
Remove extra comma mid-sentence in another.
Fix missing backslashes or typo at end of multiline commands.
Lines under section headings as long as heading text.
Fix hyperlinks. Fix list items prefixed with - insted of *.
Format configuration syntax in the middle of text as code.
Fix typo "PI" to "API" and remove extra space.
Remove colons at the end of section headers in a few places.
Use Title Case in section titles consistently with short words lowercase.
Possibly controversial: don't add whitespace before and
after main title section header text.
Possibly controversial: don't indent line continuation
backslashes, leave only 1 space before them.

Signed-off-by: Ville Ojamo <14869000+bluikko@users.noreply.github.com>
(cherry picked from commit 7fdaa94181c6fca7d4db0b6f4ee6646528121d43)

3 months agoMerge pull request #58285 from pponnuvel/wip-66701-squid
Kamoltat (Junior) Sirivadhna [Wed, 16 Apr 2025 19:34:38 +0000 (15:34 -0400)]
Merge pull request #58285 from pponnuvel/wip-66701-squid

squid: mgr/nfs: Don't crash ceph-mgr if NFS clusters are unavailable.
Reviewed-by: Kamoltat Sirivadhna <ksirivad@redhat.com>
3 months agoMerge pull request #62834 from zdover23/wip-doc-2025-04-16-backport-62795-to-squid
Anthony D'Atri [Tue, 15 Apr 2025 20:02:11 +0000 (16:02 -0400)]
Merge pull request #62834 from zdover23/wip-doc-2025-04-16-backport-62795-to-squid

squid: doc/radosgw/cloud-transition: fix details

3 months agodoc/radosgw/cloud-transition: fix details 62834/head
Laimis Juzeliūnas [Sun, 13 Apr 2025 20:14:55 +0000 (23:14 +0300)]
doc/radosgw/cloud-transition: fix details

Fix documentation on Ceph cloud storage transitions - broken link urls, returning back reStructuredText and some other details.

Signed-off-by: Laimis Juzeliunas <laimis.juzeliunas@oxylabs.io>
Co-authored-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
(cherry picked from commit c47b559547326f837dde9dfed9eef526e275fa8e)

3 months agoMerge pull request #62202 from ifed01/wip-ifed-fix-expand-squi
Igor Fedotov [Tue, 15 Apr 2025 13:38:34 +0000 (16:38 +0300)]
Merge pull request #62202 from ifed01/wip-ifed-fix-expand-squi

squid: os/bluestore: fix bdev expansion and more

Reviewed-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
Reviewed-by: Adam Kupczyk <akupczyk@ibm.com>
3 months agotool/ceph-bluestore-tool: Make bluefs-bdev-expand command output nicer. 62202/head
Igor Fedotov [Tue, 18 Feb 2025 17:20:53 +0000 (20:20 +0300)]
tool/ceph-bluestore-tool: Make bluefs-bdev-expand command output nicer.

Here is a sample output:

inferring bluefs devices from bluestore path
0 : device size 0x4049c000(1.0 GiB) : using 0x1801000(24 MiB)
1 : device size 0x140000000(5 GiB) : using 0x1502000(21 MiB)
2 : device size 0x8c0000000(35 GiB) : using 0x40014000(1.0 GiB)
Expanding DB/WAL...
0 : nothing to do, skipped
1 : Expanding to 0x140000000(5 GiB)
1 : size updated to 0x140000000(5 GiB)
2 : Expanding to 0x8c0000000(35 GiB)
2 : size updated to 0x8c0000000(35 GiB)

Fixes: https://tracker.ceph.com/issues/67966
Signed-off-by: Igor Fedotov <igor.fedotov@croit.io>
(cherry picked from commit ac7789139e3d4ba3bfd69ddcd4fe504c35b42bc3)

3 months agoos/bluestore: do not log undecodable bdev label as an error
Igor Fedotov [Fri, 17 Jan 2025 13:23:34 +0000 (16:23 +0300)]
os/bluestore: do not log undecodable bdev label as an error

Signed-off-by: Igor Fedotov <igor.fedotov@croit.io>
(cherry picked from commit a70a3ced7e1f4ba0d124550d053e54d3a320f782)

3 months agodoc/ceph-bluestore-tool: add description for show-label-at command.
Igor Fedotov [Mon, 17 Feb 2025 21:03:01 +0000 (00:03 +0300)]
doc/ceph-bluestore-tool: add description for show-label-at command.

Signed-off-by: Igor Fedotov <igor.fedotov@croit.io>
(cherry picked from commit 4f5f8483444e4fa16939d917ca5e42120e7ccbc9)

3 months agoos/bluestore: fix alloc update after bdev expansion in NCB mode.
Igor Fedotov [Mon, 17 Feb 2025 20:51:18 +0000 (23:51 +0300)]
os/bluestore: fix alloc update after bdev expansion in NCB mode.

Fixes: https://tracker.ceph.com/issues/69997
Signed-off-by: Igor Fedotov <igor.fedotov@croit.io>
(cherry picked from commit bd7764bc699b4cc6b3edaf99369e40b59f335b21)

3 months agoos/bluestore: be less strict in main bdev label validation.
Igor Fedotov [Mon, 17 Feb 2025 20:14:34 +0000 (23:14 +0300)]
os/bluestore: be less strict in main bdev label validation.

This eliminates treating as an error the case when valid bdev label(s)
exists at location(s)  beyond the size in bdev label.
This is effectively not an error but _check_main_bdev_label() returns an
error in this case. Which is undetectable by fsck and unrecoverable by repair.

Signed-off-by: Igor Fedotov <igor.fedotov@croit.io>
(cherry picked from commit 2a9c776f6aa39e8f73ed0159f3c58ad2522a114a)

3 months agoos/bluestore: use proper device when updating DB/WAL label while
Igor Fedotov [Mon, 17 Feb 2025 19:04:18 +0000 (22:04 +0300)]
os/bluestore: use proper device when updating DB/WAL label while
expanding.

Fixes: https://tracker.ceph.com/issues/69999
Signed-off-by: Igor Fedotov <igor.fedotov@croit.io>
(cherry picked from commit ba3e4d2c9daf6b3af8340607e722f31b83e69db8)

3 months agoos/bluestore: don't use bdev.size() when dealing with bdev labels in fsck.
Igor Fedotov [Sat, 15 Feb 2025 23:18:03 +0000 (02:18 +0300)]
os/bluestore: don't use bdev.size() when dealing with bdev labels in fsck.

This might cause assertions after incomplete volume expansion
(expand-device cmd hasn't been called) as allocmap bitmaps are initialized with
bdev label.size not bdev.size() and hence they are accessed
out-of-bound.

Signed-off-by: Igor Fedotov <igor.fedotov@croit.io>
(cherry picked from commit 173bbe7dba7f0b835246fab9ecdba1f13c544460)

3 months agoos/bluestore: fix bdev label.size update when expanding device.
Igor Fedotov [Sat, 15 Feb 2025 22:09:51 +0000 (01:09 +0300)]
os/bluestore: fix bdev label.size update when expanding device.

Fixes: https://tracker.ceph.com/issues/69981
Signed-off-by: Igor Fedotov <igor.fedotov@croit.io>
(cherry picked from commit c06ccf57de36d8485754a9e65ce2ce997dbe7c5c)

3 months agotools/bluestore-tool: add "show-label-at" command
Igor Fedotov [Sat, 15 Feb 2025 17:13:22 +0000 (20:13 +0300)]
tools/bluestore-tool: add "show-label-at" command

Signed-off-by: Igor Fedotov <igor.fedotov@croit.io>
(cherry picked from commit 19788291c991d11313fb2bebce48dcb7354b882e)

3 months agotools/bluestore-tool: dump label locations with "show-label" cmd
Igor Fedotov [Sat, 15 Feb 2025 14:44:20 +0000 (17:44 +0300)]
tools/bluestore-tool: dump label locations with "show-label" cmd

Signed-off-by: Igor Fedotov <igor.fedotov@croit.io>
(cherry picked from commit 97bbbb11b3b4c5e5c69059f3c07a3d026efc8261)

3 months agoMerge pull request #62151 from YiteGu/wip-70148-squid
SrinivasaBharathKanta [Tue, 15 Apr 2025 03:56:24 +0000 (09:26 +0530)]
Merge pull request #62151 from YiteGu/wip-70148-squid

squid: blk/kerneldevice: notify_all only required when discard_drain wait for condition

3 months agoMerge pull request #62576 from YiteGu/wip-70671-squid
SrinivasaBharathKanta [Tue, 15 Apr 2025 03:54:55 +0000 (09:24 +0530)]
Merge pull request #62576 from YiteGu/wip-70671-squid

squid: blk/kerneldevice: fix invalid iterator usage after erase in discard_q…

3 months agoMerge pull request #62810 from zdover23/wip-doc-2025-04-15-backport-62799-to-squid
Anthony D'Atri [Mon, 14 Apr 2025 22:19:50 +0000 (18:19 -0400)]
Merge pull request #62810 from zdover23/wip-doc-2025-04-15-backport-62799-to-squid

squid: doc/cephadm/services: Fix formatting in osd.rst

3 months agodoc/cephadm/services: Fix formatting in osd.rst 62810/head
Anthony D'Atri [Mon, 14 Apr 2025 05:18:03 +0000 (01:18 -0400)]
doc/cephadm/services: Fix formatting in osd.rst

Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
(cherry picked from commit c56d2a5aaf79a3440607946a55b9e59ca8a6de5b)

3 months agoMerge pull request #61323 from ljflores/wip-69493-squid
Laura Flores [Mon, 14 Apr 2025 15:17:02 +0000 (10:17 -0500)]
Merge pull request #61323 from ljflores/wip-69493-squid

squid: common/pick_address: Add IPv6 support to is_addr_in_subnet

3 months agoMerge pull request #62796 from zdover23/wip-doc-2025-04-14-backport-62784-to-squid
Anthony D'Atri [Mon, 14 Apr 2025 01:43:31 +0000 (21:43 -0400)]
Merge pull request #62796 from zdover23/wip-doc-2025-04-14-backport-62784-to-squid

squid: doc/cephadm: Add admonition re restarting an OSD service

3 months agodoc/cephadm: Add admonition re restarting an OSD service 62796/head
Anthony D'Atri [Fri, 11 Apr 2025 14:29:52 +0000 (10:29 -0400)]
doc/cephadm: Add admonition re restarting an OSD service

Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
(cherry picked from commit 524db4609f5f0b4639828b327cfc972243e08ce7)

3 months agoMerge pull request #62711 from cbodley/wip-70783-squid
Casey Bodley [Fri, 11 Apr 2025 16:01:53 +0000 (12:01 -0400)]
Merge pull request #62711 from cbodley/wip-70783-squid

squid: rgw: keep the tails when copying object to itself

Reviewed-by: Jane Zhu <jzhu116@bloomberg.net>
3 months agoMerge pull request #62739 from ceph/squid-release
Yuri Weinstein [Thu, 10 Apr 2025 20:07:15 +0000 (13:07 -0700)]
Merge pull request #62739 from ceph/squid-release

v19.2.2

Reviewed-by: Adam Emerson <aemerson@redhat.com>
3 months agoMerge pull request #62311 from adamemerson/wip-63786-squid
Yuri Weinstein [Thu, 10 Apr 2025 14:53:09 +0000 (07:53 -0700)]
Merge pull request #62311 from adamemerson/wip-63786-squid

squid: test/cls_2pc_queue: fix multi-threaded access to non-atomic variables

Reviewed-by: Yuval Lifshitz <ylifshit@redhat.com>
3 months agoMerge pull request #62307 from adamemerson/wip-63378-squid
Yuri Weinstein [Thu, 10 Apr 2025 14:51:43 +0000 (07:51 -0700)]
Merge pull request #62307 from adamemerson/wip-63378-squid

squid: rgw/multisite: handle errors properly in RGWDataFullSyncSingleEntryCR()

Reviewed-by: Shilpa Jagannath <smanjara@redhat.com>
3 months agoMerge pull request #60785 from awojno-bloomberg/wip-68995-squid
Yuri Weinstein [Thu, 10 Apr 2025 14:50:40 +0000 (07:50 -0700)]
Merge pull request #60785 from awojno-bloomberg/wip-68995-squid

squid: rgw: implement x-amz-replication-status for PENDING & COMPLETED

Reviewed-by: Casey Bodley <cbodley@redhat.com>
3 months agoMerge pull request #62731 from afreen23/wip-70836-squid
afreen23 [Thu, 10 Apr 2025 08:52:48 +0000 (14:22 +0530)]
Merge pull request #62731 from afreen23/wip-70836-squid

squid: mgr/dashboard: Fix empty ceph version in GET api/hosts

Reviewed-by: Afreen Misbah <afreen@ibm.com>
Reviewed-by: Naman Munet <nmunet@redhat.com>
3 months agoMerge pull request #62395 from shraddhaag/wip-70135-squid
SrinivasaBharathKanta [Thu, 10 Apr 2025 01:20:47 +0000 (06:50 +0530)]
Merge pull request #62395 from shraddhaag/wip-70135-squid

squid: rados/test_crash.sh: add PG_DEGRADED to ignorelist

3 months agoMerge pull request #62402 from adamemerson/wip-70422-squid
Yuri Weinstein [Wed, 9 Apr 2025 19:31:57 +0000 (12:31 -0700)]
Merge pull request #62402 from adamemerson/wip-70422-squid

squid: rgw: Try to handle unwatch errors sensibly

Reviewed-by: Adam Emerson <aemerson@redhat.com>
3 months agoMerge pull request #61986 from zdover23/wip-doc-2025-02-25-backport-61984-to-squid
Yuri Weinstein [Wed, 9 Apr 2025 19:27:50 +0000 (12:27 -0700)]
Merge pull request #61986 from zdover23/wip-doc-2025-02-25-backport-61984-to-squid

squid: doc/rgw: clarify path-style vs virtual-hosted-style access

Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
3 months agotest/librbd/test_notify.py: drop RBD_DISABLE_UPDATE_FEATURES 62752/head
Ilya Dryomov [Tue, 8 Apr 2025 11:53:23 +0000 (13:53 +0200)]
test/librbd/test_notify.py: drop RBD_DISABLE_UPDATE_FEATURES

This was put in place in commit 9c0b239d70cd ("qa/upgrade:
conditionally disable update_features tests") to paper over a backwards
compatibility issue that arose from commit 01ff1530544c ("librbd: make
all maintenance op notifications async").  It's not needed in squid or
later because upgrades from octopus are tested only until reef.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit bfc0b4f3015ec79c00a0ab684a4b7d58cb667e86)

3 months agotest/librbd/test_notify.py: force line-buffered output
Ilya Dryomov [Mon, 7 Apr 2025 10:40:50 +0000 (12:40 +0200)]
test/librbd/test_notify.py: force line-buffered output

"master" and "slave" invocations are intended to run in parallel and
coordinate between themselves.  Ensure that their respective output is
properly timestamped and ordered in teuthology.log file.

Fixes: https://tracker.ceph.com/issues/70831
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit 49dbabcecec7c458a6d2ddfbd8e14a6ec419b953)

3 months agoMerge pull request #62540 from jbaergen-do/btree2-backport-upstream-squid
Igor Fedotov [Wed, 9 Apr 2025 16:52:30 +0000 (19:52 +0300)]
Merge pull request #62540 from jbaergen-do/btree2-backport-upstream-squid

squid: Backport the hybrid_btree2 allocator and prereqs

Reviewed-by: Igor Fedotov <igor.fedotov@croit.io>
3 months agorgw: clean-up of some code 62748/head
J. Eric Ivancich [Mon, 24 Mar 2025 23:44:20 +0000 (19:44 -0400)]
rgw: clean-up of some code

Comments added and formatting adjusted.

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
(cherry picked from commit a84f984d0324e9abc060f166dd626063361a7ab0)

3 months agorgw: add doc & doc testing for force option on `radosgw-admin object rm ...`
J. Eric Ivancich [Thu, 3 Apr 2025 00:23:41 +0000 (20:23 -0400)]
rgw: add doc & doc testing for force option on `radosgw-admin object rm ...`

Subject says it all.

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
(cherry picked from commit 333b5cd1e36c53b69462961046199e69e906f1cc)

3 months agorgw: add force option to `radosgw-admin object rm ...`
J. Eric Ivancich [Mon, 24 Mar 2025 23:45:06 +0000 (19:45 -0400)]
rgw: add force option to `radosgw-admin object rm ...`

The `radosgw-admin object rm ...` sub-command will give up if it
determines that there's an issue with the head object. This can make
it difficult for an admin to clean up a bucket index when there's a
damaged or missing head object.

When the user adds the "--yes-i-really-mean-it" command-line option,
it enables the "force mode". The bucket index entry(ies) will be
removed. If the object being removed is the current version in a
versioned bucket, the appropriate changes to the OLH will take place.

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
(cherry picked from commit 7e1ac21069e14a4d6c4d4748971943b7c8b8137c)

3 months agoblk/kerneldevice: notify_all only required when discard_drain wait for condition 62151/head
Yite Gu [Fri, 30 Aug 2024 11:31:36 +0000 (19:31 +0800)]
blk/kerneldevice: notify_all only required when discard_drain wait for condition

This will cause discard threads to wake up each other
if bdev_async_discard_threads >= 2.

Fixes: https://tracker.ceph.com/issues/67835
Signed-off-by: Yite Gu <yitegu0@gmail.com>
(cherry picked from commit cec2e4550fe520fa60445678934c04ba605913be)

3 months agoMerge pull request #62143 from ifed01/wip-ifed-no-compression-plugin-reload-squid
NitzanMordhai [Wed, 9 Apr 2025 07:26:54 +0000 (10:26 +0300)]
Merge pull request #62143 from ifed01/wip-ifed-no-compression-plugin-reload-squid

squid: os/bluestore: do cache locally compressor engines ever used

3 months agoMerge pull request #61854 from batrick/wip-69960-squid
NitzanMordhai [Wed, 9 Apr 2025 07:13:54 +0000 (10:13 +0300)]
Merge pull request #61854 from batrick/wip-69960-squid

squid: pybind/mgr/mgr_module: turn off all automatic transactions

3 months agoMerge pull request #62221 from ifed01/wip-ifed-limit-discard-qlen-squid
NitzanMordhai [Wed, 9 Apr 2025 07:09:05 +0000 (10:09 +0300)]
Merge pull request #62221 from ifed01/wip-ifed-limit-discard-qlen-squid

squid: blk/KernelDevice: Introduce a cap on the number of pending discards

3 months agorgw: CreateBucket returns success even if a racing DeleteBucket succeeds too 62741/head
Jane Zhu [Tue, 18 Mar 2025 04:02:59 +0000 (04:02 +0000)]
rgw: CreateBucket returns success even if a racing DeleteBucket succeeds too

Signed-off-by: Jane Zhu <jzhu116@bloomberg.net>
(cherry picked from commit 68c674ad48beb23e5cfd4eedabe53c880aeb45a5)

3 months agorgw: cleanup orphaned bucket entry in <user>.buckets OMAP
Jane Zhu [Thu, 6 Feb 2025 22:51:19 +0000 (22:51 +0000)]
rgw: cleanup orphaned bucket entry in <user>.buckets OMAP

Signed-off-by: Jane Zhu <jzhu116@bloomberg.net>
(cherry picked from commit 8fdf4431dc98ee3735dde9121501fedb9835bb71)

3 months agoMerge pull request #60562 from rishabh-d-dave/wip-68678-squid
SrinivasaBharathKanta [Wed, 9 Apr 2025 00:56:59 +0000 (06:26 +0530)]
Merge pull request #60562 from rishabh-d-dave/wip-68678-squid

squid: mgr: allow disabling always-on modules

3 months agoMerge pull request #62211 from NitzanMordhai/wip-70383-squid
SrinivasaBharathKanta [Wed, 9 Apr 2025 00:55:12 +0000 (06:25 +0530)]
Merge pull request #62211 from NitzanMordhai/wip-70383-squid

squid: suites/rados: cache tier deprecated, no need to keep the tests for it

3 months ago19.2.2 62739/head v19.2.2
Ceph Release Team [Tue, 8 Apr 2025 21:08:38 +0000 (21:08 +0000)]
19.2.2

Signed-off-by: Ceph Release Team <ceph-maintainers@ceph.io>
3 months agoPendingReleaseNote: add release note that mgr/volumes plugin can be... 60562/head
Rishabh Dave [Sun, 28 Jul 2024 17:36:42 +0000 (23:06 +0530)]
PendingReleaseNote: add release note that mgr/volumes plugin can be...

disabled now.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
(cherry picked from commit 3232f6b7af15c011774c3ff37c8a98e5cf7c4887)

3 months agoqa/cephfs: test enable/disable of volumes plugin
Rishabh Dave [Sun, 28 Jul 2024 16:43:07 +0000 (22:13 +0530)]
qa/cephfs: test enable/disable of volumes plugin

Signed-off-by: Rishabh Dave <ridave@redhat.com>
(cherry picked from commit 0abc227131c3e16077013f25a7c0fcfe1b7285a1)

Conflicts:
qa/cephfs/overrides/ignorelist_health.yaml
- this file in main had more entries than on this (squid) branch,
  resulting in cherry-picking conflict.

qa/tasks/cephfs/test_admin.py
- this file in main had more tests and a new set of test adjacent to
  tests added by this patch-series, resulting in cherry-picking conflict.

3 months agomon/MgrMonitor: allow disabling always-on MGR modules
Rishabh Dave [Thu, 18 Jul 2024 19:38:07 +0000 (01:08 +0530)]
mon/MgrMonitor: allow disabling always-on MGR modules

Add a new command ("ceph mgr module force disable <module>") that allows
forcibly disabling an always-on module. This command should ideally only
be used to for cluster recovery.

Fixes: https://tracker.ceph.com/issues/66005
Signed-off-by: Rishabh Dave <ridave@redhat.com>
(cherry picked from commit 9962772358048a98a6e871dccf1bfd0a15b4d791)

3 months agomon/MgrMontitor: add log entry to support debugging
Rishabh Dave [Thu, 8 Aug 2024 17:18:03 +0000 (22:48 +0530)]
mon/MgrMontitor: add log entry to support debugging

It becomes easier to understand logs when whether command succeeded or
not are also logged.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
(cherry picked from commit 4374ac74d283ce1c50616330a0127a53623d96c3)

3 months agomon/MgrMonitor: improve a log message
Rishabh Dave [Wed, 17 Jul 2024 12:35:33 +0000 (18:05 +0530)]
mon/MgrMonitor: improve a log message

Following log message has 3 distinct information (enabled modules,
modules that are alwats on and total number of commands enabled) printed
on the same line which makes it hard to find one of the information and
also makes it comparatively hard to read -

2024-07-17T17:21:16.609+0530 7f534ae006c0  0 mon.a@0(leader).mgr e0 create_initial initial modules iostat,nfs,volumes, always on modules balancer,crash,devicehealth,orchestrator,pg_autoscaler,progress,status,telemetry, 50 commands

With this commit it would be easier to read and find needed info -

2024-07-17T17:21:16.609+0530 7f534ae006c0  0 mon.a@0(leader).mgr e0 create_initial initial modules: iostat,nfs,volumes
2024-07-17T17:21:16.609+0530 7f534ae006c0  0 mon.a@0(leader).mgr e0 create_initial always on modules: balancer,crash,devicehealth,orchestrator,pg_autoscaler,progress,status,telemetry
2024-07-17T17:21:16.609+0530 7f534ae006c0  0 mon.a@0(leader).mgr e0 create_initial 50 commands

Signed-off-by: Rishabh Dave <ridave@redhat.com>
(cherry picked from commit e830f89240e382fdf5da676437ff783c4ea6ae42)

3 months agoMerge pull request #62270 from cybozu/wip-70445-squid
Ilya Dryomov [Tue, 8 Apr 2025 19:30:02 +0000 (21:30 +0200)]
Merge pull request #62270 from cybozu/wip-70445-squid

squid: debian: add ceph-exporter package

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
3 months agomgr/dashboard: Fix empty ceph version in GET api/hosts 62731/head
Afreen Misbah [Mon, 7 Apr 2025 19:00:08 +0000 (00:30 +0530)]
mgr/dashboard: Fix empty ceph version in GET api/hosts

Fixes https://tracker.ceph.com/issues/70821

Due to the pagination the host list is being fetched from orchestrator which caused a regression as via orchestrator list ceph version is always marked empty.
Caused by https://github.com/ceph/ceph/pull/52154

Also fixed tests , as the new version addition causing whole json object mock to fail in tests

Signed-off-by: Afreen Misbah <afreen@ibm.com>
(cherry picked from commit 1aa74cf3fce6394ad08e83e91a90923d983b03c5)

3 months agoMerge pull request #61496 from ljflores/wip-69168-squid
Kamoltat (Junior) Sirivadhna [Tue, 8 Apr 2025 15:59:16 +0000 (11:59 -0400)]
Merge pull request #61496 from ljflores/wip-69168-squid

squid: qa/workunits/mon: ensure election strategy is "connectivity" for stretch mode
Reviewed-by: Kamoltat Sirivadhna <ksirivad@redhat.com>
3 months agorgw: remove keep_tail from RGWObjState
Jane Zhu [Wed, 2 Apr 2025 15:53:47 +0000 (15:53 +0000)]
rgw: remove keep_tail from RGWObjState

Signed-off-by: Jane Zhu <jzhu116@bloomberg.net>
(cherry picked from commit fd76b6466c298121994ba65cce3c0e76f8568841)

Conflicts:
src/rgw/rgw_sal_store.h RGWObjState is in rgw_sal.h on squid

3 months agorgw: keep the tails when copying object to itself
Jane Zhu [Tue, 1 Apr 2025 13:45:36 +0000 (13:45 +0000)]
rgw: keep the tails when copying object to itself

Signed-off-by: Jane Zhu <jzhu116@bloomberg.net>
(cherry picked from commit 333e4a9b0de745cf5be40c5f6c32df7a340b007a)

3 months agorgw: remove keep_tail from RGWObjState 62711/head
Jane Zhu [Wed, 2 Apr 2025 15:53:47 +0000 (15:53 +0000)]
rgw: remove keep_tail from RGWObjState

Signed-off-by: Jane Zhu <jzhu116@bloomberg.net>
(cherry picked from commit fd76b6466c298121994ba65cce3c0e76f8568841)

Conflicts:
src/rgw/rgw_sal_store.h RGWObjState is in rgw_sal.h on squid

3 months agorgw: keep the tails when copying object to itself
Jane Zhu [Tue, 1 Apr 2025 13:45:36 +0000 (13:45 +0000)]
rgw: keep the tails when copying object to itself

Signed-off-by: Jane Zhu <jzhu116@bloomberg.net>
(cherry picked from commit 333e4a9b0de745cf5be40c5f6c32df7a340b007a)