mgr/dashboard: Fix delete listener

- pass gw_group to delete API in frontend
- when more than one gw groups present delete listener failing with error message: Multiple NVMe-oF gateway groups are configured. Please specify the 'gw_group' parameter in the request.
- added missing types, i18n

Fixes https://tracker.ceph.com/issues/71236

Signed-off-by: Afreen Misbah <afreen@ibm.com>

Merge PR #62250 into main

* refs/pull/62250/head:
qa/cephfs: increase data to be delay data sync by mirror daemon
cephfs-mirror: integrate blockdiff API for regular file transfers
mds: dout snapdiff snapid's before validation check
cephfs-mirror: current sync mechanism uses sync mechanism subclass'ing
qa: add test for syncing already existing snapshots
cephfs_mirror: avoid latest changes on the source fs to enable mirroring

Reviewed-by: Jos Collin <jcollin@redhat.com>

Merge PR #62414 into main

* refs/pull/62414/head:
mds: introduce BLOCKDIFF feature bit

Reviewed-by: Dhairya Parmar <dparmar@redhat.com>

Merge pull request #63209 from bluikko/doc-vault-cosmetic-radosgw

doc/radosgw: Cosmetic and formatting improvements in vault.rst

Reviewed-by: Zac Dover <zac.dover@proton.me>

Merge pull request #63175 from rhcs-dashboard/multisite-sync-status-alignment

mgr/dashboard: Multi-site-sync-status UI distortion for status in data sync

Reviewed-by: Afreen Misbah <afreen@ibm.com>
Reviewed-by: Aashish Sharma <aasharma@redhat.com>

doc/radosgw: Cosmetic and formatting improvements in vault.rst

Use generated "contents" instead of repeating section titles in an
ordered list.

Use Title Case for section titles.

Capitalize consistently "Ceph" and "Object Gateway", "Vault".

Use consistently all caps for acronyms.

Change one entry of "kms" to "SSE-KMS", seems obvious from the context.
Use "certificates" instead of "certs".

Use double backticks for file paths, commands, config options etc.

Improve language in one sentence, several words missing.

Call it consistently "the Object Gateway" and not sometimes "the
Gateway".

Add pre-formatted block for CLI command examples where missing (should
be promptified in the future).

Signed-off-by: Ville Ojamo <14869000+bluikko@users.noreply.github.com>

Merge pull request #63127 from rishabh-d-dave/vols-snappath-v1-and-legacy

mgr/vol: make "snapshot getpath" cmd work with v1 and legacy

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge pull request #63145 from tchaikov/no-using-std

tools/ceph_dedup: remove 'using namespace std'

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Reviewed-by: Myoungwon Oh <myoungwon.oh@samsung.com>

Merge pull request #62969 from zhscn/fix-cache-lru-size-metric

crimson/os/seastore/cache/LRU: account the empty extent when adding it to LRU

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Samuel Just <sjust@redhat.com>

tools/ceph_dedup: remove 'using namespace std'

Remove 'using namespace std' from common.h to maintain consistent coding
practices. Although common.h is only used by ceph_dedup implementation,
keeping namespace declarations out of header files prevents potential
name conflicts and follows best practices for C++ code organization.

This change improves code clarity and reduces the risk of symbol collisions
when standard library elements are used alongside custom
implementations.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>

Merge pull request #63143 from ceph/wip-retrigger-rtd2

.github: Fix RTD build retrigger

Merge pull request #63203 from bluikko/doc-archsync-ref-radosgw

doc/radosgw: Use ref for hyperlink in archive-sync-module.rst

Merge pull request #63205 from bluikko/doc-group-a-ref-radosgw

doc/radosgw: Use ref for hyperlinks, 1st batch

Merge pull request #63084 from zdover23/wip-doc-2025-05-01-mgr-administrator-62782-followup

doc/mgr: edit administrator.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

doc/radosgw: Use ref for hyperlinks, 1st batch

Use validated ":ref:" hyperlinks instead of "external links" in "target
definitions" when linking within the Ceph docs:
- Add a label at beginning of referenced files if missing.
- Remove unused "target definitions".

The rendered PR should look the same as the old docs, only differing in
the source RST.

Signed-off-by: Ville Ojamo <14869000+bluikko@users.noreply.github.com>

doc/radosgw: Use ref for hyperlink in archive-sync-module.rst

Use validated ":ref:" hyperlinks instead of "external links" in "target
definitions" when linking within the Ceph docs.

Signed-off-by: Ville Ojamo <14869000+bluikko@users.noreply.github.com>

Merge pull request #63173 from zdover23/wip-doc-2025-05-08-mgr-alerts-62782-followup

doc/mgr: edit alerts.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

Merge pull request #63172 from zdover23/wip-doc-2025-05-08-mgr-ceph-api-index-62782-followup

doc/mgr/ceph_api: edit index.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

Merge pull request #63103 from jdurgin/wip-crimson-gen-state-diagram

doc/script/gen_state_diagram.py: adapt for crimson BackfillMachine

Reviewed-by: Matan Breizman <mbreizma@redhat.com>

qa/cephfs: increase data to be delay data sync by mirror daemon

Signed-off-by: Venky Shankar <vshankar@redhat.com>

cephfs-mirror: integrate blockdiff API for regular file transfers

Fixes: http://tracker.ceph.com/issues/70225
Signed-off-by: Venky Shankar <vshankar@redhat.com>

mds: dout snapdiff snapid's before validation check

As a debug aid when the snapdiff request is erroring out.

Signed-off-by: Venky Shankar <vshankar@redhat.com>

cephfs-mirror: current sync mechanism uses sync mechanism subclass'ing

Fixes: https://tracker.ceph.com/issues/69671
Signed-off-by: Jos Collin <jcollin@redhat.com>
Signed-off-by: Venky Shankar <vshankar@redhat.com>

qa: add test for syncing already existing snapshots

Fixes: https://tracker.ceph.com/issues/68567
Signed-off-by: Jos Collin <jcollin@redhat.com>

cephfs_mirror: avoid latest changes on the source fs to enable mirroring

This avoids considering latest changes from the source filesystem for
the mirroring of already existing snapshots. Thus the destination
filesystem and snapshots would be created based only on the source snapshots.
The destination fs would be a replica of the last snapshot taken.

Fixes: https://tracker.ceph.com/issues/68567
Signed-off-by: Jos Collin <jcollin@redhat.com>

mds: introduce BLOCKDIFF feature bit

Fixes: http://tracker.ceph.com/issues/70584
Signed-off-by: Venky Shankar <vshankar@redhat.com>

Merge pull request #63126 from rhcs-dashboard/rgw-site-test-skip

qa/tests: skip rgw site tests in api

.github: Fix RTD build retrigger

Fixes: https://tracker.ceph.com/issues/70430
Signed-off-by: David Galloway <david.galloway@ibm.com>

Merge pull request #63088 from spuiuk/doc-provider

doc/mgr/smb: document the 'provider' option for smb share

Merge pull request #63180 from afreen23/fix-tox

mgr/dashboard: fix make check tests

doc/mgr/smb: document the 'provider' option for smb share

Signed-off-by: Sachin Prabhu <sp@spui.uk>

Merge pull request #63090 from ceph/wip-yuriw-18.2.7-release.notes-main

doc: reef 18.2.7 release notes

Reviewed-by: Laura Flores <lflores@redhat.com>
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Igor Fedotov <ifedotov@suse.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

Merge pull request #62745 from VallariAg/fix-2279225

mgr/cephadm/module.py: Run ok_to_stop logic for stop

qa/cephfs: use "snapshot getpath" cmd instead of constructing...

the path to a specific snapshot wherever possible.

Signed-off-by: Rishabh Dave <ridave@redhat.com>

qa/cephfs: add tests for "snapshot getpath" cmd against v1 and...

legacy subvolumes.

Signed-off-by: Rishabh Dave <ridave@redhat.com>

Merge pull request #62815 from aclamk/aclamk-bs-debug-print-shards

os/bluestore: Add printing shards to Onode::printer

mgr/dashboard: fix make check tests

Fixes https://tracker.ceph.com/issues/71246

Pr are failing with errors import errors running pylint

Signed-off-by: Afreen Misbah <afreen@ibm.com>

Merge pull request #63001 from tchaikov/librbd-tools-std-variant

librbd, tools: migrate from boost::variant to std::variant

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>

Fixes:https://tracker.ceph.com/issues/71248

Signed-off-by: Prachi <prgoel@redhat.com>
Changes:
Fixes for RGW multi-site-sync-status UI distortion in data sync

doc/mgr: edit alerts.rst

Edit doc/mgr/alerts.rst as part of the project to determine where the
error is in https://github.com/ceph/ceph/pull/62782 that prevents the
Jenkins tests from passing.

This commit adds to the work done in
https://github.com/ceph/ceph/pull/62782 by correcting some of the
English that was present in that PR.

This is a change to one of twenty-five files in
https://github.com/ceph/ceph/pull/62782, and this commit represents one
of what will be at least twenty-five other commits made to track this
error down.

Signed-off-by: Zac Dover <zac.dover@proton.me>

doc/mgr/ceph_api: edit index.rst

Edit doc/mgr/ceph_api/index.rst as part of the project to determine
where the error is in https://github.com/ceph/ceph/pull/62782 that
prevents the Jenkins tests from passing.

This is a change to one of twenty-five files in
https://github.com/ceph/ceph/pull/62782, and this commit represents one
of what will be at least twenty-five other commits made to track this
error down.

Signed-off-by: Zac Dover <zac.dover@proton.me>

Merge pull request #63171 from dmick/shut-up-do-cmake

do_cmake.sh: remove --progress, it's just noise

do_cmake.sh: remove --progress, it's just noise

and is particularly annoying in jenkins logs

Signed-off-by: Dan Mick <dan.mick@redhat.com>

Merge pull request #63038 from Hezko/remove-map-collection-dec

Remove map collection dec

Merge pull request #63156 from bluikko/doc-frontends-cosmetic-radosgw

doc/radosgw: Cosmetic and formatting improvements in frontends.rst

Merge pull request #63157 from bluikko/doc-index-titlecase-radosgw

doc/radosgw: Use Title Case consistently in index.rst

Merge pull request #63164 from yuvalif/wip-yuval-lua-doc

doc/rgw/lua: add info on luarocks package

Merge pull request #63050 from nbalacha/wip-nbalacha-71138

cls/rbd: write image mirror status if state is CREATING

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>

qa/tests: skip rgw site tests in api

Failure in https://jenkins.ceph.com/job/ceph-api/95185/

```
dashboard.rest_client.RequestException: RGW REST API GET timed out after 45 seconds (url=http://172.21.5.32:8000/admin/realm?list).
```

Signed-off-by: Nizamudeen A <nia@redhat.com>

doc/rgw/lua: add info on luarocks package

* remove duplicate contexts
* trim trailing spaces

Signed-off-by: Yuval Lifshitz <ylifshit@ibm.com>

doc/radosgw: Cosmetic and formatting improvements in frontends.rst

Capitalize terms like IPv4, SSL, URI consistently.

Title case for "Ceph Monitor".

Fix "Nagel" to "Nagle".

Use inline code consistently in references to configuration values and
reference to "beast" front-end.

Signed-off-by: Ville Ojamo <14869000+bluikko@users.noreply.github.com>

librbd, tools: migrate from boost::variant to std::variant

Complete migration started in commit 017f333, replacing boost::variant with
std::variant throughout the librbd codebase. This change is part of our ongoing
effort to reduce third-party dependencies by leveraging C++ standard library
alternatives where possible.

Benefits include:
- Improved code readability and maintainability
- Reduced external dependency surface
- More consistent API usage with other components

Implementation note: Unlike Boost.variant, std::variant lacks built-in
operator<< support. This commit implements the necessary operator<< for
AttributeValue, our specific std::variant instantiation, to preserve the
existing behavior.

Also, despite that `apply_visit()` calls can be replaced with `visit()`
without being qualified with `std::` because of ADL, we are taking this
opportunity to adding the `std::` prefix for better readability.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>

Merge pull request #63139 from anthonyeleven/icu

doc/cephadm: Correct formatting in upgrade.rst

Reviewed-by: Zac Dover <zac.dover@proton.me>

doc/releases: format bullet points

Signed-off-by: Laura Flores <lflores@ibm.com>
Signed-off-by: Yuri Weinstein <yweinste@redhat.com>

doc/cephadm: Correct formatting in upgrade.rst

Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>

qa/cephfs: add a helper method to construct the snapshot path

Signed-off-by: Rishabh Dave <ridave@redhat.com>

qa/cephfs: move tests for "snapshot getpath" cmd to a separate class

Signed-off-by: Rishabh Dave <ridave@redhat.com>

Merge pull request #57789 from ifed01/wip-ifed-non-spatial-alloc

os/bluestore: introduce device type specific allocation policy

Reviewed-by: Mark Nelson <mark.a.nelson@gmail.com>
Reviewed-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>

Merge pull request #53989 from mchangir/mds-handle-bad-arguments-during-subvolume-create-2

mgr/volumes: handle bad arguments during subvolume create

Reviewed-by: Rishabh Dave <ridave@redhat.com>

Merge pull request #62709 from kshtsk/wip-another-brxnet-by-default

tasks/cephfs/mount: use 192.168.144.0.0/20 for brxnet

Reviewed-by: Venky Shankar <vshankar@redhat.com>

Merge pull request #62847 from Matan-B/wip-matanb-crimson-do_recovery

crimson/osd/pg_recovery: rework start_recovery_ops

Reviewed-by: Aishwarya Mathuria <amathuri@redhat.com>

Merge pull request #62947 from VallariAg/fix-nvmeof-limit-alerts

monitoring: Fix NVMeoF subsys/namespace limit alerts

Merge pull request #62516 from mkogan1/wip-d3n-long-cache-ident

rgw/d3n: store cached objects using hash digest

Merge pull request #63112 from ceph/wip-yuriw-build-script

qa/tests: added "tentacle" option

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

Merge pull request #62398 from AliMasarweh/wip-alimasa-rgw-standalone-zone

RGW/standalone: refactor rgw_zone.h with configstore

Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Daniel Gryniewicz <dang@redhat.com>

Merge pull request #62891 from ShwetaBhosale1/fix_issue_70985_nfs_add_vip_in_HAProxy_Hosts_list

mgr/nfs: Add VIP to HAProxy_Hosts list for ingress type haproxy-protocol

Reviewed-by: Adam King <adking@redhat.com>

Merge pull request #62848 from ShwetaBhosale1/fix_issue_70950_add_command_to_stop_host_drain

mgr/cephadm: Add command to stop host drain

Reviewed-by: Adam King <adking@redhat.com>

Merge pull request #62755 from adk3798/cephadm-upgrade-smb

mgr/cephadm: add smb to upgrade order

Reviewed-by: John Mulligan <jmulligan@redhat.com>

Merge pull request #62718 from adk3798/nfs-export-parse-systype

mgr/nfs: make sure sectype is a list when parsed

Reviewed-by: John Mulligan <jmulligan@redhat.com>

Merge pull request #62585 from adk3798/block-nvmeof-deployment-all-groups

mgr/cephadm: block deploying nvmeof daemons on the same host

Reviewed-by: John Mulligan <jmulligan@redhat.com>

qa/tests: added "tentacle" option

Signed-off-by: Yuri Weinstein <yweinste@redhat.com>

Merge pull request #62743 from cloudbehl/pool_metadata

mgr/dashboard: Added application label to pool_metadata query

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Anmol Babu <anmolbudugutta@gmail.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>

Merge pull request #62638 from rishabh-d-dave/vols-path-gone-missing

mgr/vol: some improvements for stats_util.py and async_cloner.py

Reviewed-by: Milind Changire <mchangir@redhat.com>

Merge pull request #63093 from ronen-fr/wip-rf-restrictions

osd/scrub: check all(*) conditions in restrictions_on_scrubbing()

Reviewed-by: Nitzan Mordechai <nmordech@redhat.com>

crimson/osd: Logging fixes

* Fix "failed to log message"
* PGRecovery move to new logging macro
* PGRecovery to print pg prefix as it's impossible to debug specific pg
  recovery ops without it.

Signed-off-by: Matan Breizman <mbreizma@redhat.com>

crimson/osd/pg: Let PGListener use start_peering_event_operation

PG::start_peering_event_operation is a template function while
PGRecovery::pg is of PGRecoveryListener* type. We can't expose a template
function through the PGRecoveryListener interface since it must be
also virtual.
Instead, introduce start_peering_event_operation_listener which will act
as a wrapper to PG::start_peering_event_operation for PGRecovery to use
freely.

Signed-off-by: Matan Breizman <mbreizma@redhat.com>

crimson/osd: Convert do_recovery() from bool to stop_iteration

Signed-off-by: Matan Breizman <mbreizma@redhat.com>

crimson/osd/pg_recovery: rewrite start_recovery_ops

We had few confusions around the return value from start_recovery_ops.
This commit is a groundwork for the return type change.

* Move to coroutines
* Update logging macro

Signed-off-by: Matan Breizman <mbreizma@redhat.com>

mgr/vol: log in case path goes in missing in async_cloner.py

Add a log entry in case the source and/or destination path goes missing
for a clone operation.

Fixes: https://tracker.ceph.com/issues/71019
Signed-off-by: Rishabh Dave <ridave@redhat.com>

mgr/vol: handle case where path goes missing for a clone

A thread is spawned to get the value of a certain extended attribute to
generate the progress statistics for the ongoing clone operations. In
case source and/or destination path for a clone operation goes missing,
this thread crashes. Instead of crashing, handle this case gracefully.

Fixes: https://tracker.ceph.com/issues/71019
Signed-off-by: Rishabh Dave <ridave@redhat.com>

Merge pull request #62809 from rzarzynski/wip-bug-70878

osd: fix init of op_queue_type_t due to returnable ceph_assert()

Merge pull request #62705 from NitzanMordhai/wip-nitzan-pglog-missing-validation

osd_types: Restore new_object marking for delete missing entries

osd/scrub: check all(*) conditions in restrictions_on_scrubbing()

Modified OsdScrub::restrictions_on_scrubbing() to check all(*)
conditions, instead of stopping at the first one that is true.
The "new" (since Tentacle) scrub-type-to-conditions mapping is no
longer a simple one (is not "monotonic" in the sense of restrictions
always being removed as the scrub type is more important),
and the caller may want to know them all.

(*) The somewhat costly check for the random backoff is still only
    performed if the OSD is not already running too many scrubs.

Fixes: https://tracker.ceph.com/issues/71169
Signed-off-by: Ronen Friedman <rfriedma@redhat.com>

doc/script/gen_state_diagram.py: adapt for crimson BackfillMachine

Allow non-const events and abbreviating 'boost::statechart' as 'sc'

Signed-off-by: Josh Durgin <jdurgin@ibm.com>

Merge pull request #62873 from chardan/jfw-wip-rgw-support-catch2

Add Support for Catch2 unit tests

Add support for Catch2

Makes Catch2 available for C++ unit tests;
Adds GPM script availability to CMake.
Adds rudimentary test for rgw_hex.

Signed-off-by: Jesse F. Williamson <jfw@ibm.com>

Merge pull request #63081 from clwluvw/admin-bucket-rm-err-code

rgw-admin: report correct error code for non-existent bucket on deletion

Reviewed-by: Shilpa Jagannath <smanjara@redhat.com>

Merge pull request #62993 from cbodley/wip-71098

rgw/multisite: rgw_forward_request_to_master() preserves Error responses

Reviewed-by: Seena Fallah <seenafallah@gmail.com>
Reviewed-by: Shilpa Jagannath <smanjara@redhat.com>

Merge pull request #62903 from jzhu116-bloomberg/wip-70992

rgw: prefetch data from versioned object instance head

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #62011 from kchheda3/wip-allow-multiple-rgws

rgw/frontend: Allow multiple RGWs to run on same port on same host

Reviewed-by: Adam C. Emerson <aemerson@redhat.com>

Merge pull request #62851 from cbodley/wip-rgw-beast-async-disable

rgw: frontend reads/writes respect rgw_beast_enable_async

Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>

Merge PR #63083 into main

* refs/pull/63083/head:
doc/cephfs: add snapshot name note

Reviewed-by: Anthony D Atri <anthony.datri@gmail.com>

doc: reef 18.2.7 release notes

Signed-off-by: Yuri Weinstein <yweinste@redhat.com>

doc/cephfs: add snapshot name note

The charmap is not applied to snapshot names!

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>

Merge pull request #63056 from ronen-fr/wip-rf-fadvise

osd/scrub: making Scrub's fadvide flags a constant

Reviewed-by: Alex Ainscow <aainscow@uk.ibm.com>

Merge pull request #62805 from Matan-B/wip-matanb-rep-read-perfcount

osd/PrimaryLogPG: Relax replicated reads when recovering

Reviewed-by: Samuel Just <sjust@redhat.com>

Merge pull request #62866 from ifed01/wip-ifed-osd-bench-more-logging

osd: be more verbose in OSD::run_osd_bench_test

Reviewed-by: Sridhar Seshasayee <sseshasa@redhat.com>

doc/mgr: edit administrator.rst

Edit doc/mgr/administrator.rst. Add prompts and correct some of the
inelegant English present in the file.

This commit is part of a project to separate out the twenty-five files
that were committed to https://github.com/ceph/ceph/pull/62782.

Credit for this initiative should go to Ville Ojamo.

Signed-off-by: Zac Dover <zac.dover@proton.me>

mgr/dashboard:  remove map_collection decorator and adapt host list nvme endpoint

Signed-off-by: Tomer Haskalovitch <il033030@tomers-mbp.givatayim.il.ibm.com>

Merge pull request #63041 from cbodley/wip-qa-rgw-upgrade-goodbye-quincy

qa/rgw: prepare for tentacle testing

Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>