]>
git.apps.os.sepia.ceph.com Git - ceph.git/log
David Galloway [Tue, 6 May 2025 21:31:03 +0000 (17:31 -0400)]
.github: Fix RTD build retrigger
Fixes: https://tracker.ceph.com/issues/70430
Signed-off-by: David Galloway <david.galloway@ibm.com>
(cherry picked from commit
27521bf5580d4f878fbf7cafbd854bc6ef94aed4 )
Anthony D'Atri [Fri, 9 May 2025 12:45:06 +0000 (08:45 -0400)]
Merge pull request #63196 from zdover23/wip-doc-2025-05-09-backport-63172-to-tentacle
tentacle: doc/mgr/ceph_api: edit index.rst
Anthony D'Atri [Fri, 9 May 2025 12:43:49 +0000 (08:43 -0400)]
Merge pull request #63199 from zdover23/wip-doc-2025-05-08-backport-63173-to-tentacle
tentacle: doc/mgr: edit alerts.rst
Anthony D'Atri [Fri, 9 May 2025 12:27:43 +0000 (08:27 -0400)]
Merge pull request #63206 from zdover23/wip-doc-2025-05-09-backport-63084-to-tentacle
tentacle: doc/mgr: edit administrator.rst
Zac Dover [Thu, 1 May 2025 04:12:45 +0000 (14:12 +1000)]
doc/mgr: edit administrator.rst
Edit doc/mgr/administrator.rst. Add prompts and correct some of the
inelegant English present in the file.
This commit is part of a project to separate out the twenty-five files
that were committed to https://github.com/ceph/ceph/pull/62782.
Credit for this initiative should go to Ville Ojamo.
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit
859950180f0b7314b097ee9b2f9f192f4cfb3ed4 )
Nizamudeen A [Fri, 9 May 2025 07:30:54 +0000 (13:00 +0530)]
Merge pull request #63185 from rhcs-dashboard/wip-71256-tentacle
tentacle: mgr/dashboard: fix make check tests
Zac Dover [Thu, 8 May 2025 02:29:25 +0000 (12:29 +1000)]
doc/mgr: edit alerts.rst
Edit doc/mgr/alerts.rst as part of the project to determine where the
error is in https://github.com/ceph/ceph/pull/62782 that prevents the
Jenkins tests from passing.
This commit adds to the work done in
https://github.com/ceph/ceph/pull/62782 by correcting some of the
English that was present in that PR.
This is a change to one of twenty-five files in
https://github.com/ceph/ceph/pull/62782, and this commit represents one
of what will be at least twenty-five other commits made to track this
error down.
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit
db28c1f32ff67bd1087866c7976233e8ab23fa2c )
Zac Dover [Thu, 8 May 2025 00:08:06 +0000 (10:08 +1000)]
doc/mgr/ceph_api: edit index.rst
Edit doc/mgr/ceph_api/index.rst as part of the project to determine
where the error is in https://github.com/ceph/ceph/pull/62782 that
prevents the Jenkins tests from passing.
This is a change to one of twenty-five files in
https://github.com/ceph/ceph/pull/62782, and this commit represents one
of what will be at least twenty-five other commits made to track this
error down.
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit
5c17f2242318d57e9faaafc83774a8f8a36f6e0e )
Afreen Misbah [Thu, 8 May 2025 08:53:07 +0000 (14:23 +0530)]
mgr/dashboard: fix make check tests
Fixes https://tracker.ceph.com/issues/71246
Pr are failing with errors import errors running pylint
Signed-off-by: Afreen Misbah <afreen@ibm.com>
(cherry picked from commit
29f0f2914efacd2e6b9bc7115f5c2d3790bb12cc )
Yuri Weinstein [Thu, 8 May 2025 15:27:57 +0000 (08:27 -0700)]
Merge pull request #63094 from afreen23/wip-71158-tentacle
tentacle: mgr/dashboard: Bump grafana version to 11.6.0
Reviewed-by: Adam King adking@redhat.com
Casey Bodley [Thu, 8 May 2025 12:48:52 +0000 (08:48 -0400)]
Merge pull request #63082 from cbodley/wip-qa-rgw-tentacle
tentacle: qa/rgw: point tentacle qa suites at ceph-tentacle test branches
Reviewed-by: Adam C. Emerson <aemerson@redhat.com>
Anthony D'Atri [Wed, 7 May 2025 01:38:02 +0000 (21:38 -0400)]
Merge pull request #63146 from zdover23/wip-doc-2025-05-07-backport-63139-to-tentacle
tentacle: doc/cephadm: Correct formatting in upgrade.rst
Anthony D'Atri [Tue, 6 May 2025 16:42:18 +0000 (12:42 -0400)]
doc/cephadm: Correct formatting in upgrade.rst
Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
(cherry picked from commit
0e1adc4ae69b9fdc8f4a8480f3e498efa06520f4 )
Matan Breizman [Tue, 6 May 2025 07:39:27 +0000 (10:39 +0300)]
Merge pull request #63061 from Matan-B/wip-71137-tentacle
tentacle: crimson: osd_operation cleanups and fix for MOSDRepOpReply ordering
Reviewed-by: Aishwarya Mathuria <amathuri@redhat.com>
Matan Breizman [Tue, 6 May 2025 07:38:14 +0000 (10:38 +0300)]
Merge pull request #63059 from Matan-B/wip-matanb-crimson-tentacle-62894
crimson: fix unused variable warnings due to assert() and NDEBUG builds
Reviewed-by: Aishwarya Mathuria <amathuri@redhat.com>
Matan Breizman [Tue, 6 May 2025 07:37:45 +0000 (10:37 +0300)]
Merge pull request #63058 from Matan-B/wip-matanb-crimson-tentacle-63035
tentacle: crimson/osd/recovery_backend: scan_for_backfill_primary correctly handle
Reviewed-by: Aishwarya Mathuria <amathuri@redhat.com>
Zac Dover [Tue, 6 May 2025 00:07:05 +0000 (10:07 +1000)]
Merge pull request #63107 from zdover23/wip-doc-2025-05-05-backport-62860-to-tentacle
tentacle: doc: update cephfs-journal-tool docs
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Jos Collin [Thu, 17 Apr 2025 10:13:46 +0000 (15:43 +0530)]
doc: update cephfs-journal-tool docs
Fixes: https://tracker.ceph.com/issues/70953
Signed-off-by: Jos Collin <jcollin@redhat.com>
(cherry picked from commit
7ae0c22dfd63d14773966ab3796c68f1be913534 )
Afreen Misbah [Tue, 15 Apr 2025 13:05:50 +0000 (18:35 +0530)]
mgr/dashboard: Bump grafana version to 11.6.0
Fixes https://tracker.ceph.com/issues/70929
Signed-off-by: Afreen Misbah <afreen@ibm.com>
(cherry picked from commit
8fcb0b67409d4101de7d5a53c438df7c253db898 )
Casey Bodley [Thu, 1 May 2025 19:57:36 +0000 (15:57 -0400)]
Merge pull request #63043 from cbodley/wip-71115-tentacle
tentacle: rgw/sts: correcting authentication in case s3 ops are directed to a primary from secondary after assumerole.
Reviewed-by: Seena Fallah <seenafallah@gmail.com>
Casey Bodley [Thu, 1 May 2025 19:55:03 +0000 (15:55 -0400)]
Merge pull request #63075 from cbodley/wip-71151-tentacle
tentacle: rgw/lc: stop using merge_and_store_attrs in remove_bucket_config
Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
Casey Bodley [Thu, 1 May 2025 19:54:37 +0000 (15:54 -0400)]
Merge pull request #63051 from pritha-srivastava/wip-71108-tentacle
tentacle: rgw/sts: Implementation of validating JWT using modulus and exponent
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Casey Bodley [Wed, 30 Apr 2025 20:26:52 +0000 (16:26 -0400)]
qa/rgw: point tentacle qa suites at ceph-tentacle test branches
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Casey Bodley [Tue, 29 Apr 2025 13:39:43 +0000 (09:39 -0400)]
qa/rgw/upgrade: add upgrade from squid
Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit
f9eced0ba754a4d2fe586b14a6c809292357ab6e )
Casey Bodley [Tue, 29 Apr 2025 13:36:16 +0000 (09:36 -0400)]
qa/rgw/upgrade: remove upgrade from quincy
Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit
01d2ff3fb0df1381cbfc8c8ff6af623877d4e5ff )
Casey Bodley [Fri, 25 Apr 2025 17:38:50 +0000 (13:38 -0400)]
rgw/lc: stop using merge_and_store_attrs in remove_bucket_config
merge_and_store_attrs() is no longer able to remove xattrs. change the
sal::Bucket's attrs manually and call put_info() to write them back
Fixes: https://tracker.ceph.com/issues/71083
Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit
f3cc52124c650d32be2adf3cf540167142423c42 )
Anthony D'Atri [Wed, 30 Apr 2025 13:28:26 +0000 (09:28 -0400)]
Merge pull request #63070 from sseshasa/wip-71143-tentacle
tentacle: doc/rados: Update mClock doc on steps to override OSD IOPS capacity config
Sridhar Seshasayee [Tue, 15 Apr 2025 13:01:50 +0000 (18:31 +0530)]
doc/rados: Update mClock doc on steps to override OSD IOPS capacity config
Describe the steps involved to
- Specify a global value for osd_mclock_max_capacity_iops_{ssd,hdd}, and
- Override existing individually scoped values for OSDs determined during
start-up for osd_mclock_max_capacity_iops_{ssd,hdd}.
The above is to help with the following:
- Steps to override existing setting with a global value.
- reduce the number of entries in the mon store and instead use a single
global specification for all OSDs in the cluster in case the underlying
hardware is the same for all OSDs.
Signed-off-by: Sridhar Seshasayee <sseshasa@redhat.com>
Fixes: https://tracker.ceph.com/issues/70774
(cherry picked from commit
899da82ae2e857f2a769c08d6623e6da7678d16b )
Samuel Just [Fri, 4 Apr 2025 02:13:58 +0000 (19:13 -0700)]
crimson: add operation wrapper for MOSDRepOpReply
This should avoid reordering between cores.
Fixes: https://tracker.ceph.com/issues/69439
Signed-off-by: Samuel Just <sjust@redhat.com>
(cherry picked from commit
0c15eb5ca59c98d776091c5602888b0895df0a72 )
Samuel Just [Sat, 5 Apr 2025 02:12:33 +0000 (02:12 +0000)]
crimson: convert cross-core operations to use RemoteOperation
Signed-off-by: Samuel Just <sjust@redhat.com>
(cherry picked from commit
b031373de33894e29fa4bf4d207b480a31431c08 )
Samuel Just [Sat, 5 Apr 2025 01:57:33 +0000 (18:57 -0700)]
crimson: fix DynamicPerfStats usage in ClientRequest
ClientRequest::get_connection() return l_conn, which will be
null by the time PG::add_client_request_lat is called in
ClientRequest::do_process. Modify get_connection() to
return a Connection& from whichever of l_conn or r_conn
isn't null.
Signed-off-by: Samuel Just <sjust@redhat.com>
(cherry picked from commit
794bb024efa94cb2bb2a90df226bab05c8b9449b )
Samuel Just [Fri, 4 Apr 2025 01:34:50 +0000 (01:34 +0000)]
crimson/.../osd_operation.h: add RemoteOperation
Subsequent commits will switch various ops to inherit from
this thereby removing some boilerplate.
Signed-off-by: Samuel Just <sjust@redhat.com>
(cherry picked from commit
6da6b0f83cbe18520566ca91fef609de23b399a5 )
Samuel Just [Fri, 4 Apr 2025 02:16:11 +0000 (19:16 -0700)]
crimson/.../osd.cc: convert active ops to start_pg_operation_active
Signed-off-by: Samuel Just <sjust@redhat.com>
(cherry picked from commit
607c773db36d98af65eca4df91f315782f0bb652 )
Samuel Just [Tue, 25 Mar 2025 21:02:03 +0000 (21:02 +0000)]
crimson/.../pg_shard_manager: add start_pg_operation_active
Messages between OSDs for PGs that have already completed peering
require fewer checks than otherwise.
Signed-off-by: Samuel Just <sjust@redhat.com>
(cherry picked from commit
1a75da4b0d22a765eca4807252a0667c2a2266cc )
Samuel Just [Thu, 3 Apr 2025 03:42:11 +0000 (03:42 +0000)]
crimson: remove CommonClientRequest, move do_recover_missing to PG
do_recover_missing was the only thing left, and inheriting from a class
to get a static method is somewhat confusing. Simply move
do_recover_missing to PG.
Signed-off-by: Samuel Just <sjust@redhat.com>
(cherry picked from commit
ee11626dc7cb1b8719ba3ca41d3ca0ce6d3af1a0 )
Samuel Just [Thu, 3 Apr 2025 03:04:56 +0000 (03:04 +0000)]
crimson/.../client_request_common: convert do_recover_missing to use coroutine
Signed-off-by: Samuel Just <sjust@redhat.com>
(cherry picked from commit
a85888fa6939f9feb6b7307d2d30afe4a87c3e48 )
Samuel Just [Thu, 3 Apr 2025 03:03:19 +0000 (03:03 +0000)]
crimson/.../client_request_common: convert do_recover_missing to use log macros
Signed-off-by: Samuel Just <sjust@redhat.com>
(cherry picked from commit
05230fc9bf097fecfe3cb948105277c2fc41ba63 )
Samuel Just [Fri, 4 Apr 2025 02:12:33 +0000 (19:12 -0700)]
crimson: finish_decode() of MOSDRepOp on target core
Signed-off-by: Samuel Just <sjust@redhat.com>
(cherry picked from commit
bd95adc594908047afd8bb40328ff8dda4488908 )
Samuel Just [Tue, 18 Mar 2025 19:34:53 +0000 (19:34 +0000)]
crimson: handle_rep_op_reply downgrade stale message to debug
This isn't actually unusual or alarming.
Signed-off-by: Samuel Just <sjust@redhat.com>
(cherry picked from commit
d5f6d033b612a691d27b5b78cf2361180cda696c )
Radoslaw Zarzynski [Mon, 21 Apr 2025 07:39:23 +0000 (07:39 +0000)]
crimson: fix unused variable warnings due to assert() and NDEBUG builds
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
(cherry picked from commit
1cb23c32e65315235522365f281aa3f6811e160a )
Matan Breizman [Tue, 29 Apr 2025 10:10:07 +0000 (10:10 +0000)]
crimson/osd/recovery_backend: scan_for_backfill_primary correctly handle
missing object
scan_for_backfill was seperated to scan_for_backfill_primary and
scan_for_backfill_replica.
The fix from:
https://github.com/ceph/ceph/pull/62837/commits/
88432ebd7432c513ccd495e77425401beddb9953
was only copied to the replica version.
Fixes: https://tracker.ceph.com/issues/71124
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
(cherry picked from commit
2848bc8ce33bb786e4be3ea52559660282544881 )
Guillaume Abrioux [Wed, 30 Apr 2025 07:23:15 +0000 (09:23 +0200)]
Merge pull request #63013 from guits/wip-71109-tentacle
tentacle: ceph-volume: Fix splitting with too many parts
Pritha Srivastava [Mon, 17 Feb 2025 08:11:15 +0000 (13:41 +0530)]
rgw/sts: Use client_id for assumerolewithwebidentityresponse
if aud is not present in JWT.
Signed-off-by: Pritha Srivastava <prsrivas@redhat.com>
(cherry picked from commit
b5bbeb7ea3a65bfed368f834cc6c11fa23ee24e1 )
Pritha Srivastava [Thu, 13 Feb 2025 11:18:43 +0000 (16:48 +0530)]
rgw/sts: adding validation of jwks_uri cert according
to https://docs.aws.amazon.com/IAM/latest/UserGuide/id_roles_providers_create_oidc_verify-thumbprint.html
for n&e which can be later used for all key types
(x5c, n&e).
Signed-off-by: Pritha Srivastava <prsrivas@redhat.com>
(cherry picked from commit
d970f62e3e264644ea474ad4ee513caac977268f )
Pritha Srivastava [Wed, 12 Feb 2025 08:06:20 +0000 (13:36 +0530)]
rgw/sts: fix to pick jwk which is of type
'sig' for signature validation of the token.
Fixes: https://tracker.ceph.com/issues/54562
Signed-off-by: Pritha Srivastava <prsrivas@redhat.com>
(cherry picked from commit
4c08b48a655f549c0375b2ce728737647ec5cb31 )
Pritha Srivastava [Thu, 26 Dec 2024 08:56:30 +0000 (14:26 +0530)]
rgw/sts: adding code for JWT signature validation
using modulus and exponent for RSA group of algorithms.
A couple of issues and a fix have been suggested by
Pupu Toivonen (pupu.toivonen@csc.fi) in signature calculation
using modulus and exponent.
Fixes: https://tracker.ceph.com/issues/51018
Signed-off-by: Pritha Srivastava <prsrivas@redhat.com>
(cherry picked from commit
b368cab8064925674c008c0e8c39d17fbf964ac6 )
afreen23 [Tue, 29 Apr 2025 23:56:38 +0000 (05:26 +0530)]
Merge pull request #63036 from afreen23/wip-71123-tentacle
tentacle: mgr/dashboard: Update translations
Reviewed-by: Nizamudeen A <nia@redhat.com>
Ronen Friedman [Tue, 29 Apr 2025 16:33:44 +0000 (19:33 +0300)]
Merge pull request #63037 from ronen-fr/wip-rf-63010-tentacle
tentacle: qa/standalone/scrub: fix expected outputs in repair tests
Reviewed-by: Adam Kupczyk <akupczyk@ibm.com>
Seena Fallah [Mon, 28 Apr 2025 17:44:10 +0000 (19:44 +0200)]
rgw: utilize is_impersonating for forwarded sts requests
With the introduction of is_impersonating in SysReqApplier,
RoleApplier can now use the same mechanism to mark when a request
has been forwarded by a system user on behalf of another role (e.g.,
through STS) to mark it as a system request (s->system_request).
Signed-off-by: Seena Fallah <seenafallah@gmail.com>
(cherry picked from commit
995dc6284ea32fb2c87fb8e1cf2001b0fe9f5f45 )
Seena Fallah [Wed, 23 Apr 2025 22:22:23 +0000 (00:22 +0200)]
rgw: dont rate limit forwarded requests
rely on s->system_request to skip rate limiting on forwarded requests
as well as normal system user requests.
Signed-off-by: Seena Fallah <seenafallah@gmail.com>
(cherry picked from commit
004ccc7a987c98b7eb87d698b8091ae95665fe7c )
Seena Fallah [Wed, 23 Apr 2025 22:22:08 +0000 (00:22 +0200)]
rgw: use is_admin() for permission checks
Signed-off-by: Seena Fallah <seenafallah@gmail.com>
(cherry picked from commit
cc033cb16ff2971d215a92fab3038b185251cc22 )
Seena Fallah [Fri, 18 Apr 2025 14:42:24 +0000 (16:42 +0200)]
rgw: override perms for admin on data sync
If pipe is in user mode and the user is admin, don't check for perms
and let it go.
Signed-off-by: Seena Fallah <seenafallah@gmail.com>
(cherry picked from commit
97b4b608fba21bf2bac69ebcffca114484049680 )
Seena Fallah [Thu, 17 Apr 2025 22:09:12 +0000 (00:09 +0200)]
rgw: change is_admin_of() to is_admin()
As admin propery of a user is something global and nothing related
to any other owner, we don't need any comparision.
Signed-off-by: Seena Fallah <seenafallah@gmail.com>
(cherry picked from commit
1a253ea065a5de9636b769b41cc46a4fbc18c3f8 )
Seena Fallah [Tue, 1 Apr 2025 15:28:10 +0000 (17:28 +0200)]
rgw: make rgw_sync_pipe_params::user optional
In rgw_sync_pipe_params, the mode can be either system or user.
When in system mode, no user is involved, but the current
implementation holds an empty rgw_user, which can cause confusion
in pipe_rules::find_basic_info_without_tags().
With this change, rgw_user is now optional, ensuring that when no
user is involved, it is explicitly nullopt rather than an empty object.
Signed-off-by: Seena Fallah <seenafallah@gmail.com>
(cherry picked from commit
c8aca216f7d186e4e8391a284d14948afd414957 )
Seena Fallah [Fri, 28 Mar 2025 23:00:02 +0000 (00:00 +0100)]
qa/rgw: add perm check test for copy obj between zonegroups
Make sure perms are evaluated properly for the source object.
Signed-off-by: Seena Fallah <seenafallah@gmail.com>
(cherry picked from commit
9523e15fb74e09718f5cc9c0bddf2492fc8d8128 )
Seena Fallah [Mon, 24 Feb 2025 15:47:50 +0000 (16:47 +0100)]
doc: add release note for new policy actions on replication
Fixes: https://tracker.ceph.com/issues/70093
Signed-off-by: Seena Fallah <seenafallah@gmail.com>
(cherry picked from commit
8c15d4674f567c7b35d5aac0a9ac4e62306f7b13 )
Seena Fallah [Fri, 28 Mar 2025 20:55:20 +0000 (21:55 +0100)]
rgw: remote copy obj pass rgwx-perm-check-uid for perm evaluation
When copying object from remote source (bucket from another zonegroup)
the perms of the source is not evaluated resulting in reading from
unauthorized buckets.
passing `rgwx-perm-check-uid` will let the source zone evaluates the
perm and close this bug.
Signed-off-by: Seena Fallah <seenafallah@gmail.com>
(cherry picked from commit
3c83520d3338e85e2219e34e77d1149033533a71 )
Seena Fallah [Fri, 28 Mar 2025 20:52:47 +0000 (21:52 +0100)]
rgw: RGWRadosPutObj evals source bucket perm for backward compatibility
As of
a3f40b4 we no longer evaluate perms locally for source bucket,
this could cause broken permission evaluation dusring upgrade as one
zone is not respecting the perm evaluation based on the `rgwx-perm-check-uid`
arg.
This can be dropped in T+2 release.
Signed-off-by: Seena Fallah <seenafallah@gmail.com>
(cherry picked from commit
926ed16c27c0625427ae04d7298a5e47c1aba22b )
Seena Fallah [Thu, 24 Apr 2025 19:02:08 +0000 (21:02 +0200)]
rgw: make verify_bucket_permission functions const
Signed-off-by: Seena Fallah <seenafallah@gmail.com>
(cherry picked from commit
b0200c627b1c8cd8ac236119bd6db7b18abc89dc )
Seena Fallah [Fri, 28 Mar 2025 20:48:34 +0000 (21:48 +0100)]
rgw: give hint via header for perm evaluation in GetObj
Return `Rgwx-Perm-Checked` header as a hint for the destination zone
to know whether the perms where considered or not.
This is just a backward compatibility for upgrade and can be dropped
in T+2 release.
Signed-off-by: Seena Fallah <seenafallah@gmail.com>
(cherry picked from commit
84a8d1ba0ed4a9a1abc80c1b839f95aaeef5f27b )
Seena Fallah [Fri, 28 Mar 2025 20:36:38 +0000 (21:36 +0100)]
rgw: rest client callback when all headers are passed
Signed-off-by: Seena Fallah <seenafallah@gmail.com>
(cherry picked from commit
0a93e74a0476e80c51ce5ec23b2a5ca1b28a3996 )
Seena Fallah [Wed, 5 Mar 2025 19:52:48 +0000 (20:52 +0100)]
rgw: pass rgwx-perm-check-uid for multisite fetch object
Signed-off-by: Seena Fallah <seenafallah@gmail.com>
(cherry picked from commit
86aa6d36e24b78604fd15ac52452ab2cfcc539a9 )
Seena Fallah [Fri, 28 Feb 2025 16:07:32 +0000 (17:07 +0100)]
rgw: GetObject(Version) not allowed to replicate sse-kms objects
To replicate objects encrypted via sse-kms objects,
s3:GetObjectVersionForReplication is required.
Signed-off-by: Seena Fallah <seenafallah@gmail.com>
(cherry picked from commit
3024b70ad56a7733527be7bae53d0a19a368c45c )
Seena Fallah [Thu, 27 Feb 2025 10:53:44 +0000 (11:53 +0100)]
rgw: take account GetObject(Version)Tagging when replicating
In case the uid has no permission to read tagging, the tags should
not be replicated.
Ref. https://docs.aws.amazon.com/AmazonS3/latest/userguide/setting-repl-config-perm-overview.html
Signed-off-by: Seena Fallah <seenafallah@gmail.com>
(cherry picked from commit
ae8d7a97714faabe90d1e1660aacabe27e080e42 )
Seena Fallah [Mon, 24 Feb 2025 22:56:13 +0000 (23:56 +0100)]
qa/rgw: add test for source object perm check in multisite
Check whether the policies are honored on source object in source
zone when replicating.
Signed-off-by: Seena Fallah <seenafallah@gmail.com>
(cherry picked from commit
e4f44851b3c0b46528dea6104cf32d6898c711d4 )
Seena Fallah [Fri, 28 Feb 2025 15:51:07 +0000 (16:51 +0100)]
rgw: replication require lock perm if enabled
Signed-off-by: Seena Fallah <seenafallah@gmail.com>
(cherry picked from commit
4fde9dddb8c2732ecf95fa1d508ee7c91fc53e74 )
Seena Fallah [Mon, 24 Feb 2025 22:41:13 +0000 (23:41 +0100)]
rgw: check source object replication by replication actions
Check for permissions of `s3:GetObjectVersionForReplication` in
addition to `s3:GetObject` and `s3:GetObjectVersion` when fetching
the object for multisite.
Signed-off-by: Seena Fallah <seenafallah@gmail.com>
(cherry picked from commit
89d92dee29a15c5d1be71859be9a2b485236ef4b )
Seena Fallah [Sat, 1 Mar 2025 00:22:07 +0000 (01:22 +0100)]
rgw: export action_bit_string through header file
Signed-off-by: Seena Fallah <seenafallah@gmail.com>
(cherry picked from commit
f2ba4db7b2e57ac0a7166a11251c662c88701805 )
Seena Fallah [Mon, 24 Feb 2025 22:33:45 +0000 (23:33 +0100)]
rgw: only allow system override if identity is not impersonating
Since multisite now delegates permission checks for source objects
to the source zone (
a3f40b4 ), we need to avoid allowing system-level
overrides when the request is impersonating another identity.
SysReqApplier should only grant override permission if the request
is truly system-authenticated and not acting on behalf of another
user or role (i.e., no rgwx-perm-check-uid or rgwx-perm-check-role
in the request).
Signed-off-by: Seena Fallah <seenafallah@gmail.com>
(cherry picked from commit
2a0cb65076fa63439a5d4b7c8876fb551d7ab8ec )
Seena Fallah [Thu, 17 Apr 2025 12:55:00 +0000 (14:55 +0200)]
rgw: SysReqApplier overrides is_admin_of based on impersonation
SysReqApplier now returns true for is_admin_of() when the requester
was a system user and was not impersonating any user/role using
rgwx-perm-check-uid or rgwx-perm-check-role.
Signed-off-by: Seena Fallah <seenafallah@gmail.com>
(cherry picked from commit
0e650ea276669c2c6bb236f27db07910754cc220 )
Seena Fallah [Fri, 21 Feb 2025 00:34:27 +0000 (01:34 +0100)]
qa/rgw: add test for new replication actions
Signed-off-by: Seena Fallah <seenafallah@gmail.com>
(cherry picked from commit
3f2514f7cf2941350539da86756435808db212f9 )
Seena Fallah [Thu, 20 Feb 2025 23:57:25 +0000 (00:57 +0100)]
rgw: support s3ReplicateTags perm on destination bucket for replication
Check for tag replication permission on destination bucket, so if
there was an explicit deny, donot include tags in the replicated
object.
Signed-off-by: Seena Fallah <seenafallah@gmail.com>
(cherry picked from commit
3fb1671520d62ce707ebc15e8f7874540b7e2aaa )
Seena Fallah [Thu, 20 Feb 2025 23:56:28 +0000 (00:56 +0100)]
rgw: check for s3ReplicateObject perm on destination bucket for replication
Instead of s3:PutObject rely on s3:s3ReplicateObject permission to
check whether the user can replicate to the destination bucket.
Signed-off-by: Seena Fallah <seenafallah@gmail.com>
(cherry picked from commit
97ee3287fb3b062eda0d07f07a219eafb04a5a6a )
Seena Fallah [Thu, 20 Feb 2025 21:15:31 +0000 (22:15 +0100)]
rgw: verify perm on delete replication
Check for s3:ReplicateDelete for replicating object deletes and
delete markers when pipe is set to user mode.
Signed-off-by: Seena Fallah <seenafallah@gmail.com>
(cherry picked from commit
d7fe7915b452c5639b415d6457e272fe0d235ef5 )
Seena Fallah [Sat, 22 Feb 2025 23:50:16 +0000 (00:50 +0100)]
rgw: move RGWUserPermHandler to header
So it can be used by others.
Signed-off-by: Seena Fallah <seenafallah@gmail.com>
(cherry picked from commit
857f7bd8e6be11d1d3453e0dc32dae0e3945f8f5 )
Seena Fallah [Thu, 20 Feb 2025 20:38:50 +0000 (21:38 +0100)]
rgw: weaning off RGWUserPermHandler from RGWDataSyncEnv
So it can be called by RGWAsyncRadosRequest classes not holding
sync_env.
Signed-off-by: Seena Fallah <seenafallah@gmail.com>
(cherry picked from commit
77c9304102e8650ba1d3265ef63bfa2d0a6756d1 )
Seena Fallah [Sat, 22 Feb 2025 23:47:55 +0000 (00:47 +0100)]
rgw: send bucket sync structs to bucket_sync.h
So it can be imported by headers like rgw_cr_rados.h that already
has dependency to rgw_data_sync.h.
Signed-off-by: Seena Fallah <seenafallah@gmail.com>
(cherry picked from commit
e7422956988394d334043123bc87460055a9db13 )
Seena Fallah [Wed, 19 Feb 2025 22:51:11 +0000 (23:51 +0100)]
rgw: drop unused params passed to RGWStatRemoteObjCR by RGWObjFetchCR
Signed-off-by: Seena Fallah <seenafallah@gmail.com>
(cherry picked from commit
bb337be08467d649f17712558c5414bd64cb3d09 )
Pritha Srivastava [Mon, 1 Apr 2024 15:57:06 +0000 (21:27 +0530)]
rgw/qa: added test case to assume a role after role creation
syncs, and then creating a bucket on both primary and secondary.
The test name is test_assume_role_after_sync.
Signed-off-by: Pritha Srivastava <prsrivas@redhat.com>
(cherry picked from commit
855db87f4addec8576708d56b6f6d6554caf8b37 )
Pritha Srivastava [Thu, 28 Mar 2024 11:16:20 +0000 (16:46 +0530)]
rgw/sts: by-passing authentication using temp creds
in case the request is forwarded from secondary in
a multi-site setup. authenticating with the system
user creds of which are used to sign the request.
Permissions are still derived from the role.
Signed-off-by: Pritha Srivastava <prsrivas@redhat.com>
(cherry picked from commit
63bc73802ddb0ef74d66d468293e489e4d5fa58f )
Ronen Friedman [Tue, 29 Apr 2025 03:35:13 +0000 (22:35 -0500)]
qa/standalone/scrub: fix expected output in snaps repair tests
Specifically - TEST_corrupt_snapset_scrub_rep in osd-scrub-repair.sh.
Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
(cherry picked from commit
4816832555d9f3034d2cd4c399e74c262d098e22 )
Ronen Friedman [Mon, 28 Apr 2025 16:34:47 +0000 (11:34 -0500)]
qa/standalone/scrub: fix expected output in replicated repair tests
Specifically - TEST_corrupt_scrub_replicated in osd-scrub-repair.sh.
Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
(cherry picked from commit
139967011d98d0cc75584750e19192573c8421a3 )
Ronen Friedman [Mon, 28 Apr 2025 13:14:54 +0000 (08:14 -0500)]
qa/standalone/scrub: fix expected output in EC repair tests
Specifically - TEST_corrupt_scrub_erasure_* in osd-scrub-repair.sh.
This is required following recent changes to the EC code.
Fixes: https://tracker.ceph.com/issues/70851
Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
(cherry picked from commit
3aceb1fd44876877a6ddca7cd14eb3c2f8ed8790 )
Afreen Misbah [Fri, 25 Apr 2025 16:29:23 +0000 (21:59 +0530)]
mgr/dashboard: Update translations
Fixes https://tracker.ceph.com/issues/71086
Signed-off-by: Afreen Misbah <afreen@ibm.com>
(cherry picked from commit
c8c6bee3cf4d28e80eb05b7ce65a304e0fe62018 )
Janne Heß [Mon, 28 Apr 2025 09:04:25 +0000 (11:04 +0200)]
ceph-volume: Fix splitting with too many parts
The data can be anything and also contain a `=`, causing the line to
fail with `Too many values to unpack`. In my case, it failed with
`ID_FS_LABEL=pvc_name=rook-ceph-lvm-data-44f2gc`.
Regression was introduced here: https://github.com/ceph/ceph/pull/60006
Fixes: https://tracker.ceph.com/issues/71101
Signed-off-by: Janne Heß <janne@hess.ooo>
(cherry picked from commit
315fb96243549afba316c60a8d74c24c9417c18e )
Ronen Friedman [Mon, 28 Apr 2025 16:09:17 +0000 (19:09 +0300)]
Merge pull request #62998 from ronen-fr/wip-rf-62996-tentacle
tentacle: osd/scrub: always round up reported scrub duration
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Matan Breizman <mbreizma@redhat.com>
Ronen Friedman [Sat, 26 Apr 2025 08:21:29 +0000 (03:21 -0500)]
osd/scrub: always round up reported scrub duration
as expected by some tests, and clearer for the user.
Fixes: https://tracker.ceph.com/issues/68833
Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
(cherry picked from commit
b7fca3676eec20371e0735650a91add065f8faa0 )
Patrick Donnelly [Fri, 25 Apr 2025 19:02:03 +0000 (15:02 -0400)]
Merge PR #62901 into main
* refs/pull/62901/head:
qa/workunits/fs/misc: remove data pool cleanup
Reviewed-by: Greg Farnum <gfarnum@redhat.com>
Patrick Donnelly [Fri, 25 Apr 2025 19:00:39 +0000 (15:00 -0400)]
Merge PR #62833 into main
* refs/pull/62833/head:
qa: test charmap changes with dir and snaps
mds: check for snapshots on parent snaprealms
mds: use strict_strtobool for parsing bools
common: take string_view for strict_tobool
Reviewed-by: Greg Farnum <gfarnum@redhat.com>
Anthony D'Atri [Fri, 25 Apr 2025 16:20:51 +0000 (12:20 -0400)]
Merge pull request #62966 from bluikko/doc-toc-sectionlevels-radosgw
doc/radosgw: Fix section header levels in multisite-sync-policy.rst
Adam King [Fri, 25 Apr 2025 15:11:31 +0000 (11:11 -0400)]
Merge pull request #62023 from Kushal-deb/user-friendly_error_handling_for_invalid_osd_device_paths
cephadm: Provide user friendly error message if osd device path is invalid
Reviewed-by: Adam King <adking@redhat.com>
Yingxin Cheng [Fri, 25 Apr 2025 14:41:02 +0000 (22:41 +0800)]
Merge pull request #62895 from cyx1231st/wip-seastore-omap-link-init
crimson/os/seastore/omap_manager: simplify maybe_init from tolerating duplicated calls
Reviewed-by: Xuehan Xu <xuxuehan@qianxin.com>
Yingxin Cheng [Fri, 25 Apr 2025 12:55:31 +0000 (20:55 +0800)]
Merge pull request #62938 from cyx1231st/wip-seastore-cleanup-paddr-types
crimson/os/seastore: improve checks to the paddr types
Reviewed-by: Xuehan Xu <xuxuehan@qianxin.com>
Reviewed-by: Myoungwon Oh <myoungwon.oh@samsung.com>
Yingxin Cheng [Fri, 25 Apr 2025 12:53:55 +0000 (20:53 +0800)]
Merge pull request #62838 from cyx1231st/wip-seastore-simplify-cache-access-metrics
crimson/os/seastore: simplify cache access metrics
Reviewed-by: Xuehan Xu <xuxuehan@qianxin.com>
Matt Benjamin [Fri, 25 Apr 2025 11:53:30 +0000 (07:53 -0400)]
Merge pull request #56336 from pritha-srivastava/wip-rgw-d4n-next
Wip rgw d4n next
Adam Kupczyk [Fri, 25 Apr 2025 10:18:34 +0000 (12:18 +0200)]
Merge pull request #56975 from aclamk/wip-aclamk-bs-compression-recompression
os/bluestore: Recompression, part 4. Scanner, Estimator and core recompression.
Ville Ojamo [Fri, 25 Apr 2025 07:16:52 +0000 (14:16 +0700)]
doc/radosgw: Fix section header levels in multisite-sync-policy.rst
The section header levels are reversed so the hierarchy in the TOC is
incorrect. Switch around the section header levels to make the TOC
hierarchy correct, for example individual examples are children of the
"Examples" section.
Signed-off-by: Ville Ojamo <14869000+bluikko@users.noreply.github.com>
Shraddha Agrawal [Fri, 25 Apr 2025 05:56:15 +0000 (11:26 +0530)]
Merge pull request #59673 from shraddhaag/availability-score-feature
monitor: add availability score feature
Gil Bregman [Fri, 25 Apr 2025 05:34:07 +0000 (08:34 +0300)]
Merge pull request #62937 from gbregman/main
mgr/cephadm/nvmeof: Allow setting NVMEoF gateway huge pages count in the spec file
Patrick Donnelly [Fri, 25 Apr 2025 02:41:14 +0000 (22:41 -0400)]
Merge PR #62658 into main
* refs/pull/62658/head:
libcephfs_proxy: Remove arithmetic on `void*`
Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>
Reviewed-by: Matan Breizman <mbreizma@redhat.com>
Reviewed-by: Xavi Hernandez <xhernandez@gmail.com>