]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
5 weeks agocmake: enable out-of-source build of breakpad 63655/head
Kefu Chai [Wed, 4 Jun 2025 03:05:38 +0000 (11:05 +0800)]
cmake: enable out-of-source build of breakpad

Previously, Breakpad was built in its source tree instead of the
user-specified build directory, inconsistent with other external
projects and potentially causing source tree pollution.

Include path fix:

- Add ${INSTALL_DIR}/include/breakpad to include directories to fix
  FTBFS on Jammy builders

Build system improvements:
- Replace dedicated LSS submodule symlink target with PATCH_COMMAND to
  simplify the build process
- Use user-specified make command instead of hardcoded "make"
- Skip building unused process library and tools
- Link against breakpad with PRIVATE visibility unless required

Compiler flag cleanups:
- Remove -Wno-array-bounds from CFLAGS (Breakpad uses C++/CXXFLAGS)
- Remove compile-time flags incorrectly placed in LDFLAGS
- Remove '-fPIC' from CFLAGS, as it is already included by breakpad
  when building on linux hosts.
- Replace the individual -Wno-* flags with -Wno-error to cancel
  -Werror option specified by breakpad. This is more future-proof.

CMake target modernization:
- Rename libbreakpad_client to Breakpad::client following modern conventions
- Add Breakpad::breakpad header-only target to minimize dependencies
- Install library to enable proper include path prefixes
  (breakpad/client/... vs client/...)

Header dependency optimization:
- Remove Breakpad includes from popular headers, use forward declarations
- Include Breakpad headers before internal headers for better readability

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
5 weeks agoMerge pull request #63620 from athanatos/sjust/wip-71512
Samuel Just [Fri, 6 Jun 2025 21:33:14 +0000 (14:33 -0700)]
Merge pull request #63620 from athanatos/sjust/wip-71512

cls/CMakeLists.txt: find_package Lua for cls_lua

Reviewed-by: Matan Breizman <mbreizma@redhat.com>
6 weeks agoMerge pull request #63671 from ceph/dependabot-npm_and_yarn-src-pybind-mgr-dashboard...
Ernesto Puerta [Fri, 6 Jun 2025 16:34:59 +0000 (18:34 +0200)]
Merge pull request #63671 from ceph/dependabot-npm_and_yarn-src-pybind-mgr-dashboard-frontend-tar-fs-2.1.3

mgr/dashboard: bump tar-fs from 2.1.2 to 2.1.3 in /src/pybind/mgr/dashboard/frontend

6 weeks agoMerge pull request #63782 from zdover23/wip-doc-2025-06-06-radosgw-metrics-62893...
Anthony D'Atri [Fri, 6 Jun 2025 12:28:47 +0000 (08:28 -0400)]
Merge pull request #63782 from zdover23/wip-doc-2025-06-06-radosgw-metrics-62893-followup

doc/radosgw: edit metrics.rst

6 weeks agoMerge pull request #62817 from aclamk/aclamk-bs-reshard-problem-replicate
Adam Kupczyk [Fri, 6 Jun 2025 10:49:45 +0000 (12:49 +0200)]
Merge pull request #62817 from aclamk/aclamk-bs-reshard-problem-replicate

os/bluestore: Debug code to make reshard fail faster

6 weeks agodoc/radosgw: edit metrics.rst 63782/head
Zac Dover [Fri, 6 Jun 2025 05:16:17 +0000 (15:16 +1000)]
doc/radosgw: edit metrics.rst

Edit doc/radosgw/metrics.rst.

Incorporate Anthony D'Atri's suggestion from
https://github.com/ceph/ceph/pull/62893#discussion_r2124662981 into the
RADOSGW documentation.

This commit clarifies the English that explains the behavior of
rgw-multitenancy.

Signed-off-by: Zac Dover <zac.dover@proton.me>
6 weeks agoMerge pull request #63741 from zdover23/wip-doc-2025-06-05-mgr-telemetry-63476-follow...
Zac Dover [Fri, 6 Jun 2025 04:49:57 +0000 (14:49 +1000)]
Merge pull request #63741 from zdover23/wip-doc-2025-06-05-mgr-telemetry-63476-followup-4-of-x

doc/mgr: edit telemetry (4 of x)

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
6 weeks agoMerge pull request #63740 from zdover23/wip-doc-2025-06-05-mgr-telemetry-63476-follow...
Zac Dover [Fri, 6 Jun 2025 04:48:35 +0000 (14:48 +1000)]
Merge pull request #63740 from zdover23/wip-doc-2025-06-05-mgr-telemetry-63476-followup-3-of-x

doc/mgr: edit telemetry (3 of x)

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
6 weeks agoMerge pull request #63739 from zdover23/wip-doc-2025-06-05-mgr-telemetry-63476-follow...
Zac Dover [Fri, 6 Jun 2025 04:43:11 +0000 (14:43 +1000)]
Merge pull request #63739 from zdover23/wip-doc-2025-06-05-mgr-telemetry-63476-followup-2-of-x

doc/mgr: edit telemetry (2 of x)

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
6 weeks agoMerge pull request #63735 from zdover23/wip-doc-2025-06-05-mgr-telemetry-63476-followup
Zac Dover [Fri, 6 Jun 2025 04:39:37 +0000 (14:39 +1000)]
Merge pull request #63735 from zdover23/wip-doc-2025-06-05-mgr-telemetry-63476-followup

doc/mgr: edit telemetry (1 of x)

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
6 weeks agoMerge pull request #63085 from zdover23/wip-doc-2025-05-01-mgr-yaml-in-62983-followup-1
Zac Dover [Fri, 6 Jun 2025 01:25:35 +0000 (11:25 +1000)]
Merge pull request #63085 from zdover23/wip-doc-2025-05-01-mgr-yaml-in-62983-followup-1

doc/src/common/options: mgr.yaml.in edit

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
6 weeks agoMerge pull request #63595 from tchaikov/wip-test_librados_completion-fix-leak 62330/head
Kefu Chai [Thu, 5 Jun 2025 14:56:53 +0000 (22:56 +0800)]
Merge pull request #63595 from tchaikov/wip-test_librados_completion-fix-leak

test/common: fix memory leak in librados completion tests

Reviewed-by: Adam Emerson <aemerson@redhat.com>
6 weeks agoMerge PR #63621 into main
Patrick Donnelly [Thu, 5 Jun 2025 14:36:49 +0000 (10:36 -0400)]
Merge PR #63621 into main

* refs/pull/63621/head:
mon/FSCommands: avoid unreachable code triggering compiler warning

Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
Reviewed-by: Matan Breizman <mbreizma@redhat.com>
6 weeks agoMerge pull request #63721 from guits/dashboard-hw-fix
Nizamudeen A [Thu, 5 Jun 2025 13:02:09 +0000 (18:32 +0530)]
Merge pull request #63721 from guits/dashboard-hw-fix

mgr/dashboard: fix KeyError exception in HardwareService.get_summary()

6 weeks agoMerge pull request #63713 from anoopcs9/bump-libcephfs-major-vers
Venky Shankar [Thu, 5 Jun 2025 08:51:32 +0000 (14:21 +0530)]
Merge pull request #63713 from anoopcs9/bump-libcephfs-major-vers

libcephfs: Bump API major version

Reviewed-by: Venky Shankar <vshankar@redhat.com>
6 weeks agoqa, ec-esb-fio: Add flag for easier replication 62817/head
Adam Kupczyk [Thu, 5 Jun 2025 08:09:48 +0000 (08:09 +0000)]
qa, ec-esb-fio: Add flag for easier replication

Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
6 weeks agoos/bluestore: Debug code to make reshard fail faster
Adam Kupczyk [Tue, 15 Apr 2025 08:31:49 +0000 (08:31 +0000)]
os/bluestore: Debug code to make reshard fail faster

Catch reshard on producing invalid result on encode.
This makes it much easier to catch error.
Intented for teuthology testing.

Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
6 weeks agodoc/mgr: edit telemetry (4 of x) 63741/head
Zac Dover [Thu, 5 Jun 2025 03:05:54 +0000 (13:05 +1000)]
doc/mgr: edit telemetry (4 of x)

Improve the English and the formatting in doc/mgr/telemetry.rst. This
follows up on https://github.com/ceph/ceph/pull/63476.

This commit edits the final part of doc/mgr/telemetry.rst.

Signed-off-by: Zac Dover <zac.dover@proton.me>
6 weeks agodoc/mgr: edit telemetry (3 of x) 63740/head
Zac Dover [Thu, 5 Jun 2025 02:24:08 +0000 (12:24 +1000)]
doc/mgr: edit telemetry (3 of x)

Improve the English and the formatting in doc/mgr/telemetry.rst. This
follows up on https://github.com/ceph/ceph/pull/63476.

This commit edits the third hundred lines in doc/mgr/telemetry.rst.

Signed-off-by: Zac Dover <zac.dover@proton.me>
6 weeks agodoc/mgr: edit telemetry (2 of x) 63739/head
Zac Dover [Thu, 5 Jun 2025 02:06:00 +0000 (12:06 +1000)]
doc/mgr: edit telemetry (2 of x)

Improve the English and the formatting in doc/mgr/telemetry.rst. This
follows up on https://github.com/ceph/ceph/pull/63476.

This commit edits the second hundred lines in doc/mgr/telemetry.rst.

Signed-off-by: Zac Dover <zac.dover@proton.me>
6 weeks agoMerge pull request #62935 from adk3798/cephadm-fix-shell-name-stopped-daemon
Adam King [Thu, 5 Jun 2025 00:59:09 +0000 (20:59 -0400)]
Merge pull request #62935 from adk3798/cephadm-fix-shell-name-stopped-daemon

cephadm: don't collect image ids for daemons with no container info

Reviewed-by: John Mulligan <jmulligan@redhat.com>
Reviewed-by: Redouane Kachach <rkachach@ibm.com>
6 weeks agoMerge pull request #63729 from athanatos/sjust/wip-71568
Kefu Chai [Thu, 5 Jun 2025 00:40:39 +0000 (08:40 +0800)]
Merge pull request #63729 from athanatos/sjust/wip-71568

.gitmodules: remove shallow=true config from nvmeof/gateway

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
6 weeks agodoc/mgr: edit telemetry (1 of x) 63735/head
Zac Dover [Thu, 5 Jun 2025 00:02:47 +0000 (10:02 +1000)]
doc/mgr: edit telemetry (1 of x)

Improve the English and the formatting in doc/mgr/telemetry.rst. This
follows up on https://github.com/ceph/ceph/pull/63476.

This commit edits down to the line "Note that telemetry must be on for
these commands to take effect.", inclusive.

Signed-off-by: Zac Dover <zac.dover@proton.me>
6 weeks agoMerge pull request #63734 from zdover23/wip-doc-2025-06-05-cli_api-63195-followup
Anthony D'Atri [Thu, 5 Jun 2025 00:01:26 +0000 (20:01 -0400)]
Merge pull request #63734 from zdover23/wip-doc-2025-06-05-cli_api-63195-followup

doc/mgr: edit cli_api

6 weeks agoMerge pull request #63733 from zdover23/wip-doc-2025-06-05-glossary-omap
Anthony D'Atri [Thu, 5 Jun 2025 00:00:45 +0000 (20:00 -0400)]
Merge pull request #63733 from zdover23/wip-doc-2025-06-05-glossary-omap

doc/glossary: s/OMAP/omap/

6 weeks agodoc/mgr: edit cli_api 63734/head
Zac Dover [Wed, 4 Jun 2025 23:52:40 +0000 (09:52 +1000)]
doc/mgr: edit cli_api

Improve the English in doc/mgr/cli_api.rst. Incorporate the changes
suggested by Anthony D'Atri in https://github.com/ceph/ceph/pull/63195.

Signed-off-by: Zac Dover <zac.dover@proton.me>
6 weeks agodoc/glossary: s/OMAP/omap/ 63733/head
Zac Dover [Wed, 4 Jun 2025 23:39:33 +0000 (09:39 +1000)]
doc/glossary: s/OMAP/omap/

Change "OMAP" to "omap" to match the capitalization established by
Eleanor Cawthon in her 2012 omap paper, here:
https://ceph.io/assets/pdfs/CawthonKeyValueStore.pdf.

Signed-off-by: Zac Dover <zac.dover@proton.me>
6 weeks agoMerge pull request #63596 from cbodley/wip-github-milestone-tentacle
Casey Bodley [Wed, 4 Jun 2025 22:20:55 +0000 (18:20 -0400)]
Merge pull request #63596 from cbodley/wip-github-milestone-tentacle

github: add tentacle milestone

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>
6 weeks ago.gitmodules: remove shallow=true config from nvmeof/gateway 63729/head
Samuel Just [Wed, 4 Jun 2025 20:55:21 +0000 (20:55 +0000)]
.gitmodules: remove shallow=true config from nvmeof/gateway

https://github.com/ceph/ceph/pull/61264 reintroduced
https://tracker.ceph.com/issues/67640 fixed by
383091e89.

Setting shallow=true for the nvmeof/gateway submodule
is problematic because the ceph.git submodule sha1
is only very rarely the head sha1 of the default
branch.

Fixes: https://tracker.ceph.com/issues/71568
Signed-off-by: Samuel Just <sjust@redhat.com>
6 weeks agoMerge pull request #63361 from cbodley/wip-github-label-rgw-docs
Casey Bodley [Wed, 4 Jun 2025 20:22:07 +0000 (16:22 -0400)]
Merge pull request #63361 from cbodley/wip-github-label-rgw-docs

github: add rgw label for changes in doc/radosgw

Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>
6 weeks agoMerge pull request #63702 from ThomasLamprecht/deb-radosgw-media-types-dependency
Casey Bodley [Wed, 4 Jun 2025 20:21:01 +0000 (16:21 -0400)]
Merge pull request #63702 from ThomasLamprecht/deb-radosgw-media-types-dependency

debian: radosgw: add media-types packages as alternative for mime-support

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
6 weeks agomgr/dashboard: fix KeyError exception in HardwareService.get_summary() 63721/head
Guillaume Abrioux [Wed, 4 Jun 2025 14:23:43 +0000 (16:23 +0200)]
mgr/dashboard: fix KeyError exception in HardwareService.get_summary()

Typical error:

```
[dashboard ERROR exception] Internal Server Error
Traceback (most recent call last):
  File "/usr/share/ceph/mgr/dashboard/services/exception.py", line 48, in dashboard_exception_handler
    return handler(*args, **kwargs)
  File "/lib/python3.9/site-packages/cherrypy/_cpdispatch.py", line 54, in __call__
    return self.callable(*self.args, **self.kwargs)
  File "/usr/share/ceph/mgr/dashboard/controllers/_base_controller.py", line 263, in inner
    ret = func(*args, **kwargs)
  File "/usr/share/ceph/mgr/dashboard/controllers/_rest_controller.py", line 193, in wrapper
    return func(*vpath, **params)
  File "/usr/share/ceph/mgr/dashboard/controllers/hardware.py", line 21, in summary
    return HardwareService.get_summary(categories, hostname)
  File "/usr/share/ceph/mgr/dashboard/services/hardware.py", line 33, in get_summary
    'ok': sum(item['status']['health'] == 'OK' for items in data.values()
  File "/usr/share/ceph/mgr/dashboard/services/hardware.py", line 33, in <genexpr>
    'ok': sum(item['status']['health'] == 'OK' for items in data.values()
KeyError: 'status'
```

The recent change from commit `fbcdf571ca1` introduced this regression.

Fixes: https://tracker.ceph.com/issues/71558
Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
6 weeks agoMerge pull request #63409 from cbodley/wip-70792
Casey Bodley [Wed, 4 Jun 2025 18:57:08 +0000 (14:57 -0400)]
Merge pull request #63409 from cbodley/wip-70792

run-make: work around package conflicts from llvm.sh

Reviewed-by: Dan Mick <dmick@redhat.com>
6 weeks agocls/CMakeLists.txt: find_package Lua for cls_lua 63620/head
Samuel Just [Tue, 3 Jun 2025 21:55:13 +0000 (21:55 +0000)]
cls/CMakeLists.txt: find_package Lua for cls_lua

src/CMakeLists.txt does do find_package for Lua:

if(WITH_CEPHFS OR WITH_RADOSGW)
  find_package(Lua 5.3 REQUIRED)
endif()

but only if WITH_CEPHFS or WITH_RADOSGW.  Seperately
require it in cls/CMakeLists.txt for cls_lua.

Fixes: https://tracker.ceph.com/issues/71512
Signed-off-by: Samuel Just <sjust@redhat.com>
6 weeks agoMerge pull request #63264 from yuvalif/wip-yuval-71308
Yuval Lifshitz [Wed, 4 Jun 2025 13:34:19 +0000 (16:34 +0300)]
Merge pull request #63264 from yuvalif/wip-yuval-71308

rgw/logging: Make unique portion of log object name ordered

6 weeks agorun-make: work around package conflicts from llvm.sh 63409/head
Casey Bodley [Wed, 21 May 2025 17:24:26 +0000 (13:24 -0400)]
run-make: work around package conflicts from llvm.sh

packages installed by llvm.sh sometimes conflict with existing packages
from earlier versions, leading to errors like:

> The following packages have unmet dependencies:
> python3-lldb-13 : Conflicts: python3-lldb-x.y
> python3-lldb-19 : Conflicts: python3-lldb-x.y

remove packages from any earlier versions before running llvm.sh

Fixes: https://tracker.ceph.com/issues/70792
Signed-off-by: Casey Bodley <cbodley@redhat.com>
6 weeks agoMerge pull request #63244 from yuvalif/wip-yuval-71288
Yuval Lifshitz [Wed, 4 Jun 2025 13:11:51 +0000 (16:11 +0300)]
Merge pull request #63244 from yuvalif/wip-yuval-71288

rgw/logging: add size in MPU complete in standard mode

6 weeks agoMerge PR #62865 into main
Patrick Donnelly [Wed, 4 Jun 2025 12:42:39 +0000 (08:42 -0400)]
Merge PR #62865 into main

* refs/pull/62865/head:
test/libcephfs: copy DT_NEEDED entries from input libraries
test/fs: only add libcephfs as library dependency
test/client: do not depend on libcephfs

Reviewed-by: Viacheslav Dubeyko <Slava.Dubeyko@ibm.com>
6 weeks agoMerge pull request #63136 from Naveenaidu/wip-naveen-config-diff-scripts
Naveen Naidu [Wed, 4 Jun 2025 08:54:19 +0000 (14:24 +0530)]
Merge pull request #63136 from Naveenaidu/wip-naveen-config-diff-scripts

script: add configuration diff tool

6 weeks agolibcephfs: Bump API major version 63713/head
Anoop C S [Wed, 4 Jun 2025 08:02:01 +0000 (13:32 +0530)]
libcephfs: Bump API major version

We recently had ABI changes[1] with respect to APIs from chown() family
which calls for a change in major version. Native users of the library
may not have to change their code but expected sizes differ when data
type for parameters are changed. However go-ceph, Go bindings for ceph,
couldn't build[2] unless the ABI change is made visible to the consumers
of the API. Following the Semantic Versioning guidelines[3] we reset
minor and patch (extra) versions to 0.

[1] https://github.com/ceph/ceph/pull/62934
[2] https://github.com/ceph/go-ceph/issues/1119
[3] https://semver.org/#spec-item-8

Fixes: https://tracker.ceph.com/issues/71519
Signed-off-by: Anoop C S <anoopcs@cryptolab.net>
6 weeks agoMerge pull request #62648 from guits/refactor_setup_device
Guillaume Abrioux [Wed, 4 Jun 2025 07:07:51 +0000 (09:07 +0200)]
Merge pull request #62648 from guits/refactor_setup_device

ceph-volume: refactor LvmBlueStore.setup_device()

6 weeks agoMerge pull request #63389 from cyx1231st/wip-seastore-refine-extent-states
Yingxin Cheng [Wed, 4 Jun 2025 06:10:03 +0000 (14:10 +0800)]
Merge pull request #63389 from cyx1231st/wip-seastore-refine-extent-states

crimson/os/seastore: cleanup CachedExtent::extent_state_t and related logic

Reviewed-by: Xuehan Xu <xuxuehan@qianxin.com>
6 weeks agoMerge pull request #63686 from zdover23/wip-doc-2025-06-04-start-documenting-ceph
Zac Dover [Wed, 4 Jun 2025 03:33:23 +0000 (13:33 +1000)]
Merge pull request #63686 from zdover23/wip-doc-2025-06-04-start-documenting-ceph

doc/start: edit documenting-ceph.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
6 weeks ago.github/workflow: add diff ceph config action 63136/head
Naveen Naidu [Thu, 17 Apr 2025 13:50:57 +0000 (19:20 +0530)]
.github/workflow: add diff ceph config action

Signed-off-by: Naveen Naidu <naveen.naidu@ibm.com>
6 weeks agoscript: add config-diff tool
Naveen Naidu [Thu, 17 Apr 2025 13:50:40 +0000 (19:20 +0530)]
script: add config-diff tool

Signed-off-by: Naveen Naidu <naveen.naidu@ibm.com>
6 weeks agocrimson/os/seastore/../btree_omap_manager: workaround log failure 63389/head
Yingxin Cheng [Tue, 3 Jun 2025 06:23:50 +0000 (14:23 +0800)]
crimson/os/seastore/../btree_omap_manager: workaround log failure

See https://tracker.ceph.com/issues/71524

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
6 weeks agotest/crimson/../test_transaction_manager: fix try_get_extent() to handle transaction...
Yingxin Cheng [Thu, 22 May 2025 03:52:37 +0000 (11:52 +0800)]
test/crimson/../test_transaction_manager: fix try_get_extent() to handle transaction conflicts

Outside interruptible future, transaction can become invalidated
implicitly.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
6 weeks agocrimson/os/seastore/cache: minor cleanups to prepare_record/complete_commit()
Yingxin Cheng [Thu, 22 May 2025 02:43:19 +0000 (10:43 +0800)]
crimson/os/seastore/cache: minor cleanups to prepare_record/complete_commit()

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
6 weeks agocrimson/os/seastore: more accurate usages to is_pending() vs is_stable()
Yingxin Cheng [Wed, 21 May 2025 06:21:10 +0000 (14:21 +0800)]
crimson/os/seastore: more accurate usages to is_pending() vs is_stable()

Generally, prefer is_pending() than !is_stable(), and
is_stable() than !is_pending().

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
6 weeks agocrimson/os/seastore: more accurate usages to is_mutable() vs is_data_stable()
Yingxin Cheng [Wed, 21 May 2025 03:54:05 +0000 (11:54 +0800)]
crimson/os/seastore: more accurate usages to is_mutable() vs is_data_stable()

Generally, prefer is_mutable() than !is_data_stable(), and
is_data_stable() than !is_mutable().

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
6 weeks agocrimson/os/seastore: distinguish between is_mutation_pending() and has_mutation()
Yingxin Cheng [Wed, 21 May 2025 03:33:26 +0000 (11:33 +0800)]
crimson/os/seastore: distinguish between is_mutation_pending() and has_mutation()

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
6 weeks agocrimson/os/seastore/../fixed_kv_btree: get_stable_for_key() is called when the node...
Yingxin Cheng [Wed, 21 May 2025 03:20:03 +0000 (11:20 +0800)]
crimson/os/seastore/../fixed_kv_btree: get_stable_for_key() is called when the node is pending

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
6 weeks agocrimson/os/seastore: cleanup CachedExtent::prior_instance
Yingxin Cheng [Mon, 19 May 2025 07:01:18 +0000 (15:01 +0800)]
crimson/os/seastore: cleanup CachedExtent::prior_instance

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
6 weeks agocrimson/os/seastore/cached_extent: drop the unused retired_at
Yingxin Cheng [Fri, 25 Apr 2025 08:32:07 +0000 (16:32 +0800)]
crimson/os/seastore/cached_extent: drop the unused retired_at

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
6 weeks agocrimson/os/seastore/cached_extent: merge is_clean() and is_dirty() as has_delta()
Yingxin Cheng [Fri, 25 Apr 2025 07:56:46 +0000 (15:56 +0800)]
crimson/os/seastore/cached_extent: merge is_clean() and is_dirty() as has_delta()

The original names were misleading because they don't correspond to
CLEAN and DIRTY states.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
6 weeks agocrimson/os/seastore/cached_extent: drop CLEAN_PENDING state
Yingxin Cheng [Fri, 25 Apr 2025 06:47:16 +0000 (14:47 +0800)]
crimson/os/seastore/cached_extent: drop CLEAN_PENDING state

It is only used to prevent printing details when the buffer is still
loading, and is a special case of CLEAN.

It doesn't worth a dedicated state that complicates state-related
decisions.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
6 weeks agoMerge pull request #59565 from Nuckal777/mon-increase-dns-buf-size
Kefu Chai [Wed, 4 Jun 2025 01:57:44 +0000 (09:57 +0800)]
Merge pull request #59565 from Nuckal777/mon-increase-dns-buf-size

mon: increase dns buffer size

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
6 weeks agoMerge pull request #63218 from xxhdx1985126/wip-seastore-fix-retire-absent
Yingxin Cheng [Wed, 4 Jun 2025 01:56:23 +0000 (09:56 +0800)]
Merge pull request #63218 from xxhdx1985126/wip-seastore-fix-retire-absent

crimson/os/seastore/transaction_manager: Cache::retire_absent_extent_addr should be called immediately after TransactionManager::get_extent_if_linked if necessary

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
6 weeks agoMerge pull request #63520 from xxhdx1985126/wip-71448
Yingxin Cheng [Wed, 4 Jun 2025 01:43:42 +0000 (09:43 +0800)]
Merge pull request #63520 from xxhdx1985126/wip-71448

crimson/os/seastore/omap_manager: only mutate the parent when merge/balance can proceed

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
6 weeks agoMerge pull request #63676 from irq0/wip/fix-breakpad-fedora41
Jesse Williamson [Wed, 4 Jun 2025 00:39:35 +0000 (17:39 -0700)]
Merge pull request #63676 from irq0/wip/fix-breakpad-fedora41

Fix Breakpad Builds on Newer Distros

6 weeks agoMerge pull request #63622 from zdover23/wip-doc-2025-06-02-mgr-dashboard_plugins...
Zac Dover [Tue, 3 Jun 2025 20:51:36 +0000 (06:51 +1000)]
Merge pull request #63622 from zdover23/wip-doc-2025-06-02-mgr-dashboard_plugins-63367-followup

doc/mgr/dashboard_plugins: edit feature_toggles.inc.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
6 weeks agodebian: radosgw: add media-types packages as alternative for mime-support 63702/head
Thomas Lamprecht [Tue, 3 Jun 2025 20:32:05 +0000 (22:32 +0200)]
debian: radosgw: add media-types packages as alternative for mime-support

Back in 2020 the '/etc/mime.types' file was split out into it's own
leaner 'media-types' Debian package [0], the previous 'mime-support'
was kept as transitional package to handle upgrades, but it did its
job and isn't included in Debian Trixie repos anymore.

So accept both, the new 'media-types' package or the legacy
'mime-support' one as valid dependency for radosgw, this ensures one
can install radosgw on newer Debian based releases while keeping it
also working for older ones.

[0]: https://salsa.debian.org/debian/media-types/-/commit/4d6ff19de5720196b40cf65f1173bd9333dfecf9

Fixes: https://tracker.ceph.com/issues/71545
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
6 weeks agoMerge pull request #62893 from zdover23/wip-doc-2025-04-21-radosgw-metrics
Zac Dover [Tue, 3 Jun 2025 20:30:28 +0000 (06:30 +1000)]
Merge pull request #62893 from zdover23/wip-doc-2025-04-21-radosgw-metrics

doc/radosgw: edit sentence in metrics.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
6 weeks agoMerge pull request #63614 from zdover23/wip-doc-2025-05-30-rados-ops-cache-tiering...
Zac Dover [Tue, 3 Jun 2025 20:03:47 +0000 (06:03 +1000)]
Merge pull request #63614 from zdover23/wip-doc-2025-05-30-rados-ops-cache-tiering-63465-followup

doc/rados/operations: edit cache-tiering.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
6 weeks agoMerge pull request #63476 from zdover23/wip-doc-2025-05-26-mgr-telemetry-62782-followup
Zac Dover [Tue, 3 Jun 2025 19:56:15 +0000 (05:56 +1000)]
Merge pull request #63476 from zdover23/wip-doc-2025-05-26-mgr-telemetry-62782-followup

doc/mgr: edit telemetry.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
6 weeks agoMerge pull request #63195 from zdover23/wip-doc-2025-05-09-mgr-cli-api-62782-followup
Zac Dover [Tue, 3 Jun 2025 19:42:02 +0000 (05:42 +1000)]
Merge pull request #63195 from zdover23/wip-doc-2025-05-09-mgr-cli-api-62782-followup

doc/mgr: edit cli_api.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
6 weeks agodoc/start: edit documenting-ceph.rst 63686/head
Zac Dover [Tue, 3 Jun 2025 19:23:53 +0000 (05:23 +1000)]
doc/start: edit documenting-ceph.rst

Edit the section "Build the Source (First Time)" in
doc/start/documenting-ceph.rst.

- remove references to RHEL7 (it's old)
- improve sentences (they were first-draft-like)
- improve RST formatting

Signed-off-by: Zac Dover <zac.dover@proton.me>
6 weeks agoMerge pull request #63628 from zdover23/wip-doc-2025-06-02-rados-ops-balancer-63530...
Zac Dover [Tue, 3 Jun 2025 18:52:13 +0000 (04:52 +1000)]
Merge pull request #63628 from zdover23/wip-doc-2025-06-02-rados-ops-balancer-63530-followup

doc/rados: edit balancer.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
6 weeks agoMerge pull request #63623 from zdover23/wip-doc-2025-06-02-mgr-iostat-63418-followup
Zac Dover [Tue, 3 Jun 2025 18:49:08 +0000 (04:49 +1000)]
Merge pull request #63623 from zdover23/wip-doc-2025-06-02-mgr-iostat-63418-followup

doc/mgr: edit iostat.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
6 weeks agodoc/mgr/dashboard_plugins: edit feature_toggles.inc.rst 63622/head
Zac Dover [Sun, 1 Jun 2025 23:04:25 +0000 (09:04 +1000)]
doc/mgr/dashboard_plugins: edit feature_toggles.inc.rst

Follow up on the suggestions made by Anthony D'Atri in
https://github.com/ceph/ceph/pull/63367.

- Add "nvmeof" to the list of enabled features.
- Remove an extraneous space.

Signed-off-by: Zac Dover <zac.dover@proton.me>
6 weeks agodoc/radosgw: edit sentence in metrics.rst 62893/head
Zac Dover [Mon, 21 Apr 2025 07:52:02 +0000 (17:52 +1000)]
doc/radosgw: edit sentence in metrics.rst

Change the wording of a sentence in doc/radosgw/metrics.rst so that its
articles read as though they were written by a native speaker of the
English language.

This commit is being raised as part of a diagnostic process aimed at
discovering why the ReadtheDocs check is failing on PR
https://github.com/ceph/ceph/pull/62877.

Signed-off-by: Zac Dover <zac.dover@proton.me>
6 weeks agocmake: Adjust breakpad builds for newer distros 63676/head
Marcel Lauhoff [Tue, 3 Jun 2025 15:12:27 +0000 (17:12 +0200)]
cmake: Adjust breakpad builds for newer distros

Compile Breakpad with project compiler settings, add -fPIC and silence incompatible
warnings from GCC14.

Signed-off-by: Marcel Lauhoff <marcel.lauhoff@clyso.com>
6 weeks agoMerge pull request #63556 from guits/fix-node-proxy-hw-status
Adam King [Tue, 3 Jun 2025 14:51:20 +0000 (10:51 -0400)]
Merge pull request #63556 from guits/fix-node-proxy-hw-status

node-proxy: address `ceph orch hardware status` cmd

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Teoman ONAY <tonay@ibm.com>
6 weeks agogithub: add tentacle milestone 63596/head
Casey Bodley [Thu, 29 May 2025 15:18:26 +0000 (11:18 -0400)]
github: add tentacle milestone

pull requests based on the tentacle branch aren't setting the milestone

Signed-off-by: Casey Bodley <cbodley@redhat.com>
6 weeks agoMerge pull request #62121 from aclamk/wip-aclamk-bluefs-truncate-alloc-size
Adam Kupczyk [Tue, 3 Jun 2025 12:55:35 +0000 (14:55 +0200)]
Merge pull request #62121 from aclamk/wip-aclamk-bluefs-truncate-alloc-size

os/bluestore: In BlueFS::truncate accept wierd alloc_unit

6 weeks agoMerge pull request #62913 from Jayaprakash-ibm/wip-jaya-esb-fio-test ceph-8.1-rhel-patches
Adam Kupczyk [Tue, 3 Jun 2025 09:29:18 +0000 (11:29 +0200)]
Merge pull request #62913 from Jayaprakash-ibm/wip-jaya-esb-fio-test

qa: Add Teuthology test for BlueStore ESB assertion failure

6 weeks agoMerge pull request #63188 from aclamk/aclamk-fix-70911-envelope-dirty-recover
Adam Kupczyk [Tue, 3 Jun 2025 09:28:21 +0000 (11:28 +0200)]
Merge pull request #63188 from aclamk/aclamk-fix-70911-envelope-dirty-recover

os/bluestore: Fix bluefs_fnode_t::seek

6 weeks agoMerge pull request #63358 from ifed01/wip-ifed-fix-vselector-math
Adam Kupczyk [Tue, 3 Jun 2025 09:25:20 +0000 (11:25 +0200)]
Merge pull request #63358 from ifed01/wip-ifed-fix-vselector-math

os/bluestore:fix bluestore_volume_selection_reserved_factor usage

6 weeks agoMerge pull request #63373 from aclamk/aclamk-bs-fix-split-and-compress
Adam Kupczyk [Tue, 3 Jun 2025 09:24:50 +0000 (11:24 +0200)]
Merge pull request #63373 from aclamk/aclamk-bs-fix-split-and-compress

os/bluestore/compression: Fix Estimator::split_and_compress

6 weeks agomgr/dashboard: bump tar-fs in /src/pybind/mgr/dashboard/frontend 63671/head
dependabot[bot] [Tue, 3 Jun 2025 09:16:07 +0000 (09:16 +0000)]
mgr/dashboard: bump tar-fs in /src/pybind/mgr/dashboard/frontend

Bumps [tar-fs](https://github.com/mafintosh/tar-fs) from 2.1.2 to 2.1.3.
- [Commits](https://github.com/mafintosh/tar-fs/commits)

---
updated-dependencies:
- dependency-name: tar-fs
  dependency-version: 2.1.3
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
6 weeks agoMerge pull request #63629 from zdover23/wip-doc-2025-06-02-mgr-localpool-63419-followup
Zac Dover [Tue, 3 Jun 2025 06:11:45 +0000 (16:11 +1000)]
Merge pull request #63629 from zdover23/wip-doc-2025-06-02-mgr-localpool-63419-followup

doc/mgr: edit localpool.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
6 weeks agoMerge pull request #63630 from zdover23/wip-doc-2025-06-02-mgr-modules-63451-followup
Zac Dover [Tue, 3 Jun 2025 06:09:11 +0000 (16:09 +1000)]
Merge pull request #63630 from zdover23/wip-doc-2025-06-02-mgr-modules-63451-followup

doc/mgr: edit modules.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
6 weeks agoMerge pull request #63631 from zdover23/wip-doc-2025-06-02-mgr-nfs-63452-followup
Zac Dover [Tue, 3 Jun 2025 06:06:33 +0000 (16:06 +1000)]
Merge pull request #63631 from zdover23/wip-doc-2025-06-02-mgr-nfs-63452-followup

doc/mgr: edit nfs.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
6 weeks agoMerge pull request #63632 from zdover23/wip-doc-2025-06-02-dev-cephfs-mirroring-63237...
Zac Dover [Tue, 3 Jun 2025 06:03:43 +0000 (16:03 +1000)]
Merge pull request #63632 from zdover23/wip-doc-2025-06-02-dev-cephfs-mirroring-63237-followup-4-of-x

doc/dev/cephfs-mirroring: edit file 4 of x

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
6 weeks agoMerge pull request #63643 from chardan/jfw-breakpad-add-pre-build
Jesse Williamson [Mon, 2 Jun 2025 21:29:48 +0000 (14:29 -0700)]
Merge pull request #63643 from chardan/jfw-breakpad-add-pre-build

Add PRE_BUILD to breakpad command (fix for CMake > 3.30)

6 weeks agoMerge pull request #63634 from zdover23/wip-doc-2025-06-02-start-documenting-ceph
Zac Dover [Mon, 2 Jun 2025 18:50:55 +0000 (04:50 +1000)]
Merge pull request #63634 from zdover23/wip-doc-2025-06-02-start-documenting-ceph

doc/start: edit documenting-ceph.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
6 weeks agoMerge pull request #63644 from anthonyeleven/advice
Zac Dover [Mon, 2 Jun 2025 18:43:05 +0000 (04:43 +1000)]
Merge pull request #63644 from anthonyeleven/advice

doc/rados/operations: Additional improvements to placement-groups.rst

Reviewed-by: Zac Dover <zac.dover@proton.me>
6 weeks agodoc/rados/operations: Additional improvements to placement-groups.rst 63644/head
Anthony D'Atri [Mon, 2 Jun 2025 18:35:23 +0000 (14:35 -0400)]
doc/rados/operations: Additional improvements to placement-groups.rst

Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
6 weeks agoMerge pull request #63618 from anthonyeleven/advice
Anthony D'Atri [Mon, 2 Jun 2025 18:32:34 +0000 (14:32 -0400)]
Merge pull request #63618 from anthonyeleven/advice

doc/rados/operations: Improve placement-groups.rst

6 weeks agoqa: Add Teuthology test for BlueStore ESB assertion failure 62913/head
Jaya Prakash [Wed, 16 Apr 2025 10:50:30 +0000 (16:20 +0530)]
qa: Add Teuthology test for BlueStore ESB assertion failure

Adds a test to reproduce the !ito->is_valid() assertion in BlueStore
with bluestore_elastic_shared_blobs=true on a 2+1 EC pool using a
FIO randwrite workload (512 concurrent ops, 50G, 12,500 objects).
The test deploys a 6-OSD cluster and runs FIO for 1 hour via workunit,
failing if an OSD crashes.

Signed-off-by: Jaya Prakash <jayaprakash@ibm.com>
6 weeks agoAdd PRE_BUILD (fix for CMake > 3.30) 63643/head
Jesse F. Williamson [Mon, 2 Jun 2025 17:30:45 +0000 (10:30 -0700)]
Add PRE_BUILD (fix for CMake > 3.30)

Signed-off-by: Jesse F. Williamson <jfw@ibm.com>
6 weeks agoMerge pull request #61264 from irq0/wip/breakpad
Jesse Williamson [Mon, 2 Jun 2025 16:17:43 +0000 (09:17 -0700)]
Merge pull request #61264 from irq0/wip/breakpad

Breakpad Crash Handler

6 weeks agoMerge pull request #63633 from zdover23/wip-doc-2025-06-02-mgr-progress-63470-followup
Anthony D'Atri [Mon, 2 Jun 2025 03:17:05 +0000 (23:17 -0400)]
Merge pull request #63633 from zdover23/wip-doc-2025-06-02-mgr-progress-63470-followup

doc/mgr: edit progress.rst

6 weeks agodoc/rados/operations: Improve placement-groups.rst 63618/head
Anthony D'Atri [Fri, 30 May 2025 17:43:49 +0000 (13:43 -0400)]
doc/rados/operations: Improve placement-groups.rst

Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
6 weeks agodoc/mgr: edit progress.rst 63633/head
Zac Dover [Mon, 2 Jun 2025 02:27:12 +0000 (12:27 +1000)]
doc/mgr: edit progress.rst

Edit doc/mgr/progress.rst. Make the changes suggested by Anthony D'Atri
in https://github.com/ceph/ceph/pull/63470.

Signed-off-by: Zac Dover <zac.dover@proton.me>
6 weeks agodoc/start: edit documenting-ceph.rst 63634/head
Zac Dover [Mon, 2 Jun 2025 02:32:36 +0000 (12:32 +1000)]
doc/start: edit documenting-ceph.rst

Edit the section "Build the Source" in doc/start/documenting-ceph.rst.
Also correct a misuse of the word "presently", which means "in a little
while", not "now".

Signed-off-by: Zac Dover <zac.dover@proton.me>
6 weeks agodoc/dev/cephfs-mirroring: edit file 4 of x 63632/head
Zac Dover [Mon, 2 Jun 2025 02:16:47 +0000 (12:16 +1000)]
doc/dev/cephfs-mirroring: edit file 4 of x

Add prompts (and perform necessary corrections to glaring grammatical
errors) to doc/dev/cephfs-mirroring.rst, as requested by Jos Collin in
https://github.com/ceph/ceph/pull/63237/files#r2085886075.

This commit edits the fourth (and final) quarter of the
doc/dev/cephfs-mirroring.rst file.

Further refinements to the English in this file are possible.

Signed-off-by: Zac Dover <zac.dover@proton.me>
6 weeks agodoc/mgr: edit nfs.rst 63631/head
Zac Dover [Sun, 1 Jun 2025 23:45:42 +0000 (09:45 +1000)]
doc/mgr: edit nfs.rst

Edit the "Updating an NFS Cluster" section of doc/mgr/nfs.rst. This
commit includes changes requested by Anthony D'Atri in
https://github.com/ceph/ceph/pull/63452.

Signed-off-by: Zac Dover <zac.dover@proton.me>
6 weeks agodoc/mgr: edit modules.rst 63630/head
Zac Dover [Sun, 1 Jun 2025 23:39:35 +0000 (09:39 +1000)]
doc/mgr: edit modules.rst

s/called/named/ as requested by Anthony D'Atri in
https://github.com/ceph/ceph/pull/63451#discussion_r2104487962.

Signed-off-by: Zac Dover <zac.dover@proton.me>
6 weeks agodoc/mgr: edit localpool.rst 63629/head
Zac Dover [Sun, 1 Jun 2025 23:33:20 +0000 (09:33 +1000)]
doc/mgr: edit localpool.rst

Remove "only" where it was extraneous.

This commit was made in response to a request made by Anthony D'Atri
here: https://github.com/ceph/ceph/pull/63419#discussion_r2102803276.

Signed-off-by: Zac Dover <zac.dover@proton.me>