]>
git.apps.os.sepia.ceph.com Git - ceph.git/log
Zac Dover [Mon, 16 Jun 2025 08:02:49 +0000 (18:02 +1000)]
doc/cephfs: document first-damage.py
Document the use of first-damage.py.
Fixes: https://tracker.ceph.com/issues/71628
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit
d88cdf039d02055d3379eb91a5a9bab655d40d2d )
Yuri Weinstein [Mon, 16 Jun 2025 21:21:30 +0000 (14:21 -0700)]
Merge pull request #63135 from clwluvw/wip-71171
tentacle: rgw-admin: report correct error code for non-existent bucket on deletion
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Anthony D'Atri [Mon, 16 Jun 2025 17:05:22 +0000 (13:05 -0400)]
Merge pull request #63947 from zdover23/wip-doc-2025-06-16-backport-63918-to-tentacle
tentacle: doc/cephfs: Update deprecation notice in experimental-features.rst
Anthony D'Atri [Mon, 16 Jun 2025 16:49:41 +0000 (12:49 -0400)]
Merge pull request #63957 from zdover23/wip-doc-2025-06-16-backport-63320-to-tentacle
tentacle: doc/rados/operations: Fix unordered list in health-checks.rst
Yuri Weinstein [Mon, 16 Jun 2025 14:57:21 +0000 (07:57 -0700)]
Merge pull request #63243 from mkogan1/wip-71202-tentacle
tentacle: rgw/d3n: store cached objects using hash digest
Reviewed-by: Adam Emerson <aemerson@redhat.com>
Yuri Weinstein [Mon, 16 Jun 2025 14:43:14 +0000 (07:43 -0700)]
Merge pull request #63192 from jzhu116-bloomberg/wip-71176-tentacle
tentacle: rgw: prefetch data from versioned object instance head
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Ville Ojamo [Fri, 16 May 2025 08:26:56 +0000 (15:26 +0700)]
doc/rados/operations: Fix unordered list in health-checks.rst
Fix missing empty line before an unordered list that caused it to be
rendered wrong.
Also, the sentences in each list item start with a capital case letter
so add the missing full stop at the end.
Signed-off-by: Ville Ojamo <14869000+bluikko@users.noreply.github.com>
(cherry picked from commit
0dc5f4632cb3a83cfdd9985cadb9ae953949a5b8 )
Ville Ojamo [Fri, 13 Jun 2025 09:39:35 +0000 (16:39 +0700)]
doc/cephfs: Update deprecation notice in experimental-features.rst
The "inline data" feature was not removed on Quincy so update
deprecation notice to refer to "a future release" instead.
Signed-off-by: Ville Ojamo <14869000+bluikko@users.noreply.github.com>
(cherry picked from commit
c15f7e414d2145005974a7ddb385a9b76bfec101 )
Anthony D'Atri [Mon, 16 Jun 2025 03:28:33 +0000 (23:28 -0400)]
Merge pull request #63941 from zdover23/wip-doc-2025-06-16-backport-63934-to-tentacle
tentacle: doc/rados/configuration: Improve ceph-conf.rst
Zac Dover [Mon, 16 Jun 2025 02:54:38 +0000 (12:54 +1000)]
Merge pull request #63767 from zdover23/wip-doc-2025-06-06-backport-63735-to-tentacle
tentacle: doc/mgr: edit telemetry (1 of x)
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Anthony D'Atri [Sun, 15 Jun 2025 02:09:11 +0000 (22:09 -0400)]
doc/rados/configuration: Improve ceph-conf.rst
Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
(cherry picked from commit
ac1547f587774b6f5d16e7bbb7b10deef6eb9a2c )
Anthony D'Atri [Fri, 13 Jun 2025 18:52:07 +0000 (14:52 -0400)]
Merge pull request #63914 from zdover23/wip-doc-2025-06-13-backport-63005-to-tentacle
tentacle: doc/radosgw: Promptify CLI commands and fix formatting in layout.rst
Ville Ojamo [Mon, 28 Apr 2025 09:19:22 +0000 (16:19 +0700)]
doc/radosgw: Promptify CLI commands and fix formatting in layout.rst
Move two example CLI command blocks to use a bash prompt
block with the correct privileged prompt instead of
hardcoded unprivileged prompt.
Don't use the directory "bin/" in command "bin/radosgw-admin"
especially when the next commands also don't use it.
Fix 2 instances of double-backtick missing the second
backtick that caused the rendered doc to be jumbled.
Do not use _emphasis_ that renders as underscores, instead
use RST syntax for italic for the word.
Signed-off-by: Ville Ojamo <14869000+bluikko@users.noreply.github.com>
(cherry picked from commit
6783245e98be4bd83be754fa39353d268e25b896 )
Zac Dover [Thu, 12 Jun 2025 13:00:44 +0000 (23:00 +1000)]
Merge pull request #63682 from zdover23/wip-doc-2025-06-04-backport-63628-to-tentacle
tentacle: doc/rados: edit balancer.rst
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Zac Dover [Thu, 12 Jun 2025 13:00:04 +0000 (23:00 +1000)]
Merge pull request #63904 from zdover23/wip-doc-2025-06-12-backport-63875-to-tentacle
tentacle: doc/mgr: edit telemetry.rst
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Zac Dover [Wed, 11 Jun 2025 12:19:07 +0000 (22:19 +1000)]
doc/mgr: edit telemetry.rst
Follow up on the suggestion made by Anthony D'Atri in
https://github.com/ceph/ceph/pull/63826#discussion_r2136820769.
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit
a598c46c5055fc16b77d1d56adc1bd1b125f1410 )
Zac Dover [Thu, 12 Jun 2025 05:15:21 +0000 (15:15 +1000)]
Merge pull request #63892 from zdover23/wip-doc-2025-06-12-backport-63828-to-tentacle
tentacle: doc/rados: edit ops/user-management.rst
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Zac Dover [Thu, 12 Jun 2025 05:14:30 +0000 (15:14 +1000)]
Merge pull request #63848 from zdover23/wip-doc-2025-06-10-backport-63836-to-tentacle
tentacle: doc/rados/operations: Address suggestions for stretch-mode.rst
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Zac Dover [Thu, 12 Jun 2025 03:31:16 +0000 (13:31 +1000)]
Merge pull request #63776 from zdover23/wip-doc-2025-06-06-backport-63741-to-tentacle
tentacle: doc/mgr: edit telemetry (4 of x)
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Zac Dover [Thu, 12 Jun 2025 03:26:17 +0000 (13:26 +1000)]
Merge pull request #63770 from zdover23/wip-doc-2025-06-06-backport-63739-to-tentacle
tentacle: doc/mgr: edit telemetry (2 of x)
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Zac Dover [Thu, 12 Jun 2025 03:25:33 +0000 (13:25 +1000)]
Merge pull request #63860 from zdover23/wip-doc-2025-06-11-backport-63842-to-tentacle
tentacle: doc/rados: enhance "pools.rst"
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Zac Dover [Thu, 12 Jun 2025 03:24:51 +0000 (13:24 +1000)]
Merge pull request #63829 from zdover23/wip-doc-2025-06-10-backport-63745-to-tentacle
tentacle: doc/rados/ops: edit cache-tiering.rst
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Zac Dover [Thu, 5 Jun 2025 03:05:54 +0000 (13:05 +1000)]
doc/mgr: edit telemetry (4 of x)
Improve the English and the formatting in doc/mgr/telemetry.rst. This
follows up on https://github.com/ceph/ceph/pull/63476.
This commit edits the final part of doc/mgr/telemetry.rst.
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit
b199d75763baf654fe1b21a780a4f6bcd0c4735b )
Zac Dover [Tue, 10 Jun 2025 03:04:13 +0000 (13:04 +1000)]
doc/rados: edit ops/user-management.rst
Edit an sentence in the imperative mood so that it matches the general
form of imperative sentences immediately preceding commands that contain
replaceable portions.
This commit targets only the Squid release branch.
Follows up on https://github.com/ceph/ceph/pull/58235/.
Tracker: https://tracker.ceph.com/issues/66617
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit
20e630460a0368d8e08120b0e7cf523248a06040 )
Anthony D'Atri [Wed, 11 Jun 2025 16:32:37 +0000 (12:32 -0400)]
Merge pull request #63863 from zdover23/wip-doc-2025-06-11-backport-63826-to-tentacle
tentacle: doc/mgr: edit telemetry.rst
Anthony D'Atri [Wed, 11 Jun 2025 16:31:53 +0000 (12:31 -0400)]
Merge pull request #63866 from zdover23/wip-doc-2025-06-11-backport-63827-to-tentacle
tentacle: doc/mgr: edit telemetry.rst (lines 300-400)
Guillaume Abrioux [Wed, 11 Jun 2025 06:55:34 +0000 (08:55 +0200)]
Merge pull request #63785 from guits/wip-71575-tentacle
tentacle: mgr/dashboard: fix KeyError exception in HardwareService.get_summary()
Guillaume Abrioux [Wed, 11 Jun 2025 06:55:20 +0000 (08:55 +0200)]
Merge pull request #63786 from guits/wip-71536-tentacle
tentacle: node-proxy: address `ceph orch hardware status` cmd
Zac Dover [Tue, 10 Jun 2025 02:54:18 +0000 (12:54 +1000)]
doc/mgr: edit telemetry.rst (lines 300-400)
Edit doc/mgr/telemetry.rst (lines 300-400).
Follow up on the suggestions made by Anthony D'Atri in
https://github.com/ceph/ceph/pull/63741 (except for the one about
including Lovecraftian lore in the dummy user data in this file).
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit
4587f330e455ca77294c84fd61add5d62f548a60 )
Zac Dover [Tue, 10 Jun 2025 02:50:13 +0000 (12:50 +1000)]
doc/mgr: edit telemetry.rst
Edit doc/mgr/telemetry.rst.
Follow up on the suggestions made by Anthony D'Atri in
https://github.com/ceph/ceph/pull/63740.
Make several changes that were not earmarked in that PR, but that
nonetheless improve the quality of the English in telemetry.rst.
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit
fc25b1ed12a98eace4c0665a529b69e86fcc9dc5 )
Zac Dover [Tue, 10 Jun 2025 10:58:22 +0000 (20:58 +1000)]
doc/rados: enhance "pools.rst"
Add a link to the instructions for modifying a user's caps for a given
pool. Add this link where it makes sense to add it. Add this link where
the reader would naturally want to have the link.
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit
e4979709dd09d087cf15a314b21be049fbea5e74 )
Ilya Dryomov [Tue, 10 Jun 2025 13:58:44 +0000 (15:58 +0200)]
Merge pull request #63845 from zdover23/wip-doc-2025-06-10-backport-63841-to-tentacle
tentacle: doc/rbd: add mirroring troubleshooting info
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Anthony D'Atri [Mon, 9 Jun 2025 15:02:04 +0000 (11:02 -0400)]
doc/rados/operations: Address suggestions for stretch-mode.rst
Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
fixup
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit
3f5bf8dedd18f2f6d4afc0583be124be879667f2 )
(cherry picked from commit
660d163271fd6a984be15524df6652f6aeb4b5c0 )
Zac Dover [Tue, 10 Jun 2025 10:38:54 +0000 (20:38 +1000)]
doc/rbd: add mirroring troubleshooting info
Add a note to doc/rbd/rbd-mirroring.rst that directs the reader to set
both "site-a" and "site-b" to have the same pool names in the event that
rbd throws the error message "failed to import peer bootstrap token".
This information was reported to the Ceph upstream by Petr Tlapa in June
of 2025, and credit for its development goes to Petr.
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit
83345afa898ebc2daf9a18d725447aa0c738af57 )
Zac Dover [Thu, 5 Jun 2025 03:28:13 +0000 (13:28 +1000)]
doc/rados/ops: edit cache-tiering.rst
Remove part of a sentence that might have led readers to think that it
is a good idea to deploy cache tiering on releases prior to Reef.
This incorporates Anthony D'Atri's suggestion from here: https://github.com/ceph/ceph/pull/63614#discussion_r2116020937
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit
3618b1bbbb0096a8a08f59aeb6b7436ef9d0c12e )
Anthony D'Atri [Mon, 9 Jun 2025 15:04:20 +0000 (11:04 -0400)]
Merge pull request #63811 from zdover23/wip-doc-2025-06-09-backport-63782-to-tentacle
tentacle: doc/radosgw: edit metrics.rst
Matan Breizman [Mon, 9 Jun 2025 11:23:00 +0000 (14:23 +0300)]
Merge pull request #63432 from Matan-B/wip-matanb-crimson-tentacle-62071
crimson/os/seastore: tentacle: introduce BtreeCursor to simplify the implementation of LBAMapping/BackrefMapping
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Zac Dover [Fri, 6 Jun 2025 05:16:17 +0000 (15:16 +1000)]
doc/radosgw: edit metrics.rst
Edit doc/radosgw/metrics.rst.
Incorporate Anthony D'Atri's suggestion from
https://github.com/ceph/ceph/pull/62893#discussion_r2124662981 into the
RADOSGW documentation.
This commit clarifies the English that explains the behavior of
rgw-multitenancy.
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit
c7e49b85997369c5c29fb64da89fa676cb84e989 )
Zhang Song [Mon, 12 May 2025 07:14:55 +0000 (15:14 +0800)]
crimson/os/seastore/FixedKVBtree: correct MAX_DEPTH
Signed-off-by: Zhang Song <zhangsong02@qianxin.com>
(cherry picked from commit
fc8c8e6e3aef786fca2e40d381aa3325fb2180d5 )
Zhang Song [Mon, 12 May 2025 06:36:16 +0000 (14:36 +0800)]
crimson/os/seastore/FixedKVBtree: remove with_btree_ret helper function
Signed-off-by: Zhang Song <zhangsong02@qianxin.com>
(cherry picked from commit
725ec09ee5eead3893cd43ba8706d0836399ca2f )
Zhang Song [Fri, 9 May 2025 08:12:16 +0000 (16:12 +0800)]
crimson/os/seastore/lba: flatten lba namespace to keep consistent with backref
Signed-off-by: Zhang Song <zhangsong02@qianxin.com>
(cherry picked from commit
4593e5177d20ce22943123ae986c3c86e8d010a1 )
Zhang Song [Thu, 24 Apr 2025 09:42:10 +0000 (17:42 +0800)]
crimson/os/seastore/BtreeLBAManager: support refresh LBAMapping
Signed-off-by: Zhang Song <zhangsong02@qianxin.com>
(cherry picked from commit
dca4e562f2d92c1a481256518e5999b8f3e3ec4a )
Zhang Song [Thu, 24 Apr 2025 09:39:50 +0000 (17:39 +0800)]
crimson/os/seastore: simplify the processing of indirect LBAMapping
Signed-off-by: Zhang Song <zhangsong02@qianxin.com>
(cherry picked from commit
f2a804b64f928e878a6d30c39efc853163e88e7f )
Zhang Song [Thu, 24 Apr 2025 09:33:17 +0000 (17:33 +0800)]
crimson/os/seastore: fix LBAMapping/BackrefMapping usages
Signed-off-by: Zhang Song <zhangsong02@qianxin.com>
(cherry picked from commit
9c8e0a0634936e16b39f00075c9da4aaf92b042c )
Zhang Song [Thu, 24 Apr 2025 09:26:57 +0000 (17:26 +0800)]
crimson/os/seastore/BackrefManager: adpat new BackrefMapping
Signed-off-by: Zhang Song <zhangsong02@qianxin.com>
(cherry picked from commit
32a8cf134dfe992db924980344e9b53db79e002f )
Zhang Song [Thu, 24 Apr 2025 09:25:37 +0000 (17:25 +0800)]
crimson/os/seastore/BtreeLBAManager: cleanup the impl of alloc mapping and remap
Signed-off-by: Zhang Song <zhangsong02@qianxin.com>
(cherry picked from commit
d143fa7bb09b004f60efd6c94a6d34e00205249c )
Zhang Song [Thu, 24 Apr 2025 08:26:33 +0000 (16:26 +0800)]
crimson/os/seastore/BtreeLBAManager: refactor update_mapping_ret_bare_t
Signed-off-by: Zhang Song <zhangsong02@qianxin.com>
(cherry picked from commit
98df29eea1a2d3ba5694724a31c08e33d40cc9f9 )
Zhang Song [Thu, 24 Apr 2025 06:40:42 +0000 (14:40 +0800)]
crimson/os/seastore/BtreeLBAManager: refactor with LBACursorRef
Signed-off-by: Zhang Song <zhangsong02@qianxin.com>
(cherry picked from commit
0751f1a64a4957267c2f594a89e0d4bc92b25a12 )
Zhang Song [Thu, 24 Apr 2025 06:23:38 +0000 (14:23 +0800)]
crimson/os/seastore/BtreeLBAManager: split _alloc_extents implementation
Signed-off-by: Zhang Song <zhangsong02@qianxin.com>
(cherry picked from commit
1ab74cd5110d4a1397642369b5527226a68dc5fe )
Zhang Song [Thu, 24 Apr 2025 06:11:55 +0000 (14:11 +0800)]
crimson/os/seastore/BtreeLBAManager: cleanup alloc_mapping_info_t
Signed-off-by: Zhang Song <zhangsong02@qianxin.com>
(cherry picked from commit
20f2ed8a72eeb35620645d3d3a34853f2d2737e6 )
Zhang Song [Thu, 24 Apr 2025 05:57:04 +0000 (13:57 +0800)]
crimson/os/seastore: rename type remap_entry to remap_entry_t
Signed-off-by: Zhang Song <zhangsong02@qianxin.com>
(cherry picked from commit
14afe98f7353c16db5e70ff5b117795d8220e781 )
Zhang Song [Tue, 22 Apr 2025 08:25:28 +0000 (16:25 +0800)]
crimson/os/seastore: refactor LBAMapping and BackrefMapping
Signed-off-by: Zhang Song <zhangsong02@qianxin.com>
(cherry picked from commit
23883c91d5f80032a54609fc95ad2a7606509f5b )
Zhang Song [Thu, 10 Apr 2025 03:18:01 +0000 (11:18 +0800)]
crimson/os/seastore/FixedKVBtree: return BtreeCursor instead of BtreeMapping
Signed-off-by: Zhang Song <zhangsong02@qianxin.com>
(cherry picked from commit
84cb3d8ae44ddbf20a02f056141a7cd132de4d16 )
Zhang Song [Tue, 22 Apr 2025 08:16:12 +0000 (16:16 +0800)]
crimson/os/seastore/btree: introduce BtreeCursor
Signed-off-by: Zhang Song <zhangsong02@qianxin.com>
(cherry picked from commit
972c139e9c5c1405378495fa9d50b1a314dea618 )
Zhang Song [Wed, 26 Feb 2025 09:58:50 +0000 (17:58 +0800)]
crimson/os/seastore/btree: move lba/backref_map_val_t to the common header file
rename btree_range_pin.h to btree_types.h
Signed-off-by: Zhang Song <zhangsong02@qianxin.com>
(cherry picked from commit
8c6d82e0c7d6d27a9544d065bc6b9ccec4c6a3cc )
Xuehan Xu [Mon, 21 Apr 2025 06:39:08 +0000 (14:39 +0800)]
crimson/os/seastore: remove child_pos in LBAMapping
Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
(cherry picked from commit
fa6ed28eddedff368bb77447cefac64b196f6bf8 )
Zhang Song [Thu, 10 Apr 2025 03:15:11 +0000 (11:15 +0800)]
crimson/os/seastore: remove PhysicalNodeMapping and BtreeNodeMapping
Signed-off-by: Zhang Song <zhangsong02@qianxin.com>
(cherry picked from commit
3c4d047e1ed8d798aa83f156152fcbbef7e84ce9 )
Zhang Song [Thu, 10 Apr 2025 03:11:15 +0000 (11:11 +0800)]
crimson/os/seastore: move BtreeNodeMapping::is_viewable_by_trans to CachedExtent
Signed-off-by: Zhang Song <zhangsong02@qianxin.com>
(cherry picked from commit
54476e829fb83b9894c84691ec68d8417f336ffe )
Zhang Song [Mon, 7 Apr 2025 03:50:01 +0000 (11:50 +0800)]
crimson/os/seastore/btree: remove the unused template argument of op_context_t
Signed-off-by: Zhang Song <zhangsong02@qianxin.com>
(cherry picked from commit
796b1ec43e7992286dc7229c04af1ed40396e6cb )
Zhang Song [Wed, 26 Feb 2025 09:04:19 +0000 (17:04 +0800)]
crimson/os/seastore/FixedKVBtree: use min_max_t<>::min to build begin iterator
Signed-off-by: Zhang Song <zhangsong02@qianxin.com>
(cherry picked from commit
6ef9ee1697ddf528d53ce4ec92c45ea0bb32d851 )
Matan Breizman [Sun, 8 Jun 2025 06:55:39 +0000 (09:55 +0300)]
Merge pull request #63431 from Matan-B/wip-matanb-crimson-tentacle-63219
crimson/os/seastore/linked_tree_node: tentacle: correct balance pivots calculation for both fixed-kv tree and omap tree
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Guillaume Abrioux [Wed, 28 May 2025 11:33:10 +0000 (13:33 +0200)]
node-proxy: address `ceph orch hardware status` cmd
ce360a4a introduced a regression.
`ceph orch hardware status` fails when no hostname is passed (global
cluster hw status report).
Typical failure:
```
Error EINVAL: Traceback (most recent call last):
File "/usr/share/ceph/mgr/mgr_module.py", line 1928, in _handle_command
return self.handle_command(inbuf, cmd)
File "/usr/share/ceph/mgr/orchestrator/_interface.py", line 186, in handle_command
return dispatch[cmd['prefix']].call(self, cmd, inbuf)
File "/usr/share/ceph/mgr/mgr_module.py", line 527, in call
return self.func(mgr, **kwargs)
File "/usr/share/ceph/mgr/orchestrator/_interface.py", line 122, in <lambda>
wrapper_copy = lambda *l_args, **l_kwargs: wrapper(*l_args, **l_kwargs) # noqa: E731
File "/usr/share/ceph/mgr/orchestrator/_interface.py", line 111, in wrapper
return func(*args, **kwargs)
File "/usr/share/ceph/mgr/orchestrator/module.py", line 553, in _hardware_status
row = [k, v['sn']]
KeyError: 'sn'
```
Only the last node in the list has the `sn`, `host` and `firmwares`
information because of the wrong identation.
Fixes: https://tracker.ceph.com/issues/71472
Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
(cherry picked from commit
fbcdf571ca11d1b9f504dba64c23fb9f389c0710 )
Guillaume Abrioux [Wed, 4 Jun 2025 14:23:43 +0000 (16:23 +0200)]
mgr/dashboard: fix KeyError exception in HardwareService.get_summary()
Typical error:
```
[dashboard ERROR exception] Internal Server Error
Traceback (most recent call last):
File "/usr/share/ceph/mgr/dashboard/services/exception.py", line 48, in dashboard_exception_handler
return handler(*args, **kwargs)
File "/lib/python3.9/site-packages/cherrypy/_cpdispatch.py", line 54, in __call__
return self.callable(*self.args, **self.kwargs)
File "/usr/share/ceph/mgr/dashboard/controllers/_base_controller.py", line 263, in inner
ret = func(*args, **kwargs)
File "/usr/share/ceph/mgr/dashboard/controllers/_rest_controller.py", line 193, in wrapper
return func(*vpath, **params)
File "/usr/share/ceph/mgr/dashboard/controllers/hardware.py", line 21, in summary
return HardwareService.get_summary(categories, hostname)
File "/usr/share/ceph/mgr/dashboard/services/hardware.py", line 33, in get_summary
'ok': sum(item['status']['health'] == 'OK' for items in data.values()
File "/usr/share/ceph/mgr/dashboard/services/hardware.py", line 33, in <genexpr>
'ok': sum(item['status']['health'] == 'OK' for items in data.values()
KeyError: 'status'
```
The recent change from commit `
fbcdf571ca1 ` introduced this regression.
Fixes: https://tracker.ceph.com/issues/71558
Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
(cherry picked from commit
1b9bb174bf9a86242d1f0933a8aef6a61d1ac992 )
Zac Dover [Thu, 5 Jun 2025 02:06:00 +0000 (12:06 +1000)]
doc/mgr: edit telemetry (2 of x)
Improve the English and the formatting in doc/mgr/telemetry.rst. This
follows up on https://github.com/ceph/ceph/pull/63476.
This commit edits the second hundred lines in doc/mgr/telemetry.rst.
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit
f8975b05a6cff674ad5fb6ce93c839ca1856464c )
Zac Dover [Thu, 5 Jun 2025 00:02:47 +0000 (10:02 +1000)]
doc/mgr: edit telemetry (1 of x)
Improve the English and the formatting in doc/mgr/telemetry.rst. This
follows up on https://github.com/ceph/ceph/pull/63476.
This commit edits down to the line "Note that telemetry must be on for
these commands to take effect.", inclusive.
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit
b3e2ce500f3903a039b9ad442a3d4f4ffa9492e4 )
Zac Dover [Fri, 6 Jun 2025 01:52:38 +0000 (11:52 +1000)]
Merge pull request #63703 from zdover23/wip-doc-2025-06-04-backport-63622-to-tentacle
tentacle: doc/mgr/dashboard_plugins: edit feature_toggles.inc.rst
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Zac Dover [Fri, 6 Jun 2025 01:33:57 +0000 (11:33 +1000)]
Merge pull request #63651 from zdover23/wip-doc-2025-06-03-backport-63634-to-tentacle
tentacle: doc/start: edit documenting-ceph.rst
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Zac Dover [Fri, 6 Jun 2025 01:32:26 +0000 (11:32 +1000)]
Merge pull request #63648 from zdover23/wip-doc-2025-06-03-backport-63644-to-tentacle
tentacle: doc/rados/operations: Additional improvements to placement-groups.rst
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Zac Dover [Mon, 2 Jun 2025 02:32:36 +0000 (12:32 +1000)]
doc/start: edit documenting-ceph.rst
Edit the section "Build the Source" in doc/start/documenting-ceph.rst.
Also correct a misuse of the word "presently", which means "in a little
while", not "now".
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit
dd66c9e68b3518058382454949021504c65efe4b )
Casey Bodley [Thu, 5 Jun 2025 13:11:41 +0000 (09:11 -0400)]
Merge pull request #63730 from cbodley/wip-github-milestone-tentacle-tentacle
tentacle: github: add tentacle milestone
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Casey Bodley [Thu, 5 Jun 2025 13:10:40 +0000 (09:10 -0400)]
Merge pull request #63722 from cbodley/wip-71562-tentacle
tentacle: run-make: work around package conflicts from llvm.sh
Reviewed-by: Dan Mick <dmick@redhat.com>
Reviewed-by: Matan Breizman <mbreizma@redhat.com>
Anthony D'Atri [Thu, 5 Jun 2025 03:57:01 +0000 (23:57 -0400)]
Merge pull request #63742 from zdover23/wip-doc-2025-06-05-backport-63734-to-tentacle
tentacle: doc/mgr: edit cli_api
Zac Dover [Wed, 4 Jun 2025 23:52:40 +0000 (09:52 +1000)]
doc/mgr: edit cli_api
Improve the English in doc/mgr/cli_api.rst. Incorporate the changes
suggested by Anthony D'Atri in https://github.com/ceph/ceph/pull/63195.
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit
7722272c35044cd4e735427352cd4cef791091ee )
Anthony D'Atri [Thu, 5 Jun 2025 02:48:09 +0000 (22:48 -0400)]
Merge pull request #63736 from zdover23/wip-doc-2025-06-05-backport-63733-to-tentacle
tentacle: doc/glossary: s/OMAP/omap/
Zac Dover [Wed, 4 Jun 2025 23:39:33 +0000 (09:39 +1000)]
doc/glossary: s/OMAP/omap/
Change "OMAP" to "omap" to match the capitalization established by
Eleanor Cawthon in her 2012 omap paper, here:
https://ceph.io/assets/pdfs/CawthonKeyValueStore.pdf.
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit
2872986f9a581539b2aafe11a6cc085683623419 )
Casey Bodley [Thu, 29 May 2025 15:18:26 +0000 (11:18 -0400)]
github: add tentacle milestone
pull requests based on the tentacle branch aren't setting the milestone
Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit
88cdbc281ea71fba444f48ac9069dfed62dd6668 )
Casey Bodley [Wed, 21 May 2025 17:24:26 +0000 (13:24 -0400)]
run-make: work around package conflicts from llvm.sh
packages installed by llvm.sh sometimes conflict with existing packages
from earlier versions, leading to errors like:
> The following packages have unmet dependencies:
> python3-lldb-13 : Conflicts: python3-lldb-x.y
> python3-lldb-19 : Conflicts: python3-lldb-x.y
remove packages from any earlier versions before running llvm.sh
Fixes: https://tracker.ceph.com/issues/70792
Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit
54f0fe19447308f2127ad4bacecfa0aab4e44c4d )
Anthony D'Atri [Wed, 4 Jun 2025 06:03:41 +0000 (02:03 -0400)]
Merge pull request #63706 from zdover23/wip-doc-2025-06-04-backport-63686-to-tentacle
tentacle: doc/start: edit documenting-ceph.rst
Zac Dover [Wed, 4 Jun 2025 04:09:54 +0000 (14:09 +1000)]
Merge pull request #63422 from zdover23/wip-doc-2025-05-22-backport-63369-to-tentacle
tentacle: doc/mgr: edit diskpredictor.rst
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Zac Dover [Tue, 3 Jun 2025 19:23:53 +0000 (05:23 +1000)]
doc/start: edit documenting-ceph.rst
Edit the section "Build the Source (First Time)" in
doc/start/documenting-ceph.rst.
- remove references to RHEL7 (it's old)
- improve sentences (they were first-draft-like)
- improve RST formatting
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit
24771aecdcfb43c01bf3b54c87ce329b90d13389 )
Zac Dover [Wed, 4 Jun 2025 03:32:46 +0000 (13:32 +1000)]
Merge pull request #63447 from zdover23/wip-doc-2025-05-23-backport-63446-to-tentacle
tentacle: doc/radosgw: Cosmetic improvements in cloud-transition.rst
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Anthony D'Atri [Tue, 3 Jun 2025 21:51:27 +0000 (17:51 -0400)]
Merge pull request #63688 from zdover23/wip-doc-2025-06-04-backport-63195-to-tentacle
tentacle: doc/mgr: edit cli_api.rst
Anthony D'Atri [Tue, 3 Jun 2025 21:47:45 +0000 (17:47 -0400)]
Merge pull request #63691 from zdover23/wip-doc-2025-06-04-backport-63476-to-tentacle
tentacle: doc/mgr: edit telemetry.rst
Anthony D'Atri [Tue, 3 Jun 2025 21:46:19 +0000 (17:46 -0400)]
Merge pull request #63694 from zdover23/wip-doc-2025-06-04-backport-63614-to-tentacle
tentacle: doc/rados/operations: edit cache-tiering.rst
Anthony D'Atri [Tue, 3 Jun 2025 21:23:15 +0000 (17:23 -0400)]
Merge pull request #63699 from zdover23/wip-doc-2025-06-04-backport-62893-to-tentacle
tentacle: doc/radosgw: edit sentence in metrics.rst
Anthony D'Atri [Mon, 2 Jun 2025 18:35:23 +0000 (14:35 -0400)]
doc/rados/operations: Additional improvements to placement-groups.rst
Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
(cherry picked from commit
201e34119ab8628f5c99763212613678ec29dde3 )
Zac Dover [Sun, 1 Jun 2025 23:04:25 +0000 (09:04 +1000)]
doc/mgr/dashboard_plugins: edit feature_toggles.inc.rst
Follow up on the suggestions made by Anthony D'Atri in
https://github.com/ceph/ceph/pull/63367.
- Add "nvmeof" to the list of enabled features.
- Remove an extraneous space.
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit
6117c4eff3721a995612329cf51c25968371d48d )
Zac Dover [Tue, 3 Jun 2025 20:38:14 +0000 (06:38 +1000)]
Merge pull request #63645 from zdover23/wip-doc-2025-06-03-backport-63618-to-tentacle
tentacle: doc/rados/operations: Improve placement-groups.rst
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Zac Dover [Mon, 21 Apr 2025 07:52:02 +0000 (17:52 +1000)]
doc/radosgw: edit sentence in metrics.rst
Change the wording of a sentence in doc/radosgw/metrics.rst so that its
articles read as though they were written by a native speaker of the
English language.
This commit is being raised as part of a diagnostic process aimed at
discovering why the ReadtheDocs check is failing on PR
https://github.com/ceph/ceph/pull/62877.
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit
90ac0bdf7d6b1cda3a7e99a91bbeddbc8511c815 )
Zac Dover [Fri, 30 May 2025 12:38:03 +0000 (22:38 +1000)]
doc/rados/operations: edit cache-tiering.rst
Strengthen the warning against deploying cache tiering in releases after
Reef. This follows up on Anthony D'Atri's request in
https://github.com/ceph/ceph/pull/63465.
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit
f4de34f4bdbc7b3930afd8c034064675640df202 )
Zac Dover [Mon, 26 May 2025 04:56:24 +0000 (14:56 +1000)]
doc/mgr: edit telemetry.rst
Edit doc/mgr/telemetry.rst.
The English in this file is unacceptably demotic and exhibits a curious
but all-too-familiar lack here and there of definite articles.
This is part of a project to separate out the twenty-five files that
were committed to https://github.com/ceph/ceph/pull/62782.
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit
be67afcfcb51d07251f8a2be86de8dd7f45c713f )
Zac Dover [Fri, 9 May 2025 05:12:49 +0000 (15:12 +1000)]
doc/mgr: edit cli_api.rst
Edit doc/mgr/cli_api.rst as part of the project to determine where the
error is in https://github.com/ceph/ceph/pull/62782 that prevents the
Jenkins tests from passing.
This is a change to one of twenty-five files in
https://github.com/ceph/ceph/pull/62782 and this commit represents one
of what will be at least twenty-five other commits made to track this
error down.
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit
2ae483840ae1629677446150f649ca484b613dbe )
Zac Dover [Sun, 1 Jun 2025 23:25:42 +0000 (09:25 +1000)]
doc/rados: edit balancer.rst
Edit doc/rados/operations/balancer.rst. Follow up on matters raised in
https://github.com/ceph/ceph/pull/63530. Make the English clearer.
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit
7bf5196e7037a89e6a04c770241ef25b53d2a809 )
Anthony D'Atri [Tue, 3 Jun 2025 14:20:04 +0000 (10:20 -0400)]
Merge pull request #63656 from zdover23/wip-doc-2025-06-03-backport-63633-to-tentacle
tentacle: doc/mgr: edit progress.rst
Anthony D'Atri [Tue, 3 Jun 2025 14:18:41 +0000 (10:18 -0400)]
Merge pull request #63659 from zdover23/wip-doc-2025-06-03-backport-63632-to-tentacle
tentacle: doc/dev/cephfs-mirroring: edit file 4 of x
Anthony D'Atri [Tue, 3 Jun 2025 14:17:28 +0000 (10:17 -0400)]
Merge pull request #63662 from zdover23/wip-doc-2025-06-03-backport-63631-to-tentacle
tentacle: doc/mgr: edit nfs.rst
Anthony D'Atri [Tue, 3 Jun 2025 14:16:19 +0000 (10:16 -0400)]
Merge pull request #63665 from zdover23/wip-doc-2025-06-03-backport-63630-to-tentacle
tentacle: doc/mgr: edit modules.rst
Anthony D'Atri [Tue, 3 Jun 2025 11:16:46 +0000 (07:16 -0400)]
Merge pull request #63668 from zdover23/wip-doc-2025-06-03-backport-63629-to-tentacle
tentacle: doc/mgr: edit localpool.rst
afreen23 [Tue, 3 Jun 2025 09:53:25 +0000 (15:23 +0530)]
Merge pull request #63640 from piyushagarwal1411/wip-71477-tentacle
tentacle: mgr/dashboard: Creating CephFS dashboard for Grafana
Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Zac Dover [Sun, 1 Jun 2025 23:33:20 +0000 (09:33 +1000)]
doc/mgr: edit localpool.rst
Remove "only" where it was extraneous.
This commit was made in response to a request made by Anthony D'Atri
here: https://github.com/ceph/ceph/pull/63419#discussion_r2102803276.
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit
e43de826ca5ba122e900ad986db2be8edbac0982 )