]>
git.apps.os.sepia.ceph.com Git - ceph.git/log
Hyun Jin Kim [Tue, 17 Jun 2025 13:01:28 +0000 (09:01 -0400)]
doc/radosgw/admin.rst: explain bucket and uid flags for bucket quota
Clarify behavior of bucket and uid flags when setting a quota with
quota-scope=bucket.
Signed-off-by: Hyun Jin Kim <hello.hyunjin@gmail.com>
Zac Dover [Wed, 11 Jun 2025 00:16:26 +0000 (10:16 +1000)]
Merge pull request #63827 from zdover23/wip-doc-2025-06-10-mgr-telemetry-63741-followup
doc/mgr: edit telemetry.rst (lines 300-400)
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Zac Dover [Wed, 11 Jun 2025 00:09:13 +0000 (10:09 +1000)]
Merge pull request #63826 from zdover23/wip-doc-2025-06-10-mgr-telemetry-63740-followup
doc/mgr: edit telemetry.rst
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Zac Dover [Wed, 11 Jun 2025 00:05:22 +0000 (10:05 +1000)]
Merge pull request #63842 from zdover23/wip-doc-2025-06-10-rados-ops-pools
doc/rados: enhance "pools.rst"
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Zac Dover [Tue, 10 Jun 2025 12:50:16 +0000 (22:50 +1000)]
Merge pull request #63836 from zdover23/wip-doc-2025-06-10-63824-followup-test
doc/rados/operations: Address suggestions for stretch-mode.rst
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Ilya Dryomov [Tue, 10 Jun 2025 11:46:46 +0000 (13:46 +0200)]
Merge pull request #63841 from zdover23/wip-doc-2025-06-10-rbd-mirroring-tracker-71620
doc/rbd: add mirroring troubleshooting info
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Zac Dover [Tue, 10 Jun 2025 10:38:54 +0000 (20:38 +1000)]
doc/rbd: add mirroring troubleshooting info
Add a note to doc/rbd/rbd-mirroring.rst that directs the reader to set
both "site-a" and "site-b" to have the same pool names in the event that
rbd throws the error message "failed to import peer bootstrap token".
This information was reported to the Ceph upstream by Petr Tlapa in June
of 2025, and credit for its development goes to Petr.
Signed-off-by: Zac Dover <zac.dover@proton.me>
Zac Dover [Tue, 10 Jun 2025 10:58:22 +0000 (20:58 +1000)]
doc/rados: enhance "pools.rst"
Add a link to the instructions for modifying a user's caps for a given
pool. Add this link where it makes sense to add it. Add this link where
the reader would naturally want to have the link.
Signed-off-by: Zac Dover <zac.dover@proton.me>
Kefu Chai [Tue, 10 Jun 2025 10:21:59 +0000 (18:21 +0800)]
Merge pull request #63819 from tchaikov/wip-lua-fix-leak
rgw/rgw_lua_utils: fix memory leak in luaL_error() formatting
Reviewed-by: Yuval Lifshitz <ylifshit@ibm.com>
Anthony D'Atri [Mon, 9 Jun 2025 15:02:04 +0000 (11:02 -0400)]
doc/rados/operations: Address suggestions for stretch-mode.rst
Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
fixup
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit
3f5bf8dedd18f2f6d4afc0583be124be879667f2 )
Zac Dover [Tue, 10 Jun 2025 05:51:38 +0000 (15:51 +1000)]
Merge pull request #63745 from zdover23/wip-doc-2025-06-05-rados-ops-cache-tiering-63614-followup
doc/rados/ops: edit cache-tiering.rst
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Kefu Chai [Tue, 10 Jun 2025 04:02:00 +0000 (12:02 +0800)]
Merge pull request #58194 from bill-scales/fix_unittest_rocksdb_option
test/objectstore/TestRocksdbOptionParse.cc: Fix race hazard
Reviewed-by: Igor Fedotov <igor.fedotov@croit.io>
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
Zac Dover [Tue, 10 Jun 2025 02:54:18 +0000 (12:54 +1000)]
doc/mgr: edit telemetry.rst (lines 300-400)
Edit doc/mgr/telemetry.rst (lines 300-400).
Follow up on the suggestions made by Anthony D'Atri in
https://github.com/ceph/ceph/pull/63741 (except for the one about
including Lovecraftian lore in the dummy user data in this file).
Signed-off-by: Zac Dover <zac.dover@proton.me>
Zac Dover [Tue, 10 Jun 2025 02:50:13 +0000 (12:50 +1000)]
doc/mgr: edit telemetry.rst
Edit doc/mgr/telemetry.rst.
Follow up on the suggestions made by Anthony D'Atri in
https://github.com/ceph/ceph/pull/63740.
Make several changes that were not earmarked in that PR, but that
nonetheless improve the quality of the English in telemetry.rst.
Signed-off-by: Zac Dover <zac.dover@proton.me>
Casey Bodley [Mon, 9 Jun 2025 16:29:58 +0000 (12:29 -0400)]
Merge pull request #63599 from tchaikov/wip-dbstore_tests
rgw/dbstore: free objectmap in DB::Destroy()
Reviewed-by: Soumya Koduri <skoduri@redhat.com>
Casey Bodley [Mon, 9 Jun 2025 16:18:59 +0000 (12:18 -0400)]
Merge pull request #63677 from yuvalif/wip-yuval-71537
rgw/logging: fix partitioned key format
Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>
Casey Bodley [Mon, 9 Jun 2025 16:15:19 +0000 (12:15 -0400)]
Merge pull request #63750 from yuvalif/wip-yuval-71563
rgw/logging: log only object ACls in journal mode
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Casey Bodley [Mon, 9 Jun 2025 16:12:38 +0000 (12:12 -0400)]
Merge pull request #63715 from benhanokh/dedup_thread_name_fix
rgw/dedup: Bug-Fix
Reviewed-by: Yuval Lifshitz <ylifshit@ibm.com>
Kefu Chai [Mon, 9 Jun 2025 10:26:21 +0000 (18:26 +0800)]
rgw/rgw_lua_utils: fix memory leak in luaL_error() formatting
Previously, error messages passed to luaL_error() were formatted using
std::string concatenation. Since luaL_error() never returns (it throws
a Lua exception via longjmp), the allocated std::string memory was
leaked, as detected by AddressSanitizer:
```
Direct leak of 105 byte(s) in 1 object(s) allocated from:
#0 0x7fc5f1921a2d in operator new(unsigned long) /usr/src/debug/gcc/gcc/libsanitizer/asan/asan_new_delete.cpp:86
#1 0x563bd89144c7 in std::__new_allocator<char>::allocate(unsigned long, void const*) /usr/include/c++/15.1.1/bits/new_allocator.h:151
#2 0x563bd89144c7 in std::allocator<char>::allocate(unsigned long) /usr/include/c++/15.1.1/bits/allocator.h:203
#3 0x563bd89144c7 in std::allocator_traits<std::allocator<char> >::allocate(std::allocator<char>&, unsigned long) /usr/include/c++/15.1.1/bits/alloc_traits.h:614
#4 0x563bd89144c7 in std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_S_allocate(std::allocator<char>&, unsigned long) /usr/include/c++/15.1.1/bits/basic_string.h:142
#5 0x563bd89144c7 in std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_create(unsigned long&, unsigned long) /usr/include/c++/15.1.1/bits/basic_string.tcc:164
#6 0x563bd896ae1b in std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_mutate(unsigned long, unsigned long, char const*, unsigned long) /usr/include/c++/15.1.1/bits/basic_string.tcc:363
#7 0x563bd896b256 in std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_append(char const*, unsigned long) /usr/include/c++/15.1.1/bits/basic_string.tcc:455
#8 0x563bd896b2bb in std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::append(char const*) /usr/include/c++/15.1.1/bits/basic_string.h:1585
#9 0x563bd943c2f2 in std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > std::operator+<char, std::char_traits<char>, std::allocator<char> >(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&&, char const*) /usr/include/c++/15.1.1/bits/basic_string.h:3977
#10 0x563bd943c2f2 in rgw::lua::lua_state_guard::runtime_hook(lua_State*, lua_Debug*) /home/kefu/dev/ceph/src/rgw/rgw_lua_utils.cc:245
#11 0x7fc5f139f8ef (/usr/lib/liblua.so.5.4+0xe8ef) (BuildId:
b7533e2973d4b0d82e10fc29973ec5a8d355d2b8 )
#12 0x7fc5f139fbfe (/usr/lib/liblua.so.5.4+0xebfe) (BuildId:
b7533e2973d4b0d82e10fc29973ec5a8d355d2b8 )
#13 0x7fc5f13b26fe (/usr/lib/liblua.so.5.4+0x216fe) (BuildId:
b7533e2973d4b0d82e10fc29973ec5a8d355d2b8 )
#14 0x7fc5f139f581 (/usr/lib/liblua.so.5.4+0xe581) (BuildId:
b7533e2973d4b0d82e10fc29973ec5a8d355d2b8 )
#15 0x7fc5f139b735 (/usr/lib/liblua.so.5.4+0xa735) (BuildId:
b7533e2973d4b0d82e10fc29973ec5a8d355d2b8 )
#16 0x7fc5f139ba8f (/usr/lib/liblua.so.5.4+0xaa8f) (BuildId:
b7533e2973d4b0d82e10fc29973ec5a8d355d2b8 )
#17 0x7fc5f139f696 in lua_pcallk (/usr/lib/liblua.so.5.4+0xe696) (BuildId:
b7533e2973d4b0d82e10fc29973ec5a8d355d2b8 )
#18 0x563bd8a925ef in rgw::lua::request::execute(rgw::sal::Driver*, RGWREST*, OpsLogSink*, req_state*, RGWOp*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) /home/kefu/dev/ceph/src/rgw/rgw_lua_request.cc:824
#19 0x563bd8952e3d in TestRGWLua_LuaRuntimeLimit_Test::TestBody() /home/kefu/dev/ceph/src/test/rgw/test_rgw_lua.cc:1628
#20 0x563bd8a37817 in void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) /home/kefu/dev/ceph/src/googletest/googletest/src/gtest.cc:2653
#21 0x563bd8a509b5 in void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) (/home/kefu/dev/ceph/build/bin/unittest_rgw_lua+0x11199b5) (BuildId:
b2628caba5290d882d25f7bea166f058b682bc85 )`
```
This change replaces std::string formatting with stack-allocated buffer
and std::to_chars() to eliminate the memory leak.
Note: We cannot format int64_t directly through luaL_error() because
lua_pushfstring() does not support long long or int64_t format specifiers,
even in Lua 5.4 (see https://www.lua.org/manual/5.4/manual.html#lua_pushfstring).
Since libstdc++ uses int64_t for std::chrono::milliseconds::rep, we use
std::to_chars() for safe, efficient conversion without heap allocation.
The maximum runtime limit was a configuration introduced by
3e3cb156 .
Fixes: https://tracker.ceph.com/issues/71595
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
Zac Dover [Mon, 9 Jun 2025 09:51:33 +0000 (19:51 +1000)]
Merge pull request #62714 from anthonyeleven/improve-stretchops
doc/rados/operations: Improve stretch-mode.rst
Reviewed-by: Zac Dover <zac.dover@proton.me>
Zac Dover [Mon, 9 Jun 2025 09:01:00 +0000 (19:01 +1000)]
Merge pull request #63781 from zdover23/wip-doc-2025-06-06-mgr-telemetry-63739-followup
doc/mgr: edit telemetry.rst
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Matan Breizman [Mon, 9 Jun 2025 07:42:13 +0000 (10:42 +0300)]
Merge pull request #63460 from myoungwon/wip-fix-wrong-print-format
crimson/osd: fix incorrect format error in log message
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Matan Breizman [Mon, 9 Jun 2025 07:41:41 +0000 (10:41 +0300)]
Merge pull request #63350 from Matan-B/wip-matanb-crimson-hwloc
src/CMakeLists: Crimson - enable libhwloc
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Matan Breizman [Mon, 9 Jun 2025 07:39:01 +0000 (10:39 +0300)]
Merge pull request #63333 from Matan-B/wip-matanb-crimson-poll-mode
common/options/crimson: introduce crimson_poll_mode
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Kefu Chai [Sun, 8 Jun 2025 13:23:55 +0000 (21:23 +0800)]
Merge pull request #63655 from tchaikov/wip-cmake-breakpad
cmake: enable out-of-source build of breakpad
Reviewed-by: Marcel Lauhoff <marcel.lauhoff@clyso.com>
Reviewed-by: Jesse F. Williamson <jfw@ibm.com>
Ronen Friedman [Sun, 8 Jun 2025 11:53:15 +0000 (14:53 +0300)]
Merge pull request #63758 from ronen-fr/wip-rf-startedat
osd/scrub: make m_session_started_at at Session state ctor
Reviewed-by: Samuel Just <sjust@redhat.com>
Kefu Chai [Wed, 4 Jun 2025 03:05:38 +0000 (11:05 +0800)]
cmake: enable out-of-source build of breakpad
Previously, Breakpad was built in its source tree instead of the
user-specified build directory, inconsistent with other external
projects and potentially causing source tree pollution.
Include path fix:
- Add ${INSTALL_DIR}/include/breakpad to include directories to fix
FTBFS on Jammy builders
Build system improvements:
- Replace dedicated LSS submodule symlink target with PATCH_COMMAND to
simplify the build process
- Use user-specified make command instead of hardcoded "make"
- Skip building unused process library and tools
- Link against breakpad with PRIVATE visibility unless required
Compiler flag cleanups:
- Remove -Wno-array-bounds from CFLAGS (Breakpad uses C++/CXXFLAGS)
- Remove compile-time flags incorrectly placed in LDFLAGS
- Remove '-fPIC' from CFLAGS, as it is already included by breakpad
when building on linux hosts.
- Replace the individual -Wno-* flags with -Wno-error to cancel
-Werror option specified by breakpad. This is more future-proof.
CMake target modernization:
- Rename libbreakpad_client to Breakpad::client following modern conventions
- Add Breakpad::breakpad header-only target to minimize dependencies
- Install library to enable proper include path prefixes
(breakpad/client/... vs client/...)
Header dependency optimization:
- Remove Breakpad includes from popular headers, use forward declarations
- Include Breakpad headers before internal headers for better readability
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
Samuel Just [Fri, 6 Jun 2025 21:33:14 +0000 (14:33 -0700)]
Merge pull request #63620 from athanatos/sjust/wip-71512
cls/CMakeLists.txt: find_package Lua for cls_lua
Reviewed-by: Matan Breizman <mbreizma@redhat.com>
Ernesto Puerta [Fri, 6 Jun 2025 16:34:59 +0000 (18:34 +0200)]
Merge pull request #63671 from ceph/dependabot-npm_and_yarn-src-pybind-mgr-dashboard-frontend-tar-fs-2.1.3
mgr/dashboard: bump tar-fs from 2.1.2 to 2.1.3 in /src/pybind/mgr/dashboard/frontend
Ronen Friedman [Wed, 4 Jun 2025 17:44:16 +0000 (12:44 -0500)]
osd/scrub: make m_session_started_at at Session state ctor
ScrubMachine::get_time_scrubbing() must access the Session object
to compute the scrub duration. But the State data is not externally
accessible before its ctor has completed.
As we always happen to try to access that data inside the ctor,
this always results in a warning log message.
Here we move m_session_started_at into the outer state, simplifying
the logic required to access it.
Fixes: https://tracker.ceph.com/issues/64955
Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
Anthony D'Atri [Fri, 6 Jun 2025 12:28:47 +0000 (08:28 -0400)]
Merge pull request #63782 from zdover23/wip-doc-2025-06-06-radosgw-metrics-62893-followup
doc/radosgw: edit metrics.rst
Adam Kupczyk [Fri, 6 Jun 2025 10:49:45 +0000 (12:49 +0200)]
Merge pull request #62817 from aclamk/aclamk-bs-reshard-problem-replicate
os/bluestore: Debug code to make reshard fail faster
Zac Dover [Fri, 6 Jun 2025 05:16:17 +0000 (15:16 +1000)]
doc/radosgw: edit metrics.rst
Edit doc/radosgw/metrics.rst.
Incorporate Anthony D'Atri's suggestion from
https://github.com/ceph/ceph/pull/62893#discussion_r2124662981 into the
RADOSGW documentation.
This commit clarifies the English that explains the behavior of
rgw-multitenancy.
Signed-off-by: Zac Dover <zac.dover@proton.me>
Zac Dover [Fri, 6 Jun 2025 05:11:15 +0000 (15:11 +1000)]
doc/mgr: edit telemetry.rst
Edit doc/mgr/telemetry.rst.
Incorporate Anthony D'Atri's suggestions from
https://github.com/ceph/ceph/pull/63739.
Signed-off-by: Zac Dover <zac.dover@proton.me>
Zac Dover [Fri, 6 Jun 2025 04:49:57 +0000 (14:49 +1000)]
Merge pull request #63741 from zdover23/wip-doc-2025-06-05-mgr-telemetry-63476-followup-4-of-x
doc/mgr: edit telemetry (4 of x)
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Zac Dover [Fri, 6 Jun 2025 04:48:35 +0000 (14:48 +1000)]
Merge pull request #63740 from zdover23/wip-doc-2025-06-05-mgr-telemetry-63476-followup-3-of-x
doc/mgr: edit telemetry (3 of x)
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Zac Dover [Fri, 6 Jun 2025 04:43:11 +0000 (14:43 +1000)]
Merge pull request #63739 from zdover23/wip-doc-2025-06-05-mgr-telemetry-63476-followup-2-of-x
doc/mgr: edit telemetry (2 of x)
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Zac Dover [Fri, 6 Jun 2025 04:39:37 +0000 (14:39 +1000)]
Merge pull request #63735 from zdover23/wip-doc-2025-06-05-mgr-telemetry-63476-followup
doc/mgr: edit telemetry (1 of x)
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Zac Dover [Fri, 6 Jun 2025 01:25:35 +0000 (11:25 +1000)]
Merge pull request #63085 from zdover23/wip-doc-2025-05-01-mgr-yaml-in-62983-followup-1
doc/src/common/options: mgr.yaml.in edit
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Kefu Chai [Thu, 5 Jun 2025 14:56:53 +0000 (22:56 +0800)]
Merge pull request #63595 from tchaikov/wip-test_librados_completion-fix-leak
test/common: fix memory leak in librados completion tests
Reviewed-by: Adam Emerson <aemerson@redhat.com>
Patrick Donnelly [Thu, 5 Jun 2025 14:36:49 +0000 (10:36 -0400)]
Merge PR #63621 into main
* refs/pull/63621/head:
mon/FSCommands: avoid unreachable code triggering compiler warning
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
Reviewed-by: Matan Breizman <mbreizma@redhat.com>
Nizamudeen A [Thu, 5 Jun 2025 13:02:09 +0000 (18:32 +0530)]
Merge pull request #63721 from guits/dashboard-hw-fix
mgr/dashboard: fix KeyError exception in HardwareService.get_summary()
Venky Shankar [Thu, 5 Jun 2025 08:51:32 +0000 (14:21 +0530)]
Merge pull request #63713 from anoopcs9/bump-libcephfs-major-vers
libcephfs: Bump API major version
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Adam Kupczyk [Thu, 5 Jun 2025 08:09:48 +0000 (08:09 +0000)]
qa, ec-esb-fio: Add flag for easier replication
Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
Adam Kupczyk [Tue, 15 Apr 2025 08:31:49 +0000 (08:31 +0000)]
os/bluestore: Debug code to make reshard fail faster
Catch reshard on producing invalid result on encode.
This makes it much easier to catch error.
Intented for teuthology testing.
Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
Yuval Lifshitz [Thu, 5 Jun 2025 07:48:07 +0000 (07:48 +0000)]
rgw/logging: log only object ACls in journal mode
Fixes: https://tracker.ceph.com/issues/71563
Signed-off-by: Yuval Lifshitz <ylifshit@ibm.com>
Zac Dover [Thu, 5 Jun 2025 03:28:13 +0000 (13:28 +1000)]
doc/rados/ops: edit cache-tiering.rst
Remove part of a sentence that might have led readers to think that it
is a good idea to deploy cache tiering on releases prior to Reef.
This incorporates Anthony D'Atri's suggestion from here: https://github.com/ceph/ceph/pull/63614#discussion_r2116020937
Signed-off-by: Zac Dover <zac.dover@proton.me>
Zac Dover [Thu, 5 Jun 2025 03:05:54 +0000 (13:05 +1000)]
doc/mgr: edit telemetry (4 of x)
Improve the English and the formatting in doc/mgr/telemetry.rst. This
follows up on https://github.com/ceph/ceph/pull/63476.
This commit edits the final part of doc/mgr/telemetry.rst.
Signed-off-by: Zac Dover <zac.dover@proton.me>
Zac Dover [Thu, 5 Jun 2025 02:24:08 +0000 (12:24 +1000)]
doc/mgr: edit telemetry (3 of x)
Improve the English and the formatting in doc/mgr/telemetry.rst. This
follows up on https://github.com/ceph/ceph/pull/63476.
This commit edits the third hundred lines in doc/mgr/telemetry.rst.
Signed-off-by: Zac Dover <zac.dover@proton.me>
Zac Dover [Thu, 5 Jun 2025 02:06:00 +0000 (12:06 +1000)]
doc/mgr: edit telemetry (2 of x)
Improve the English and the formatting in doc/mgr/telemetry.rst. This
follows up on https://github.com/ceph/ceph/pull/63476.
This commit edits the second hundred lines in doc/mgr/telemetry.rst.
Signed-off-by: Zac Dover <zac.dover@proton.me>
Adam King [Thu, 5 Jun 2025 00:59:09 +0000 (20:59 -0400)]
Merge pull request #62935 from adk3798/cephadm-fix-shell-name-stopped-daemon
cephadm: don't collect image ids for daemons with no container info
Reviewed-by: John Mulligan <jmulligan@redhat.com>
Reviewed-by: Redouane Kachach <rkachach@ibm.com>
Kefu Chai [Thu, 5 Jun 2025 00:40:39 +0000 (08:40 +0800)]
Merge pull request #63729 from athanatos/sjust/wip-71568
.gitmodules: remove shallow=true config from nvmeof/gateway
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
Zac Dover [Thu, 5 Jun 2025 00:02:47 +0000 (10:02 +1000)]
doc/mgr: edit telemetry (1 of x)
Improve the English and the formatting in doc/mgr/telemetry.rst. This
follows up on https://github.com/ceph/ceph/pull/63476.
This commit edits down to the line "Note that telemetry must be on for
these commands to take effect.", inclusive.
Signed-off-by: Zac Dover <zac.dover@proton.me>
Anthony D'Atri [Thu, 5 Jun 2025 00:01:26 +0000 (20:01 -0400)]
Merge pull request #63734 from zdover23/wip-doc-2025-06-05-cli_api-63195-followup
doc/mgr: edit cli_api
Anthony D'Atri [Thu, 5 Jun 2025 00:00:45 +0000 (20:00 -0400)]
Merge pull request #63733 from zdover23/wip-doc-2025-06-05-glossary-omap
doc/glossary: s/OMAP/omap/
Zac Dover [Wed, 4 Jun 2025 23:52:40 +0000 (09:52 +1000)]
doc/mgr: edit cli_api
Improve the English in doc/mgr/cli_api.rst. Incorporate the changes
suggested by Anthony D'Atri in https://github.com/ceph/ceph/pull/63195.
Signed-off-by: Zac Dover <zac.dover@proton.me>
Zac Dover [Wed, 4 Jun 2025 23:39:33 +0000 (09:39 +1000)]
doc/glossary: s/OMAP/omap/
Change "OMAP" to "omap" to match the capitalization established by
Eleanor Cawthon in her 2012 omap paper, here:
https://ceph.io/assets/pdfs/CawthonKeyValueStore.pdf.
Signed-off-by: Zac Dover <zac.dover@proton.me>
Casey Bodley [Wed, 4 Jun 2025 22:20:55 +0000 (18:20 -0400)]
Merge pull request #63596 from cbodley/wip-github-milestone-tentacle
github: add tentacle milestone
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>
Samuel Just [Wed, 4 Jun 2025 20:55:21 +0000 (20:55 +0000)]
.gitmodules: remove shallow=true config from nvmeof/gateway
https://github.com/ceph/ceph/pull/61264 reintroduced
https://tracker.ceph.com/issues/67640 fixed by
383091e89 .
Setting shallow=true for the nvmeof/gateway submodule
is problematic because the ceph.git submodule sha1
is only very rarely the head sha1 of the default
branch.
Fixes: https://tracker.ceph.com/issues/71568
Signed-off-by: Samuel Just <sjust@redhat.com>
Casey Bodley [Wed, 4 Jun 2025 20:22:07 +0000 (16:22 -0400)]
Merge pull request #63361 from cbodley/wip-github-label-rgw-docs
github: add rgw label for changes in doc/radosgw
Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>
Casey Bodley [Wed, 4 Jun 2025 20:21:01 +0000 (16:21 -0400)]
Merge pull request #63702 from ThomasLamprecht/deb-radosgw-media-types-dependency
debian: radosgw: add media-types packages as alternative for mime-support
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
Guillaume Abrioux [Wed, 4 Jun 2025 14:23:43 +0000 (16:23 +0200)]
mgr/dashboard: fix KeyError exception in HardwareService.get_summary()
Typical error:
```
[dashboard ERROR exception] Internal Server Error
Traceback (most recent call last):
File "/usr/share/ceph/mgr/dashboard/services/exception.py", line 48, in dashboard_exception_handler
return handler(*args, **kwargs)
File "/lib/python3.9/site-packages/cherrypy/_cpdispatch.py", line 54, in __call__
return self.callable(*self.args, **self.kwargs)
File "/usr/share/ceph/mgr/dashboard/controllers/_base_controller.py", line 263, in inner
ret = func(*args, **kwargs)
File "/usr/share/ceph/mgr/dashboard/controllers/_rest_controller.py", line 193, in wrapper
return func(*vpath, **params)
File "/usr/share/ceph/mgr/dashboard/controllers/hardware.py", line 21, in summary
return HardwareService.get_summary(categories, hostname)
File "/usr/share/ceph/mgr/dashboard/services/hardware.py", line 33, in get_summary
'ok': sum(item['status']['health'] == 'OK' for items in data.values()
File "/usr/share/ceph/mgr/dashboard/services/hardware.py", line 33, in <genexpr>
'ok': sum(item['status']['health'] == 'OK' for items in data.values()
KeyError: 'status'
```
The recent change from commit `
fbcdf571ca1 ` introduced this regression.
Fixes: https://tracker.ceph.com/issues/71558
Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
Casey Bodley [Wed, 4 Jun 2025 18:57:08 +0000 (14:57 -0400)]
Merge pull request #63409 from cbodley/wip-70792
run-make: work around package conflicts from llvm.sh
Reviewed-by: Dan Mick <dmick@redhat.com>
Samuel Just [Tue, 3 Jun 2025 21:55:13 +0000 (21:55 +0000)]
cls/CMakeLists.txt: find_package Lua for cls_lua
src/CMakeLists.txt does do find_package for Lua:
if(WITH_CEPHFS OR WITH_RADOSGW)
find_package(Lua 5.3 REQUIRED)
endif()
but only if WITH_CEPHFS or WITH_RADOSGW. Seperately
require it in cls/CMakeLists.txt for cls_lua.
Fixes: https://tracker.ceph.com/issues/71512
Signed-off-by: Samuel Just <sjust@redhat.com>
Yuval Lifshitz [Tue, 3 Jun 2025 15:06:44 +0000 (15:06 +0000)]
rgw/logging: fix partitioned key format
Fixes: https://tracker.ceph.com/issues/71537
Signed-off-by: Yuval Lifshitz <ylifshit@ibm.com>
Yuval Lifshitz [Wed, 4 Jun 2025 13:34:19 +0000 (16:34 +0300)]
Merge pull request #63264 from yuvalif/wip-yuval-71308
rgw/logging: Make unique portion of log object name ordered
Casey Bodley [Wed, 21 May 2025 17:24:26 +0000 (13:24 -0400)]
run-make: work around package conflicts from llvm.sh
packages installed by llvm.sh sometimes conflict with existing packages
from earlier versions, leading to errors like:
> The following packages have unmet dependencies:
> python3-lldb-13 : Conflicts: python3-lldb-x.y
> python3-lldb-19 : Conflicts: python3-lldb-x.y
remove packages from any earlier versions before running llvm.sh
Fixes: https://tracker.ceph.com/issues/70792
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Yuval Lifshitz [Wed, 4 Jun 2025 13:11:51 +0000 (16:11 +0300)]
Merge pull request #63244 from yuvalif/wip-yuval-71288
rgw/logging: add size in MPU complete in standard mode
Patrick Donnelly [Wed, 4 Jun 2025 12:42:39 +0000 (08:42 -0400)]
Merge PR #62865 into main
* refs/pull/62865/head:
test/libcephfs: copy DT_NEEDED entries from input libraries
test/fs: only add libcephfs as library dependency
test/client: do not depend on libcephfs
Reviewed-by: Viacheslav Dubeyko <Slava.Dubeyko@ibm.com>
Gabriel BenHanokh [Wed, 4 Jun 2025 11:29:20 +0000 (11:29 +0000)]
rgw/dedup: Bug-Fix
Move ceph_pthread_setname() call from main RGW code to the dedup
bg-thread
Signed-off-by: Gabriel BenHanokh <gbenhano@redhat.com>
Naveen Naidu [Wed, 4 Jun 2025 08:54:19 +0000 (14:24 +0530)]
Merge pull request #63136 from Naveenaidu/wip-naveen-config-diff-scripts
script: add configuration diff tool
Anoop C S [Wed, 4 Jun 2025 08:02:01 +0000 (13:32 +0530)]
libcephfs: Bump API major version
We recently had ABI changes[1] with respect to APIs from chown() family
which calls for a change in major version. Native users of the library
may not have to change their code but expected sizes differ when data
type for parameters are changed. However go-ceph, Go bindings for ceph,
couldn't build[2] unless the ABI change is made visible to the consumers
of the API. Following the Semantic Versioning guidelines[3] we reset
minor and patch (extra) versions to 0.
[1] https://github.com/ceph/ceph/pull/62934
[2] https://github.com/ceph/go-ceph/issues/1119
[3] https://semver.org/#spec-item-8
Fixes: https://tracker.ceph.com/issues/71519
Signed-off-by: Anoop C S <anoopcs@cryptolab.net>
Guillaume Abrioux [Wed, 4 Jun 2025 07:07:51 +0000 (09:07 +0200)]
Merge pull request #62648 from guits/refactor_setup_device
ceph-volume: refactor LvmBlueStore.setup_device()
Yingxin Cheng [Wed, 4 Jun 2025 06:10:03 +0000 (14:10 +0800)]
Merge pull request #63389 from cyx1231st/wip-seastore-refine-extent-states
crimson/os/seastore: cleanup CachedExtent::extent_state_t and related logic
Reviewed-by: Xuehan Xu <xuxuehan@qianxin.com>
Zac Dover [Wed, 4 Jun 2025 03:33:23 +0000 (13:33 +1000)]
Merge pull request #63686 from zdover23/wip-doc-2025-06-04-start-documenting-ceph
doc/start: edit documenting-ceph.rst
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Naveen Naidu [Thu, 17 Apr 2025 13:50:57 +0000 (19:20 +0530)]
.github/workflow: add diff ceph config action
Signed-off-by: Naveen Naidu <naveen.naidu@ibm.com>
Naveen Naidu [Thu, 17 Apr 2025 13:50:40 +0000 (19:20 +0530)]
script: add config-diff tool
Signed-off-by: Naveen Naidu <naveen.naidu@ibm.com>
Yingxin Cheng [Tue, 3 Jun 2025 06:23:50 +0000 (14:23 +0800)]
crimson/os/seastore/../btree_omap_manager: workaround log failure
See https://tracker.ceph.com/issues/71524
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Yingxin Cheng [Thu, 22 May 2025 03:52:37 +0000 (11:52 +0800)]
test/crimson/../test_transaction_manager: fix try_get_extent() to handle transaction conflicts
Outside interruptible future, transaction can become invalidated
implicitly.
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Yingxin Cheng [Thu, 22 May 2025 02:43:19 +0000 (10:43 +0800)]
crimson/os/seastore/cache: minor cleanups to prepare_record/complete_commit()
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Yingxin Cheng [Wed, 21 May 2025 06:21:10 +0000 (14:21 +0800)]
crimson/os/seastore: more accurate usages to is_pending() vs is_stable()
Generally, prefer is_pending() than !is_stable(), and
is_stable() than !is_pending().
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Yingxin Cheng [Wed, 21 May 2025 03:54:05 +0000 (11:54 +0800)]
crimson/os/seastore: more accurate usages to is_mutable() vs is_data_stable()
Generally, prefer is_mutable() than !is_data_stable(), and
is_data_stable() than !is_mutable().
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Yingxin Cheng [Wed, 21 May 2025 03:33:26 +0000 (11:33 +0800)]
crimson/os/seastore: distinguish between is_mutation_pending() and has_mutation()
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Yingxin Cheng [Wed, 21 May 2025 03:20:03 +0000 (11:20 +0800)]
crimson/os/seastore/../fixed_kv_btree: get_stable_for_key() is called when the node is pending
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Yingxin Cheng [Mon, 19 May 2025 07:01:18 +0000 (15:01 +0800)]
crimson/os/seastore: cleanup CachedExtent::prior_instance
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Yingxin Cheng [Fri, 25 Apr 2025 08:32:07 +0000 (16:32 +0800)]
crimson/os/seastore/cached_extent: drop the unused retired_at
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Yingxin Cheng [Fri, 25 Apr 2025 07:56:46 +0000 (15:56 +0800)]
crimson/os/seastore/cached_extent: merge is_clean() and is_dirty() as has_delta()
The original names were misleading because they don't correspond to
CLEAN and DIRTY states.
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Yingxin Cheng [Fri, 25 Apr 2025 06:47:16 +0000 (14:47 +0800)]
crimson/os/seastore/cached_extent: drop CLEAN_PENDING state
It is only used to prevent printing details when the buffer is still
loading, and is a special case of CLEAN.
It doesn't worth a dedicated state that complicates state-related
decisions.
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Kefu Chai [Wed, 4 Jun 2025 01:57:44 +0000 (09:57 +0800)]
Merge pull request #59565 from Nuckal777/mon-increase-dns-buf-size
mon: increase dns buffer size
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
Yingxin Cheng [Wed, 4 Jun 2025 01:56:23 +0000 (09:56 +0800)]
Merge pull request #63218 from xxhdx1985126/wip-seastore-fix-retire-absent
crimson/os/seastore/transaction_manager: Cache::retire_absent_extent_addr should be called immediately after TransactionManager::get_extent_if_linked if necessary
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Yingxin Cheng [Wed, 4 Jun 2025 01:43:42 +0000 (09:43 +0800)]
Merge pull request #63520 from xxhdx1985126/wip-71448
crimson/os/seastore/omap_manager: only mutate the parent when merge/balance can proceed
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Jesse Williamson [Wed, 4 Jun 2025 00:39:35 +0000 (17:39 -0700)]
Merge pull request #63676 from irq0/wip/fix-breakpad-fedora41
Fix Breakpad Builds on Newer Distros
Zac Dover [Tue, 3 Jun 2025 20:51:36 +0000 (06:51 +1000)]
Merge pull request #63622 from zdover23/wip-doc-2025-06-02-mgr-dashboard_plugins-63367-followup
doc/mgr/dashboard_plugins: edit feature_toggles.inc.rst
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Thomas Lamprecht [Tue, 3 Jun 2025 20:32:05 +0000 (22:32 +0200)]
debian: radosgw: add media-types packages as alternative for mime-support
Back in 2020 the '/etc/mime.types' file was split out into it's own
leaner 'media-types' Debian package [0], the previous 'mime-support'
was kept as transitional package to handle upgrades, but it did its
job and isn't included in Debian Trixie repos anymore.
So accept both, the new 'media-types' package or the legacy
'mime-support' one as valid dependency for radosgw, this ensures one
can install radosgw on newer Debian based releases while keeping it
also working for older ones.
[0]: https://salsa.debian.org/debian/media-types/-/commit/
4d6ff19de5720196b40cf65f1173bd9333dfecf9
Fixes: https://tracker.ceph.com/issues/71545
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Zac Dover [Tue, 3 Jun 2025 20:30:28 +0000 (06:30 +1000)]
Merge pull request #62893 from zdover23/wip-doc-2025-04-21-radosgw-metrics
doc/radosgw: edit sentence in metrics.rst
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Zac Dover [Tue, 3 Jun 2025 20:03:47 +0000 (06:03 +1000)]
Merge pull request #63614 from zdover23/wip-doc-2025-05-30-rados-ops-cache-tiering-63465-followup
doc/rados/operations: edit cache-tiering.rst
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Zac Dover [Tue, 3 Jun 2025 19:56:15 +0000 (05:56 +1000)]
Merge pull request #63476 from zdover23/wip-doc-2025-05-26-mgr-telemetry-62782-followup
doc/mgr: edit telemetry.rst
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Zac Dover [Tue, 3 Jun 2025 19:42:02 +0000 (05:42 +1000)]
Merge pull request #63195 from zdover23/wip-doc-2025-05-09-mgr-cli-api-62782-followup
doc/mgr: edit cli_api.rst
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Zac Dover [Tue, 3 Jun 2025 19:23:53 +0000 (05:23 +1000)]
doc/start: edit documenting-ceph.rst
Edit the section "Build the Source (First Time)" in
doc/start/documenting-ceph.rst.
- remove references to RHEL7 (it's old)
- improve sentences (they were first-draft-like)
- improve RST formatting
Signed-off-by: Zac Dover <zac.dover@proton.me>
Zac Dover [Tue, 3 Jun 2025 18:52:13 +0000 (04:52 +1000)]
Merge pull request #63628 from zdover23/wip-doc-2025-06-02-rados-ops-balancer-63530-followup
doc/rados: edit balancer.rst
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>