]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
8 days agoqa/standalone/scrub: fix "scrubbed in 0ms" in osd-scrub-test.sh 64429/head
Ronen Friedman [Thu, 10 Jul 2025 07:57:37 +0000 (02:57 -0500)]
qa/standalone/scrub: fix "scrubbed in 0ms" in osd-scrub-test.sh

The specific test looks for a 'last scrub duration' higher than
0 as a sign that the scrub actually ran.  Previous code fixes
guaranteed that even a scrub duration as low as 1ms would be
reported as "1" (1s).  However, none of the 15 objects created
in this test were designated for the tested PG, which remained
empty.  As a result, the scrub duration was reported as "0".

The fix is to create a large enough number of objects so that
at least one of them is mapped to the tested PG.

Fixes: https://tracker.ceph.com/issues/71801
Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
9 days agoMerge pull request #64254 from synarete/ss-mgr-smb-pershare-profile
Shachar Sharon [Wed, 9 Jul 2025 12:23:53 +0000 (15:23 +0300)]
Merge pull request #64254 from synarete/ss-mgr-smb-pershare-profile

mgr/smb: Enable per-share profile counters

9 days agoMerge pull request #64380 from rhcs-dashboard/rm-requirements-extra
Nizamudeen A [Wed, 9 Jul 2025 04:33:42 +0000 (10:03 +0530)]
Merge pull request #64380 from rhcs-dashboard/rm-requirements-extra

mgr/dashboard: rm requirements-extra file

9 days agoMerge pull request #64041 from tchaikov/wip-buffer-raw-no-aligned_storage
Kefu Chai [Wed, 9 Jul 2025 04:16:30 +0000 (12:16 +0800)]
Merge pull request #64041 from tchaikov/wip-buffer-raw-no-aligned_storage

include/buffer_raw: avoid using std::aligned_storage_t

Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>
9 days agoMerge pull request #63935 from tchaikov/wip-bluestore-exclude-unencoded-field-in...
Kefu Chai [Wed, 9 Jul 2025 02:42:29 +0000 (10:42 +0800)]
Merge pull request #63935 from tchaikov/wip-bluestore-exclude-unencoded-field-in-dump

os/bluestore: use default value for non-decoded field in test instances

Reviewed-by: Igor Fedotov <igor.fedotov@croit.io>
9 days agoMerge pull request #63780 from zdover23/wip-doc-2025-06-06-mgr-telemetry-63735-followup-2
Zac Dover [Wed, 9 Jul 2025 01:57:09 +0000 (11:57 +1000)]
Merge pull request #63780 from zdover23/wip-doc-2025-06-06-mgr-telemetry-63735-followup-2

doc/mgr: edit telemetry.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
9 days agoMerge pull request #64334 from zdover23/wip-doc-2025-07-03-tr71943-man-8-rados-cloned...
Zac Dover [Wed, 9 Jul 2025 01:10:00 +0000 (11:10 +1000)]
Merge pull request #64334 from zdover23/wip-doc-2025-07-03-tr71943-man-8-rados-clonedata-removal

doc/rados: remove clonedata command

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
9 days agoMerge pull request #64378 from connorfawcett/consistency-build-fix
Dan Mick [Tue, 8 Jul 2025 18:36:35 +0000 (11:36 -0700)]
Merge pull request #64378 from connorfawcett/consistency-build-fix

erasure-code: Add ceph_ec_consistency_checker into ceph_test_package

9 days agoMerge pull request #64263 from abitdrag/build_scrpt_opt
Ilya Dryomov [Tue, 8 Jul 2025 18:14:17 +0000 (20:14 +0200)]
Merge pull request #64263 from abitdrag/build_scrpt_opt

qa/workunits/rbd: remove build dependency on ceph-mds and dashboard

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
9 days agoMerge pull request #64004 from shraddhaag/wip-shraddhaag-availability-clean-up
Shraddha Agrawal [Tue, 8 Jul 2025 16:00:52 +0000 (21:30 +0530)]
Merge pull request #64004 from shraddhaag/wip-shraddhaag-availability-clean-up

mon/MgrStatMonitor.cc: cleanup pool_availability

10 days agoMerge pull request #64135 from NitzanMordhai/wip-nitzan-slow-ops-preprocess-osd-alive
SrinivasaBharathKanta [Tue, 8 Jul 2025 14:06:37 +0000 (19:36 +0530)]
Merge pull request #64135 from NitzanMordhai/wip-nitzan-slow-ops-preprocess-osd-alive

mon/OSDMonitor: call no_reply() on ignored osd alive

10 days agoMerge pull request #63987 from adamemerson/wip-70916
SrinivasaBharathKanta [Tue, 8 Jul 2025 14:06:11 +0000 (19:36 +0530)]
Merge pull request #63987 from adamemerson/wip-70916

neorados: Increase timeouts in watch/notify poll tests

10 days agoerasure-code: Add ceph_ec_consistency_checker into ceph_test_package 64378/head
Connor Fawcett [Tue, 8 Jul 2025 07:29:58 +0000 (08:29 +0100)]
erasure-code: Add ceph_ec_consistency_checker into ceph_test_package

Signed-off-by: Connor Fawcett <connorfa@uk.ibm.com>
10 days agoMerge pull request #63562 from phlogistonjohn/jjm-smb-rados-chunk-size
Adam King [Tue, 8 Jul 2025 13:00:51 +0000 (09:00 -0400)]
Merge pull request #63562 from phlogistonjohn/jjm-smb-rados-chunk-size

mgr/smb: remove restriction on 1MiB smb config objects in rados

Reviewed-by: Adam King <adking@redhat.com>
10 days agoMerge pull request #62112 from ljflores/wip-tracker-70307
SrinivasaBharathKanta [Tue, 8 Jul 2025 12:55:27 +0000 (18:25 +0530)]
Merge pull request #62112 from ljflores/wip-tracker-70307

qa/tasks: generalize stuck pg ignorelist entry

10 days agomgr/dashboard: rm requirements-extra file 64380/head
Nizamudeen A [Tue, 8 Jul 2025 09:11:50 +0000 (14:41 +0530)]
mgr/dashboard: rm requirements-extra file

which brings in python3-saml and is not needed anymore after https://github.com/ceph/ceph/pull/62239

Fixes: https://tracker.ceph.com/issues/70937
Signed-off-by: Nizamudeen A <nia@redhat.com>
10 days agoqa/workunits/rbd: remove build dependency on dashboard 64263/head
Miki Patel [Tue, 8 Jul 2025 08:12:24 +0000 (13:42 +0530)]
qa/workunits/rbd: remove build dependency on dashboard

Removed build dependency on dashboard for unit test rbd_mirror

Signed-off-by: Miki Patel <miki.patel132@gmail.com>
10 days agoMerge pull request #64370 from Matan-B/wip-matanb-crimson-install-task
Matan Breizman [Tue, 8 Jul 2025 07:39:01 +0000 (10:39 +0300)]
Merge pull request #64370 from Matan-B/wip-matanb-crimson-install-task

qa/suites/crimson-rados/singleton: add install task

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: chunmei liu <chunmei.liu@ibm.com>
Reviewed-by: Aishwarya Mathuria <amathuri@redhat.com>
10 days agoMerge pull request #64069 from phlogistonjohn/jjm-bwc-test-tweak
Dan Mick [Mon, 7 Jul 2025 16:38:10 +0000 (09:38 -0700)]
Merge pull request #64069 from phlogistonjohn/jjm-bwc-test-tweak

test: improvments for running make check test suite in containers

10 days agoMerge pull request #63986 from yuvalif/wip-yuval-71390
Yuval Lifshitz [Mon, 7 Jul 2025 15:40:29 +0000 (18:40 +0300)]
Merge pull request #63986 from yuvalif/wip-yuval-71390

rgw/notifications: replace timer waiter with async waiter

10 days agoMerge pull request #64203 from Matan-B/wip-matanb-crimson-smp-coroutines
Matan Breizman [Mon, 7 Jul 2025 15:31:32 +0000 (18:31 +0300)]
Merge pull request #64203 from Matan-B/wip-matanb-crimson-smp-coroutines

crimson/common/smp_helpers: fix missing include

Reviewed-by: Zhang Song <zhangsong02@qianxin.com>
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
10 days agoMerge pull request #63909 from yuvalif/wip-yuval-71638
Yuval Lifshitz [Mon, 7 Jul 2025 15:28:13 +0000 (18:28 +0300)]
Merge pull request #63909 from yuvalif/wip-yuval-71638

rgw/logging: fix canonical names

11 days agoMerge pull request #62713 from soumyakoduri/wip-skoduri-restore-glacier
Soumya Koduri [Mon, 7 Jul 2025 15:17:26 +0000 (20:47 +0530)]
Merge pull request #62713 from soumyakoduri/wip-skoduri-restore-glacier

rgw/cloud-restore [PART2] : Add Restore support from Glacier/Tape cloud endpoints

Reviewed-by: Adam Emerson <aemerson@redhat.com>
Reviewed-by: Jiffin Tony Thottan <thottanjiffin@gmail.com>
Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>
Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
11 days agoMerge pull request #64017 from samarahu/samarahu-d4n-test-update
Casey Bodley [Mon, 7 Jul 2025 14:42:23 +0000 (10:42 -0400)]
Merge pull request #64017 from samarahu/samarahu-d4n-test-update

test/d4n: Change D4N filter test cleaning interval values to ints

Reviewed-by: Pritha Srivastava <prsrivas@redhat.com>
11 days agoqa/suites/crimson-rados/singleton: add install task 64370/head
Matan Breizman [Mon, 7 Jul 2025 12:10:45 +0000 (12:10 +0000)]
qa/suites/crimson-rados/singleton: add install task

This should fix the chmod 777 /var/log/ceph failures.

We were missing the install task which resulted in no /var/log/ceph:
```
2025-07-07T08:55:44.586 INFO:teuthology.run_tasks:Running task ceph...
2025-07-07T08:55:44.679 INFO:tasks.ceph:Making ceph log dir writeable by
non-root...
2025-07-07T08:55:44.679 DEBUG:teuthology.orchestra.run.smithi144:> sudo
chmod 777 /var/log/ceph
2025-07-07T08:55:44.711
INFO:teuthology.orchestra.run.smithi144.stderr:chmod: cannot access
'/var/log/ceph': No such file or directory
```

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
11 days agoMerge pull request #64275 from xxhdx1985126/wip-crimson-backedn-namespace
Matan Breizman [Mon, 7 Jul 2025 11:43:47 +0000 (14:43 +0300)]
Merge pull request #64275 from xxhdx1985126/wip-crimson-backedn-namespace

crimson/osd: put PGBackend/RecoveryBackend/PGRecovery and other related classes into the crimson::osd  namespace

Reviewed-by: Xuehan Xu <xuxuehan@qianxin.com>
11 days agoMerge pull request #64262 from Matan-B/wip-matanb-crimson-abort-msg
Matan Breizman [Mon, 7 Jul 2025 11:43:03 +0000 (14:43 +0300)]
Merge pull request #64262 from Matan-B/wip-matanb-crimson-abort-msg

crimson: switch to ceph_abort_msg

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
11 days agoMerge pull request #64246 from tchaikov/wip-cmake-drop-with_seastar
Matan Breizman [Mon, 7 Jul 2025 11:42:30 +0000 (14:42 +0300)]
Merge pull request #64246 from tchaikov/wip-cmake-drop-with_seastar

cmake: replace WITH_SEASTAR with WITH_CRIMSON

Reviewed-by: Matan Breizman <mbreizma@redhat.com>
11 days agoMerge pull request #63817 from mohit84/objectstore_type
Matan Breizman [Mon, 7 Jul 2025 11:38:53 +0000 (14:38 +0300)]
Merge pull request #63817 from mohit84/objectstore_type

crimson: Use osd_objectstore instead of using crimson_osd_objectstore

Reviewed-by: Matan Breizman <mbreizma@redhat.com>
11 days agoMerge pull request #64067 from VallariAg/wip-nvmeof-keepalive-alert
Vallari Agrawal [Mon, 7 Jul 2025 11:36:33 +0000 (17:06 +0530)]
Merge pull request #64067 from VallariAg/wip-nvmeof-keepalive-alert

monitoring: Add alert NVMeoFHostKeepAliveTimeout

11 days agoMerge pull request #62170 from connorfawcett/wip-online-consistency-checker-0703
Connor Fawcett [Mon, 7 Jul 2025 10:32:05 +0000 (11:32 +0100)]
Merge pull request #62170 from connorfawcett/wip-online-consistency-checker-0703

erasure-code: Add a new utility which checks the consistency of objects within an EC pool

11 days agoMerge pull request #64110 from yuvalif/wip-yuval-71402
Yuval Lifshitz [Mon, 7 Jul 2025 08:18:37 +0000 (11:18 +0300)]
Merge pull request #64110 from yuvalif/wip-yuval-71402

rgw/notifications: add http request timeout and max inflight

11 days agoMerge pull request #64328 from yuvalif/wip-yuval-71945
Yuval Lifshitz [Mon, 7 Jul 2025 07:52:21 +0000 (10:52 +0300)]
Merge pull request #64328 from yuvalif/wip-yuval-71945

doc/rgw/logging: fix journal record format

11 days agomgr/smb: Enable per-share profile counters 64254/head
Shachar Sharon [Thu, 26 Jun 2025 06:43:01 +0000 (09:43 +0300)]
mgr/smb: Enable per-share profile counters

Samba's commit 9f8d272 ("vfs_ceph_new: use per-share profile macros")
enables per-share profile counters for VFS ceph bridge. Enable those by
default for each smb-ceph share.

Signed-off-by: Shachar Sharon <ssharon@redhat.com>
11 days agoMerge pull request #63144 from liu-chunmei/omap_noexist
Matan Breizman [Mon, 7 Jul 2025 06:31:24 +0000 (09:31 +0300)]
Merge pull request #63144 from liu-chunmei/omap_noexist

crimson/osd/pg_backend: needn't check if os.exist

Reviewed-by: Matan Breizman <mbreizma@redhat.com>
11 days agoMerge pull request #64061 from rhcs-dashboard/local-storage-class
naman munet [Mon, 7 Jul 2025 05:53:07 +0000 (11:23 +0530)]
Merge pull request #64061 from rhcs-dashboard/local-storage-class

mgr/dashboard: Local Storage Class - create and list

12 days agocrimson/CMakeLists: simplify crimson-common deps 64203/head
Matan Breizman [Sun, 8 Jun 2025 10:20:25 +0000 (10:20 +0000)]
crimson/CMakeLists: simplify crimson-common deps

instead of appending conditional dependencies to crimson-common with
crimson_common_deps and crimson_common_public_deps, use
target_link_libraries directly.

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
12 days agoMerge pull request #63378 from Matan-B/wip-matanb-readme-build-types
Matan Breizman [Sun, 6 Jul 2025 13:16:54 +0000 (16:16 +0300)]
Merge pull request #63378 from Matan-B/wip-matanb-readme-build-types

README: add Build Types section

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Reviewed-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
12 days agodoc/README: add Build Types section 63378/head
Matan Breizman [Tue, 20 May 2025 09:12:18 +0000 (09:12 +0000)]
doc/README: add Build Types section

Originated from: https://tracker.ceph.com/issues/71360

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
13 days agoAdds a new command-line utility which can check the consistency of objects within... 62170/head
Connor Fawcett [Tue, 24 Jun 2025 11:45:06 +0000 (12:45 +0100)]
Adds a new command-line utility which can check the consistency of objects within an erasure coded pool.
A new test-only inject tells the EC backend to return both data and parity shards to the client so that they can
be checked for consistency by the new tool.

Supports both optimized and unoptimized EC pools.

Signed-off-by: Connor Fawcett <connorfa@uk.ibm.com>
2 weeks agorgw/cloud-restore: Update doc with new options added 62713/head
Soumya Koduri [Fri, 4 Jul 2025 07:20:53 +0000 (12:50 +0530)]
rgw/cloud-restore: Update doc with new options added

Signed-off-by: Soumya Koduri <skoduri@redhat.com>
2 weeks agorgw/restore: Update to neorados FIFO routines
Soumya Koduri [Fri, 6 Jun 2025 20:12:17 +0000 (01:42 +0530)]
rgw/restore: Update to neorados FIFO routines

Use new neorados/FIFO routines to store restore state.

Note: Old librados ioctx is also still retained as it is needed
by RestoreRadosSerializer.

Signed-off-by: Soumya Koduri <skoduri@redhat.com>
2 weeks agorgw/restore: Use strtoull to read size till 2^64
Soumya Koduri [Fri, 23 May 2025 21:39:50 +0000 (03:09 +0530)]
rgw/restore: Use strtoull to read size till 2^64

Reviewed-by: Adam Emerson <aemerson@redhat.com>
Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
2 weeks agorgw/cloud-restore: Fixing issues with initializing and resetting FIFO
Soumya Koduri [Fri, 23 May 2025 21:37:58 +0000 (03:07 +0530)]
rgw/cloud-restore: Fixing issues with initializing and resetting FIFO

In addition, added some more debug statements and done code cleanup

Reviewed-by: Adam Emerson <aemerson@redhat.com>
Reviewed-by: Jiffin Tony Thottan <thottanjiffin@gmail.com>
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
2 weeks agorgw/cloud-restore: Handle failure with adding restore entry
Soumya Koduri [Fri, 23 May 2025 20:25:30 +0000 (01:55 +0530)]
rgw/cloud-restore: Handle failure with adding restore entry

In case adding restore entry to FIFO fails, reset the `restore_status`
of that object as "RestoreFailed" so that restore process can be
retried from the end S3 user.

Reviewed-by: Adam Emerson <aemerson@redhat.com>
Reviewed-by: Jiffin Tony Thottan <thottanjiffin@gmail.com>
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
2 weeks agorgw/cloud-restore: Support restoration of objects transitioned to Glacier/Tape endpoint
Soumya Koduri [Wed, 30 Apr 2025 20:36:21 +0000 (02:06 +0530)]
rgw/cloud-restore: Support restoration of objects transitioned to Glacier/Tape endpoint

Restoration of objects from certain cloud services (like Glacier/Tape) could
take significant amount of time (even days). Hence store the state of such restore requests
and periodically process them.

Brief summary of changes

* Refactored existing restore code to consolidate and move all restore processing into rgw_restore* file/class

* RGWRestore class is defined to manage the restoration of objects.

* Lastly, for SAL_RADOS, FIFO is used to store and read restore entries.

Currently, this PR handles storing state of restore requests sent to cloud-glacier tier-type which need async processing.
The changes are tested with AWS Glacier Flexible Retrieval with tier_type Expedited and Standard.

Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>
Reviewed-by: Adam Emerson <aemerson@redhat.com>
Reviewed-by: Jiffin Tony Thottan <thottanjiffin@gmail.com>
Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
2 weeks agomgr/dashboard: Local Storage Class - create and list 64061/head
Dnyaneshwari [Thu, 22 May 2025 07:08:25 +0000 (12:38 +0530)]
mgr/dashboard: Local Storage Class - create and list
Fixes: https://tracker.ceph.com/issues/71460
Signed-off-by: Dnyaneshwari Talwekar <dtalwekar@redhat.com>
2 weeks agoMerge pull request #64252 from xxhdx1985126/wip-seastore-lba-bottom-up-search
Yingxin Cheng [Fri, 4 Jul 2025 06:03:54 +0000 (14:03 +0800)]
Merge pull request #64252 from xxhdx1985126/wip-seastore-lba-bottom-up-search

crimson/os/seastore/btree: bottom-up search capability

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
2 weeks agoMerge pull request #64318 from xxhdx1985126/wip-seastore-omap-leaf-node-rewrite
Yingxin Cheng [Fri, 4 Jul 2025 06:01:55 +0000 (14:01 +0800)]
Merge pull request #64318 from xxhdx1985126/wip-seastore-omap-leaf-node-rewrite

crimson/os/seastore/omap_manager: fix OMapLeafNode rewrite type error

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
2 weeks agoMerge pull request #64109 from xxhdx1985126/wip-71794
Yingxin Cheng [Fri, 4 Jul 2025 03:21:55 +0000 (11:21 +0800)]
Merge pull request #64109 from xxhdx1985126/wip-71794

crimson/os/seastore/lba/btree_lba_manager: never downcast reserved ptrs

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
2 weeks agoMerge pull request #63779 from zdover23/wip-doc-2025-06-06-mgr-telemetry-63735-followup
Zac Dover [Thu, 3 Jul 2025 22:10:30 +0000 (08:10 +1000)]
Merge pull request #63779 from zdover23/wip-doc-2025-06-06-mgr-telemetry-63735-followup

doc/mgr: edit telemetry.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 weeks agoMerge pull request #61989 from rhcs-dashboard/edit-topic
afreen23 [Thu, 3 Jul 2025 19:00:58 +0000 (00:30 +0530)]
Merge pull request #61989 from rhcs-dashboard/edit-topic

mgr/dashboard: Add RGW CRUD topic in dashboard

Reviewed-by: Afreen Misbah <afreen@ibm.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Naman Munet <nmunet@redhat.com>
2 weeks agorgw/notifications: allow for graceful shutdown of notification manager 63986/head
Yuval Lifshitz [Tue, 1 Jul 2025 15:00:22 +0000 (15:00 +0000)]
rgw/notifications: allow for graceful shutdown of notification manager

* use short timers even for the longer timeouts
* allow graceful shutdown when stopping

Fixes: https://tracker.ceph.com/issues/71963
Signed-off-by: Yuval Lifshitz <ylifshit@ibm.com>
2 weeks agorgw/notifications: replace timer waiter with async waiter
Yuval Lifshitz [Tue, 17 Jun 2025 12:51:47 +0000 (12:51 +0000)]
rgw/notifications: replace timer waiter with async waiter

this should allow for proper shutdown of the queue handling
code of persistent notifications.

Fixes: https://tracker.ceph.com/issues/71963
Signed-off-by: Yuval Lifshitz <ylifshit@ibm.com>
2 weeks agoMerge pull request #61286 from Jayaprakash-ibm/discard_queue_overutilized
Jaya Prakash [Thu, 3 Jul 2025 14:07:28 +0000 (19:37 +0530)]
Merge pull request #61286 from Jayaprakash-ibm/discard_queue_overutilized

blk:Warning added for discard queue overflow

Reviewed-by: Adam Kupczyk <akupczyk@ibm.com>
2 weeks agoMerge pull request #44283 from mkogan1/wip-rgw-radosgw-admin-cert
Casey Bodley [Thu, 3 Jul 2025 14:04:26 +0000 (10:04 -0400)]
Merge pull request #44283 from mkogan1/wip-rgw-radosgw-admin-cert

rgw: allow specifying ssl certificate for radosgw-admin operations

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2 weeks agoMerge pull request #62949 from joscollin/wip-test-mirroring-fix
Jos Collin [Thu, 3 Jul 2025 13:22:05 +0000 (18:52 +0530)]
Merge pull request #62949 from joscollin/wip-test-mirroring-fix

qa: setup mount_b in test_mirroring.py

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Rishabh Dave <ridave@redhat.com>
2 weeks agodoc/mgr: edit telemetry.rst 63780/head
Zac Dover [Fri, 6 Jun 2025 05:02:31 +0000 (15:02 +1000)]
doc/mgr: edit telemetry.rst

Ask whether the data reported to the telemetry module includes IP
addresses, which might well be regarded as sensitive data.

Signed-off-by: Zac Dover <zac.dover@proton.me>
2 weeks agoMerge pull request #64319 from zdover23/wip-doc-2025-07-03-tr58092-radosgw-config-ref
Zac Dover [Thu, 3 Jul 2025 13:02:58 +0000 (23:02 +1000)]
Merge pull request #64319 from zdover23/wip-doc-2025-07-03-tr58092-radosgw-config-ref

doc/radosgw: add rgw_enable_lc_threads & rgw_enable_gc_threads

Reviewed-by: Casey Bodley <cbodely@redhat.com>
2 weeks agodoc/rados: remove clonedata command 64334/head
Zac Dover [Thu, 3 Jul 2025 12:32:48 +0000 (22:32 +1000)]
doc/rados: remove clonedata command

Remove the "clonedata" command from the rados manpage.

The "clonedata" command was removed in
https://github.com/ceph/ceph/pull/13008.

Fixes: https://tracker.ceph.com/issues/71943
Signed-off-by: Zac Dover <zac.dover@proton.me>
2 weeks agoMerge pull request #62842 from joscollin/wip-B68001-B68446
Jos Collin [Thu, 3 Jul 2025 12:02:57 +0000 (17:32 +0530)]
Merge pull request #62842 from joscollin/wip-B68001-B68446

qa: fix multi-fs tests in test_mds_metrics.py

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Neeraj Pratap Singh <neesingh@redhat.com>
2 weeks agodoc/rgw/logging: fix journal record format 64328/head
Yuval Lifshitz [Thu, 3 Jul 2025 10:24:30 +0000 (10:24 +0000)]
doc/rgw/logging: fix journal record format

Fixes: https://tracker.ceph.com/issues/71945
Signed-off-by: Yuval Lifshitz <ylifshit@ibm.com>
2 weeks agomon/MgrStatMonitor.cc: cleanup handle_conf_change 64004/head
Shraddha Agrawal [Thu, 26 Jun 2025 12:27:45 +0000 (17:57 +0530)]
mon/MgrStatMonitor.cc: cleanup handle_conf_change

Prior to this change, we were using a flag value,
`reset_availability_last_uptime_downtime_val` to record the
timestamp to which the last_uptime and last_downtime should be
updated to. This was originally done so to avoid the values
being overwritten by a paxos update.

Now, instead of using an intermediate value, we are immediately
clearing the last_uptime and last_downtime values in
pending_pool_availability object. Since we are updating the values
in the pending object, we will not lost this information due to
an incoming paxos update.

Fixes: https://tracker.ceph.com/issues/71857
Signed-off-by: Shraddha Agrawal <shraddhaag@ibm.com>
2 weeks agoMerge pull request #64245 from leonidc/delete_gw_fix
leonidc [Thu, 3 Jul 2025 09:32:31 +0000 (12:32 +0300)]
Merge pull request #64245 from leonidc/delete_gw_fix

nvmeofgw:

2 weeks agorgw/logging: verify http method exists 63909/head
Yuval Lifshitz [Wed, 2 Jul 2025 14:28:27 +0000 (14:28 +0000)]
rgw/logging: verify http method exists

Signed-off-by: Yuval Lifshitz <ylifshit@ibm.com>
2 weeks agoCMakeLists: Use target_compile_options for seastar
Matan Breizman [Mon, 30 Jun 2025 09:11:03 +0000 (09:11 +0000)]
CMakeLists: Use target_compile_options for seastar

Now that target_compile_options is used to set no-non-virtual-dtor,
Move all the other CXX_FLAGS to CMake's compile_options.

Added status message of the flags set now that they are no longer stored
in a global variable and are as easily accessible.

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
2 weeks agoMinor cleanup to ensure make check passes 61286/head
Jaya Prakash [Thu, 3 Jul 2025 07:51:46 +0000 (07:51 +0000)]
Minor cleanup to ensure make check passes

Signed-off-by: Jaya Prakash <jayaprakash@ibm.com>
2 weeks agocrimson/os/alienstore/CMakeLists: Cleanup alien::cflags interface
Matan Breizman [Mon, 9 Jun 2025 07:58:29 +0000 (07:58 +0000)]
crimson/os/alienstore/CMakeLists: Cleanup alien::cflags interface

alienstore FTBFS [1] due to virtual-dtor warning when compiling seastar [2].
Instead of using alien::cflags which define INTERFACE_COMPILE_OPTIONS of
-Wno-non-virtual-dtor - Let's directly add this compile option to
tagets using seastar.

Crimson non-alien targets solve that with crimson::cflags which
defines the relevant compile flag. However, we don't reuse it here since
it also carries WITH_CRIMSON.

As both crimson::cflags and crimson-alienstore which are using seastar
have to set no-non-virtual-dtor - The compile option moved to the common
cmake file instead of setting it in both targets.

[1]
```
crimson/os/alienstore/alien_log.cc:21:28:   required from here
seastar/include/seastar/core/future.hh:666:7:
warning: ‘class seastar::continuation_base<void>’ has virtual functions
and accessible non-virtual destructor [-Wnon-virtual-dtor]
```

[2] See 36963dd7ccd50eff2f8b91d97ffb66295a7a6292

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
2 weeks agocrimson/common/smp_helpers: fix missing include
Matan Breizman [Thu, 26 Jun 2025 08:04:46 +0000 (11:04 +0300)]
crimson/common/smp_helpers: fix missing include

With 550b2b8ade7e10078ab9610442d039b65cce6a2b introducing coroutines in
smp_helpers header, GCC 15 FTBFS with:
```
FAILED: src/crimson/CMakeFiles/crimson.dir/net/ProtocolV2.cc.o
In file included from /home/zhscn/project/ceph/src/crimson/net/io_handler.h:11,
                 from /home/zhscn/project/ceph/src/crimson/net/ProtocolV2.h:9,
                 from /home/zhscn/project/ceph/src/crimson/net/ProtocolV2.cc:4:
/home/zhscn/project/ceph/src/crimson/common/smp_helpers.h: In function ‘decltype (seastar::futurize_invoke(f)) crimson::invoke_on_all_seq(F)’:
/home/zhscn/project/ceph/src/crimson/common/smp_helpers.h:64:7: error: coroutines require a traits template; cannot find ‘std::coroutine_traits’ [-Wtemplate-body]
   64 |       co_await crimson::submit_to(core, [&f] { return seastar::futurize_invoke(f);});
      |       ^~~~~~~~
/home/zhscn/project/ceph/src/crimson/common/smp_helpers.h:64:7: note: perhaps ‘#include <coroutine>’ is missing
```

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
2 weeks agomon: Integrate discard queue overflow into pg health warnings
Jaya Prakash [Thu, 3 Jul 2025 07:15:52 +0000 (07:15 +0000)]
mon: Integrate discard queue overflow into pg health warnings

Added a health warning mechanism to monitor the discard queue for potential overload
Emits a warning if the accumulated discarded bytes in the queue exceed the configured threshold
Introduced a debugging tool to simulate slow discard operations by adding a configurable delay

Fixes : https://tracker.ceph.com/issues/69082

Signed-off-by: Jaya Prakash <jayaprakash@ibm.com>
2 weeks agocommon/options: Added bdev_discard_max_bytes and bdev_debug_discard_sleep options
Jaya Prakash [Thu, 3 Jul 2025 07:09:11 +0000 (07:09 +0000)]
common/options: Added bdev_discard_max_bytes and bdev_debug_discard_sleep options

Added a health warning mechanism to monitor the discard queue for potential overload
Emits a warning if the accumulated discarded bytes in the queue exceed the configured threshold
Introduced a debugging tool to simulate slow discard operations by adding a configurable delay

Fixes : https://tracker.ceph.com/issues/69082

Signed-off-by: Jaya Prakash <jayaprakash@ibm.com>
2 weeks agoblk:Warning added for discard queue overflow
Jaya Prakash [Thu, 9 Jan 2025 16:14:05 +0000 (21:44 +0530)]
blk:Warning added for discard queue overflow

Added a health warning mechanism to monitor the discard queue for potential overload
Emits a warning if the accumulated discarded bytes in the queue exceed the configured threshold
Introduced a debugging tool to simulate slow discard operations by adding a configurable delay

Fixes : https://tracker.ceph.com/issues/69082

Signed-off-by: Jaya Prakash <jayaprakash@ibm.com>
2 weeks agoMerge pull request #64306 from zdover23/wip-doc-2025-07-02-tr23594-rados-ops-user...
Zac Dover [Thu, 3 Jul 2025 06:52:57 +0000 (16:52 +1000)]
Merge pull request #64306 from zdover23/wip-doc-2025-07-02-tr23594-rados-ops-user-management

doc/rados/ops: add caps restore command

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 weeks agodoc/radosgw: add rgw_enable_lc_threads & rgw_enable_gc_threads 64319/head
Zac Dover [Thu, 3 Jul 2025 06:45:31 +0000 (16:45 +1000)]
doc/radosgw: add rgw_enable_lc_threads & rgw_enable_gc_threads

Add rgw_enable_lc_threads and rgw_enable_gc_threads to
doc/radosgw/config-ref.rst.

Fixes: https://tracker.ceph.com/issues/58092
Signed-off-by: Zac Dover <zac.dover@proton.me>
2 weeks agocrimson/os/seastore/omap_manager: fix OMapLeafNode rewrite type error 64318/head
Xuehan Xu [Thu, 3 Jul 2025 04:38:09 +0000 (12:38 +0800)]
crimson/os/seastore/omap_manager: fix OMapLeafNode rewrite type error

Fixes: https://tracker.ceph.com/issues/71939
Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
2 weeks agoMerge pull request #62943 from rhcs-dashboard/tieiring-allow-read
naman munet [Thu, 3 Jul 2025 06:18:41 +0000 (11:48 +0530)]
Merge pull request #62943 from rhcs-dashboard/tieiring-allow-read

mgr/dashboard: Tieiring - allow read through

2 weeks agoMerge pull request #64238 from tchaikov/wip-test-ec-fix-stack-use-after-scope
Kefu Chai [Thu, 3 Jul 2025 04:41:33 +0000 (12:41 +0800)]
Merge pull request #64238 from tchaikov/wip-test-ec-fix-stack-use-after-scope

test/erasure-code: fix stack-use-after-scope by replacing initializer_list with array

Reviewed-by: Adam Emerson <aemerson@redhat.com>
2 weeks agoMerge pull request #64250 from tchaikov/wip-cmake-boost-1.88
Kefu Chai [Thu, 3 Jul 2025 04:29:06 +0000 (12:29 +0800)]
Merge pull request #64250 from tchaikov/wip-cmake-boost-1.88

cmake/modules/FindBoost: add support for Boost 1.88.0

Reviewed-by: Adam Emerson <aemerson@redhat.com>
2 weeks agoMerge pull request #64228 from phlogistonjohn/jjm-lab-extras
David Galloway [Thu, 3 Jul 2025 01:36:27 +0000 (21:36 -0400)]
Merge pull request #64228 from phlogistonjohn/jjm-lab-extras

install-deps.sh: enable lab extras on el10 builders

2 weeks agoMerge pull request #63359 from zdover23/wip-doc-2025-05-20-restore-63351-document_HTT...
Zac Dover [Thu, 3 Jul 2025 00:43:18 +0000 (10:43 +1000)]
Merge pull request #63359 from zdover23/wip-doc-2025-05-20-restore-63351-document_HTTP_X_AMZ_DELETE_IF_UNMODIFIED_SINCE

doc/radosgw/s3: Document delete-if-unmodified-since

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 weeks agodoc/radosgw/s3: Document delete-if-unmodified-since 63359/head
Anthony D'Atri [Mon, 19 May 2025 14:14:00 +0000 (10:14 -0400)]
doc/radosgw/s3: Document delete-if-unmodified-since

Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
(cherry picked from commit 3381041d190fd48cf9f6d53f679f1737028cccf4)

2 weeks agorgw/logging: fix/remove/add bucket logging op names
Yuval Lifshitz [Thu, 12 Jun 2025 12:21:07 +0000 (12:21 +0000)]
rgw/logging: fix/remove/add bucket logging op names

Fixes: https://tracker.ceph.com/issues/71638
Signed-off-by: Yuval Lifshitz <ylifshit@ibm.com>
2 weeks agorgw/logging: refactor canonical_name()
Yuval Lifshitz [Thu, 12 Jun 2025 10:05:03 +0000 (10:05 +0000)]
rgw/logging: refactor canonical_name()

function is moved up in the inheritance hierarchy
when possible

Signed-off-by: Yuval Lifshitz <ylifshit@ibm.com>
2 weeks agorgw/logging: fix canonical names
Yuval Lifshitz [Wed, 11 Jun 2025 14:16:31 +0000 (14:16 +0000)]
rgw/logging: fix canonical names

Fixes: https://tracker.ceph.com/issues/71638
Signed-off-by: Yuval Lifshitz <ylifshit@ibm.com>
2 weeks agodoc/rados/ops: add caps restore command 64306/head
Zac Dover [Wed, 2 Jul 2025 12:29:48 +0000 (22:29 +1000)]
doc/rados/ops: add caps restore command

Add a command that restores caps to client.admin after they have been
accidentally destroyed or removed.

Fixes: https://tracker.ceph.com/issues/23594
Signed-off-by: Zac Dover <zac.dover@proton.me>
2 weeks agoMerge pull request #64296 from Naveenaidu/wip-naveen-introduce-fix-config-ok-command...
Naveen Naidu [Wed, 2 Jul 2025 10:16:54 +0000 (15:46 +0530)]
Merge pull request #64296 from Naveenaidu/wip-naveen-introduce-fix-config-ok-command-logic

.github/workflows/scripts/config-diff-post-comment.js: fix config check ok logic

2 weeks agocrimson/os/seastore/btree: only compile debug-purposed methods in debug 64252/head
Xuehan Xu [Sun, 29 Jun 2025 09:38:37 +0000 (17:38 +0800)]
crimson/os/seastore/btree: only compile debug-purposed methods in debug
builds

Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
2 weeks agocrimson/os/seastore/fixed_kv_btree: remove unused constructors
Xuehan Xu [Fri, 6 Jun 2025 12:39:00 +0000 (20:39 +0800)]
crimson/os/seastore/fixed_kv_btree: remove unused constructors

Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
2 weeks agomgr/dashboard: Add RGW CRUD topic in dashboard 61989/head
pujaoshahu [Thu, 9 Jan 2025 05:14:43 +0000 (10:44 +0530)]
mgr/dashboard: Add RGW CRUD topic in dashboard

Fixes: https://tracker.ceph.com/issues/699654
Signed-off-by: pujaoshahu <pshahu@redhat.com>
2 weeks agocrimson: switch to ceph_abort_msg 64262/head
Matan Breizman [Mon, 30 Jun 2025 09:44:24 +0000 (09:44 +0000)]
crimson: switch to ceph_abort_msg

ceph_abort doesn't print a message. Use ceph_abort_msg instead.
Most of the instances are not printing useful information but some are:
  ceph_abort_msg("seastore device size setting is too small");

```
  ::ceph::__ceph_abort( __FILE__, __LINE__, __CEPH_ASSERT_FUNCTION, "abort() called")

  ::ceph::__ceph_abort( __FILE__, __LINE__, __CEPH_ASSERT_FUNCTION, msg)
```

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
2 weeks agoMerge pull request #64215 from Hezko/nvmeof-cli-migrate-prs
afreen23 [Wed, 2 Jul 2025 08:34:36 +0000 (14:04 +0530)]
Merge pull request #64215 from Hezko/nvmeof-cli-migrate-prs

mgr/dashboard: NVMeoF CLI migrate prs

Reviewed-by: Afreen Misbah <afreen@ibm.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
2 weeks agonvmeofgw: fixing GW delete issues 64245/head
Leonid Chernin [Tue, 24 Jun 2025 13:00:49 +0000 (16:00 +0300)]
nvmeofgw: fixing GW delete issues
1.fixing the issue when gw is deleted based on invalid subsystem info
2. in function track_deleting_gws: break from loop only if
  delete was really done
        3. fix published rebalance index - publish ana-group instead of
  index
        4. do not dump gw-id string after gw was removed

Fixes: https://tracker.ceph.com/issues/71896
Signed-off-by: Leonid Chernin <leonidc@il.ibm.com>
2 weeks agoMerge pull request #64260 from tchaikov/wip-osdc-iwyu
Kefu Chai [Wed, 2 Jul 2025 06:06:57 +0000 (14:06 +0800)]
Merge pull request #64260 from tchaikov/wip-osdc-iwyu

osdc: remove unused rados.h include from error_code.h

Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
2 weeks agoMerge pull request #64087 from NitzanMordhai/wip-nitzan-aio-pool-eio-flag-mutex-left
SrinivasaBharathKanta [Wed, 2 Jul 2025 05:30:48 +0000 (11:00 +0530)]
Merge pull request #64087 from NitzanMordhai/wip-nitzan-aio-pool-eio-flag-mutex-left

test/librados/aio_cxx: Fix potential mutex destruction failure on Pool EIOFlag

2 weeks ago.github/workflows/scripts/config-diff-post-comment.js: fix config check ok logic 64296/head
Naveen Naidu [Wed, 2 Jul 2025 04:52:02 +0000 (10:22 +0530)]
.github/workflows/scripts/config-diff-post-comment.js: fix config check ok logic

currently, whenever a "config diff tool output" comment is created it
also has the string `/config check ok` string in it. The next time the
test run it see's this text and assumes that the user has commented it.
We fix the logic to makes sure that we ignore such cases.

Signed-off-by: Naveen Naidu <naveennaidu479@gmail.com>
2 weeks agoMerge pull request #62239 from rhcs-dashboard/xmlsec-fail-main
Nizamudeen A [Wed, 2 Jul 2025 04:40:43 +0000 (10:10 +0530)]
Merge pull request #62239 from rhcs-dashboard/xmlsec-fail-main

mgr/dashboard: use system packages when running tox

2 weeks agoMerge pull request #63889 from shreya-subramanian/perf_counters_clean
Samuel Just [Wed, 2 Jul 2025 01:40:34 +0000 (18:40 -0700)]
Merge pull request #63889 from shreya-subramanian/perf_counters_clean

osd: Added perf counters for full and incremental maps

Reviewed-by: Samuel Just <sjust@redhat.com>
2 weeks agoMerge pull request #61535 from kinazarov1999/import-stdin-progress
Ilya Dryomov [Tue, 1 Jul 2025 18:48:09 +0000 (20:48 +0200)]
Merge pull request #61535 from kinazarov1999/import-stdin-progress

rbd: add --estimated-size option for import from stdin

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2 weeks agoMerge pull request #61468 from Nordix/fix-69610-sunnat 63818/head
Adam King [Tue, 1 Jul 2025 14:23:02 +0000 (10:23 -0400)]
Merge pull request #61468 from Nordix/fix-69610-sunnat

mgr/prometheus: Make prometheus TLS config work with Rook orchestrator

Reviewed-by: Redouane Kachach <rkachach@ibm.com>
2 weeks agoMerge pull request #64255 from bluikko/doc-config-ceph-conf-improvements-rados
Anthony D'Atri [Tue, 1 Jul 2025 13:24:18 +0000 (09:24 -0400)]
Merge pull request #64255 from bluikko/doc-config-ceph-conf-improvements-rados

doc/rados/configuration: Small improvements in ceph-conf.rst