]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/log
ceph.git
12 months agomgr/smb: move prune function to be a staging store method 64444/head
John Mulligan [Wed, 2 Jul 2025 18:25:32 +0000 (14:25 -0400)]
mgr/smb: move prune function to be a staging store method

The prune function was tightly linked to the staging store. Re-implement
it as more generic operation on the staging store.
Continue shrinking handler.py a bit and preparing to make it simpler to
add future SMBResource types.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
(cherry picked from commit 3633bfbb219834d5d2489c8955bac297d693cee0)

12 months agomgr/smb: add docstrings to a few staging.py functions
John Mulligan [Wed, 2 Jul 2025 18:19:19 +0000 (14:19 -0400)]
mgr/smb: add docstrings to a few staging.py functions

Signed-off-by: John Mulligan <jmulligan@redhat.com>
(cherry picked from commit ee6b29bb31193ccf021b4b06520e7e2abc3cfe5e)

12 months agomgr/smb: replace cross check if-block with singledispatch
John Mulligan [Wed, 2 Jul 2025 18:06:21 +0000 (14:06 -0400)]
mgr/smb: replace cross check if-block with singledispatch

The previous code relied on a cascading block of if-isintance statements
that was dense and somwehat error prone as I found out during an
experiment to add a new top level resource type. Refactor the cross
check function to use singledispatch:
  https://docs.python.org/3.9/library/functools.html#functools.singledispatch

Now instead of correctly adding check function(s) and updating the
if-block, only new check functions using the register decorator is
needed.

Note that making this checking more generic is difficult as each
different resource type really has different cross checking needs.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
(cherry picked from commit f0ffb26b80627931096d2e8283613a9310fbca9c)

12 months agomgr/smb: move functions from handler.py to staging.py
John Mulligan [Wed, 2 Jul 2025 17:44:39 +0000 (13:44 -0400)]
mgr/smb: move functions from handler.py to staging.py

Create a new file staging.py to reduce the size of handler.py and
organize this a bit more. The staging.py file will be responsible for
the special staging area store as well as functions that work directly
on the staging store like the cross-check of resources.

This change is nearly a straight more except for renaming some functions
from _foo to foo.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
(cherry picked from commit 978e92fb68a1717a2713017382bfb5fbe9a24e63)

12 months agomgr/smb: extract a cross_check_resource function from handler class
John Mulligan [Wed, 2 Jul 2025 17:30:14 +0000 (13:30 -0400)]
mgr/smb: extract a cross_check_resource function from handler class

Move the sequence of if-isinstance checks out of the class into a
function that can be called (and tested) on it's own. This prepares
for additional future refactoring of this area.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
(cherry picked from commit 5db0a0cc759fc321e7c1fe2c34ed0c91cab75fca)

12 months agomgr/smb: document ResourceEntry base class methods better
John Mulligan [Wed, 2 Jul 2025 17:10:26 +0000 (13:10 -0400)]
mgr/smb: document ResourceEntry base class methods better

Add docstrings to many previously undocumented methods.
Add a real exception instead of an assert when getting a real
resource object.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
(cherry picked from commit 51a098d9ee1f3f6b7ed68d35dc0903e6a53ea495)

12 months agomgr/smb: reorganize internal.py to use fewer if-isinstance blocks
John Mulligan [Tue, 1 Jul 2025 15:28:02 +0000 (11:28 -0400)]
mgr/smb: reorganize internal.py to use fewer if-isinstance blocks

While working on adding a new top-level resource type I realized that
this code can be a bit error prone and un-DRY. Use a single method for
mapping between resource classes and resource entry classes and refactor
the rest of the module around that idea.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
(cherry picked from commit c81a666fe071afb1ea8cc6adba20d09eb38cc9d6)

12 months agomgr/smb: add new ResourceKey protocol class
John Mulligan [Tue, 1 Jul 2025 21:15:10 +0000 (17:15 -0400)]
mgr/smb: add new ResourceKey protocol class

Add a new protocol class that can be used to uniquely identify a resource
within a given store namespace. The idea is to use this key class where
a resource can be ID'd by either one metadata field or by two allowing
more common interfaces and fewer special code paths.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
(cherry picked from commit d5fb7f8c2ba84ac9ecfc38365027f2c3a6531130)

12 months agoMerge pull request #63880 from Matan-B/wip-matanb-crimson-tentacle-63376
Matan Breizman [Thu, 10 Jul 2025 12:45:41 +0000 (15:45 +0300)]
Merge pull request #63880 from Matan-B/wip-matanb-crimson-tentacle-63376

tentacle: crimson/os/seastore/omap_manager: handle the cases in which omap nodes are rewritten before seen by users

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
12 months agoMerge pull request #64404 from rhcs-dashboard/wip-72036-tentacle
Nizamudeen A [Thu, 10 Jul 2025 09:33:17 +0000 (15:03 +0530)]
Merge pull request #64404 from rhcs-dashboard/wip-72036-tentacle

tentacle: mgr/dashboard: rm requirements-extra file

12 months agoMerge pull request #64413 from Matan-B/wip-matanb-crimson-tentacle-compalint-time
Matan Breizman [Thu, 10 Jul 2025 07:42:41 +0000 (10:42 +0300)]
Merge pull request #64413 from Matan-B/wip-matanb-crimson-tentacle-compalint-time

tentacle: qa/config/crimson_qa_overrides: increase complaint time

Reviewed-by: Samuel Just <sjust@redhat.com>
12 months agoMerge pull request #64178 from adk3798/tentacle-nvmeof-interval
Yuri Weinstein [Wed, 9 Jul 2025 21:18:12 +0000 (14:18 -0700)]
Merge pull request #64178 from adk3798/tentacle-nvmeof-interval

tentacle: mgr/cephadm/nvmeof: Allow setting NVMEoF gateway read notifications interval in the spec file

Reviewed-by: Adam King adking@redhat.com
12 months agoMerge pull request #64300 from aainscow/wip-71874-tentacle
Yuri Weinstein [Wed, 9 Jul 2025 21:16:34 +0000 (14:16 -0700)]
Merge pull request #64300 from aainscow/wip-71874-tentacle

tentacle: Fix _setattr() with rare memory alignments

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Laura Flores <lflores@redhat.com>
12 months agoqa/config/crimson_qa_overrides: increase complaint time 64413/head
Matan Breizman [Wed, 9 Jul 2025 15:22:38 +0000 (18:22 +0300)]
qa/config/crimson_qa_overrides: increase complaint time

The following is true only for tentacle:
We're unlikely to backport the fix of https://tracker.ceph.com/issues/69612
to tentacle.
The only 2 failures we see in tentacle runs are of the tracker above.
This commit doubles the complaint time in order to keep tentacle runs
fully green.
If decided to backport the fix for specific reasons, we could revert
this change.

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
12 months agoMerge pull request #64189 from Matan-B/wip-71823-tentacle
Matan Breizman [Wed, 9 Jul 2025 15:16:16 +0000 (18:16 +0300)]
Merge pull request #64189 from Matan-B/wip-71823-tentacle

tentacle: crimson/os/seastore/omap_manager: only mutate the parent when merge/balance can proceed

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
12 months agoMerge pull request #64187 from Matan-B/wip-71843-tentacle
Matan Breizman [Wed, 9 Jul 2025 15:11:40 +0000 (18:11 +0300)]
Merge pull request #64187 from Matan-B/wip-71843-tentacle

tentacle: crimson/osd: Admin Socket fixes

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
12 months agoMerge pull request #64407 from Matan-B/wip-72029-tentacle
Matan Breizman [Wed, 9 Jul 2025 15:10:58 +0000 (18:10 +0300)]
Merge pull request #64407 from Matan-B/wip-72029-tentacle

tentacle: qa/suites/crimson-rados/singleton: add install task

Reviewed-by: Aishwarya Mathuria <amathuri@redhat.com>
12 months agoMerge pull request #64367 from VallariAg/wip-71984-tentacle
afreen23 [Wed, 9 Jul 2025 12:56:28 +0000 (18:26 +0530)]
Merge pull request #64367 from VallariAg/wip-71984-tentacle

tentacle: monitoring: Add alert NVMeoFHostKeepAliveTimeout

Reviewed-by: Afreen Misbah <afreen@ibm.com>
12 months agoqa/suites/crimson-rados/singleton: add install task 64407/head
Matan Breizman [Mon, 7 Jul 2025 12:10:45 +0000 (12:10 +0000)]
qa/suites/crimson-rados/singleton: add install task

This should fix the chmod 777 /var/log/ceph failures.

We were missing the install task which resulted in no /var/log/ceph:
```
2025-07-07T08:55:44.586 INFO:teuthology.run_tasks:Running task ceph...
2025-07-07T08:55:44.679 INFO:tasks.ceph:Making ceph log dir writeable by
non-root...
2025-07-07T08:55:44.679 DEBUG:teuthology.orchestra.run.smithi144:> sudo
chmod 777 /var/log/ceph
2025-07-07T08:55:44.711
INFO:teuthology.orchestra.run.smithi144.stderr:chmod: cannot access
'/var/log/ceph': No such file or directory
```

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
(cherry picked from commit ecbc607d2e715ba05c113a4d9c9dd3f04c6e2b68)

12 months agomgr/dashboard: rm requirements-extra file 64404/head
Nizamudeen A [Tue, 8 Jul 2025 09:11:50 +0000 (14:41 +0530)]
mgr/dashboard: rm requirements-extra file

which brings in python3-saml and is not needed anymore after https://github.com/ceph/ceph/pull/62239

Fixes: https://tracker.ceph.com/issues/70937
Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit 70642943be767b47fddb40e470dc9ca813fc4307)

12 months agoMerge pull request #64165 from zdover23/wip-doc-2025-06-25-backport-64160-to-tentacle
Anthony D'Atri [Wed, 9 Jul 2025 04:23:38 +0000 (00:23 -0400)]
Merge pull request #64165 from zdover23/wip-doc-2025-06-25-backport-64160-to-tentacle

tentacle: doc/dev/config: Document how to use :confval: directive for config op…

12 months agoMerge pull request #64395 from zdover23/wip-doc-2025-07-09-backport-64161-to-tentacle
Anthony D'Atri [Wed, 9 Jul 2025 04:04:04 +0000 (00:04 -0400)]
Merge pull request #64395 from zdover23/wip-doc-2025-07-09-backport-64161-to-tentacle

tentacle: doc: Document ceph-mgr module configuration options

12 months agodoc: Document ceph-mgr module configuration options 64395/head
Kefu Chai [Wed, 25 Jun 2025 02:26:58 +0000 (10:26 +0800)]
doc: Document ceph-mgr module configuration options

Add comprehensive documentation for defining configuration options in
ceph-mgr modules, including all supported properties and their usage.

Previously, the documentation did not explain how to define ceph-mgr
module configuration options, despite subtle differences from other Ceph
components. This change documents all supported Option properties, their
types, and provides clear examples to help module developers properly
configure their options.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
(cherry picked from commit 121192f4c95df0ee282cecc7237c8ca788e9cfba)

12 months agoMerge pull request #64392 from zdover23/wip-doc-2025-07-09-backport-64334-to-tentacle
Zac Dover [Wed, 9 Jul 2025 02:01:22 +0000 (12:01 +1000)]
Merge pull request #64392 from zdover23/wip-doc-2025-07-09-backport-64334-to-tentacle

tentacle: doc/rados: remove clonedata command

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
12 months agoMerge pull request #64216 from zdover23/wip-doc-2025-06-27-backport-62944-to-tentacle
Anthony D'Atri [Wed, 9 Jul 2025 01:58:56 +0000 (21:58 -0400)]
Merge pull request #64216 from zdover23/wip-doc-2025-06-27-backport-62944-to-tentacle

tentacle: common/options: fix typo in description

12 months agodoc/rados: remove clonedata command 64392/head
Zac Dover [Thu, 3 Jul 2025 12:32:48 +0000 (22:32 +1000)]
doc/rados: remove clonedata command

Remove the "clonedata" command from the rados manpage.

The "clonedata" command was removed in
https://github.com/ceph/ceph/pull/13008.

Fixes: https://tracker.ceph.com/issues/71943
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 1eff1c1147bdb683701a55fbe3ea846fde6937f0)

12 months agoMerge pull request #64011 from cbodley/wip-71673-tentacle
Yuri Weinstein [Tue, 8 Jul 2025 21:25:22 +0000 (14:25 -0700)]
Merge pull request #64011 from cbodley/wip-71673-tentacle

tentacle: build: Fix opentelemetry-cpp build failure on Noble

Reviewed-by: Adam Emerson <aemerson@redhat.com>
Reviewed-by: David Galloway <dgallowa@redhat.com>
12 months agoMerge pull request #64241 from Hezko/wip-71888-tentacle
afreen23 [Tue, 8 Jul 2025 17:45:42 +0000 (23:15 +0530)]
Merge pull request #64241 from Hezko/wip-71888-tentacle

tentacle: mgr/dashboard: add missing namespace CLI commands

Reviewed-by: Afreen Misbah <afreen@ibm.com>
12 months agoMerge pull request #63944 from thotz/bp-tentacle-cloud-restore-allow-copy-cloud-resto...
Casey Bodley [Tue, 8 Jul 2025 11:58:02 +0000 (07:58 -0400)]
Merge pull request #63944 from thotz/bp-tentacle-cloud-restore-allow-copy-cloud-restored-temp-obj

tentacle: rgw/cloud-restore: allow copy of temporary object

Reviewed-by: Casey Bodley <cbodley@redhat.com>
12 months agomgr/dashboard: add missing ns commands 64241/head
Tomer Haskalovitch [Thu, 22 May 2025 10:35:26 +0000 (13:35 +0300)]
mgr/dashboard: add missing ns commands

Signed-off-by: Tomer Haskalovitch <tomer.haska@ibm.com>
(cherry picked from commit f682d62a9d897ae82d48e155b7b8ee4d07eaaecb)

12 months agoMerge pull request #63982 from cbodley/wip-71699-tentacle
anrao19 [Tue, 8 Jul 2025 05:01:31 +0000 (10:31 +0530)]
Merge pull request #63982 from cbodley/wip-71699-tentacle

tentacle: rgw/multisite: change HTTP error handling from EIO to ERR_INTERNAL_ERROR

12 months agoMerge pull request #64304 from Hezko/wip-71934-tentacle
afreen23 [Tue, 8 Jul 2025 03:14:30 +0000 (08:44 +0530)]
Merge pull request #64304 from Hezko/wip-71934-tentacle

tentacle: mgr/dashboard: NVMeoF CLI migrate prs

Reviewed-by: Afreen Misbah <afreen@ibm.com>
12 months agoMerge pull request #64237 from Hezko/wip-71884-tentacle
afreen23 [Tue, 8 Jul 2025 03:14:10 +0000 (08:44 +0530)]
Merge pull request #64237 from Hezko/wip-71884-tentacle

tentacle: mgr/dashboard: align response of subsystem add and ns add with old cli

Reviewed-by: Afreen Misbah <afreen@ibm.com>
12 months agoMerge pull request #64080 from adk3798/wip-71665-tentacle
Adam King [Mon, 7 Jul 2025 17:18:16 +0000 (13:18 -0400)]
Merge pull request #64080 from adk3798/wip-71665-tentacle

tentacle: src/pybind/mgr/cephadm/service_discovery: fixed HAProxy labels

Reviewed-by: Redouane Kachach <rkachach@redhat.com>
12 months agoMerge pull request #64078 from adk3798/wip-71196-tentacle
Adam King [Mon, 7 Jul 2025 17:06:54 +0000 (13:06 -0400)]
Merge pull request #64078 from adk3798/wip-71196-tentacle

tentacle: mgr/cephadm: Add command to stop host drain

Reviewed-by: Redouane Kachach <rkachach@redhat.com>
12 months agoMerge pull request #64209 from shraddhaag/wip-71858-tentacle
Shraddha Agrawal [Mon, 7 Jul 2025 15:48:56 +0000 (21:18 +0530)]
Merge pull request #64209 from shraddhaag/wip-71858-tentacle

tentacle: mon: add command osd pool clear-availability-status

12 months agoMerge pull request #64129 from NitzanMordhai/wip-71799-tentacle
Shraddha Agrawal [Mon, 7 Jul 2025 15:48:42 +0000 (21:18 +0530)]
Merge pull request #64129 from NitzanMordhai/wip-71799-tentacle

tentacle: src/mon/MgrStatMonitor: fix invalid iterator increment in calc_pool_availability()

12 months agoMerge pull request #64064 from aainscow/wip-71717-tentacle
Laura Flores [Mon, 7 Jul 2025 14:55:51 +0000 (10:55 -0400)]
Merge pull request #64064 from aainscow/wip-71717-tentacle

tentacle: osd: Correct scrub analysis for optimised EC

12 months agoMerge pull request #64077 from adk3798/wip-71195-tentacle
Adam King [Mon, 7 Jul 2025 14:31:37 +0000 (10:31 -0400)]
Merge pull request #64077 from adk3798/wip-71195-tentacle

tentacle: mgr/nfs: Add VIP to HAProxy_Hosts list for ingress type haproxy-protocol

Reviewed-by: Redouane Kachach <rkachach@redhat.com>
12 months agomonitoring: Add alert NVMeoFHostKeepAliveTimeout 64367/head
Vallari Agrawal [Fri, 20 Jun 2025 14:37:00 +0000 (20:07 +0530)]
monitoring: Add alert NVMeoFHostKeepAliveTimeout

Fixes: https://tracker.ceph.com/issues/71772
Signed-off-by: Vallari Agrawal <vallari.agrawal@ibm.com>
(cherry picked from commit 9977e5c963d6d9c303cf50335f2b6a52e60fba6e)

12 months agoMerge pull request #64197 from idryomov/wip-71838-tentacle
Sunil Angadi [Mon, 7 Jul 2025 06:24:40 +0000 (11:54 +0530)]
Merge pull request #64197 from idryomov/wip-71838-tentacle

tentacle: librbd/migration/QCOWFormat: don't complete read_clusters() inline

12 months agoMerge pull request #64242 from NitzanMordhai/wip-71867-tentacle
NitzanMordhai [Sun, 6 Jul 2025 11:00:37 +0000 (14:00 +0300)]
Merge pull request #64242 from NitzanMordhai/wip-71867-tentacle

tentacle: test/librados/aio_cxx: skip EIO boundary assertion when no in-flight I/Os

12 months agomgr/dashboard: migrate nvmeof pr #1346 to new cli 64304/head
Tomer Haskalovitch [Thu, 26 Jun 2025 10:25:53 +0000 (13:25 +0300)]
mgr/dashboard: migrate nvmeof pr #1346 to new cli

Signed-off-by: Tomer Haskalovitch <tomer.haska@ibm.com>
(cherry picked from commit 2e82486884b67ac6b7fd553a2ab7283f8b8cb096)

12 months agoMerge pull request #64188 from Matan-B/wip-71821-tentacle
NitzanMordhai [Sun, 6 Jul 2025 08:01:41 +0000 (11:01 +0300)]
Merge pull request #64188 from Matan-B/wip-71821-tentacle

tentacle: src: fix NDEBUG typo

12 months agoMerge pull request #64134 from JonBailey1993/wip-71798-tentacle
NitzanMordhai [Sun, 6 Jul 2025 08:01:26 +0000 (11:01 +0300)]
Merge pull request #64134 from JonBailey1993/wip-71798-tentacle

tentacle: test/osd: Improve readability of errors in ceph_test_rados_io_sequence

12 months agoMerge pull request #63014 from jamiepryde/tentacle-ec-plugins-tidying-nits-and-bits
NitzanMordhai [Sun, 6 Jul 2025 08:01:01 +0000 (11:01 +0300)]
Merge pull request #63014 from jamiepryde/tentacle-ec-plugins-tidying-nits-and-bits

tentacle: erasure-code: reformat EC plugins

12 months agomgr/dashboard: migrate nvmeof pr #1335 to new cli
Tomer Haskalovitch [Thu, 26 Jun 2025 10:00:22 +0000 (13:00 +0300)]
mgr/dashboard: migrate nvmeof pr #1335 to new cli

Signed-off-by: Tomer Haskalovitch <tomer.haska@ibm.com>
(cherry picked from commit 652d93acd96660fa1359377b2ed32aef0145293d)

12 months agomgr/dashboard: migrate nvmeof pr #1327 to new cli
Tomer Haskalovitch [Thu, 26 Jun 2025 09:53:05 +0000 (12:53 +0300)]
mgr/dashboard: migrate nvmeof pr #1327 to new cli

Signed-off-by: Tomer Haskalovitch <tomer.haska@ibm.com>
(cherry picked from commit 4713b19f2c418af340c0d58d46a8f0eeb0e1643f)

12 months agomgr/dashboard: migrate nvmeof pr #1233 to new cli
Tomer Haskalovitch [Wed, 25 Jun 2025 19:08:16 +0000 (22:08 +0300)]
mgr/dashboard: migrate nvmeof pr #1233 to new cli

Signed-off-by: Tomer Haskalovitch <tomer.haska@ibm.com>
(cherry picked from commit 9b1a24bf502267237b3aec594ce5521be7df3ba5)

12 months agomgr/dashboard: migrate nvmeof pr #1277 to new cli
Tomer Haskalovitch [Wed, 25 Jun 2025 09:05:53 +0000 (12:05 +0300)]
mgr/dashboard: migrate nvmeof pr #1277 to new cli

Signed-off-by: Tomer Haskalovitch <tomer.haska@ibm.com>
(cherry picked from commit a3165e081e783d24fa4e5987b01546108cc2f270)

12 months agomgr/dashboard: migrate nvmeof pr #1308 to new cli
Tomer Haskalovitch [Mon, 23 Jun 2025 21:00:58 +0000 (00:00 +0300)]
mgr/dashboard: migrate nvmeof pr #1308 to new cli

Signed-off-by: Tomer Haskalovitch <tomer.haska@ibm.com>
(cherry picked from commit 9a85c27c3749d14693cdbd90b682af8ebb6ab667)

12 months agomgr/dashboard: migrate nvmeof pr #1238 to new cli
Tomer Haskalovitch [Mon, 23 Jun 2025 20:23:05 +0000 (23:23 +0300)]
mgr/dashboard: migrate nvmeof pr #1238 to new cli

Signed-off-by: Tomer Haskalovitch <tomer.haska@ibm.com>
(cherry picked from commit 4c6304e7ff1e2df469b7f6e26337e5cfa13bc4b2)

12 months agomgr/dashboard: align response of subsystem add and ns add with old cli 64237/head
Tomer Haskalovitch [Tue, 20 May 2025 20:27:43 +0000 (23:27 +0300)]
mgr/dashboard: align response of subsystem add and ns add with old cli

Signed-off-by: Tomer Haskalovitch <il033030@Tomers-MBP.lan>
(cherry picked from commit 512f2133bd746094bd1cecd9d1e897b79ec3dd6d)
Signed-off-by: Tomer Haskalovitch <tomer.haska@ibm.com>
12 months agoMerge pull request #64234 from Hezko/wip-71882-tentacle
Hezko [Sun, 6 Jul 2025 07:41:11 +0000 (10:41 +0300)]
Merge pull request #64234 from Hezko/wip-71882-tentacle

tentacle: mgr/dashboard: Nvmeof CLI plain format support

12 months agoMerge pull request #64257 from leonidc/wip-71893-tentacle
leonidc [Sun, 6 Jul 2025 05:33:34 +0000 (08:33 +0300)]
Merge pull request #64257 from leonidc/wip-71893-tentacle

tentacle: fix duplicated entity addr in the map during reboot of several GWs

12 months agoMerge pull request #64258 from leonidc/wip-71894-tentacle
leonidc [Sun, 6 Jul 2025 05:33:07 +0000 (08:33 +0300)]
Merge pull request #64258 from leonidc/wip-71894-tentacle

tentacle: nvmeofgw: fix sending acks during upgrade

13 months agomgr/dashboard: add plain output type support to nvme cli 64234/head
Tomer Haskalovitch [Thu, 8 May 2025 08:54:39 +0000 (11:54 +0300)]
mgr/dashboard: add plain output type support to nvme cli

Signed-off-by: Tomer Haskalovitch <tomer.haska@ibm.com>
(cherry picked from commit 27698aec2b1aedf9124725709e85803213633232)

13 months agoMerge pull request #64295 from rhcs-dashboard/sys-packages-dashboard-tentacle
afreen23 [Fri, 4 Jul 2025 08:00:20 +0000 (13:30 +0530)]
Merge pull request #64295 from rhcs-dashboard/sys-packages-dashboard-tentacle

tentacle: mgr/dashboard: use system packages when running tox

Reviewed-by: Afreen Misbah <afreen@ibm.com>
13 months agoMerge pull request #64240 from Hezko/wip-71887-tentacle
afreen23 [Fri, 4 Jul 2025 07:52:25 +0000 (13:22 +0530)]
Merge pull request #64240 from Hezko/wip-71887-tentacle

tentacle: mgr/dashboard: update ceph nvmeof proto files

Reviewed-by: Afreen Misbah <afreen@ibm.com>
13 months agoMerge pull request #64236 from Hezko/wip-71885-tentacle
afreen23 [Fri, 4 Jul 2025 07:52:10 +0000 (13:22 +0530)]
Merge pull request #64236 from Hezko/wip-71885-tentacle

tentacle: mgr/dashboard: align cli commands listener list, ns list, host list

Reviewed-by: Afreen Misbah <afreen@ibm.com>
13 months agoMerge pull request #64342 from zdover23/wip-doc-2025-07-04-backport-63779-to-tentacle
Anthony D'Atri [Thu, 3 Jul 2025 22:36:14 +0000 (18:36 -0400)]
Merge pull request #64342 from zdover23/wip-doc-2025-07-04-backport-63779-to-tentacle

tentacle: doc/mgr: edit telemetry.rst

13 months agoMerge pull request #63980 from cbodley/wip-71690-tentacle
Casey Bodley [Thu, 3 Jul 2025 22:16:29 +0000 (18:16 -0400)]
Merge pull request #63980 from cbodley/wip-71690-tentacle

tentacle: test/common: unittest_fault_injector omits unit-main target

Reviewed-by: Adam C. Emerson <aemerson@redhat.com>
13 months agoMerge pull request #64337 from zdover23/wip-doc-2025-07-03-backport-64319-to-tentacle
Zac Dover [Thu, 3 Jul 2025 22:14:37 +0000 (08:14 +1000)]
Merge pull request #64337 from zdover23/wip-doc-2025-07-03-backport-64319-to-tentacle

tentacle: doc/radosgw: add rgw_enable_lc_threads & rgw_enable_gc_threads

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
13 months agodoc/mgr: edit telemetry.rst 64342/head
Zac Dover [Fri, 6 Jun 2025 04:57:19 +0000 (14:57 +1000)]
doc/mgr: edit telemetry.rst

Edit doc/mgr/telemetry.rst.

Incorporate the suggestions made by Anthony D'Atri in
https://github.com/ceph/ceph/pull/63735.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 97ef126e4b6a9dcdf9872cf37cdebec289e84acd)

13 months agoMerge pull request #64279 from mkogan1/wip-71906-tentacle
Yuri Weinstein [Thu, 3 Jul 2025 16:54:45 +0000 (09:54 -0700)]
Merge pull request #64279 from mkogan1/wip-71906-tentacle

tentacle: qa/rgw: fix perl tests missing Amazon::S3 module

Reviewed-by: Adam Emerson <aemerson@redhat.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>
13 months agoMerge pull request #63929 from cbodley/wip-71672-tentacle
Yuri Weinstein [Thu, 3 Jul 2025 16:53:57 +0000 (09:53 -0700)]
Merge pull request #63929 from cbodley/wip-71672-tentacle

tentacle: qa/rgw: bump maven version in hadoop task to resolve 404 Not Found

Reviewed-by: Adam Emerson <aemerson@redhat.com>
13 months agoMerge pull request #63724 from cbodley/wip-71564-tentacle
Yuri Weinstein [Thu, 3 Jul 2025 16:53:04 +0000 (09:53 -0700)]
Merge pull request #63724 from cbodley/wip-71564-tentacle

tentacle: debian: radosgw: add media-types packages as alternative for mime-support

Reviewed-by: Adam Emerson <aemerson@redhat.com>
13 months agoMerge pull request #63436 from mkogan1/wip-71420-tentacle
Yuri Weinstein [Thu, 3 Jul 2025 16:52:21 +0000 (09:52 -0700)]
Merge pull request #63436 from mkogan1/wip-71420-tentacle

tentacle: rgw/d3n: fix valgrind invalid read during exit

Reviewed-by: Casey Bodley <cbodley@redhat.com>
13 months agoMerge pull request #63362 from cbodley/wip-71376-tentacle
Yuri Weinstein [Thu, 3 Jul 2025 16:50:46 +0000 (09:50 -0700)]
Merge pull request #63362 from cbodley/wip-71376-tentacle

tentacle: rgw/rgw_rest: determine the domain uri prefix by rgw_transport_is_secure

Reviewed-by: Adam Emerson <aemerson@redhat.com>
13 months agoMerge pull request #64320 from zdover23/wip-doc-2025-07-03-backport-64306-to-tentacle
Anthony D'Atri [Thu, 3 Jul 2025 14:37:03 +0000 (10:37 -0400)]
Merge pull request #64320 from zdover23/wip-doc-2025-07-03-backport-64306-to-tentacle

tentacle: doc/rados/ops: add caps restore command

13 months agodoc/radosgw: add rgw_enable_lc_threads & rgw_enable_gc_threads 64337/head
Zac Dover [Thu, 3 Jul 2025 06:45:31 +0000 (16:45 +1000)]
doc/radosgw: add rgw_enable_lc_threads & rgw_enable_gc_threads

Add rgw_enable_lc_threads and rgw_enable_gc_threads to
doc/radosgw/config-ref.rst.

Fixes: https://tracker.ceph.com/issues/58092
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 45e5468ea7fc57b1cb60f1936558dc2678adc6fd)

13 months agoMerge pull request #64079 from adk3798/wip-71571-tentacle
Adam King [Thu, 3 Jul 2025 12:43:47 +0000 (08:43 -0400)]
Merge pull request #64079 from adk3798/wip-71571-tentacle

tentacle: cephadm: don't collect image ids for daemons with no container info

Reviewed-by: John Mulligan <jmulligan@redhat.com>
13 months agoMerge pull request #63444 from JoshuaGabriel/wip-71407-tentacle
Adam King [Thu, 3 Jul 2025 12:39:56 +0000 (08:39 -0400)]
Merge pull request #63444 from JoshuaGabriel/wip-71407-tentacle

tentacle: orch/module: Make orch unpause an alias for orch resume

Reviewed-by: Redouane Kachach <rkachach@ibm.com>
13 months agomgr/dashboard: catch protobuf error due to mismatch in version 64295/head
Nizamudeen A [Thu, 26 Jun 2025 07:25:22 +0000 (12:55 +0530)]
mgr/dashboard: catch protobuf error due to mismatch in version

Signed-off-by: Nizamudeen A <nia@redhat.com>
13 months agomgr/dashboard: unpin grpcio deps
Nizamudeen A [Thu, 26 Jun 2025 04:51:34 +0000 (10:21 +0530)]
mgr/dashboard: unpin grpcio deps

Fixes: https://tracker.ceph.com/issues/70411
Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit 84922d1ff0f3aae39ecd998b2b94469ce9989c08)

13 months agomgr/dashboard: sitepackages only for py3
Nizamudeen A [Mon, 17 Mar 2025 05:10:21 +0000 (10:40 +0530)]
mgr/dashboard: sitepackages only for py3

Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit 6985ed15ce20c24f7fa87c23ac65b28cf544c9b7)

13 months agoRevert "mgr/dashboard: pin lxml to fix run-dashboard-tox-make-check failure"
Nizamudeen A [Thu, 13 Mar 2025 06:47:41 +0000 (12:17 +0530)]
Revert "mgr/dashboard: pin lxml to fix run-dashboard-tox-make-check failure"

This reverts commit 1f84505f1232dd8445df1a2a819fa000062d3934.

Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit 8e6b6cdd5c302577c81aa041ef4b3f494ed717a7)

13 months agomgr/dashboard: disable saml2 tests when the dep is not there
Nizamudeen A [Wed, 12 Mar 2025 08:32:10 +0000 (14:02 +0530)]
mgr/dashboard: disable saml2 tests when the dep is not there

Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit 8acf8f7e4fe6d283212154857abd97b6e641de4d)

13 months agomgr/dashboard: use system packages when running tox
Nizamudeen A [Wed, 12 Mar 2025 05:27:29 +0000 (10:57 +0530)]
mgr/dashboard: use system packages when running tox

Fixes: https://tracker.ceph.com/issues/70411
Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit ffde8d044a207d304ec8f916e45c98289f740bec)

13 months agodoc/rados/ops: add caps restore command 64320/head
Zac Dover [Wed, 2 Jul 2025 12:29:48 +0000 (22:29 +1000)]
doc/rados/ops: add caps restore command

Add a command that restores caps to client.admin after they have been
accidentally destroyed or removed.

Fixes: https://tracker.ceph.com/issues/23594
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit de8c148a2f99db3a1dc4eb70a19aca19a0e9bacf)

13 months agoMerge pull request #64180 from zdover23/wip-doc-2025-06-25-backport-64172-to-tentacle
Zac Dover [Thu, 3 Jul 2025 05:41:13 +0000 (15:41 +1000)]
Merge pull request #64180 from zdover23/wip-doc-2025-06-25-backport-64172-to-tentacle

tentacle: doc/radosgw: line edit bucket_logging.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Yuval Lifshitz <ylifshit@ibm.com>
13 months agoMerge pull request #64314 from zdover23/wip-doc-2025-07-03-backport-63359-to-tentacle
Anthony D'Atri [Thu, 3 Jul 2025 02:02:18 +0000 (22:02 -0400)]
Merge pull request #64314 from zdover23/wip-doc-2025-07-03-backport-63359-to-tentacle

tentacle: doc/radosgw/s3: Document delete-if-unmodified-since

13 months agodoc/radosgw/s3: Document delete-if-unmodified-since 64314/head
Anthony D'Atri [Mon, 19 May 2025 14:14:00 +0000 (10:14 -0400)]
doc/radosgw/s3: Document delete-if-unmodified-since

Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
(cherry picked from commit 3381041d190fd48cf9f6d53f679f1737028cccf4)
(cherry picked from commit 7e2bd1595d64c12e1959cc29acfaf906a9027fc6)

13 months agoMerge pull request #64232 from Hezko/wip-71880-tentacle
afreen23 [Wed, 2 Jul 2025 14:38:21 +0000 (20:08 +0530)]
Merge pull request #64232 from Hezko/wip-71880-tentacle

tentacle: mgr/dashboard: Add missing fields to subsytem list API/CLI

Reviewed-by: Afreen Misbah <afreen@ibm.com>
13 months agoMerge pull request #64233 from Hezko/wip-71881-tentacle
afreen23 [Wed, 2 Jul 2025 14:37:03 +0000 (20:07 +0530)]
Merge pull request #64233 from Hezko/wip-71881-tentacle

tentacle: mgr/dashboard: fix set spdk log level cli command

Reviewed-by: Afreen Misbah <afreen@ibm.com>
13 months agoMerge pull request #64146 from zdover23/wip-doc-2025-06-25-backport-64088-to-tentacle
Zac Dover [Wed, 2 Jul 2025 13:19:34 +0000 (23:19 +1000)]
Merge pull request #64146 from zdover23/wip-doc-2025-06-25-backport-64088-to-tentacle

tentacle: doc: Fixed a spelling error.

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
13 months agoMerge pull request #64283 from zdover23/wip-doc-2025-07-01-backport-64239-to-tentacle
Zac Dover [Wed, 2 Jul 2025 13:19:05 +0000 (23:19 +1000)]
Merge pull request #64283 from zdover23/wip-doc-2025-07-01-backport-64239-to-tentacle

tentacle: doc/mgr/crash.rst: remove outdated module enabling instructions

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
13 months agoMerge pull request #64286 from zdover23/wip-doc-2025-07-01-backport-64255-to-tentacle
Zac Dover [Wed, 2 Jul 2025 13:18:02 +0000 (23:18 +1000)]
Merge pull request #64286 from zdover23/wip-doc-2025-07-01-backport-64255-to-tentacle

tentacle: doc/rados/configuration: Small improvements in ceph-conf.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
13 months agoMerge pull request #64169 from zdover23/wip-doc-2025-06-25-backport-64163-to-tentacle
Zac Dover [Wed, 2 Jul 2025 13:09:53 +0000 (23:09 +1000)]
Merge pull request #64169 from zdover23/wip-doc-2025-06-25-backport-64163-to-tentacle

tentacle: doc: Fix unterminated inline literal in ceph-conf.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
13 months agodoc/radosgw: line edit bucket_logging.rst 64180/head
Zac Dover [Wed, 25 Jun 2025 09:19:49 +0000 (19:19 +1000)]
doc/radosgw: line edit bucket_logging.rst

Edit doc/radosgw/bucket_logging.rst so that it is not solecistic and so
that its punctuation is corrected and its use of articles is corrected.
This file remains in my judgment demotic and maybe demotic enough to
warrant another editorial pass in the future.

Fixes: https://tracker.ceph.com/issues/70758
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit c01eb372326be49cbb76d602eabba951663979ec)

13 months agobluestore: Fix _setattr() with rare memory alignments 64300/head
Adam Kupczyk [Wed, 18 Jun 2025 10:25:21 +0000 (10:25 +0000)]
bluestore: Fix _setattr() with rare memory alignments

Fix case bufferlist is length 0.

Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
(cherry picked from commit e82bf6d0fd8bf4e461441a7e0cab87397043c754)

13 months agotest/store_test.cc: Expanded test for setattr
Adam Kupczyk [Wed, 18 Jun 2025 09:41:45 +0000 (09:41 +0000)]
test/store_test.cc: Expanded test for setattr

Added case for setting attr that has buffelist empty (size 0).

Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
(cherry picked from commit 04ad137e4460a3b2422f6dac992b112e3fa15f78)

13 months agobluestore: Fix _setattr() with rare memory alignments
Alex Ainscow [Tue, 10 Jun 2025 09:54:13 +0000 (10:54 +0100)]
bluestore: Fix _setattr() with rare memory alignments

Fix an issue in BlueStore_setattr whereby if a buffer was contiguous and non-partial, then bluestore could completely drop the attribute.

setattr seems to be rarely used outside of new EC. In new EC it is only
used on non-primary shards, so this was only ever seen if the non-primary
happened to be on the same OSD as the primary - this is transient and rare
that scrubbing would actually catche the issue.

Fixes: https://tracker.ceph.com/issues/71623
Signed-off-by: Alex Ainscow <aainscow@uk.ibm.com>
(cherry picked from commit d4e2d4977016bce22a4b9e779c5da54be2d4aaba)

13 months agotest/store_test: Fix BluestorePerPoolOmapFixOnMount
Adam Kupczyk [Tue, 10 Jun 2025 15:14:44 +0000 (15:14 +0000)]
test/store_test: Fix BluestorePerPoolOmapFixOnMount

We called inject_legacy_omap() before waiting to commit
initial transaction that created the object.
The results is that sometimes the initial clean state
removed legacy omap signalling used by unittest.

Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
(cherry picked from commit 3c9defab46e3ea7f9b9fbd05bdae9d6597687f0a)

13 months agotest/store_test.cc: Add test for setattr
Adam Kupczyk [Tue, 10 Jun 2025 10:36:32 +0000 (10:36 +0000)]
test/store_test.cc: Add test for setattr

Added case for setting attr that has its buffelist full.

Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
(cherry picked from commit 87a73576a5125e46494aa2642d3c89eda3561f5b)

13 months agoMerge pull request #64231 from Hezko/wip-71879-tentacle
afreen23 [Wed, 2 Jul 2025 08:34:46 +0000 (14:04 +0530)]
Merge pull request #64231 from Hezko/wip-71879-tentacle

tentacle: mgr/dashboard: Remove map collection dec

Reviewed-by: Afreen Misbah <afreen@ibm.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
13 months agoMerge pull request #64235 from Hezko/wip-71883-tentacle
afreen23 [Wed, 2 Jul 2025 08:22:18 +0000 (13:52 +0530)]
Merge pull request #64235 from Hezko/wip-71883-tentacle

tentacle: mgr/dashboard: align gw info, gw version, spdk_log_level get with old cli

Reviewed-by: Afreen Misbah <afreen@ibm.com>
13 months agoMerge pull request #64076 from adk3798/tentacle-cephadm-guess-name
Adam King [Tue, 1 Jul 2025 15:30:48 +0000 (11:30 -0400)]
Merge pull request #64076 from adk3798/tentacle-cephadm-guess-name

tentacle: cephadm: minor ergonomic improvements for hackers

Reviewed-by: John Mulligan <jmulligan@redhat.com>
13 months agodoc/rados/configuration: Small improvements in ceph-conf.rst 64286/head
Ville Ojamo [Mon, 30 Jun 2025 07:30:34 +0000 (14:30 +0700)]
doc/rados/configuration: Small improvements in ceph-conf.rst

Fix a missing space typo.

Use title case in section titles.

Use ref for hyperlink to a section that already has a label instead of
linking to title text of the section.

Use privileged command prompt for all ceph commands except ceph commands
that invoke help.

Use INI preformatted block for last remaining block that was just using
plain preformatted.

Signed-off-by: Ville Ojamo <14869000+bluikko@users.noreply.github.com>
(cherry picked from commit 6687c9767d9764f34d7099ba6980992dd8ae8737)

13 months agodoc/mgr/crash.rst: remove outdated module enabling instructions 64283/head
Kefu Chai [Sun, 29 Jun 2025 02:55:30 +0000 (10:55 +0800)]
doc/mgr/crash.rst: remove outdated module enabling instructions

The crash module has been enabled by default since commit 18f253aa in
Nautilus and is now in the always_on_modules list. However, the
documentation still contained instructions for manually enabling it.

When users followed these outdated instructions, they encountered:
```
  module 'crash' is already enabled (always-on)
```

The module cannot be disabled either. Running:
```
  ceph mgr module disable crash
```

Returns the error:
```
  Error EINVAL: module 'crash' cannot be disabled (always-on)
```
In this change, we remove the obsolete enabling instructions and clarify
that this module is always active and cannot be disabled.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
(cherry picked from commit 0fcd7677586f7edf3eb091420a8ace0c4f887167)