]>
git.apps.os.sepia.ceph.com Git - ceph.git/log
Adam King [Wed, 21 May 2025 15:41:06 +0000 (11:41 -0400)]
qa/rbd/iscsi: ignore MON_DOWN warning in logs
These seem to be popping up very briefly and don't
appear to be relevant to what is being tested
Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit
3b2064e7066fa58e0d812e85a293f74401d295f4 )
SrinivasaBharathKanta [Sun, 20 Jul 2025 10:59:25 +0000 (16:29 +0530)]
Merge pull request #59443 from kamoltat/wip-67720-squid
squid: src/pybind/mgr/pg_autoscaler/module.py: fix 'pg_autoscale_mode' output
SrinivasaBharathKanta [Sun, 20 Jul 2025 10:59:15 +0000 (16:29 +0530)]
Merge pull request #62924 from kamoltat/wip-71028-squid
squid: mon: Track and process pending pings after election
SrinivasaBharathKanta [Sun, 20 Jul 2025 10:59:03 +0000 (16:29 +0530)]
Merge pull request #63024 from kamoltat/wip-71091-squid
squid: HealthMonitor: Add topology-aware netsplit detection and warning
SrinivasaBharathKanta [Sun, 20 Jul 2025 10:58:50 +0000 (16:28 +0530)]
Merge pull request #63804 from badone/wip-tracker-70645-mon_memory_target-fix-squid
Squid: OSDMonitor: Make sure pcm is initialised
Anthony D'Atri [Thu, 17 Jul 2025 04:04:28 +0000 (00:04 -0400)]
Merge pull request #64547 from zdover23/wip-doc-2025-07-17-backport-64532-to-squid
squid: doc/radosgw: edit "Lifecycle Settings"
Zac Dover [Wed, 16 Jul 2025 12:11:03 +0000 (22:11 +1000)]
doc/radosgw: edit "Lifecycle Settings"
Edit the section "Lifecycle Settings" in the file
doc/radosgw/config-ref.rst. Remove solecisms and pleonasms and plain old
infelicitious formulations.
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit
ac2e5f502523d1bf326303e904ccb47236c81fcb )
Anthony D'Atri [Wed, 16 Jul 2025 14:22:53 +0000 (10:22 -0400)]
Merge pull request #64530 from zdover23/wip-doc-2025-07-16-backport-64433-to-squid
squid: doc: update mgr modules notify_types
Zac Dover [Wed, 16 Jul 2025 12:26:41 +0000 (22:26 +1000)]
Merge pull request #63809 from zdover23/wip-doc-2025-06-09-backport-63781-to-squid
squid: doc/mgr: edit telemetry.rst
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Nitzan Mordechai [Thu, 10 Jul 2025 10:03:06 +0000 (10:03 +0000)]
doc: update mgr modules notify_types
Signed-off-by: Nitzan Mordechai <nmordec@redhat.com>
(cherry picked from commit
fc4396d6280fcbf0a95567cff144052d81dcd964 )
Anthony D'Atri [Tue, 15 Jul 2025 13:44:45 +0000 (09:44 -0400)]
Merge pull request #64496 from zdover23/wip-doc-2025-07-15-backport-63877-to-squid
squid: doc/rados/ops: edit cache-tiering.rst
Zac Dover [Wed, 11 Jun 2025 12:44:32 +0000 (22:44 +1000)]
doc/rados/ops: edit cache-tiering.rst
Add material to doc/rados/operations/cache-tiering.rst, as suggested by
Anthony D'Atri in
https://github.com/ceph/ceph/pull/63745#discussion_r2127887785.
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit
d3c46820a5fc72391ef46ab4b03bbe867e0e51d2 )
anrao19 [Tue, 15 Jul 2025 05:04:14 +0000 (10:34 +0530)]
Merge pull request #64357 from mkogan1/wip-71957-squid
squid: rgw: allow specifying ssl certificate for radosgw-admin operations
anrao19 [Tue, 15 Jul 2025 05:03:32 +0000 (10:33 +0530)]
Merge pull request #64202 from ideepika/wip-71152-squid
squid: rgw: make keystone work without admin token(service ac requirement)
Anthony D'Atri [Tue, 15 Jul 2025 02:36:52 +0000 (22:36 -0400)]
Merge pull request #64492 from zdover23/wip-doc-2025-07-15-backport-64483-to-squid
squid: doc: add note admonitions in two files
Zac Dover [Mon, 14 Jul 2025 14:40:21 +0000 (00:40 +1000)]
doc: add note admonitions in two files
Add note admonitions when discussing client package support in the
context of OS Recommendations in the following two files:
- doc/cephfs/ceph-dokan.rst
- doc/rbd/rbd-windows.rst
This addresses a change requested by Ilya Dryomov in
https://github.com/ceph/ceph/pull/64374#discussion_r2199756581.
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit
69d641f0207d803cd9a3c3e102d5b2073e6b0f77 )
J. Eric Ivancich [Mon, 14 Jul 2025 17:24:02 +0000 (13:24 -0400)]
Merge pull request #64313 from ivancich/wip-69408-squid
squid: rgw: fix empty storage class on display of multipart uploads
Reviewed-by: Adam C. Emerson <aemerson@redhat.com>
Anthony D'Atri [Mon, 14 Jul 2025 17:22:40 +0000 (13:22 -0400)]
Merge pull request #64481 from zdover23/wip-doc-2025-07-15-backport-64374-to-squid
squid: doc: Clarify the status of MS Windows client support
Anthony D'Atri [Mon, 7 Jul 2025 15:47:02 +0000 (11:47 -0400)]
doc: Clarify the status of MS Windows client support
Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
(cherry picked from commit
89eabfc3f0c8db3501b3ea3097e2983617c5234a )
Anthony D'Atri [Mon, 14 Jul 2025 13:30:05 +0000 (09:30 -0400)]
Merge pull request #64472 from zdover23/wip-doc-2025-07-14-backport-64462-to-squid
squid: doc/cephfs: Improve mount-using-fuse.rst
Anthony D'Atri [Mon, 14 Jul 2025 13:28:51 +0000 (09:28 -0400)]
Merge pull request #64475 from zdover23/wip-doc-2025-07-14-backport-63080-to-squid
squid: doc/radosgw: Improve rgw-cache.rst
Ville Ojamo [Wed, 30 Apr 2025 18:17:14 +0000 (01:17 +0700)]
doc/radosgw: Improve rgw-cache.rst
Try to improve the language by completely rewriting some sentences.
Attempt to format the document more like the rest of the docs.
Fix several errors in punctuation, capitalization, spaces etc.
Use blocks with bash prompts for CLI commands instead of hardcoded
prompts.
Fix section hierarchy and section title underline lengths.
Use admonition.
Signed-off-by: Ville Ojamo <14869000+bluikko@users.noreply.github.com>
(cherry picked from commit
6e836f8f1e1e53bc7f8d8b497960b100e6b625d6 )
Anthony D'Atri [Fri, 11 Jul 2025 19:02:45 +0000 (15:02 -0400)]
doc/cephfs: Improve mount-using-fuse.rst
Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
(cherry picked from commit
329ee7b3038e49cf0def2f2628444e3e90796c05 )
anrao19 [Mon, 14 Jul 2025 04:57:19 +0000 (10:27 +0530)]
Merge pull request #64387 from cbodley/wip-72026-squid
squid: rgw: don't use merge_and_store_attrs() when recreating a bucket
afreen23 [Fri, 11 Jul 2025 15:30:29 +0000 (21:00 +0530)]
Merge pull request #64269 from zdover23/wip-doc-2025-06-30-backport-64164-to-squid
squid: mgr/dashboard: Fix inline markup warning in API documentation
Reviewed-by: Afreen Misbah <afreen@ibm.com>
Adam King [Wed, 9 Jul 2025 15:48:22 +0000 (11:48 -0400)]
Merge pull request #64086 from adk3798/wip-69514-squid
squid: mgr/cephadm: mgr orchestrator module raise exception if there is trailing tab in yaml file
Reviewed-by: Redouane Kachach <rkachach@ibm.com>
Jos Collin [Wed, 9 Jul 2025 09:35:37 +0000 (15:05 +0530)]
Merge pull request #59829 from joscollin/wip-68108-squid
squid: qa: multiple fixes in test_mirroring.py
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Jos Collin [Wed, 9 Jul 2025 04:36:20 +0000 (10:06 +0530)]
Merge pull request #62115 from joscollin/wip-70285-squid
squid: cephfs-journal-tool: fix segfault during 'journal import' from invalid dump file
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Anthony D'Atri [Wed, 9 Jul 2025 04:05:20 +0000 (00:05 -0400)]
Merge pull request #64166 from zdover23/wip-doc-2025-06-25-backport-64160-to-squid
squid: doc/dev/config: Document how to use :confval: directive for config op…
Anthony D'Atri [Wed, 9 Jul 2025 04:04:20 +0000 (00:04 -0400)]
Merge pull request #64396 from zdover23/wip-doc-2025-07-09-backport-64161-to-squid
squid: doc: Document ceph-mgr module configuration options
Kefu Chai [Wed, 25 Jun 2025 02:26:58 +0000 (10:26 +0800)]
doc: Document ceph-mgr module configuration options
Add comprehensive documentation for defining configuration options in
ceph-mgr modules, including all supported properties and their usage.
Previously, the documentation did not explain how to define ceph-mgr
module configuration options, despite subtle differences from other Ceph
components. This change documents all supported Option properties, their
types, and provides clear examples to help module developers properly
configure their options.
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
(cherry picked from commit
121192f4c95df0ee282cecc7237c8ca788e9cfba )
Jos Collin [Wed, 9 Jul 2025 02:10:16 +0000 (07:40 +0530)]
Merge pull request #61774 from joscollin/wip-69927-squid
squid: cephfs-top: exception when terminal size greater than PAD_WIDTH
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Zac Dover [Wed, 9 Jul 2025 02:01:13 +0000 (12:01 +1000)]
Merge pull request #64393 from zdover23/wip-doc-2025-07-09-backport-64334-to-squid
squid: doc/rados: remove clonedata command
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Anthony D'Atri [Wed, 9 Jul 2025 01:58:32 +0000 (21:58 -0400)]
Merge pull request #64217 from zdover23/wip-doc-2025-06-27-backport-62944-to-squid
squid: common/options: fix typo in description
Zac Dover [Fri, 6 Jun 2025 05:11:15 +0000 (15:11 +1000)]
doc/mgr: edit telemetry.rst
Edit doc/mgr/telemetry.rst.
Incorporate Anthony D'Atri's suggestions from
https://github.com/ceph/ceph/pull/63739.
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit
ac7f757db7b3644761a2295cfe5e1a9a55319f72 )
Zac Dover [Thu, 3 Jul 2025 12:32:48 +0000 (22:32 +1000)]
doc/rados: remove clonedata command
Remove the "clonedata" command from the rados manpage.
The "clonedata" command was removed in
https://github.com/ceph/ceph/pull/13008.
Fixes: https://tracker.ceph.com/issues/71943
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit
1eff1c1147bdb683701a55fbe3ea846fde6937f0 )
Casey Bodley [Wed, 18 Dec 2024 16:28:02 +0000 (11:28 -0500)]
rgw: don't use merge_and_store_attrs() when recreating a bucket
https://github.com/ceph/ceph/pull/56583 recently fixed
merge_and_store_attrs() to preserve existing attrs, but this broke the
swift api's ability to remove container metadata. RGWCreateBucket
handles this merging itself with prepare_add_del_attrs(), so we should
just assign createparams.attrs to the bucket and store it with
bucket->put_info()
make the same change for RGWPutMetadataBucket which swift uses to
add/remove existing metadata
Fixes: https://tracker.ceph.com/issues/69301
Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit
340e353de6882dcd6e327d6691da9ef2b767ab4f )
Adam King [Mon, 7 Jul 2025 17:36:34 +0000 (13:36 -0400)]
Merge pull request #64084 from adk3798/wip-69712-squid
squid: cephadm: rgw: allow specifying the ssl_certificate by filepath
Reviewed-by: Redouane Kachach <rkachach@ibm.com>
Mark Kogan [Sun, 12 Dec 2021 17:30:42 +0000 (17:30 +0000)]
rgw: allow specifying ssl certificate for radosgw-admin operations
for example
../src/mrun c2 radosgw-admin realm pull --url=https://localhost:1443 --access-key
a2345678901234567890 --secret
a234567890123456789012345678901234567890 --default --rgw_verify_ssl_cacert=./cert.pem
../src/mrun c2 radosgw-admin period pull --url=https://localhost:1443 --access-key
a2345678901234567890 --secret
a234567890123456789012345678901234567890 --default --rgw_verify_ssl_cacert=./cert.pem
../src/mrun c2 radosgw-admin period update --commit --rgw_verify_ssl_cacert=./cert.pem
../src/mrun c2 radosgw-admin sync status --rgw_verify_ssl_cacert=./cert.pem
fixes: https://tracker.ceph.com/issues/53588
Signed-off-by: Mark Kogan <mkogan@redhat.com>
(cherry picked from commit
7c7633bb6795b410974dc3a61cdc162bfaf15e52 )
Anthony D'Atri [Thu, 3 Jul 2025 23:42:06 +0000 (19:42 -0400)]
Merge pull request #64343 from zdover23/wip-doc-2025-07-04-backport-63779-to-squid
squid: doc/mgr: edit telemetry.rst
Casey Bodley [Thu, 3 Jul 2025 22:16:38 +0000 (18:16 -0400)]
Merge pull request #63981 from cbodley/wip-71691-squid
squid: test/common: unittest_fault_injector omits unit-main target
Reviewed-by: Adam C. Emerson <aemerson@redhat.com>
Zac Dover [Thu, 3 Jul 2025 22:14:43 +0000 (08:14 +1000)]
Merge pull request #64338 from zdover23/wip-doc-2025-07-03-backport-64319-to-squid
squid: doc/radosgw: add rgw_enable_lc_threads & rgw_enable_gc_threads
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Zac Dover [Fri, 6 Jun 2025 04:57:19 +0000 (14:57 +1000)]
doc/mgr: edit telemetry.rst
Edit doc/mgr/telemetry.rst.
Incorporate the suggestions made by Anthony D'Atri in
https://github.com/ceph/ceph/pull/63735.
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit
97ef126e4b6a9dcdf9872cf37cdebec289e84acd )
Anthony D'Atri [Thu, 3 Jul 2025 14:36:49 +0000 (10:36 -0400)]
Merge pull request #64321 from zdover23/wip-doc-2025-07-03-backport-64306-to-squid
squid: doc/rados/ops: add caps restore command
Zac Dover [Thu, 3 Jul 2025 06:45:31 +0000 (16:45 +1000)]
doc/radosgw: add rgw_enable_lc_threads & rgw_enable_gc_threads
Add rgw_enable_lc_threads and rgw_enable_gc_threads to
doc/radosgw/config-ref.rst.
Fixes: https://tracker.ceph.com/issues/58092
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit
45e5468ea7fc57b1cb60f1936558dc2678adc6fd )
Adam King [Thu, 3 Jul 2025 12:39:00 +0000 (08:39 -0400)]
Merge pull request #59880 from adk3798/squid-cephadm-nvmeof-allow-passing-group
squid: mgr/orchestrator: allow passing group to apply/add nvmeof commands
Reviewed-by: John Mulligan <jmulligan@redhat.com>
Adam King [Thu, 3 Jul 2025 12:37:13 +0000 (08:37 -0400)]
Merge pull request #63115 from adk3798/squid-nfs-export-parse-sectype
squid: mgr/nfs: make sure sectype is a list when parsed
Reviewed-by: Redouane Kachach <rkachach@ibm.com>
Reviewed-by: Shweta Bhosale <Shweta.Bhosale1@ibm.com>
Adam King [Thu, 3 Jul 2025 12:34:14 +0000 (08:34 -0400)]
Merge pull request #64082 from adk3798/wip-68583-squid
squid: cephadm: add ability to continue on failure when applying multiple specs
Reviewed-by: Redouane Kachach <rkachach@ibm.com>
Reviewed-by: Shweta Bhosale <Shweta.Bhosale1@ibm.com>
Zac Dover [Wed, 2 Jul 2025 12:29:48 +0000 (22:29 +1000)]
doc/rados/ops: add caps restore command
Add a command that restores caps to client.admin after they have been
accidentally destroyed or removed.
Fixes: https://tracker.ceph.com/issues/23594
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit
de8c148a2f99db3a1dc4eb70a19aca19a0e9bacf )
Anthony D'Atri [Thu, 3 Jul 2025 02:02:33 +0000 (22:02 -0400)]
Merge pull request #64315 from zdover23/wip-doc-2025-07-03-backport-63359-to-squid
squid: doc/radosgw/s3: Document delete-if-unmodified-since
Zac Dover [Thu, 3 Jul 2025 01:27:47 +0000 (11:27 +1000)]
Merge pull request #62612 from zdover23/wip-doc-2025-04-02-backport-62610-to-squid
squid: doc/dev/release-process.rst: document new Jenkins job for containers
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Anthony D'Atri [Mon, 19 May 2025 14:14:00 +0000 (10:14 -0400)]
doc/radosgw/s3: Document delete-if-unmodified-since
Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
(cherry picked from commit
3381041d190fd48cf9f6d53f679f1737028cccf4 )
(cherry picked from commit
7e2bd1595d64c12e1959cc29acfaf906a9027fc6 )
Zac Dover [Wed, 2 Jul 2025 21:11:41 +0000 (07:11 +1000)]
Merge pull request #63812 from zdover23/wip-doc-2025-06-09-backport-63782-to-squid
squid: doc/radosgw: edit metrics.rst
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Zac Dover [Wed, 2 Jul 2025 21:04:22 +0000 (07:04 +1000)]
Merge pull request #62551 from zdover23/wip-doc-2025-03-28-backport-62537-to-squid
squid: src/common: add guidance for mon_warn_pg_not_scrubbed
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
J. Eric Ivancich [Tue, 22 Oct 2024 17:17:14 +0000 (13:17 -0400)]
rgw: fix empty storage class on display of multipart uploads
Some multipart uploads do not have a stored storage class, however the
code is written such that an empty storage class is treated as the
"STANDARD" storage class. So when encoding the storage class in JSON,
use the canonical storage.
Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
(cherry picked from commit
eab096c188d2430ccc3e865b614b845f1a92af08 )
Zac Dover [Fri, 6 Jun 2025 05:16:17 +0000 (15:16 +1000)]
doc/radosgw: edit metrics.rst
Edit doc/radosgw/metrics.rst.
Incorporate Anthony D'Atri's suggestion from
https://github.com/ceph/ceph/pull/62893#discussion_r2124662981 into the
RADOSGW documentation.
This commit clarifies the English that explains the behavior of
rgw-multitenancy.
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit
c7e49b85997369c5c29fb64da89fa676cb84e989 )
Zac Dover [Wed, 2 Jul 2025 13:19:28 +0000 (23:19 +1000)]
Merge pull request #64147 from zdover23/wip-doc-2025-06-25-backport-64088-to-squid
squid: doc: Fixed a spelling error.
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Zac Dover [Wed, 2 Jul 2025 13:18:18 +0000 (23:18 +1000)]
Merge pull request #64284 from zdover23/wip-doc-2025-07-01-backport-64239-to-squid
squid: doc/mgr/crash.rst: remove outdated module enabling instructions
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Zac Dover [Wed, 2 Jul 2025 13:17:56 +0000 (23:17 +1000)]
Merge pull request #64287 from zdover23/wip-doc-2025-07-01-backport-64255-to-squid
squid: doc/rados/configuration: Small improvements in ceph-conf.rst
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Zac Dover [Wed, 2 Jul 2025 13:10:01 +0000 (23:10 +1000)]
Merge pull request #64170 from zdover23/wip-doc-2025-06-25-backport-64163-to-squid
squid: doc: Fix unterminated inline literal in ceph-conf.rst
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Adam King [Tue, 1 Jul 2025 15:52:05 +0000 (11:52 -0400)]
Merge pull request #60360 from adk3798/squid-ganesha-set-io-flusher-fail-true
squid: mgr/cephadm: add "allow_set_io_flusher_fail = true;" to ganesha conf
Reviewed-by: John Mulligan <jmulligan@redhat.com>
Adam King [Tue, 1 Jul 2025 15:50:29 +0000 (11:50 -0400)]
Merge pull request #59932 from adk3798/wip-68138-squid
squid: mgr/cephadm: open ceph-exporter when firewalld is enabled
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: John Mulligan <jmulligan@redhat.com>
Casey Bodley [Tue, 1 Jul 2025 15:14:24 +0000 (11:14 -0400)]
Merge pull request #63567 from cbodley/wip-70374-squid
squid: rgw: trigger resharding of versioned buckets sooner
Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>
Adam King [Tue, 1 Jul 2025 14:56:06 +0000 (10:56 -0400)]
Merge pull request #64081 from adk3798/wip-67499-squid
squid: mgr/nfs: scrape nfs monitoring endpoint
Reviewed-by: Shweta Bhosale <Shweta.Bhosale1@ibm.com>
Adam King [Tue, 1 Jul 2025 14:51:13 +0000 (10:51 -0400)]
Merge pull request #62593 from adk3798/squid-cephadm-sidecar-redeploy
squid: cephadm: stop sidecar systemd units when restarting main units
Reviewed-by: Shweta Bhosale <Shweta.Bhosale1@ibm.com>
Adam King [Tue, 1 Jul 2025 14:50:10 +0000 (10:50 -0400)]
Merge pull request #61905 from adk3798/squid-stop-orch-on-cleanup
squid: qa/cephadm: stop cephadm mgr module during cleanup
Reviewed-by: Shweta Bhosale <Shweta.Bhosale1@ibm.com>
Adam King [Tue, 1 Jul 2025 14:28:20 +0000 (10:28 -0400)]
Merge pull request #61902 from adk3798/squid-cephadm-fix-vrrp-typo
squid: mgr/cephadm: fix typo with vrrp_interfaces in keepalive setup
Reviewed-by: Shweta Bhosale <Shweta.Bhosale1@ibm.com>
Adam King [Tue, 1 Jul 2025 14:26:41 +0000 (10:26 -0400)]
Merge pull request #61350 from adk3798/squid-cephadm-rgw-no-multisite-traffic
squid: mgr/cephadm: allow disabling rgw_run_sync_thread through spec
Reviewed-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
Reviewed-by: Shweta Bhosale <Shweta.Bhosale1@ibm.com>
Ville Ojamo [Mon, 30 Jun 2025 07:30:34 +0000 (14:30 +0700)]
doc/rados/configuration: Small improvements in ceph-conf.rst
Fix a missing space typo.
Use title case in section titles.
Use ref for hyperlink to a section that already has a label instead of
linking to title text of the section.
Use privileged command prompt for all ceph commands except ceph commands
that invoke help.
Use INI preformatted block for last remaining block that was just using
plain preformatted.
Signed-off-by: Ville Ojamo <14869000+bluikko@users.noreply.github.com>
(cherry picked from commit
6687c9767d9764f34d7099ba6980992dd8ae8737 )
Kefu Chai [Sun, 29 Jun 2025 02:55:30 +0000 (10:55 +0800)]
doc/mgr/crash.rst: remove outdated module enabling instructions
The crash module has been enabled by default since commit
18f253aa in
Nautilus and is now in the always_on_modules list. However, the
documentation still contained instructions for manually enabling it.
When users followed these outdated instructions, they encountered:
```
module 'crash' is already enabled (always-on)
```
The module cannot be disabled either. Running:
```
ceph mgr module disable crash
```
Returns the error:
```
Error EINVAL: module 'crash' cannot be disabled (always-on)
```
In this change, we remove the obsolete enabling instructions and clarify
that this module is always active and cannot be disabled.
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
(cherry picked from commit
0fcd7677586f7edf3eb091420a8ace0c4f887167 )
Yuri Weinstein [Mon, 30 Jun 2025 17:09:08 +0000 (10:09 -0700)]
Merge pull request #64227 from adamemerson/wip-71577-squid
squid: qa/rgw: fix perl tests missing Amazon::S3 module
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Mark Kogan <mkogan@redhat.com>
Kefu Chai [Wed, 25 Jun 2025 04:14:36 +0000 (12:14 +0800)]
mgr/dashboard: Fix inline markup warning in API documentation
Remove trailing space from summary field that was causing Sphinx build
warning.
Sphinx was generating a warning due to malformed inline markup:
```
/home/kefu/dev/ceph/doc/mgr/ceph_api/index.rst:3349: WARNING: Inline strong start-string without end-string.`
```
The openapi directive appears to convert trailing spaces into asterisk
markers, creating unterminated strong markup. This change removes the
trailing space to eliminate the warning and maintain consistency with
other entries in the file.
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
(cherry picked from commit
5f1dc9af57b0398c33226410f801d16feed823f2 )
Mark Kogan [Wed, 25 Jun 2025 12:21:49 +0000 (12:21 +0000)]
qa/rgw: fix perl tests missing Amazon::S3 module
and a second case where perl tests can fail without error output
1. fix errors like: `Can't locate Amazon/S3.pm in @INC (you may need to
install the Amazon::S3 module)`
by priming the perl tests with installing the Amazon::S3 module from cpan
ex:
```
2025-06-23T19:18:40.162 INFO:tasks.workunit.client.0.smithi090.stderr:Can't locate Amazon/S3.pm in @INC (you may need to install the Amazon::S3 module) (@INC contains: /usr/local/lib64/perl5/5.32 ...
```
2. log an error when RGW process is not detected
Fixes: https://tracker.ceph.com/issues/71577
Signed-off-by: Mark Kogan <mkogan@redhat.com>
(cherry picked from commit
7faa23f160c9f4b40d25fe27f2345dbf999b0c84 )
Conflicts:
qa/suites/rgw/multifs/0-install.yaml
- Doesn't exist in this branch, or support for it, so duplicated in
individual tests.
qa/suites/rgw/multifs/tasks/rgw_bucket_quota.yaml
qa/suites/rgw/multifs/tasks/rgw_multipart_upload.yaml
qa/suites/rgw/multifs/tasks/rgw_user_quota.yaml
- Has overrides no longer needed in main
Fixes: https://tracker.ceph.com/issues/71873
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
Ilya Dryomov [Fri, 27 Jun 2025 14:29:35 +0000 (16:29 +0200)]
Merge pull request #64196 from idryomov/wip-71838-squid
squid: librbd/migration/QCOWFormat: don't complete read_clusters() inline
Reviewed-by: Ramana Raja <rraja@redhat.com>
Ilya Dryomov [Fri, 27 Jun 2025 14:28:32 +0000 (16:28 +0200)]
Merge pull request #64092 from idryomov/wip-70951-squid
squid: rbd-mirror: release lock before calling m_async_op_tracker.finish_op()
Reviewed-by: VinayBhaskar-V <vvarada@redhat.com>
Ilya Dryomov [Fri, 27 Jun 2025 14:27:39 +0000 (16:27 +0200)]
Merge pull request #64097 from idryomov/wip-71335-squid
squid: librbd/cache/pwl: fix memory leak in SyncPoint persist context cleanup
Reviewed-by: Ramana Raja <rraja@redhat.com>
Zac Dover [Thu, 26 Jun 2025 20:28:36 +0000 (06:28 +1000)]
Merge pull request #64113 from zdover23/wip-doc-2025-06-23-backport-64103-to-squid
squid: doc/radosgw: improve "pubsub_push_pending" info
Reviewed-by: Yuval Lifshitz <ylifshit@ibm.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Lorenz Bausch [Thu, 24 Apr 2025 09:55:45 +0000 (11:55 +0200)]
common/options: fix typo in description
Signed-off-by: Lorenz Bausch <info@lorenzbausch.de>
(cherry picked from commit
aa54c08eb01efa4f048cc8fba9f909e0226ac905 )
Deepika Upadhyay [Mon, 28 Oct 2024 09:19:52 +0000 (14:49 +0530)]
rgw: make keystone work without admin token(service ac requirement)
Ceph RGW admin credentials must not be a requirement.
Both ec2 auth and keystone token validation work without an admin token.
And the user token verification will use its own token. The only
requirement for the service admin user token is the allow_expired, but
in our case we don't use this parameter.
fixes: https://tracker.ceph.com/issues/68327
Co-authored-by: @kayrus
Signed-off-by: Deepika Upadhyay <deepika.upadhyay@clyso.com>
(cherry picked from commit
55ce1782e159190fd9202b6e270a1a2c470b0626 )
Ilya Dryomov [Wed, 25 Jun 2025 10:24:35 +0000 (12:24 +0200)]
librbd/migration/QCOWFormat: don't complete read_clusters() inline
When the cluster needs to be read, the completion is posted to ASIO.
However, in the two special cases (cluster DNE and zero cluster), the
completion is completed inline at the moment. This violates invariants
and can eventually lead to a lockup. For example, in a scenario of
a read from a clone image whose parent is under migration:
io::ObjectReadRequest::read_parent()
io::util::read_parent()
< image_lock is taken for read >
io::ImageDispatchSpec::send()
migration::ImageDispatch::read()
migration::QCOWFormat::ReadRequest::send()
...
migration::QCOWFormat::ReadRequest::read_clusters()
< cluster DNE >
migration::QCOWFormat::ReadRequest::handle_read_clusters()
io::AioCompletion::complete()
io::ObjectReadRequest::copyup()
is_copy_on_read()
< image_lock is taken for read >
copyup() expects to be called with no locks held, but going through
QCOWFormat in the "cluster DNE" case essentially maintains image_lock
taken in read_parent() and then it's taken again by the same thread in
is_copy_on_read(). Under pthreads, it's not a problem:
A thread may hold multiple concurrent read locks on rwlock (that is,
successfully call the pthread_rwlock_rdlock() function n times). If
so, the thread must perform matching unlocks (that is, it must call
the pthread_rwlock_unlock() function n times).
But according to C++ standard it's undefined behavior:
If lock_shared is called by a thread that already owns the mutex in
any mode (exclusive or shared), the behavior is undefined.
Other, longer and more elaborate, call chains are possible too and
there it may end up being a write lock, a tripped assertion, etc. To
avoid this, make the special cases in read_clusters() behave the same
as the main path.
Fixes: https://tracker.ceph.com/issues/71838
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit
a02cc13191d5e695620791c883ff1460d2e42f57 )
Ilya Dryomov [Wed, 25 Jun 2025 10:55:06 +0000 (12:55 +0200)]
librbd/migration/QCOWFormat: rename handle_read_cluster()
... to handle_read_clusters() as it's a callback for read_clusters().
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit
9d9c73435341f98cecf0a450357408f8d49624fa )
Zac Dover [Wed, 25 Jun 2025 13:11:36 +0000 (23:11 +1000)]
Merge pull request #64155 from zdover23/wip-doc-2025-06-25-backport-64107-to-squid
squid: doc/radosgw: remove "pubsub_event_triggered"
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Yuval Lifshitz <ylifshit@ibm.com>
afreen23 [Wed, 25 Jun 2025 09:52:44 +0000 (15:22 +0530)]
Merge pull request #64132 from afreen23/wip-71808-squid
squid: mgr/dashboard: Add --force flag for listeners
Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Kefu Chai [Wed, 25 Jun 2025 03:34:50 +0000 (11:34 +0800)]
doc: Fix unterminated inline literal in ceph-conf.rst
Add missing space after closing backticks to properly terminate inline literal.
Sphinx was generating a warning due to an unterminated inline literal
string:
```
/home/kefu/dev/ceph/doc/rados/configuration/ceph-conf.rst:320: WARNING: Inline literal start-string without end-string.
```
This fix ensures the inline literal is properly closed and eliminates the
build warning.
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
(cherry picked from commit
7f79f3d6aa7f71c9b2434b843036a3f1da660231 )
Afreen Misbah [Mon, 16 Jun 2025 15:16:39 +0000 (20:46 +0530)]
mgr/dashboard: Add --force flag for listeners
Fixes https://tracker.ceph.com/issues/71685
Signed-off-by: Afreen Misbah <afreen@ibm.com>
(cherry picked from commit
604d351a4e7bbf47baf57e10f67219a2eea919e0 )
Conflicts:
src/pybind/mgr/dashboard/frontend/src/app/shared/api/nvmeof.service.ts
src/pybind/mgr/dashboard/frontend/src/app/ceph/block/nvmeof-listeners-list/nvmeof-listeners-list.component.ts
Kefu Chai [Wed, 25 Jun 2025 03:50:24 +0000 (11:50 +0800)]
doc/dev/config: Document how to use :confval: directive for config options
Add comprehensive guide for documenting configuration options using the
:confval: directive, including naming conventions and cross-referencing.
Previously, the documentation lacked guidance on using the :confval:
directive and the important distinction between regular config options
and mgr module options (which require the mgr/<module>/ namespace
prefix). This change provides detailed examples and best practices for
properly documenting and referencing both types of configuration options.
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
(cherry picked from commit
d61f9fffac0a1a0c18cbba89e8c43f469ee55c44 )
Yuri Weinstein [Tue, 24 Jun 2025 19:58:50 +0000 (12:58 -0700)]
Merge pull request #64049 from cbodley/wip-71751-squid
squid: fix: the RGW crash caused by special characters
Reviewed-by: Adam Emerson <aemerson@redhat.com>
Yuri Weinstein [Tue, 24 Jun 2025 19:58:21 +0000 (12:58 -0700)]
Merge pull request #63928 from cbodley/wip-71671-squid
squid: qa/rgw: bump maven version in hadoop task to resolve 404 Not Found
Reviewed-by: Adam Emerson <aemerson@redhat.com>
Yuri Weinstein [Tue, 24 Jun 2025 19:57:42 +0000 (12:57 -0700)]
Merge pull request #61162 from ivancich/wip-69182-squid
squid: Revert "rgw/auth: Fix the return code returned by AuthStrategy,"
Reviewed-by: Adam Emerson <aemerson@redhat.com>
Zac Dover [Mon, 23 Jun 2025 08:07:40 +0000 (18:07 +1000)]
doc/radosgw: remove "pubsub_event_triggered"
Remove "pubsub_event_triggered" from the list of "Notification
Performance Statistics". It is obsolete.
Fixes: https://tracker.ceph.com/issues/71789
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit
44dc57fc15749583fc13560c9409b7687df7c223 )
Stellios Williams [Mon, 23 Jun 2025 10:54:31 +0000 (20:54 +1000)]
doc: Fixed a spelling error.
Corrected communicte to communicate
Signed-off-by: Instelligence.io <github@instelligence.io>
(cherry picked from commit
c328902e3929d9841f952948b0336ec5b20d36fa )
Zac Dover [Tue, 24 Jun 2025 17:45:56 +0000 (03:45 +1000)]
Merge pull request #64139 from zdover23/wip-doc-2025-06-25-backport-64106-to-squid
squid: doc/radosgw: add "persistent_topic_size"
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Zac Dover [Tue, 24 Jun 2025 16:42:33 +0000 (02:42 +1000)]
Merge pull request #64126 from zdover23/wip-doc-2025-06-24-backport-64104-to-squid
squid: doc/radosgw: remove "pubsub_event_lost"
Reviewed-by: Yuval Lifshitz <ylifshit@ibm.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Zac Dover [Mon, 23 Jun 2025 08:35:05 +0000 (18:35 +1000)]
doc/radosgw: add "persistent_topic_size"
Add "persistent_topic_size" to the list of "Notification Performance
Statistics" in doc/radosgw/notifications.rst.
Fixes: https://tracker.ceph.com/issues/71792
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit
5f96ade1734d1ab7053b792a1df4e316e31691a5 )
Jos Collin [Tue, 6 May 2025 11:50:39 +0000 (17:20 +0530)]
qa: fix test_cephfs_mirror_stats failure
* Don't create huge files that results in 'No space left on device'.
* Relax last_synced_end > last_synced_start check, so that
the test wouldn't fail even if 'counter dump' delays getting updated
values within a particular snapshot sync.
Fixes: https://tracker.ceph.com/issues/71186
Signed-off-by: Jos Collin <jcollin@redhat.com>
(cherry picked from commit
9738b8d36275fda42d847058aab55ba1e6e6e7fc )
Jos Collin [Fri, 13 Dec 2024 02:53:07 +0000 (08:23 +0530)]
qa: fix test_cephfs_mirror_stats failure
100MB files would take less than a second to sync, which makes no difference
in 'last_synced_end' and the test fails intermittently. We need to increase the
size of the files, as the time/duration is determined only in seconds.
Because of this, it also needs more sleep time before checking the status.
Fixes: https://tracker.ceph.com/issues/69232
Signed-off-by: Jos Collin <jcollin@redhat.com>
(cherry picked from commit
005e492288b71c641f33396cc8b13cc53d52b478 )
Jos Collin [Thu, 8 Aug 2024 05:22:14 +0000 (10:52 +0530)]
qa: do the set/get attribute on the remote filesystem
Fixes: https://tracker.ceph.com/issues/67435
Signed-off-by: Jos Collin <jcollin@redhat.com>
(cherry picked from commit
9a46c52387fbdce580dd50584f9ea01469de6d51 )
SrinivasaBharathKanta [Tue, 24 Jun 2025 06:21:26 +0000 (11:51 +0530)]
Merge pull request #63718 from NitzanMordhai/wip-71542-squid
squid: qa/suites: wait longer before stopping OSDs with valgrind
Zac Dover [Mon, 23 Jun 2025 08:18:07 +0000 (18:18 +1000)]
doc/radosgw: remove "pubsub_event_lost"
Remove "pubsub_event_lost" from the list of "Notification Performance
Statistics" in doc/radosgw/notifications.rst. "pubsub_event_lost" is now
obsolete.
Fixes: https://tracker.ceph.com/issues/71790
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit
b308f50d1e0c2d238c3b2bf54df99cc7ac2ac679 )
SrinivasaBharathKanta [Mon, 23 Jun 2025 23:47:23 +0000 (05:17 +0530)]
Merge pull request #63154 from NitzanMordhai/wip-71224-squid
squid: osd_types: Restore new_object marking for delete missing entries