]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
11 days agorgw/notifications: test refactoring 64662/head
Yuval Lifshitz [Thu, 3 Jul 2025 16:57:39 +0000 (16:57 +0000)]
rgw/notifications: test refactoring

* kafka: pass full broker list to consumer in tests
* kafka: use ip instead of localhost
* kafka: make sure topic exists before consumer start
* kafka: fix zookeeper and broker conf in tests
* kafka: verify receiver in the test
* kafka: tests were not running (Fixes: https://tracker.ceph.com/issues/72240)
* kafka: failover tests were failing (Fixes: https://tracker.ceph.com/issues/71585)
* simplify basic tests run command
* v2 migration tests were not running
* fix failing migration tests

Signed-off-by: Yuval Lifshitz <ylifshit@ibm.com>
11 days agoMerge pull request #64824 from bluikko/doc-kmip-improvements-radosgw
Anthony D'Atri [Tue, 5 Aug 2025 12:51:35 +0000 (08:51 -0400)]
Merge pull request #64824 from bluikko/doc-kmip-improvements-radosgw

doc/radosgw: Small improvements in kmip.rst

11 days agoMerge pull request #64823 from bluikko/doc-s3-notification-compatibility-radosgw
Anthony D'Atri [Tue, 5 Aug 2025 12:15:31 +0000 (08:15 -0400)]
Merge pull request #64823 from bluikko/doc-s3-notification-compatibility-radosgw

doc/radosgw: Small improvements in s3-notification-compatibility.rst

11 days agodoc/radosgw: Small improvements in kmip.rst 64824/head
Ville Ojamo [Tue, 5 Aug 2025 06:08:09 +0000 (13:08 +0700)]
doc/radosgw: Small improvements in kmip.rst

Major rewrite of the last section that is a copypasta from vault.rst:
- "engines" are relevant only to Hashicorp Vault and not KMIP
- leave only 1 copy of the 2 identical CLI examples
- talk about KMIP and not Vault, it is an alternative to Vault
Also fix other mention of "Vault" into "KMIP".

Auto-generate contents list instead of hardcoding it.

Use '=' in ceph.conf example, I believe ':' cannot be used.

Capitalize "Ceph", "Python", "KMIP", "OpenSSL", "PyKMIP" consistently.
Call it consistently "Ceph Object Gateway".
Format "pykmip" in italic when referring to the binary.
Hyphen in "PEM-encoded" along with capitalization.
Use double backticks for data.

Spell out a lonesome number "1" in text.
Fix typo "correspondent" to "corresponding".

Promptify CLI commands.

Use title case consistently in section titles.

Linkify mention of Ceph configuration file.

Signed-off-by: Ville Ojamo <14869000+bluikko@users.noreply.github.com>
12 days agoMerge pull request #64388 from rhcs-dashboard/reusable-popover
Aashish Sharma [Tue, 5 Aug 2025 05:37:05 +0000 (11:07 +0530)]
Merge pull request #64388 from rhcs-dashboard/reusable-popover

mgr/dashboard: add reusable carbon popover

Reviewed-by: Afreen Misbah <afreen@ibm.com>
12 days agoMerge pull request #64628 from rhcs-dashboard/accounts-enhancements
Aashish Sharma [Tue, 5 Aug 2025 05:32:15 +0000 (11:02 +0530)]
Merge pull request #64628 from rhcs-dashboard/accounts-enhancements

mgr/dashboard: user accounts enhancements

Reviewed-by: Nizamudeen A <nia@redhat.com>
12 days agodoc/radosgw: Small improvements in s3-notification-compatibility.rst 64823/head
Ville Ojamo [Tue, 5 Aug 2025 05:14:13 +0000 (12:14 +0700)]
doc/radosgw: Small improvements in s3-notification-compatibility.rst

Attempt a small fix to a grammatical error in a sentence.
It should also refer to "below" and not "above", probably.

End full sentences in full stops.

Indent an unordered list consistently so that it renders consistently
with the same bullets.
Also indent all various blocks at the same columns consistently.

Wrap lines before column 80 while we're at it.

Signed-off-by: Ville Ojamo <14869000+bluikko@users.noreply.github.com>
12 days agoMerge pull request #64376 from smanjara/wip-fix-full-sync-urlencoding
anrao19 [Tue, 5 Aug 2025 05:00:48 +0000 (10:30 +0530)]
Merge pull request #64376 from smanjara/wip-fix-full-sync-urlencoding

rgw/multisite: url-encode list_bucket query param 'key-marker'

12 days agoMerge pull request #63063 from ShirleyFei/add-read-latency
Yite Gu [Tue, 5 Aug 2025 02:29:49 +0000 (10:29 +0800)]
Merge pull request #63063 from ShirleyFei/add-read-latency

kv/rocksdb: raise rocksdb get latency perf counter

12 days agoMerge pull request #64671 from avanthakkar/add-share-label-smb-metadata-metric
Avan [Mon, 4 Aug 2025 18:16:07 +0000 (23:46 +0530)]
Merge pull request #64671 from avanthakkar/add-share-label-smb-metadata-metric

mgr/prometheus: add share name as label to SMB_METADATA metric

Reviewed-by: John Mulligan <jmulligan@redhat.com>
Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
12 days agoMerge pull request #64141 from rzarzynski/wip-bug-69805
Radoslaw Zarzynski [Mon, 4 Aug 2025 17:58:39 +0000 (19:58 +0200)]
Merge pull request #64141 from rzarzynski/wip-bug-69805

osd: _send_boot() doesn't put stale, cached cluster_addrs in MOSDBoot

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
12 days agoMerge pull request #63227 from bluikko/doc-group-b-ref-radosgw
Anthony D'Atri [Mon, 4 Aug 2025 17:57:13 +0000 (13:57 -0400)]
Merge pull request #63227 from bluikko/doc-group-b-ref-radosgw

doc/radosgw: Use ref for hyperlinks, 2nd batch

12 days agoMerge pull request #64808 from bluikko/doc-services-tracing-improvements-cephadm
Anthony D'Atri [Mon, 4 Aug 2025 17:45:31 +0000 (13:45 -0400)]
Merge pull request #64808 from bluikko/doc-services-tracing-improvements-cephadm

doc/cephadm: Small improvements in services/tracing.rst

12 days agoMerge pull request #64221 from tchaikov/wip-ec-test-fix-leak
Kefu Chai [Mon, 4 Aug 2025 10:01:29 +0000 (18:01 +0800)]
Merge pull request #64221 from tchaikov/wip-ec-test-fix-leak

test/erasure-code: fix memory leak when erasure_code_init() fails

Reviewed-by: Matan Breizman <mbreizma@redhat.com>
12 days agoMerge PR #60326 into main
Venky Shankar [Mon, 4 Aug 2025 07:06:12 +0000 (12:36 +0530)]
Merge PR #60326 into main

* refs/pull/60326/head:

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>
12 days agodoc/radosgw: Use ref for hyperlinks, 2nd batch 63227/head
Ville Ojamo [Mon, 12 May 2025 09:01:44 +0000 (16:01 +0700)]
doc/radosgw: Use ref for hyperlinks, 2nd batch

Use validated ":ref:" hyperlinks instead of "external links" in "target
definitions" when linking within the Ceph docs:
- Add a label at beginning of referenced files if missing.
- Remove unused "target definitions".
- Updated links targeting files: compression encryption keystone

Cleaned hyperlinks usage in kmip.rst:
- Some links were using anonymous links (double underscore) unnecessarily.
- Some links were not using backticks, add for consistency.
- Move anonymous link definition to after the ordered list to avoid
  unnecessary empty line between list items.

Use an already existing label for 2 intra-docs links that used full URLs.
Use an already existing label for intra-docs link instead of a file name
reference in s3/authentication.rst.

The rendered PR should look the same as the old docs, only differing in
the source RST.

Signed-off-by: Ville Ojamo <14869000+bluikko@users.noreply.github.com>
12 days agodoc/cephadm: Small improvements in services/tracing.rst 64808/head
Ville Ojamo [Mon, 4 Aug 2025 06:06:38 +0000 (13:06 +0700)]
doc/cephadm: Small improvements in services/tracing.rst

Use ref instead of a full URL link and add label for it in
doc/jaegertracing/index.rst.

Capitalize "Ceph", "Jaeger", "ElasticSearch" consistently.
Start sentences with capital case consistently.
Fix a typo.

Wrap lines a bit before column 80.

Use an ordered list instead of hardcoding list numbers in separate
paragraphs.

Don't use ordered list for items that do not both fit under the text
paragraph introducing the list.
Rewrite the sentences to be more consistent and hopefully more correct.

Add articles that I believe should be there, also for consistency with
the previous paragraph.

Signed-off-by: Ville Ojamo <14869000+bluikko@users.noreply.github.com>
12 days agoMerge pull request #64521 from tchaikov/wip-run-cli-tests-with-asan-supp
Kefu Chai [Mon, 4 Aug 2025 05:59:48 +0000 (13:59 +0800)]
Merge pull request #64521 from tchaikov/wip-run-cli-tests-with-asan-supp

test/run-cli-tests: inherit ASAN_OPTIONS and LSAN_OPTIONS

Reviewed-by: Matan Breizman <mbreizma@redhat.com>
12 days agoMerge pull request #64494 from vshankar/wip-71615
Venky Shankar [Mon, 4 Aug 2025 05:56:10 +0000 (11:26 +0530)]
Merge pull request #64494 from vshankar/wip-71615

qa/suites/upgrade: update ignorelist with cephfs specific warnings (under stress-split)

Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
12 days agoMerge pull request #62948 from MaxKellermann/cephfs_includes
Venky Shankar [Mon, 4 Aug 2025 05:52:11 +0000 (11:22 +0530)]
Merge pull request #62948 from MaxKellermann/cephfs_includes

cephfs: include cleanup

Reviewed-by: Venky Shankar <vshankar@redhat.com>
13 days agoMerge pull request #64803 from bluikko/doc-external-links-to-internal
Anthony D'Atri [Mon, 4 Aug 2025 05:07:46 +0000 (01:07 -0400)]
Merge pull request #64803 from bluikko/doc-external-links-to-internal

doc: Use ref instead of full URLs for intra-docs links

13 days agoMerge pull request #64806 from nh2/docs-ec-change-crush-rule-profile
Anthony D'Atri [Mon, 4 Aug 2025 02:19:10 +0000 (22:19 -0400)]
Merge pull request #64806 from nh2/docs-ec-change-crush-rule-profile

doc: Erasure Code: Document set CRUSH rule precedence vs EC profile

13 days agodoc: Erasure Code: Document set CRUSH rule precedence vs EC profile 64806/head
Niklas Hambüchen [Sun, 3 Aug 2025 13:36:35 +0000 (13:36 +0000)]
doc: Erasure Code: Document set CRUSH rule precedence vs EC profile

Signed-off-by: Niklas Hambüchen <mail@nh2.me>
2 weeks agodoc: Use ref instead of full URLs for intra-docs links 64803/head
Ville Ojamo [Sat, 2 Aug 2025 06:26:14 +0000 (13:26 +0700)]
doc: Use ref instead of full URLs for intra-docs links

Labels mostly existed already but add labels in 2 files.

Add missing closing quotation mark in
rados/troubleshooting/log-and-debug.rst.

Signed-off-by: Ville Ojamo <14869000+bluikko@users.noreply.github.com>
2 weeks agoMerge pull request #64789 from bluikko/doc-rgw-policy-check-links-man
Anthony D'Atri [Fri, 1 Aug 2025 16:08:25 +0000 (12:08 -0400)]
Merge pull request #64789 from bluikko/doc-rgw-policy-check-links-man

doc/man/8: Fix links in rgw-policy-check.rst

2 weeks agoMerge pull request #64790 from bluikko/doc-monitoring-osd-pg-mclock-links-rados
Anthony D'Atri [Fri, 1 Aug 2025 13:45:55 +0000 (09:45 -0400)]
Merge pull request #64790 from bluikko/doc-monitoring-osd-pg-mclock-links-rados

doc/rados: Fix more mClock links in ops/monitoring-osd-pg.rst

2 weeks agoMerge pull request #64792 from bluikko/doc-ceph-objectstore-tool-link-man
Anthony D'Atri [Fri, 1 Aug 2025 13:30:42 +0000 (09:30 -0400)]
Merge pull request #64792 from bluikko/doc-ceph-objectstore-tool-link-man

doc/man/8: Fix link in ceph-objectstore-tool.rst

2 weeks agoMerge pull request #64797 from jecluis/wip-mon-stretch-docs
Anthony D'Atri [Fri, 1 Aug 2025 13:09:11 +0000 (09:09 -0400)]
Merge pull request #64797 from jecluis/wip-mon-stretch-docs

 doc: fix formatting, typos in mon elections and stretch mode

2 weeks agoMerge pull request #64502 from aainscow/ec_reduce_rebalance_reads
Alex Ainscow [Fri, 1 Aug 2025 13:08:41 +0000 (14:08 +0100)]
Merge pull request #64502 from aainscow/ec_reduce_rebalance_reads

osd: Reduce reads when rebalancing healthy Erasure Coded PGs

Reviewed-by: Bill Scales <bill_scales@uk.ibm.com>
2 weeks agomgr/dashboard: user accounts enhancements 64628/head
Naman Munet [Tue, 22 Jul 2025 17:08:42 +0000 (22:38 +0530)]
mgr/dashboard: user accounts enhancements

fixes: https://tracker.ceph.com/issues/72072

PR covers:
1) Displaying account name instead of account id in bucket list page & bucket edit form for account owned buckets
2) non-root account user can now be assigned with managed policies with which they can perform operations
3) The root user indication shifted next to username in users list rather than on Account Name with a new icon.

Signed-off-by: Naman Munet <naman.munet@ibm.com>
2 weeks agodoc: fix formatting, typos in mon elections and stretch mode 64797/head
Joao Eduardo Luis [Fri, 1 Aug 2025 11:29:03 +0000 (11:29 +0000)]
doc: fix formatting, typos in mon elections and stretch mode

Signed-off-by: Joao Eduardo Luis <joao@clyso.com>
2 weeks agodoc/man/8: Fix link in ceph-objectstore-tool.rst 64792/head
Ville Ojamo [Fri, 1 Aug 2025 08:22:11 +0000 (15:22 +0700)]
doc/man/8: Fix link in ceph-objectstore-tool.rst

Fix another occurrence of invalid Ceph docs website link that resulted
in a 404.

Signed-off-by: Ville Ojamo <14869000+bluikko@users.noreply.github.com>
2 weeks agoosd: Optimised EC avoids ever reading more than K shards (if plugin supports it). 64502/head
Alex Ainscow [Mon, 14 Jul 2025 15:55:40 +0000 (16:55 +0100)]
osd: Optimised EC avoids ever reading more than K shards (if plugin supports it).

Plugins which support partial reads, should never need more than k shards
to read the data, even if some shards have failed. However, rebalancing commonly
requests k + m shards, as very frequently all shards are moved. If this occurs
and all k + m shards are online, the read will be achieved by reading ALL shards
rather than just reading k shards. This commit fixes that issue.

The problem is that we don't want to change the API to the old EC, so we cannot
update the plugin behaviour here.  Instead, the EC code itself will reduce
the number of shards it tells minimum_to_decode about.

In a comment we note that bitset_set performance could be improved using _pdep_u64.
This would require fiddly platform-specific code and would likely not show
any performance improvements for most applications. The majority of the calls to
this function will be with a bitset that has <=n set bits and will never enter this
if statement. When there are >n bits set we are going to save one or more read I/Os,
the cost of the for loop is insignificant vs this saving. I have left the comment
in as a hint to future users of this function.

Further notes were made in a review comment that are worth recording:

- If performance is limited by the drives, then less read I/Os is a clear advantage.
- If performance is limited by the network then less remote read I/Os is a clear advantage.
- If performance is limited by the CPU then the CPU cost of M unnecessary remote
  read I/Os (messenger+bluestore) is almost certainly more than the cost of doing an
  extra encode operation to calculate the coding parities.
- If performance is limited by system memory bandwidth the encode+crc generation
  has less overhead than the read+bluestore crc check+messenger overheads.

Longer term this logic should probably be pushed into the plugins, in particular
to give LRC the opportunity to optimize for locality of the shards. Reason for
not doing this now is that it would be messy because the legacy EC code cannot
support this optimization and LRC isn't yet optimizing for locality

Signed-off-by: Alex Ainscow <aainscow@uk.ibm.com>
2 weeks agodoc/rados: Fix more mClock links in ops/monitoring-osd-pg.rst 64790/head
Ville Ojamo [Fri, 1 Aug 2025 05:49:09 +0000 (12:49 +0700)]
doc/rados: Fix more mClock links in ops/monitoring-osd-pg.rst

Inspired by #64752 these are the last few external link definitions in
main that incorrectly include the .rst extension.

There is a strong case for eventually moving all internal links to :doc:
and/or :ref:.

Signed-off-by: Ville Ojamo <14869000+bluikko@users.noreply.github.com>
2 weeks agodoc/man/8: Fix links in rgw-policy-check.rst 64789/head
Ville Ojamo [Fri, 1 Aug 2025 05:41:05 +0000 (12:41 +0700)]
doc/man/8: Fix links in rgw-policy-check.rst

Fix a link to the Ceph docs website that resulted in a 404.

Remove an unused external link definition.

Signed-off-by: Ville Ojamo <14869000+bluikko@users.noreply.github.com>
2 weeks agoMerge pull request #64754 from rhcs-dashboard/fix-cypress-tests
afreen23 [Thu, 31 Jul 2025 21:57:12 +0000 (03:27 +0530)]
Merge pull request #64754 from rhcs-dashboard/fix-cypress-tests

Fix cypress tests

Reviewed-by: Afreen Misbah <afreen@ibm.com>
2 weeks agoMerge pull request #64766 from zdover23/wip-doc-2025-07-31-cephfs-ceph-dokan
Anthony D'Atri [Thu, 31 Jul 2025 16:21:19 +0000 (12:21 -0400)]
Merge pull request #64766 from zdover23/wip-doc-2025-07-31-cephfs-ceph-dokan

doc/cephfs: edit ceph-dokan.rst (3 of x)

2 weeks agoMerge pull request #64624 from cbodley/wip-70965
Adam Emerson [Thu, 31 Jul 2025 15:53:40 +0000 (11:53 -0400)]
Merge pull request #64624 from cbodley/wip-70965

common/async: remove null_yield support for spawn_throttle

Reviewed-by: Adam C. Emerson <aemerson@redhat.com>
2 weeks agomgr/dashboard: fix cypress tests 64754/head
Aashish Sharma [Wed, 30 Jul 2025 09:26:23 +0000 (14:56 +0530)]
mgr/dashboard: fix cypress tests

Signed-off-by: Aashish Sharma <aasharma@redhat.com>
2 weeks agoMerge pull request #64038 from NitzanMordhai/wip-nitzan-mon-ops-historic-dump
SrinivasaBharathKanta [Thu, 31 Jul 2025 13:35:40 +0000 (19:05 +0530)]
Merge pull request #64038 from NitzanMordhai/wip-nitzan-mon-ops-historic-dump

monitor: Enhance historic ops command output and error handling

2 weeks agomgr/dashboard: add reusable carbon popover 64388/head
Naman Munet [Tue, 8 Jul 2025 15:26:34 +0000 (20:56 +0530)]
mgr/dashboard: add reusable carbon popover

https://tracker.ceph.com/issues/72002

Signed-off-by: Naman Munet <naman.munet@ibm.com>
2 weeks agoMerge pull request #64708 from rhcs-dashboard/fix-bucket-replication
afreen23 [Thu, 31 Jul 2025 12:16:06 +0000 (17:46 +0530)]
Merge pull request #64708 from rhcs-dashboard/fix-bucket-replication

mgr/dashboard: fix bucket replication disable

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Abhishek Desai <abhishek.desai1@ibm.com>
2 weeks agoMerge pull request #64631 from rhcs-dashboard/details-card-component
afreen23 [Thu, 31 Jul 2025 12:10:14 +0000 (17:40 +0530)]
Merge pull request #64631 from rhcs-dashboard/details-card-component

mgr/dashboard: introduce details card component

Reviewed-by: Naman Munet <nmunet@redhat.com>
Reviewed-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
2 weeks agoMerge pull request #64638 from rhcs-dashboard/alert-panel-variant
afreen23 [Thu, 31 Jul 2025 12:09:21 +0000 (17:39 +0530)]
Merge pull request #64638 from rhcs-dashboard/alert-panel-variant

mgr/dashboard: alert panel enhancements

Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Aashish Sharma <aasharma@redhat.com>
2 weeks agoMerge pull request #64680 from afreen23/cypress-suppress
afreen23 [Thu, 31 Jul 2025 09:01:49 +0000 (14:31 +0530)]
Merge pull request #64680 from afreen23/cypress-suppress

mgr/dashboard: cypress tests do not fail on failures

Reviewed-by: Naman Munet <nmunet@redhat.com>
2 weeks agoMerge pull request #62992 from rhcs-dashboard/notif-ui
naman munet [Thu, 31 Jul 2025 07:07:46 +0000 (12:37 +0530)]
Merge pull request #62992 from rhcs-dashboard/notif-ui

mgr/dashboard: Create and delete and update s3 notification in dashboard

2 weeks agomgr/dashboard: introduce details card component 64631/head
Naman Munet [Thu, 31 Jul 2025 07:04:51 +0000 (12:34 +0530)]
mgr/dashboard: introduce details card component

fixed test case

Fixes: https://tracker.ceph.com/issues/72246
Signed-off-by: Naman Munet <naman.munet@ibm.com>
2 weeks agodoc/cephfs: edit ceph-dokan.rst (3 of x) 64766/head
Zac Dover [Thu, 31 Jul 2025 05:55:40 +0000 (15:55 +1000)]
doc/cephfs: edit ceph-dokan.rst (3 of x)

Incorporate into doc/cephfs/ceph-dokan.rst the suggestions made by
Anthony D'Atri in https://github.com/ceph/ceph/pull/64737, and make a
few other small improvements to the English language in that file.

Signed-off-by: Zac Dover <zac.dover@proton.me>
2 weeks agoMerge pull request #64657 from ceph/wip-main-rocky9
David Galloway [Wed, 30 Jul 2025 19:41:14 +0000 (15:41 -0400)]
Merge pull request #64657 from ceph/wip-main-rocky9

build: Rocky 9 support

2 weeks agoMerge pull request #64757 from VinayBhaskar-V/wip-unittest-72325
Ilya Dryomov [Wed, 30 Jul 2025 18:39:22 +0000 (20:39 +0200)]
Merge pull request #64757 from VinayBhaskar-V/wip-unittest-72325

test/rbd-mirror: eliminate a race in ResyncRequestedRemoteNotPrimary

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2 weeks agoMerge pull request #64750 from bluikko/doc-bucketops-fixes-plus-radosgw
Anthony D'Atri [Wed, 30 Jul 2025 17:35:24 +0000 (13:35 -0400)]
Merge pull request #64750 from bluikko/doc-bucketops-fixes-plus-radosgw

doc/radosgw: Simple fixes and improvements, links improvements

2 weeks agoMerge pull request #64565 from synarete/ss-samba-metrics-image-devbuilds-centos-amd64
Adam King [Wed, 30 Jul 2025 15:40:07 +0000 (11:40 -0400)]
Merge pull request #64565 from synarete/ss-samba-metrics-image-devbuilds-centos-amd64

mgr/cephadm: use same tag for all samba images

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: John Mulligan <jmulligan@redhat.com>
2 weeks agoMerge pull request #64737 from zdover23/wip-doc-2025-07-29-cephfs-ceph-dokan
Zac Dover [Wed, 30 Jul 2025 13:29:02 +0000 (23:29 +1000)]
Merge pull request #64737 from zdover23/wip-doc-2025-07-29-cephfs-ceph-dokan

doc/cephfs: edit ceph-dokan.rst (2 of x)

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 weeks agotest/rbd-mirror: eliminate a race in ResyncRequestedRemoteNotPrimary 64757/head
VinayBhaskar-V [Wed, 30 Jul 2025 10:10:27 +0000 (10:10 +0000)]
test/rbd-mirror: eliminate a race in ResyncRequestedRemoteNotPrimary

Adjust the wait_for_notification call in TestMockImageReplayerSnapshotReplayer.ResyncRequestedRemoteNotPrimary
to expect 2 notifications instead of 1. This allows the test to correctly wait for both expected events
i.e for finish_sync() and handle_replay_complete(locker, -EREMOTEIO, "remote image demoted"), ensuring the
replayer transitions to STATE_COMPLETE and is_replaying() returns false as intended.

Fixes: https://tracker.ceph.com/issues/72325
Signed-off-by: VinayBhaskar-V <vvarada@redhat.com>
2 weeks agomgr/prometheus: add share name as label to SMB_METADATA metric 64671/head
Avan Thakkar [Thu, 24 Jul 2025 13:25:10 +0000 (18:55 +0530)]
mgr/prometheus: add share name as label to SMB_METADATA metric

Fixes: https://tracker.ceph.com/issues/72068
Signed-off-by: Avan Thakkar <athakkar@redhat.com>
2 weeks agoMerge pull request #64351 from ifed01/wip-ifed-discard-threads-better-lifecycle
Igor Fedotov [Wed, 30 Jul 2025 11:25:42 +0000 (14:25 +0300)]
Merge pull request #64351 from ifed01/wip-ifed-discard-threads-better-lifecycle

blk/kernel: improve DiscardThread life cycle.

Reviewed-by: Yite Gu <guyite@bytedance.com>
2 weeks agoMerge pull request #64060 from zhscn/wip-seastore-2q
Matan Breizman [Wed, 30 Jul 2025 08:03:54 +0000 (11:03 +0300)]
Merge pull request #64060 from zhscn/wip-seastore-2q

crimson/os/seastore: introduce 2Q cache replacement algorithm

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
2 weeks agoMerge pull request #64452 from xxhdx1985126/wip-72087
Matan Breizman [Wed, 30 Jul 2025 07:38:15 +0000 (10:38 +0300)]
Merge pull request #64452 from xxhdx1985126/wip-72087

crimson/os/seastore/epm: make max_generation and gc_formula configurable

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
2 weeks agoMerge pull request #64617 from xxhdx1985126/wip-seastore-invalidate-logical
Matan Breizman [Wed, 30 Jul 2025 07:37:58 +0000 (10:37 +0300)]
Merge pull request #64617 from xxhdx1985126/wip-seastore-invalidate-logical

crimson/os/seastore/logical_child_node: LogicalChildNode should respond to the invalidation event

Reviewed-by: Samuel Just <sjust@redhat.com>
2 weeks agoMerge pull request #63604 from guojidan/kv-tool
Matan Breizman [Wed, 30 Jul 2025 07:25:47 +0000 (10:25 +0300)]
Merge pull request #63604 from guojidan/kv-tool

crimson: Add objectstore tool with partial functionality

Reviewed-by: Aishwarya Mathuria <amathuri@redhat.com>
2 weeks agoqa/suites/upgrade: update ignorelist with cephfs specific warnings (under stress... 64494/head
Venky Shankar [Tue, 15 Jul 2025 04:04:34 +0000 (09:34 +0530)]
qa/suites/upgrade: update ignorelist with cephfs specific warnings (under stress-split)

The warnings are expected as the MDSs are upgraded and restarted.

Fixes: http://tracker.ceph.com/issues/71615
Signed-off-by: Venky Shankar <vshankar@redhat.com>
2 weeks agomds/MDSDaemon: unlock `mds_lock` while shutting down Beacon and others 60326/head
Max Kellermann [Fri, 11 Oct 2024 22:35:13 +0000 (00:35 +0200)]
mds/MDSDaemon: unlock `mds_lock` while shutting down Beacon and others

This fixes a deadlock bug during MDS shutdown:

- the "signal_handler" thread receives the shutdown signal and invokes
  MDSDaemon::suicide() while holding `mds_lock`

- MDSDaemon::suicide() invokes Beacon::send_and_wait() while still
  holding `mds_lock`

- meanwhile, all "ms_dispatch" threads get stuck waiting for
  `mds_lock`, for example in MDCache::upkeep_main() or
  MDSDaemon::ms_dispatch2()

- Beacon::send_and_wait() waits for a `MSG_MDS_BEACON` packet to be
  dispatched (via `cvar` with a timeout)

At this point, even if a `MSG_MDS_BEACON` packet is received by one of
the worker threads, they will put it in the `DispatchQueue`, but no
dispatcher thread will be able to handle it because they are all
stuck.  The cvar.wait_for() call in Beacon::send_and_wait() will
therefore time out and the `MSG_MDS_BEACON` will never be processed.

The proper solution is to unlock `mds_lock` to avoid the dispatchers
from getting stuck.  And in general, we should be holding a lock
strictly only when it is needed and never do blocking calls while
holding a lock.

Fixes: https://tracker.ceph.com/issues/68760
Signed-off-by: Max Kellermann <max.kellermann@ionos.com>
2 weeks agodoc/radosgw: Simple fixes and improvements, links improvements 64750/head
Ville Ojamo [Fri, 18 Jul 2025 05:53:08 +0000 (12:53 +0700)]
doc/radosgw: Simple fixes and improvements, links improvements

Fix table with a column separator problem in s3/bucketops.rst.

Remove whitespaces at end of lines in s3/bucketops.rst.

Linkify mention of multizone into multisite.rst in bucket_logging.rst.

Separate units from numbers with a space in bucket_logging.rst

Consistency in capitalization and full stop usage in table data in
s3-notification-compatibility.rst s3/bucketops.rst.

Use ref for intra-docs link instead of "external links" feature in
s3/bucketops.rst notifications.rst s3.rst, add a label in start of
s3-notification-compatibility.rst for it. Follow label format that seems
to be in the majority.
Use auto-generated link text that ref provides.
Reflow the text in the cell. Extend table syntax width to accommodate
longer text in cell.

Use ref similarly on links to s3/bucketops.rst. Add a label in it and
use it from bucket_logging.rst and notifications.rst.

Delete unused external link definition in s3/bucketops.rst.

Remove multiple whitespace at the end of lines in notifications.rst
s3-notification-compatibility.rst bucketops.rst.

Change tab characters to spaces in indentation in bucketops.rst

Signed-off-by: Ville Ojamo <14869000+bluikko@users.noreply.github.com>
2 weeks agomgr/dashboard: Create and delete and update s3 notification in dashboard 62992/head
pujaoshahu [Fri, 25 Apr 2025 15:48:51 +0000 (21:18 +0530)]
mgr/dashboard: Create and delete and update s3 notification in dashboard

Fixes: https://tracker.ceph.com/issues/70955
Signed-off-by: pujaoshahu <pshahu@redhat.com>
2 weeks agomgr/dasboard: fix pool e2e 64680/head
Afreen Misbah [Tue, 29 Jul 2025 18:01:15 +0000 (23:31 +0530)]
mgr/dasboard: fix pool e2e

- added data-testid for mirroring checkbox

Signed-off-by: Afreen Misbah <afreen@ibm.com>
2 weeks agomgr/dashboard: Fix cephfs tests
Afreen Misbah [Tue, 29 Jul 2025 16:43:01 +0000 (22:13 +0530)]
mgr/dashboard: Fix cephfs tests

-  updated with new cd-usage-bar changes

Signed-off-by: Afreen Misbah <afreen@ibm.com>
2 weeks agomgr/dashboard: fix mirroring e2e
Afreen Misbah [Tue, 29 Jul 2025 16:28:08 +0000 (21:58 +0530)]
mgr/dashboard: fix mirroring e2e

- fixed by using data-testis selector

Signed-off-by: Afreen Misbah <afreen@ibm.com>
2 weeks agomgr/dashboard: fix pool tests
Afreen Misbah [Tue, 29 Jul 2025 16:16:43 +0000 (21:46 +0530)]
mgr/dashboard: fix pool tests

-  added data-testid

Signed-off-by: Afreen Misbah <afreen@ibm.com>
2 weeks agoMerge pull request #64070 from samarahu/samarahu-get-storage-admin
Samarah Uriarte [Tue, 29 Jul 2025 15:22:11 +0000 (10:22 -0500)]
Merge pull request #64070 from samarahu/samarahu-get-storage-admin

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
2 weeks agoMerge pull request #64733 from stackhpc/doc-fix-mclock-links
Anthony D'Atri [Tue, 29 Jul 2025 14:44:34 +0000 (10:44 -0400)]
Merge pull request #64733 from stackhpc/doc-fix-mclock-links

doc: Fix links to mClock config reference

2 weeks agoMerge pull request #64466 from chanyoung/fix-list-complete
Matan Breizman [Tue, 29 Jul 2025 14:05:33 +0000 (17:05 +0300)]
Merge pull request #64466 from chanyoung/fix-list-complete

crimson/.../omap_btree_node_impl: fix complete flag for depth 2 omap scan

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
2 weeks agoqa/suites/crimson-rados: Introduce objectstore_tool testing 63604/head
Matan Breizman [Wed, 23 Jul 2025 13:20:04 +0000 (13:20 +0000)]
qa/suites/crimson-rados: Introduce objectstore_tool testing

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
2 weeks agoqa/tasks/ceph_objectstore_tool: Support Crimson tool
Matan Breizman [Wed, 23 Jul 2025 13:18:46 +0000 (13:18 +0000)]
qa/tasks/ceph_objectstore_tool: Support Crimson tool

fixes: https://tracker.ceph.com/issues/71504

Signed-off-by: junxiang Mu <1948535941@qq.com>
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
2 weeks agoMerge pull request #64323 from guits/cv-seastore
Adam King [Tue, 29 Jul 2025 13:38:25 +0000 (09:38 -0400)]
Merge pull request #64323 from guits/cv-seastore

ceph-volume: add seastore OSDs support

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Matan Breizman <mbreizma@redhat.com>
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
2 weeks agomgr/dashboard: cypress tests do not fail on failures
Afreen Misbah [Thu, 24 Jul 2025 16:41:31 +0000 (22:11 +0530)]
mgr/dashboard: cypress tests do not fail on failures

- the on 'fail' requires errors to be thrown explicitly
- this is causing all tests to pass as of now irrescpective fo failures

Fixes https://tracker.ceph.com/issues/72292

Signed-off-by: Afreen Misbah <afreen@ibm.com>
2 weeks agodoc/cephfs: edit ceph-dokan.rst (2 of x) 64737/head
Zac Dover [Tue, 29 Jul 2025 12:37:07 +0000 (22:37 +1000)]
doc/cephfs: edit ceph-dokan.rst (2 of x)

Edit the last half of doc/cephfs/ceph-dokan.rst. This is part of a
larger project whose goal is the improvement of the CephFS
documentation.

Follows https://github.com/ceph/ceph/pull/64690.

Signed-off-by: Zac Dover <zac.dover@proton.me>
2 weeks agodoc: Fix links to mClock config reference 64733/head
Pierre Riteau [Tue, 29 Jul 2025 09:44:52 +0000 (11:44 +0200)]
doc: Fix links to mClock config reference

Signed-off-by: Pierre Riteau <pierre@stackhpc.com>
2 weeks agoMerge pull request #63555 from Matan-B/wip-matanb-crimson-asock-race-coro
Matan Breizman [Tue, 29 Jul 2025 09:29:40 +0000 (12:29 +0300)]
Merge pull request #63555 from Matan-B/wip-matanb-crimson-asock-race-coro

crimson/osd: committed/handle_osd_maps into coroutines

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Aishwarya Mathuria <amathuri@redhat.com>
2 weeks agoMerge pull request #63270 from VinayBhaskar-V/wip-resync-changes
Ilya Dryomov [Tue, 29 Jul 2025 07:24:55 +0000 (09:24 +0200)]
Merge pull request #63270 from VinayBhaskar-V/wip-resync-changes

rbd-mirror: prevent image deletion if remote image is not primary

Reviewed-by: Ramana Raja <rraja@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2 weeks agomgr/dashboard: introduce details card component
Nizamudeen A [Wed, 23 Jul 2025 05:24:51 +0000 (10:54 +0530)]
mgr/dashboard: introduce details card component

as per https://pages.github.ibm.com/ibmcloud/pal/storybook/?path=/story/components-card--details-with-stacked-rows

added a details component which can be used as

```
<cd-details-card title="card title">
  <ng-container class="details-body-content">
   <div cdsCol [columnNumbers]="{lg: 4}">
     <span class="cds--label">
       label
     </span>
     <span>value</span>
   </div
  </ng-container>
</cd-details-card>
```

Fixes: https://tracker.ceph.com/issues/72246
Signed-off-by: Nizamudeen A <nia@redhat.com>
2 weeks agoMerge pull request #64601 from tchaikov/wip-dencoder-without-hitset
Kefu Chai [Tue, 29 Jul 2025 01:49:44 +0000 (09:49 +0800)]
Merge pull request #64601 from tchaikov/wip-dencoder-without-hitset

tools/ceph-dencoder: do not test HitSet types

Reviewed-by: Matan Breizman <mbreizma@redhat.com>
2 weeks agoMerge pull request #64705 from tchaikov/wip-pybind-setup-license-classifier
Ilya Dryomov [Mon, 28 Jul 2025 21:33:26 +0000 (23:33 +0200)]
Merge pull request #64705 from tchaikov/wip-pybind-setup-license-classifier

pybind: replace deprecated license classifiers with SPDX expression

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Reviewed-by: John Mulligan <jmulligan@redhat.com>
2 weeks agoMerge pull request #64711 from idryomov/wip-72134-cont
Ilya Dryomov [Mon, 28 Jul 2025 18:27:01 +0000 (20:27 +0200)]
Merge pull request #64711 from idryomov/wip-72134-cont

qa/suites/krbd: request msgr1 explicitly in unmap subsuite

Reviewed-by: Miki Patel <miki.patel132@gmail.com>
2 weeks agocommon/async: fold async_spawn_throttle_impl into spawn_throttle_impl 64624/head
Casey Bodley [Tue, 22 Jul 2025 19:01:12 +0000 (15:01 -0400)]
common/async: fold async_spawn_throttle_impl into spawn_throttle_impl

spawn_throttle_impl was a virtual base class for the sync_ and async_
variants. with the sync variant removed, combine the classes into one
and remove the use of virtual functions

Signed-off-by: Casey Bodley <cbodley@redhat.com>
2 weeks agocommon/async: remove null_yield support for spawn_throttle
Casey Bodley [Tue, 22 Jul 2025 18:37:08 +0000 (14:37 -0400)]
common/async: remove null_yield support for spawn_throttle

null_yield support was provided by sync_spawn_throttle_impl, which
itself stores the boost::asio::io_context that it runs on. however,
valgrind reports issues with object lifetimes

each spawn_throttle_handler holds a reference count on the
spawn_throttle_impl to prevent it from going away while coroutines are
in flight. on completion, this spawn_throttle_handler gets invoked on
its associated executor. this invocation may drop the last reference
to spawn_throttle_impl while that associated executor is still trying
to use the io_context that was destroyed with sync_spawn_throttle_impl

finding no good way for a custom executor to preserve the lifetime of
the spawn_throttle_impl, we instead remove support for this flawed
design. the null_yield callers must first spawn a parent coroutine
before using spawn_throttle

Fixes: https://tracker.ceph.com/issues/70965
Signed-off-by: Casey Bodley <cbodley@redhat.com>
2 weeks agocommon/async: remove null_yield support for max_concurrent_for_each()
Casey Bodley [Thu, 24 Jul 2025 13:25:41 +0000 (09:25 -0400)]
common/async: remove null_yield support for max_concurrent_for_each()

max_concurrent_for_each() is a thin wrapper around spawn_throttle.
remove its support for null_yield too

Signed-off-by: Casey Bodley <cbodley@redhat.com>
2 weeks agorgw: RGWSI_Notify spawns a coroutine on null_yield
Casey Bodley [Tue, 22 Jul 2025 18:27:55 +0000 (14:27 -0400)]
rgw: RGWSI_Notify spawns a coroutine on null_yield

init_watch() and finalize_watch() use spawn_throttle for concurrent
operations, so need to spawn a parent coroutine unless init_watch()
already has one

Signed-off-by: Casey Bodley <cbodley@redhat.com>
2 weeks agorgw: RGWDeleteMultiObj spawns a coroutine on null_yield
Casey Bodley [Tue, 22 Jul 2025 18:25:37 +0000 (14:25 -0400)]
rgw: RGWDeleteMultiObj spawns a coroutine on null_yield

if called with null_yield, RGWDeleteMultiObj::execute() creates an
io_context and spawns a coroutine to run on it. this ensures that
spawn_throttle always gets a valid yield context

Signed-off-by: Casey Bodley <cbodley@redhat.com>
2 weeks agoMerge pull request #64583 from ceph/wip-yuriw-release-19.2.3-main
Yuri Weinstein [Mon, 28 Jul 2025 14:54:21 +0000 (07:54 -0700)]
Merge pull request #64583 from ceph/wip-yuriw-release-19.2.3-main

doc: squid 19.2.3 release notes

Reviewed-by: Adam Emerson <aemerson@redhat.com>
Reviewed-by: Laura Flores <lflores@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
2 weeks agoMerge pull request #63348 from AliMasarweh/wip-alimasa-68183
Ali Masarwa [Mon, 28 Jul 2025 13:55:06 +0000 (16:55 +0300)]
Merge pull request #63348 from AliMasarweh/wip-alimasa-68183

RGW | fix conditional Delete, MultiDelete and Put

Reviewed-by: Casey Bodley <cbodley@redhat.com>, Matt Benjamin <mbenjamin@redhat.com>
2 weeks agoMerge pull request #64503 from Matan-B/wip-matanb-crimson-misdirected-fix
Matan Breizman [Mon, 28 Jul 2025 10:34:56 +0000 (13:34 +0300)]
Merge pull request #64503 from Matan-B/wip-matanb-crimson-misdirected-fix

crimson/osd/../client_request: fix is_misdirected

Reviewed-by: Samuel Just <sjust@redhat.com>
2 weeks agoqa/suites/krbd: request msgr1 explicitly in unmap subsuite 64711/head
Ilya Dryomov [Mon, 28 Jul 2025 07:01:34 +0000 (09:01 +0200)]
qa/suites/krbd: request msgr1 explicitly in unmap subsuite

Since commit 5011cc926cd4 ("qa/suites/krbd: run unmap subsuite with
msgr1 only"), unmap.t is run only against msgr1.  pre-single-major.yaml
kernel has actually been gone for some time now, but there is still
value in maintaining a msgr1-only test.  With the default switched to
msgr2 in commit a577f6fa405c ("krbd: "rbd device map" command should
use msgr2 by default"), msgr1 needs to be requested explicitly.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2 weeks agodoc/man/rbd: update ms_mode default (legacy -> prefer-crc)
Ilya Dryomov [Sat, 26 Jul 2025 09:35:08 +0000 (11:35 +0200)]
doc/man/rbd: update ms_mode default (legacy -> prefer-crc)

The default was switched to msgr2 in prefer-crc mode in commit
a577f6fa405c ("krbd: "rbd device map" command should use msgr2 by
default").

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2 weeks agoMerge pull request #63945 from ArbitCode/wip-raja-get-account-summary
Raja [Mon, 28 Jul 2025 05:26:26 +0000 (10:56 +0530)]
Merge pull request #63945 from ArbitCode/wip-raja-get-account-summary

rgw/iam: getAccountSummary API

2 weeks agoMerge pull request #64592 from ArbitCode/wip-raja-get-caller-identity-docs
Raja [Mon, 28 Jul 2025 05:25:59 +0000 (10:55 +0530)]
Merge pull request #64592 from ArbitCode/wip-raja-get-caller-identity-docs

doc/radosgw: get caller identity docs

2 weeks agoMerge pull request #64289 from sseshasa/wip-mclock-new-benchmark-mechanism
Sridhar Seshasayee [Mon, 28 Jul 2025 03:39:10 +0000 (09:09 +0530)]
Merge pull request #64289 from sseshasa/wip-mclock-new-benchmark-mechanism

src/ceph_osd, osd: Implement running benchmark during OSD creation - Phase 1

Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
2 weeks agomgr/dashboard: fix bucket replication disable 64708/head
Naman Munet [Sun, 27 Jul 2025 13:53:17 +0000 (19:23 +0530)]
mgr/dashboard: fix bucket replication disable

fixes: https://tracker.ceph.com/issues/72074

Signed-off-by: Naman Munet <naman.munet@ibm.com>
2 weeks agocrimson/osd/../client_request: drop rwoedered with balanced/localize reads 64503/head
Matan Breizman [Tue, 15 Jul 2025 08:24:22 +0000 (08:24 +0000)]
crimson/osd/../client_request: drop rwoedered with balanced/localize reads

This is the counterpart of https://github.com/ceph/ceph/pull/62806
Which fixes classical: https://tracker.ceph.com/issues/70715

Fixes: https://tracker.ceph.com/issues/71007
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
2 weeks agocrimson/osd/../client_request: rename is_misdirected and add logs
Matan Breizman [Tue, 15 Jul 2025 08:24:06 +0000 (08:24 +0000)]
crimson/osd/../client_request: rename is_misdirected and add logs

This function mainly verifies replicated read related info.

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
2 weeks agocrimson/osd: handle_osd_map to coroutines 63555/head
Matan Breizman [Tue, 8 Jul 2025 14:40:16 +0000 (14:40 +0000)]
crimson/osd: handle_osd_map to coroutines

Signed-off-by: Matan Breizman <mbreizma@redhat.com>