Kefu Chai [Sun, 29 Mar 2026 11:41:24 +0000 (19:41 +0800)]
crimson/osd: fix inaccurate comment about child early-exit in get_early_config
The comment contained a typo ("taged") and vaguely referred to "one of
the parameters" without explaining what actually happens: the child
calls exit(0) for early-exit paths such as --help and --version, and
the parent detects this by checking for a clean exit with no pipe data.
Kefu Chai [Sun, 29 Mar 2026 11:40:46 +0000 (19:40 +0800)]
crimson/osd: remove redundant comments
Remove comments that merely restate what the code already says clearly:
- SeastarOption field comments (option_name, config_key, value_type)
- "Define a list of Seastar options" above seastar_options
- "Function to get the option value as a string" above get_option_value
- "stop()s registered using defer() are called here" in main()
Also fix the trailing space before the semicolon in the value_type
field declaration.
Lumir Sliva [Sat, 28 Mar 2026 23:27:10 +0000 (00:27 +0100)]
doc/dev: fix typos in running-tests-locally.rst
Fix grammar error ('is be tested' -> 'can be tested'), misspellings
of 'bootstrap', 'teuthology', and 'environment', a repeated word
('manually manually'), and a missing article ('maybe bootstrap' ->
'maybe the bootstrap').
Lumir Sliva [Sat, 28 Mar 2026 23:43:27 +0000 (00:43 +0100)]
doc: fix typos and outdated refs across developer guide
Fix 'elipsis' to 'ellipsis' in SubmittingPatches.rst, update
outdated 'master' branch references to 'main' in essentials.rst
and running-tests-locally.rst, fix 'sometime' to 'sometimes' in
merging.rst, and remove duplicated word in teuthology-intro.rst.
Ronen Friedman [Mon, 23 Mar 2026 16:24:20 +0000 (16:24 +0000)]
Crimson/osd/run_bench(): make randomness follow Classic more closely
Direct gen() calls for randomness: Crimson uses dis(gen) % onum and
dis(gen) % (osize / bsize) to pick random object indices and
offsets, which limits the range to 0–255. Classic uses mt19937s
directly, allowing the full 32-bit range of randomness.
rbd: improve mirror image status and validation error messages
When a mirror image is left in a transitional state such as DISABLING,
the current mirror image status command reports:
$ rbd mirror image status test_pool/test_image1
rbd: mirroring not enabled on the image
This is the same message shown when mirroring is disabled or not yet
enabled, which can give the impression that mirroring is already
disabled.
Improve the validation logic and error messages to distinguish between
the DISABLED state and other non-enabled states, and include the image
name and current state in the output.
Examples:
When the image is completely disabled:
$ rbd mirror image status test_pool/test_image1
rbd: mirroring disabled on image 'test_image1'
When the image is in a transitional state (ex: DISABLING):
$ rbd mirror image status test_pool/test_image1
rbd: mirroring not enabled on image 'test_image1' (state: disabling)
Adam Kupczyk [Thu, 25 Sep 2025 07:03:12 +0000 (03:03 -0400)]
extblkdev/fcm: Refuse to operate on multimedia lvm block devices
BlueStore is selecting were data is put to the device.
Merging 2 FCM devices together means that BlueStore will see free space
on one of the devices, but not know the other is full and asking to put
data there. It will cause -ENOSPC while free space is reported.
Casey Bodley [Wed, 25 Mar 2026 16:38:59 +0000 (12:38 -0400)]
qa/rgw/upgrade: symlinks are explicit about distro versions
avoid relying on "ubuntu_latest" and "rpm_latest" symlinks, which change
over time on main. be explicit about the distro versions supported by
the initial release
Casey Bodley [Wed, 25 Mar 2026 16:33:40 +0000 (12:33 -0400)]
qa/rgw: remove ragweed from verify subsuite
it's currently broken with newer python on rocky 10 and ubuntu 24
(tracked in https://tracker.ceph.com/issues/72500) and doesn't provide
interesting test coverage outside of rgw/upgrade
John Mulligan [Mon, 10 Nov 2025 21:15:29 +0000 (16:15 -0500)]
cephadm: add pid file directory option to cfg watch sidecar
This will enable the config watch sidecar to signal processes
with a SIGHUP to tell them to reload configuration when config
watch has detected a configuration change. Currently only used
by keybridge.
Signed-off-by: John Mulligan <jmulligan@redhat.com>
John Mulligan [Tue, 22 Jul 2025 23:24:11 +0000 (19:24 -0400)]
mgr/smb: add new cephfs parameter for getting fscrypt keys
Add a new field to the cephfs configuration section for shares. This
section selects the keybridge scope and key name to use when acquiring
the key to use for fscrypt.
Signed-off-by: John Mulligan <jmulligan@redhat.com>
John Mulligan [Tue, 22 Jul 2025 23:22:15 +0000 (19:22 -0400)]
mgr/smb: add keybridge configuration to cluster resource
Add keybridge service configuration classes and parameters to the
resources module. This supports enabling the keybridge, setting up
scopes for the keybridge and it's access control.
A helper class is added that parses and helps validate the scope names.
Signed-off-by: John Mulligan <jmulligan@redhat.com>
John Mulligan [Wed, 16 Jul 2025 21:55:44 +0000 (17:55 -0400)]
mgr/smb: add enums that will be used for configuring keybridge
Add a pair of enum types that will be used for configuring the
keybridge. The scope type identifies what kind of scope is being
used. The peer policy can be used to allow a dev or other user
more access to the keybridge api for development purposes.
Signed-off-by: John Mulligan <jmulligan@redhat.com>
John Mulligan [Fri, 18 Jul 2025 14:23:31 +0000 (10:23 -0400)]
mgr/smb: fix a resource error unpacking str instead of list
Add special handling for the case where a string is passed instead of a
list. Without this fix a string will be converted into a list of single
letter items, something pretty much no one ever wants. Raise an
exception instead.
Signed-off-by: John Mulligan <jmulligan@redhat.com>
John Mulligan [Fri, 18 Jul 2025 16:20:17 +0000 (12:20 -0400)]
cephadm: add keybridge sidecar to smb daemon module
The keybridge uses the sambacc configuration but can also be passed
CLI options. Since cephadm writes the cert files, cephadm must also
pass the file names to use to the container args.
Signed-off-by: John Mulligan <jmulligan@redhat.com>
John Mulligan [Wed, 16 Jul 2025 21:08:49 +0000 (17:08 -0400)]
python-common/deployment: add keybridge feature to smb service spec
The keybridge sidecar is enabled by the keybridge feature flag.
This sidecar will be used to help fetch keys over various protocols
for the ceph module to use to set up fs encryption.
Signed-off-by: John Mulligan <jmulligan@redhat.com>
projects / ceph.git / log