RBD: remove redundant parent check

Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>

RBD: fix unhandle result code during list/list_children

Fixes: #14333
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>

RBD: fix potential memory leak

Fixes: #14332
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>

Merge pull request #7126 from tchaikov/wip-detect-bzip2-lz4

cmake: detect bzip2 and lz4

Merge pull request #7166 from kylinstorage/wip-rbdnbd-misc

rbd-nbd: add copyright

Merge pull request #7161 from liewegas/wip-port

test/mon/osd-erasure-code-profile: pick new mon port

Reviewed-by: Loic Dachary <ldachary@redhat.com>

test/mon/osd-erasure-code-profile: pick new mon port

7108 is used by mark-down.sh

Signed-off-by: Sage Weil <sage@redhat.com>

Merge pull request #6911 from stiopaa1/const_variable_length

tests: add const for ec test

Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #6989 from stiopaa1/message_inline

msg: remove unneeded inline

Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #7160 from yehudasa/wip-rgw-warn

rgw: fix compilation warning

Reviewed-by: Sage Weil <sage@redhat.com>

rgw: fix compilation warning

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

Merge pull request #7149 from fullerdj/wip-14280

cls_rbd: enable object map checksums for object_map_save

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #7154 from liewegas/wip-make-check

unittest_ipaddr: fix segv

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

unittest_ipaddr: fix segv

Since b6d0fc9e0e515e50894c08217d688a8c94db7570 we need ifa_name to
be defined.

Signed-off-by: Sage Weil <sage@redhat.com>

Add copyright for rbd-nbd

Signed-off-by: Li Wang <li.wang@kylin-cloud.com>

Merge pull request #6002 from Sandy4999/wip-12890

rgw: add a method to purge all associate keys when removing a subuser

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>

Merge pull request #6080 from clever215/wkm-master-139

rgw: modify documents and help infos' descriptions to the usage of option date when executing command "log show"

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>

Merge pull request #4216 from rzarzynski/wip-10682

rgw: add support for "end_marker" parameter for GET on Swift account.

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>

Merge pull request #6652 from ifed01/wip-13824

rgw_admin: orphans finish segfaults

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>

Merge pull request #7037 from mathslinux/rgw-add-missing-error-code

rgw: add missing error code for admin op API

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>

Merge pull request #7093 from dwj192/dwj-bucket-index-fix

rgw: radosgw-admin bucket check --fix not work

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>

Merge pull request #6817 from david-z/wip-fix-init-radosgw

rgw: fix a typo in init-radosgw

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>

Merge pull request #7102 from dzafman/wip-cot-fixes

Fix for make check.

Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #7153 from liewegas/wip-make-check

build: misc make check fixes

Merge pull request #7152 from liewegas/wip-hexdump

unittest_bufferlist: fix hexdump test

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>

unittest_bluefs: call close_for_write()

Signed-off-by: Sage Weil <sage@redhat.com>

test/test_objectstore_memstore.sh: clear store_test_temp_dir

ceph_test_objectstore now expects this to not exist.

Signed-off-by: Sage Weil <sage@redhat.com>

unittest_bufferlist: fix hexdump test

Signed-off-by: Sage Weil <sage@redhat.com>

cls_rbd: enable object map checksums for object_map_save

object_map_save disables CRCs when an object map footer isn't provided.
Unconditionally re-enable object map CRCs before re-encoding the new object
map.

Fixes: #14280
Signed-off-by: Douglas Fuller <dfuller@redhat.com>

Merge pull request #6955 from dachary/wip-dev-guide-ceph-qa-suite

doc: dev: document ceph-qa-suite

Reviewed-by: Nathan Cutler <ncutler@suse.cz>

doc: dev: document ceph-qa-suite

Signed-off-by: Loic Dachary <loic@dachary.org>

cmake: detect bzip2 and lz4 for rocksdb

* this change is the cmake port of 911e7a0.
  the rocksdb's Makefile will detect the installed libbz2 and libz4 by
  its own. if the building env happens to have these libraries installed,
  a link time dependency is introduced. so we are forced to link against
  them.
* do not REQUIRE BZip2 in cmake anymore
* only link against bzip2 if it is detected

Signed-off-by: Kefu Chai <kchai@redhat.com>

cmake: add check for liblz4

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #7131 from ceph/wip-cmake

cmake: made rocksdb an imported library

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #7073 from dllgzcl/wip-zcl-show-version

tools: monstore: add 'show-versions' command.

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Joao Eduardo Luis <joao@suse.de>

cmake: made rocksdb an imported library

Systems with the minimum required version of CMake
such as Ubuntu Trusty Tahr don't support
INTERFACE_LINK_LIBRARIES, so rocksdb was made into
an IMPORTED library. Added ROCKSDB_INCLUDE_DIR to
simplify target_include_directories rocksdb.

Signed-off-by: Ali Maredia <amaredia@redhat.com>

Merge remote-tracking branch 'origin/jewel'

Merge pull request #7129 from dillaman/wip-14167-jewel

librbd: disable copy-on-read when not exclusive lock owner

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

Merge pull request #6886 from ssssztes/renhw-wip-14047

rbd: rbd order will be place in 22, when set to 0 in the config_opt

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

Merge remote-tracking branch 'origin/jewel'

Merge branch 'wip-14241-jewel' of git://github.com/dillaman/ceph into jewel

librbd: don't use write_full optimization with clones

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

Merge pull request #7127 from trociny/wip-rbd-nbd-misc

rbd-nbd: small improvements in logging and forking

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

Merge pull request #6388 from ukernel/wip-13583

ceph-fuse: fix fsync()

Reviewed-by: Greg Farnum <gfarnum@redhat.com>

Merge remote-tracking branch 'origin/jewel'

Merge branch 'wip-client-readdir-fix' of git://github.com/ukernel/ceph into jewel

Reviewed-by: Greg Farnum <gfarnum@redhat.com>

librbd: disable write_full optimization if image has parent

Fixes: #14241
Signed-off-by: Jason Dillaman <dillaman@redhat.com>

tests: new test case for write_full optimization

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #7032 from liupeiyang/wip_metadata_list

rgw:modify command stucking when operating radosgw-admin metadata list user

Merge pull request #7044 from HeyoQiang/master

rbd-fuse:image name can not include snap name

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #7010 from majianpeng/skip-promote-for-writefull

osd: skip promote for writefull w/ FADVISE_DONTNEED/NOCACHE

Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #7012 from chenji-kael/wip-fix-eth-bind

msg: filter out lo addr when bind osd addr

Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #6879 from dachary/wip-13970-ceph-disk-cciss

ceph-disk: ceph-disk list fails on /dev/cciss!c0d0

Reviewed-by: Sage Weil <sage@redhat.com>

librbd: directly execute copy-on-read copyup operations

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #7052 from branch-predictor/bp-faster-kv-get

kv: implement value_as_ptr() and use it in .get()

Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #5351 from Aran85/master

common/Formatter: avoid newline if there is no output

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>

Merge pull request #7065 from majianpeng/osd-recover-sleep-cause-thread-suicide

osd: prevent osd_recovery_sleep from causing recovery-thread suicide

Reviewed-by: Sage Weli <sage@redhat.com>

Merge pull request #7091 from liewegas/wip-14212

osd: clear pg_stat_queue after stopping pgs

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #7095 from xiexingguo/xxg-wip-14204

osd: kstore: small fixes to kstore

Reviewed-by: Sage Weil <sage@newdream.net>

rbd-nbd: prefork only for map command

Signed-off-by: Mykola Golub <mgolub@mirantis.com>

Merge pull request #7105 from vshankar/rdb-dist-cleanup

rocksdb: remove rdb sources from dist tarball

Reviewed-by: Kefu Chai <kchai@redhat.com>

rbd-nbd: set reply error properly

Signed-off-by: Mykola Golub <mgolub@mirantis.com>

rbd-nbd: improve logging

Signed-off-by: Mykola Golub <mgolub@mirantis.com>

ceph-disk: retry cryptsetup remove

Retry a cryptsetup remove ten times. After the ceph-osd terminates, the
device is released asyncrhonously and an attempt to cryptsetup remove
will may fail because it is considered busy. Although a few attempts are
made before giving up, the number of attempts / the duration of the
attempts cannot be controlled with a cryptsetup option. The workaround
is to increase this by trying a few times.

If cryptsetup remove fails for a reason that is unrelated to timeout,
the error will be repeated a few times. There is no undesirable side
effect. It will not hide a problem.

Signed-off-by: Loic Dachary <loic@dachary.org>

ceph-disk: fix regression in cciss devices names

The cciss driver has device paths such as /dev/cciss/c0d1 with a
matching /sys/block/cciss!c0d1. The general case is that whenever a
device name is found in /sys/block, the / is replaced by the !.

When refactoring the ceph-disk list subcommand, this conversion was
overlooked in a few places. All explicit concatenation of /dev with a
device name are replaced with a call to get_dev_name which does the same
but also converts all ! in /.

http://tracker.ceph.com/issues/13970 Fixes: #13970

Signed-off-by: Loic Dachary <loic@dachary.org>

ceph-disk: factorize duplicated dmcrypt mapping

Signed-off-by: Loic Dachary <loic@dachary.org>

ceph-disk: list accepts absolute dev names

The ceph-disk list subcommand now accepts /dev/sda as well as sda.
The filtering is done on the full list of devices instead of restricting
the number of devices explored. Always obtaining the full list of
devices makes things simpler when trying to match a dmcrypted device to
the corresponding raw device.

Signed-off-by: Loic Dachary <loic@dachary.org>

ceph-disk: deactivate must unmap dmcrypted journal

If the journal is not unmapped, ceph-disk destroy will fail to zap the
corresponding devices because it is still held by devicemapper.

A consequence of this modification is that

   ceph-disk activate --dmcrypt --reactivate

no longer works from the command line, because it does not map the
dmcrypted journal. The --reactivate option is added to activate-journal
which will map both the journal and the data devices, if necessary.

http://tracker.ceph.com/issues/14233 Fixes: #14233

Signed-off-by: Loic Dachary <loic@dachary.org>

ceph-disk: display OSD details when listing dmcrypt devices

The details about a device that mapped via dmcrypt are directly
available. Do not try to fetch them from the device entry describing the
devicemapper entry.

http://tracker.ceph.com/issues/14230 Fixes: #14230

Signed-off-by: Loic Dachary <loic@dachary.org>

tests: limit ceph-disk unit tests to test dir

Signed-off-by: Loic Dachary <loic@dachary.org>

tests: update ceph-disk workunit debug reminders

Signed-off-by: Loic Dachary <loic@dachary.org>

rgw:modify command stucking when operating radosgw-admin metadata list user

When no user exists,the command stucks by operating radosgw-admin metadata list user. It seems all right now.

Signed-off-by: Peiyang Liu <liu.peiyang@h3c.com>

tools: monstore: add 'show-versions' command.

Using this tool, the first/last committed version of maps will be shown.

Signed-off-by: Cilang Zhao <zhao.cilang@h3c.com>

Merge pull request #7119 from dmick/master

admin/build-doc: make paths absolute

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

admin/build-doc: make paths absolute

Build failure on docs.dhc because pip apparently was changing directory
before building rbd with cython, causing the relative library path
references to fail.  Bite the bullet and make everything absolute (since
we already have TOPDIR to use).

Signed-off-by: Dan Mick <dan.mick@redhat.com>

librbd: disable copy-on-read when not exclusive lock owner

Fixes: #14167
Backport: infernalis, hammer
Signed-off-by: Jason Dillaman <dillaman@redhat.com>

tests: fsx should disable journaling feature for krbd

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #7103 from ceph/wip-cmake-reorg

cmake: cleanups and more features from automake

cmake: udev linking and Findudev module changes

Linked udev into librbd, restored UDEV_I to
UDEV_INCLUDE_DIR in Findudev.cmake

Signed-off-by: Ali Maredia <amaredia@redhat.com>

cmake: Findxio.cmake update Xio OFF by default

Option WITH_XIO now OFF but required by default,
Findxio.cmake now using
FIND_PACKAGE_HANDLE_STANDARD_ARGS.

Signed-off-by: Ali Maredia <amaredia@redhat.com>

cmake: Check for required Cython package

Added a FindCython.cmake, Cython is required.

Signed-off-by: Ali Maredia <amaredia@redhat.com>

cmake: Added cls_numops_client library

Signed-off-by: Ali Maredia <amaredia@redhat.com>

cmake: test/erasure-code CMake additions

Added missing executables and libraries.

Signed-off-by: Ali Maredia <amaredia@redhat.com>

cmake: test CMake additions

Added missing tests, changed linking, among
other changes.

Signed-off-by: Ali Maredia <amaredia@redhat.com>

cmake: src/erasure-code CMakeLists.txt's changes

Added ec_neon libraries in jerasure and shec dirs,
reorganized checks for flags, other minor
erasure-code directory changes.

Signed-off-by: Ali Maredia <amaredia@redhat.com>

cmake: Missing binaries from src/tools added

Added ceph-objecstore-tool, ceph-kvstore-tool,
ceph-psim, ceph-client-debug, ceph-scratchtool,
ceph-scratchtoolpp, ceph-radosacl,
ceph-osdomap-tool, ceph-monmap-tool from src/tools
Makefiles.

Signed-off-by: Ali Maredia <amaredia@redhat.com>

cmake: CMAKE_DL_LIBS is not linked into osdmaptool

Signed-off-by: Ali Maredia <amaredia@redhat.com>

cmake: libradosstriper dir CMakeLists.txt added

Signed-off-by: Ali Maredia <amaredia@redhat.com>

cmake: Added librados_api library

Signed-off-by: Ali Maredia <amaredia@redhat.com>

cmake: Added common/Cycles.cc to libcommon

Signed-off-by: Ali Maredia <amaredia@redhat.com>

cmake: Boost libraries cleanup

Added components to Boost find_package, changed
libraries from boost_foo to ${Boost_FOO_LIBRARY}

Signed-off-by: Ali Maredia <amaredia@redhat.com>

cmake: add detection for HAVE_CURL_MULTI_WAIT

Signed-off-by: Casey Bodley <cbodley@redhat.com>

cmake: rbd_replay CMakeLists.txt, rbd_replay fixes

moved rbd_replay targets into it's directory,
rbd-replay-prep added, removed "lib" in front of
all rbd_replay libraries, linked rbd_replay into
ceph-dencoder.

Signed-off-by: Ali Maredia <amaredia@redhat.com>

cmake: Babeltrace detection supported

Babeltrace defaults to ON, Findbabeltrace.cmake &
BABELTRACE variables in config-h.in.cmake added.

Signed-off-by: Ali Maredia <amaredia@redhat.com>

cmake: LTTng functionality added

Set LTTNG option to ON by default, added
Findlttng.cmake, added CMakeLists.txt in
src/tracing that generates .h files using
lttng-gen-tp, added WITH_LTTNG to
config-h.in.cmake.

Signed-off-by: Ali Maredia <amaredia@redhat.com>

cmake: Updated allocator checking

Added a FindJeMalloc.cmake file, changed
allocator checking logic (tcmalloc is default),
replaced TCMALLOC_LIBS to ALLOC_LIBS, added
HAVE_LIB(ALLOCATOR) to config-h.in.cmake.

Signed-off-by: Ali Maredia <amaredia@redhat.com>

cmake: kv dir and bluestore unittests

Added CMakeLists.txt in src/kv, replaced
os_mon_objs with kv_objs, linked libkv to os,
added HAVE_LIBROCKSDB to config-h.in.cmake,
tweaked rocksdb unittest, added bluestore
unittests, made rocksdb build with
add_custom_target instead of custom_command.

Signed-off-by: Ali Maredia <amaredia@redhat.com>

Merge remote-tracking branch 'origin/jewel'

Merge pull request #7114 from dillaman/wip-14234-jewel

librbd: reduce verbosity of common error condition logging

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

Merge branch 'wip-14237-jewel' of git://github.com/dillaman/ceph into jewel

qa/workunits/rbd: import_export should use clean temp space

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

Merge pull request #7113 from dillaman/wip-14168-jewel

journal: disconnect watch after watch error

Reviewed-by: Josh Durgin <jdurgin@redhat.com>