assert: choose function-var name on non-gnu

Selects __PRETTY_FUNCTION__ or __func__. Linux assumes GNU, and chooses
__PRETTY_FUNCTION__ if gcc/g++ versions are favorable.

This also includes a fix in ax_c_var_func.m4:

AC_TRY_COMPILE will wrap the test in main{}, and then GCC will complain
about nested functions. Just use the original main{} body.

diff --git a/m4/ax_c_var_func.m4 b/m4/ax_c_var_func.m4
index 0ad7d2b..8b57563 100644
--- a/m4/ax_c_var_func.m4
+++ b/m4/ax_c_var_func.m4
@@ -57,9 +57,9 @@ AC_DEFUN([AX_C_VAR_FUNC],
 [AC_REQUIRE([AC_PROG_CC])
 AC_CACHE_CHECK(whether $CC recognizes __func__, ac_cv_c_var_func,
 AC_TRY_COMPILE(,
-[int main() {
+[
 char *s = __func__;
-}],
+],
 AC_DEFINE(HAVE_FUNC,,
 [Define if the C complier supports __func__]) ac_cv_c_var_func=yes,
 ac_cv_c_var_func=no) )

Signed-off-by: Noah Watkins <noahwatkins@gmail.com>

Merge remote-tracking branch 'gh/wip-doc-radosgw'

Revert "doc: radosgw workaround for OpenStack Horizon bug"

This reverts commit c3c962eb7d2fb5ceea829924af08f8a1471f7acf.

Merge pull request #799 from ceph/wip-doc-install

Wip doc install

Reviewed-by: Neil Levine <neil.levine@inktank.com>

Merge pull request #821 from ceph/port/missing-headers

add missing headers

Reviewed-by: Sage Weil <sage@inktank.com>

Merge pull request #822 from ceph/port/rgw

portability patches in rgw

Reviewed-by: Sage Weil <sage@inktank.com>

Merge pull request #825 from ceph/port/utime

utime: use to_timespec for conversion

Reviewed-by: Sage Weil <sage@inktank.com>

rgw: add compat file for name service macros

Signed-off-by: Noah Watkins <noahwatkins@gmail.com>

rgw: avoid sighandler_t in favor of sig_t

Signed-off-by: Noah Watkins <noahwatkins@gmail.com>

crush: add mising header for count

Signed-off-by: Noah Watkins <noahwatkins@gmail.com>

auth: add missing header for list

Signed-off-by: Noah Watkins <noahwatkins@gmail.com>

mon: add missing header for std::find

Signed-off-by: Noah Watkins <noahwatkins@gmail.com>

auth: add missing header file for std::replace

Signed-off-by: Noah Watkins <noahwatkins@gmail.com>

Merge pull request #811 from dmsimard/wip_6710

Be more verbose in radosgw init script issues, return the right exit codes

Reviewed-by: Yehuda Sadeh <yehuda@inktank.com>

utime: use to_timespec for conversion

Signed-off-by: Noah Watkins <noahwatkins@gmail.com>

Add a verbose argument and some verbosity

This allows a user to use "-v|--verbose" to get some insight as to
what could be preventing radosgw from starting properly.

Signed-off-by: David Moreau Simard <dmsimard@iweb.com>

Verify that radosgw started, return appropriate exit code

Changed "/etc/init.d/radosgw status" into a function that now
returns the appropriate exit code.
We now also verify that radosgw actually started properly.

Signed-off-by: David Moreau Simard <dmsimard@iweb.com>

We should exit 1 if radosgw is not executable

An exit 0 means everything went okay - we should exit 1 if there is a problem in
starting radosgw.

Signed-off-by: David Moreau Simard <dmsimard@iweb.com>

Merge pull request #816 from ceph/wip-fadvise

wbthrottle: use posix_fadvise if available

Reviewed-by: Sage Weil <sage@inktank.com>

Merge pull request #815 from ceph/wip-static-cast

assert: use feature test for static_cast

Reviewed-by: Sage Weil <sage@inktank.com>

Merge pull request #813 from ceph/wip-blkdev

support blkdev size query on osx/freebsd

Reviewed-by: Sage Weil <sage@inktank.com>

Merge pull request #803 from ceph/wip-6698

upstart: fix ceph-crush-location default

Reviewed-by: Sage Weil <sage@inktank.com>

pdatedoc: Added index link to new install doc. Requires merge of wip-doc-install to work.

Signed-off-by: John Wilkins <john.wilkins@inktank.com>

doc: Deleted old manual install doc.

Signed-off-by: John Wilkins <john.wilkins@inktank.com>

doc: Mentioned that install procedure is for manual deployments, not ceph-deploy or others.

Signed-off-by: John Wilkins <john.wilkins@inktank.com>

doc: Changed text for ceph-extras. Made it required. Mentioned newer versions.

Signed-off-by: John Wilkins <john.wilkins@inktank.com>

assert: use feature test for static_cast

Signed-off-by: Noah Watkins <noahwatkins@gmail.com>

wbthrottle: use posix_fadvise if available

Only adding information about data usage. This won't effect correctness.

Signed-off-by: Noah Watkins <noahwatkins@gmail.com>

doc: Added DNS and SSL dialog.

Signed-off-by: John Wilkins <john.wilkins@inktank.com>

test: test helper for get_block_device_size

This is the start of a potential unit test for get_block_device_size. An
actual unit test will probably need to be run as root, and either find a
device, have one specified, or create one (e.g. ramdisk)  in a platform
agnostic way. In the mean time, this tool can be run by hand, or called
for a bash script.

Signed-off-by: Noah Watkins <noahwatkins@gmail.com>

blkdev: support blkdev size query on osx

Support OSX, add checks for platform specific headers.

Signed-off-by: Noah Watkins <noahwatkins@gmail.com>

doc: Implemented changes suggested from feedback.

Signed-off-by: John Wilkins <john.wilkins@inktank.com>

Merge pull request #812 from ceph/revert-struct-init

Revert "fix -Wgnu-designator warnings"

Revert "fix -Wgnu-designator warnings"

Struct initialization using dot notation as in C99, but that happens to
not be valid C++, although apparently in C++11 it is valid. We'll need a
way to keep clang from throwing warnings at this initialization style,
either using some macros to detect the comiler environment, or perhaps
moving struct initialization to a C file rather than C++.

This reverts commit 6efc2b54d5ce85fcb4b66237b051bcbb5072e6a3.

Signed-off-by: Noah Watkins <noahwatkins@gmail.com>

test/libcephfs: free cmount after tests finishes

unmount and release cmount at the end of tests

Signed-off-by: Xing Lin <xinglin@cs.utah.edu>
Reviewed-by: Sage Weil <sage@inktank.com>

Merge pull request #790 from ceph/wip-warnings

ease clang's anxieties

Reviewed-by: Sage Weil <sage@inktank.com>

Merge pull request #793 from ceph/wip-pipe

pipe: use pipe2 feature test; check fcntl retval

Reviewed-by: Sage Weil <sage@inktank.com>

upstart: fix ceph-crush-location default

Behave if it is not specified on ceph.conf.  (init-ceph also falls back
to the default.)

Fixes: #6698
Signed-off-by: Sage Weil <sage@inktank.com>

doc: radosgw workaround for OpenStack Horizon bug

Signed-off-by: Loic Dachary <loic@dachary.org>
Reviewed-by: Josh Durgin <josh.durgin@inktank.com>

doc: fix typo in openstack radosgw integration

s/type-object store/type object-store/

Signed-off-by: Loic Dachary <loic@dachary.org>
Reviewed-by: Josh Durgin <josh.durgin@inktank.com>

mon/OSDMonitor: refix warning

mon/OSDMonitor.cc: In member function 'int OSDMonitor::_prepare_rename_pool(int64_t, std::string)':
mon/OSDMonitor.cc:4370:55: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]

Two fixes for this crossed paths in
0c186096bb9534165394046fd8dd914e1be44094 and
2181b4c94696432814fea828a7efa54586b324a4

Signed-off-by: Sage Weil <sage@inktank.com>

pipe: use pipe2 feature test; check fcntl retval

Signed-off-by: Noah Watkins <noahwatkins@gmail.com>

fix -Wmismatched-tags warnings

Example: warning: class 'ObjecterDispatcher' was previously declared as
a struct [-Wmismatched-tags]

Signed-off-by: Noah Watkins <noahwatkins@gmail.com>

fix -Wgnu-designator warnings

Example: warning: use of GNU old-style field designator extension
[-Wgnu-designator]

Signed-off-by: Noah Watkins <noahwatkins@gmail.com>

OSD: remove unused private var [-Wunused-private-field]

Signed-off-by: Noah Watkins <noahwatkins@gmail.com>

CrushTester: remove unused private var [-Wunused-private-field]

Signed-off-by: Noah Watkins <noahwatkins@gmail.com>

auth: remove unused private var [-Wunused-private-field]

Signed-off-by: Noah Watkins <noahwatkins@gmail.com>

common/buffer.cc: fix rebuild_page_aligned typo

Introduced: 66a9fbe2c7ba59b7cd034c17865adce3432cd2cb
Fixes: #6003
Signed-off-by: Samuel Just <sam.just@inktank.com>

test: add gcc compile test for installed headers

libcephfs/librados headers should work with gcc.

Signed-off-by: Noah Watkins <noahwatkins@gmail.com>

libcephfs: Fix compilation for C compiler

Use struct instead of class, even if it warns.

Warnings are lower priority than compilation break.

Signed-off-by: Christophe Courtaut <christophe.courtaut@gmail.com>

ceph: Fix compilation with GCC compiler

Signed-off-by: Christophe Courtaut <christophe.courtaut@gmail.com>

Merge branch 'next'

Really use the hostname, otherwise ambiguous

"hostname" can return either the hostname or the fqdn depending on
configuration.
This refers to the issue http://tracker.ceph.com/issues/6706

Signed-off-by: David Moreau Simard <dmsimard@iweb.com>
Reviewed-by: Sage Weil <sage@inktank.com>

ceph-object-corpus: revert accidental revert

from 5df3024d7847950672169069b9dc8c8dcb876019

Signed-off-by: Sage Weil <sage@inktank.com>

docs: Fix a typo in RGW documentation

Merge pull request #792 from ceph/wip-doc-openstack

Reviewed-by: Josh Durgin <josh.durgin@inktank.com>

Merge pull request #766 from kri5/wip-5374

Rebase of Wip 5374 against master

Reviewed-by: Yehuda Sadeh <yehdua@inktank.com>

Wrap hex_to_num table into class HexTable

Reviewed-by: Yehuda Sadeh <yehuda@inktank.com>

[rgw] Set initialized to true after populating table in hex_to_num()

Reviewed-by: Yehuda Sadeh <yehuda@inktank.com>

sharedptr_registry.hpp: removed ptrs need to not blast contents

See the included unit test update.  Consider:
1) x = lookup_or_create(1, 1)
2) remove(1)
3) y = lookup_or_create(1, 2)
4) x.reset()
5) z = lookup(1)

The bug is that z will be null since x.reset() caused the
cleanup callback to remove y's key value from contents.

To fix this, contents also records the pointer value for
the weak_ptr.  The removal callback only removes the
key from contents if it matches the ptr in contents.

This should work since the pointer passed to the removal
callback must be unique up to that point since it has
not yet been deleted.

This allowed a pg removal -> pg recreation -> pg removal
sequence to cause the second pg removal entry to be
erroneously cleared by the first pg removal's destructor
as it finally made its way through the removal queue.

Fixes: #5951
Signed-off-by: Samuel Just <sam.just@inktank.com>
Reviewed-by: Greg Farnum <greg@inktank.com>

prio-q: initialize cur iterator

For new SubQueues `cur` is not intialized, so front/pop_front will freak
out. I honestly I have no idea how this hasn't been seen, but it was
being triggered frequently on OSX.

Fixes: #6686
Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
Reviewed-by: Samuel Just <sam.just@inktank.com>

PGLog: remove obsolete assert in merge_log

This assert assumes that if olog.head != log.head, olog contains
a log entry at log.head, which may not be true since pg splitting
might have left the log with arbitrary holes.

Related: 0c2769d3321bff6e85ec57c85a08ee0b8e751bcb
Signed-off-by: Samuel Just <sam.just@inktank.com>
Reviewed-by: Sage Weil <sage@inktank.com>

test/osd/RadosModel.h: select and reserve roll_back_to atomically

Signed-off-by: Samuel Just <sam.just@inktank.com>
Reviewed-by: Sage Weil <sage@inktank.com>

test/rados/list.cc: we might get some objects more than once

Signed-off-by: Samuel Just <sam.just@inktank.com>
Reviewed-by: Sage Weil <sage@inktank.com>

os/chain_listxattr: fix leak fix

e22347df3854a5c5ebc6631c62d70447d67d722d added a bad goto; just free
explicitly instead.

Signed-off-by: Sage Weil <sage@inktank.com>
Reviewed-by: Noah Watkins <noahwatkins@gmail.com>

doc: Updated rewrite rule.

Signed-off-by: John Wilkins <john.wilkins@inktank.com>

doc: Incorporated feedback.

Signed-off-by: John Wilkins <john.wilkins@inktank.com>

doc: Created new zone sync image.

Signed-off-by: John Wilkins <john.wilkins@inktank.com>

doc: Modified image.

Signed-off-by: John Wilkins <john.wilkins@inktank.com>

doc: Removed references to OpenSuse and SLES.

Signed-off-by: John Wilkins <john.wilkins@inktank.com>

doc: Retitled document. Made example generic. Fixed link.

Signed-off-by: John Wilkins <john.wilkins@inktank.com>

doc: Retitled document.

Signed-off-by: John Wilkins <john.wilkins@inktank.com>

doc: Removed the Folsom reference.

Signed-off-by: John Wilkins <john.wilkins@inktank.com>

doc: Restored show_image_direct and added a link to older versions.

Signed-off-by: John Wilkins <john.wilkins@inktank.com>

doc: Removed nova-volume, early Ceph references and Folsom references.

fixes: 5006

Signed-off-by: John Wilkins <john.wilkins@inktank.com>

doc: Removed install yum priorities. Duplicated where relevant.

Signed-off-by: John Wilkins <john.wilkins@inktank.com>

doc: Added quick ceph object store with links to manual install and config.

Signed-off-by: John Wilkins <john.wilkins@inktank.com>

doc: Restored Object Store Quick Start entry for parallelism.

Signed-off-by: John Wilkins <john.wilkins@inktank.com>

doc: Changed install to ceph-deploy install.

Signed-off-by: John Wilkins <john.wilkins@inktank.com>

doc: Added note for ARM support in quantal and raring.

Signed-off-by: John Wilkins <john.wilkins@inktank.com>

Removed add repositories, yum priorities, and consolidated index.

Signed-off-by: John Wilkins <john.wilkins@inktank.com>

doc: Added consolidated install of VM/Cloud software.

Signed-off-by: John Wilkins <john.wilkins@inktank.com>

doc: Removed install qemu. Consolidated to install-vm-cloud.

Signed-off-by: John Wilkins <john.wilkins@inktank.com>

doc: Removed install libvirt. Consolidated to install-vm-cloud.

Signed-off-by: John Wilkins <john.wilkins@inktank.com>

doc: Consolidated install object gateway and install Apache/FastCGI

Signed-off-by: John Wilkins <john.wilkins@inktank.com>

doc: Removed. Consolidated into install-ceph-gateway.

Signed-off-by: John Wilkins <john.wilkins@inktank.com>

doc: Consolidated Add Repositories.

Signed-off-by: John Wilkins <john.wilkins@inktank.com>

doc: Removed doc. Consolidated with Get Packages.

Signed-off-by: John Wilkins <john.wilkins@inktank.com>

doc/release-notes: formatting

Signed-off-by: Sage Weil <sage@inktank.com>

doc/release-notes: fix formatting

Signed-off-by: Sage Weil <sage@inktank.com>

doc/release-notes: fix indentation

ERROR: /srv/autobuild-ceph/gitbuilder.git/build/doc/release-notes.rst:48: Unexpected indentation.

Signed-off-by: Sage Weil <sage@inktank.com>

Merge branch 'next'

Merge branch 'next' of jenkins:ceph/ceph into next

ceph: Release resource before return in BackedObject::download()

Close file before return

Signed-off-by: Li Wang <liwang@ubuntukylin.com>
Reviewed-by: Sage Weil <sage@inktank.com>

ceph: Fix memory leak in chain_listxattr

Free allocated memory before return

Signed-off-by: Li Wang <liwang@ubuntukylin.com>
Reviewed-by: Sage Weil <sage@inktank.com>

Fix memory leak in Backtrace::print()

Free already allocated memory if short of memory

Signed-off-by: Li Wang <liwang@ubuntukylin.com>
Reviewed-by: Sage Weil <sage@inktank.com>

v0.72-rc1

Merge pull request #788 from ceph/wip-6605

mon: OSDMonitor: only allow an osd to boot iff it has the fsid on record

Fixes: #6605
Reviewed-by: Sage Weil <sage@inktank.com>

Merge remote-tracking branch 'gh/wip-crush-hook'

Reviewed-by: Loic Dachary <loic@dachary.org>

upstart, sysvinit: use ceph-crush-location hook

Instead of hard-coding a check in ceph.conf and some reasonable
defaults, defer this work to ceph-crush-location, and allow users to
specify their own hook with alternative logic.

This can be helpful in a nubmer of cases, like:

 - rack (or other) information included in hostname and easily parsed
   out by a hook
 - multiple types of devices in each host, resulting in 'parallel'
   crush trees (e.g., one for hdd, one for ssd)

Signed-off-by: Sage Weil <sage@inktank.com>